Bug in genirq: record trigger type

2008-10-21 Thread Benjamin Herrenschmidt
On Mon, 2008-10-20 at 22:05 +, Linux Kernel Mailing List wrote: Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0c5d1eb77a8be917b638344a22afe1398236482b Commit: 0c5d1eb77a8be917b638344a22afe1398236482b Parent:

Re: Bug in genirq: record trigger type

2008-10-21 Thread Ingo Molnar
* Yinghai Lu [EMAIL PROTECTED] wrote: On Mon, Oct 20, 2008 at 11:32 PM, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Mon, 2008-10-20 at 22:05 +, Linux Kernel Mailing List wrote: Gitweb:

Re: Bug in genirq: record trigger type

2008-10-21 Thread Benjamin Herrenschmidt
On Tue, 2008-10-21 at 09:28 +0200, Ingo Molnar wrote: From: Chris Friesen [EMAIL PROTECTED] Date: Mon, 20 Oct 2008 12:41:58 -0600 Subject: [PATCH] genirq: fix set_irq_type() when recording trigger type In set_irq_type() we want to pass the type rather than the current interrupt state.

Re: Bug in genirq: record trigger type

2008-10-21 Thread Ingo Molnar
* Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Tue, 2008-10-21 at 09:28 +0200, Ingo Molnar wrote: From: Chris Friesen [EMAIL PROTECTED] Date: Mon, 20 Oct 2008 12:41:58 -0600 Subject: [PATCH] genirq: fix set_irq_type() when recording trigger type In set_irq_type() we want to

Re: Bug in genirq: record trigger type

2008-10-21 Thread David Brownell
On Monday 20 October 2008, Benjamin Herrenschmidt wrote: This one is obviously broken and breaks booting on a whole bunch of machines (including powermac's and thus my G5, it's never good when my own machine breaks !). Nice to see 3 SOB's and one Ack and nobody caught the obvious bug :-) As

Re: Bug in genirq: record trigger type

2008-10-21 Thread Benjamin Herrenschmidt
On Tue, 2008-10-21 at 01:01 -0700, David Brownell wrote: I'm a bit more curious about another potential issue though ... as described in the patch comment: - Make set_irq_type() usage match request_irq() usage: * IRQ_TYPE_NONE should be a NOP; succeed, so irq_chip methods

Re: Bug in genirq: record trigger type

2008-10-21 Thread Yinghai Lu
On Mon, Oct 20, 2008 at 11:32 PM, Benjamin Herrenschmidt [EMAIL PROTECTED] wrote: On Mon, 2008-10-20 at 22:05 +, Linux Kernel Mailing List wrote: Gitweb: http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0c5d1eb77a8be917b638344a22afe1398236482b Commit: