Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-08 Thread Wols Lists
On 26/01/2022 11:41, Paul Menzel wrote: So, do the same as commit 9564a8cf422d (Kbuild: fix # escaping in .cmd files for future Make) and commit 929bef467771 (bpf: Use $(pound) instead of \# in Makefiles) and define and use a `$(pound)` variable. Ouch! In the English (as opposed to American)

Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-02-07 Thread Song Liu
Hi Paul, Sorry for the delayed reply. On Wed, Jan 26, 2022 at 3:42 AM Paul Menzel wrote: > > Buidling `raid6test` on Ubuntu 21.10 (ppc64le) with GNU Make 4.3 shows the > errors below: Please do not use `xxx` in the commit log (and subject). > > $ cd lib/raid6/test/ > $ make >

Re: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-01-26 Thread Paul Menzel
Dear David, Am 26.01.22 um 13:06 schrieb David Laight: From: Paul Menzel Sent: 26 January 2022 11:42 .. +pound := \# Please use 'hash' not 'pound'. Only american greengrocers use that horrid name. A 'pound' is '£'. Sure, I can change that, if you send a patch cleaning this up for the

RE: [PATCH 1/3] lib/raid6/test/Makefile: Use `$(pound)` instead of `\#` for Make 4.3

2022-01-26 Thread David Laight
From: Paul Menzel > Sent: 26 January 2022 11:42 > .. > +pound := \# Please use 'hash' not 'pound'. Only american greengrocers use that horrid name. A 'pound' is '£'. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386