Re: [PATCH V3 03/17] asm-generic: compat: Cleanup duplicate definitions

2022-01-27 Thread Guo Ren
On Thu, Jan 20, 2022 at 9:02 PM Arnd Bergmann wrote: > > On Thu, Jan 20, 2022 at 8:38 AM wrote: > > > > From: Guo Ren > > > > There are 7 64bit architectures that support Linux COMPAT mode to > > run 32bit applications. A lot of definitions are duplicate: > > - COMPAT_USER_HZ > > -

RE: [PATCH V3 03/17] asm-generic: compat: Cleanup duplicate definitions

2022-01-20 Thread David Laight
From: Arnd Bergmann > Sent: 20 January 2022 11:52 .. > As with compat_flock, the packed attribute has no impact on the layout > here, but please drop it anyway for consistency. Never mind the structure layout, because 'packed' allows the structure to be aligned on any boundary it forces the

Re: [PATCH V3 03/17] asm-generic: compat: Cleanup duplicate definitions

2022-01-20 Thread Arnd Bergmann
On Thu, Jan 20, 2022 at 8:38 AM wrote: > > From: Guo Ren > > There are 7 64bit architectures that support Linux COMPAT mode to > run 32bit applications. A lot of definitions are duplicate: > - COMPAT_USER_HZ > - COMPAT_RLIM_INFINITY > - COMPAT_OFF_T_MAX > - __compat_uid_t, __compat_uid_t >