Re: tlb flushing on Power

2012-03-07 Thread Seth Jennings
On 03/06/2012 11:28 PM, Michael Neuling wrote: Seth, Thanks for the help! I was wondering if you could take a look at something for me. I've been working on this staging driver (zsmalloc memory allocator) that does virtual mapping of two pages. I have a github repo with the driver and

Re: tlb flushing on Power

2012-03-06 Thread Michael Neuling
Seth, Thanks for the help! I was wondering if you could take a look at something for me. I've been working on this staging driver (zsmalloc memory allocator) that does virtual mapping of two pages. I have a github repo with the driver and the unsubmitted changes. I'm trying to make to

Re: tlb flushing on Power

2012-03-05 Thread Seth Jennings
Hey Ben, Thanks for the help! I was wondering if you could take a look at something for me. I've been working on this staging driver (zsmalloc memory allocator) that does virtual mapping of two pages. I have a github repo with the driver and the unsubmitted changes. I'm trying to make to get

Re: tlb flushing on Power

2012-02-16 Thread Seth Jennings
On 02/10/2012 01:14 PM, Seth Jennings wrote: On 02/08/2012 03:04 PM, Benjamin Herrenschmidt wrote: You can look at https://lkml.org/lkml/2012/1/9/389 in zsmalloc-main.c, zs_[un]map_object() functions for the currently uses of set_pte() and __flush_tlb_one(). set_pte() is long gone on all

Re: tlb flushing on Power

2012-02-16 Thread Benjamin Herrenschmidt
On Thu, 2012-02-16 at 11:11 -0600, Seth Jennings wrote: Just wanted to bump you again about this. You mentioned that if I wanted to do a cpu-local flush of a single tlb entry, that there would have to be a new hook. Is that right? I've been looking through the powerpc arch and I thought

Re: tlb flushing on Power

2012-02-10 Thread Seth Jennings
On 02/08/2012 03:04 PM, Benjamin Herrenschmidt wrote: You can look at https://lkml.org/lkml/2012/1/9/389 in zsmalloc-main.c, zs_[un]map_object() functions for the currently uses of set_pte() and __flush_tlb_one(). set_pte() is long gone on all archs really (or if it's still there it's not

Re: tlb flushing on Power

2012-02-08 Thread Seth Jennings
Hey Ben, Thanks for responding. On 01/26/2012 03:39 PM, Benjamin Herrenschmidt wrote: On Thu, 2012-01-26 at 08:41 -0600, Brian King wrote: CC'ing linuxppc-dev... On 01/26/2012 08:18 AM, Seth Jennings wrote: Hey Dave, So I submitted the zsmalloc patches to lkml at the beginning of the

Re: tlb flushing on Power

2012-02-08 Thread Benjamin Herrenschmidt
You can look at https://lkml.org/lkml/2012/1/9/389 in zsmalloc-main.c, zs_[un]map_object() functions for the currently uses of set_pte() and __flush_tlb_one(). set_pte() is long gone on all archs really (or if it's still there it's not meant to be used as is), use set_pte_at().

Re: tlb flushing on Power

2012-01-26 Thread Brian King
CC'ing linuxppc-dev... On 01/26/2012 08:18 AM, Seth Jennings wrote: Hey Dave, So I submitted the zsmalloc patches to lkml at the beginning of the year https://lkml.org/lkml/2012/1/9/389 I found there are two functions Nitin used in the mapping functions that are not supported in the

Re: tlb flushing on Power

2012-01-26 Thread Benjamin Herrenschmidt
On Thu, 2012-01-26 at 08:41 -0600, Brian King wrote: CC'ing linuxppc-dev... On 01/26/2012 08:18 AM, Seth Jennings wrote: Hey Dave, So I submitted the zsmalloc patches to lkml at the beginning of the year https://lkml.org/lkml/2012/1/9/389 I found there are two functions

Re: tlb flushing on Power

2012-01-26 Thread Dave Hansen
On 01/26/2012 01:39 PM, Benjamin Herrenschmidt wrote: Can you explain to me a bit more the whole business in this patch set about doing kmap_atomic() vs. manually trying to populate the PTEs ? They're compressing pages and the allocator is trying getting very poor packing of compressed pages

Re: tlb flushing on Power

2012-01-26 Thread Benjamin Herrenschmidt
On Thu, 2012-01-26 at 14:30 -0800, Dave Hansen wrote: On 01/26/2012 01:39 PM, Benjamin Herrenschmidt wrote: Can you explain to me a bit more the whole business in this patch set about doing kmap_atomic() vs. manually trying to populate the PTEs ? They're compressing pages and the