Re: [PATCH] [V3] net: add Xilinx emac lite device driver

2009-08-20 Thread Grant Likely
need to be exact for the IP cores. No wildcards. No abbreviations or stripping. Newer cores can claim compatibility with older when appropriate. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev

[RFC PATCH 0/3] Make 64-bit PCI device tree scanning code common

2009-08-20 Thread Grant Likely
I'll actually try running this stuff and debugging the details. Thanks, g. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/3] powerpc/pci: Remove dead checks for CONFIG_PPC_OF

2009-08-20 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca PPC_OF is always selected for arch/powerpc. This patch removes the stale #defines Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/powerpc/kernel/pci-common.c |8 arch/powerpc/kernel/pci_32.c |9 - 2 files

[PATCH 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-20 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The two versions are doing almost exactly the same thing. No need to maintain them as separate files. This patch also has the side effect of making the PCI device tree scanning code available to 32 bit powerpc machines, but no board ports actually

[PATCH 2/3] powerpc/pci: move pci_64.c device tree scanning code into pci-common.c

2009-08-20 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The PCI device tree scanning code in pci_64.c is some useful functionality. It allows PCI devices to be described in the device tree instead of being probed for, which in turn allows pci devices to use all of the device tree facilities to describe

Re: [PATCH 2/3] powerpc/pci: move pci_64.c device tree scanning code into pci-common.c

2009-08-21 Thread Grant Likely
consolidation there. I agree, but I'll do those things in a separate patch. I'm making as few code changes as possible in this patch to ease review. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH 2/3] powerpc/pci: move pci_64.c device tree scanning code into pci-common.c

2009-08-21 Thread Grant Likely
On Fri, Aug 21, 2009 at 12:05 AM, Benjamin Herrenschmidtb...@kernel.crashing.org wrote: On Thu, 2009-08-20 at 23:30 -0600, Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca The PCI device tree scanning code in pci_64.c is some useful functionality. It allows PCI devices

Re: mpc5200, reboots will idle

2009-08-21 Thread Grant Likely
in the back trace. Data corruption in a device driver perhaps? I'll keep my eyes open if I see anything similar. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

[PATCH] powerpc: add cascade support to xilinx intc controller

2009-08-25 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca This patch allows the Xilinx intc interrupt controller to be cascaded instead of being the master irqhost. Useful when attaching an FPGA to an SoC that has its own interrupt controller. Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch

Re: [PATCH] powerpc/pci: Pull ppc32 PCI features into common

2009-08-25 Thread Grant Likely
the logic in fake_pci_bus() to assume it will always get a valid pci_controller.  Since all current callers seem to pass it one. Signed-off-by: Kumar Gala ga...@kernel.crashing.org Looks okay to me. Acked-by: Grant Likely grant.lik...@secretlab.ca g

[PATCH V2 1/3] powerpc/pci: Remove dead checks for CONFIG_PPC_OF

2009-08-26 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca PPC_OF is always selected for arch/powerpc. This patch removes the stale #defines Signed-off-by: Grant Likely grant.lik...@secretlab.ca Acked-by: Stephen Rothwell s...@canb.auug.org.au Acked-by: Kumar Gala ga...@kernel.crashing.org --- arch/powerpc

[PATCH V2 2/3] powerpc/pci: move pci_64.c device tree scanning code into pci-common.c

2009-08-26 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The PCI device tree scanning code in pci_64.c is some useful functionality. It allows PCI devices to be described in the device tree instead of being probed for, which in turn allows pci devices to use all of the device tree facilities to describe

[PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-26 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The two versions are doing almost exactly the same thing. No need to maintain them as separate files. This patch also has the side effect of making the PCI device tree scanning code available to 32 bit powerpc machines, but no board ports actually

[PATCH V2 0/3] Make 64-bit PCI device tree scanning code common

2009-08-26 Thread Grant Likely
what I'm up to. Basically, I want access to the device tree scanning in ppc32 land, and these patches start to get me there.  Please take a look and comment.  Tomorrow I'll actually try running this stuff and debugging the details. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd

[PATCH V2 0/3] Make 64-bit PCI device tree scanning code common

2009-08-26 Thread Grant Likely
what I'm up to. Basically, I want access to the device tree scanning in ppc32 land, and these patches start to get me there.  Please take a look and comment.  Tomorrow I'll actually try running this stuff and debugging the details. -- Grant Likely, B.Sc. P.Eng. Secret Lab Technologies Ltd

Re: [PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-26 Thread Grant Likely
On Wed, Aug 26, 2009 at 7:29 AM, Kumar Galaga...@kernel.crashing.org wrote: On Aug 26, 2009, at 1:07 AM, Grant Likely wrote: +/** + * pci_scan_phb - Given a pci_controller, setup and scan the PCI bus + * @hose: Pointer to the PCI host controller instance structure + * @data: value to use

Re: [RFC] Clock binding

2009-08-26 Thread Grant Likely
On Wed, Aug 26, 2009 at 10:09 PM, Benjamin Herrenschmidtb...@kernel.crashing.org wrote: On Tue, 2009-08-18 at 14:21 +1000, Benjamin Herrenschmidt wrote: So here's a followup to my discussion about the clock API. Really nobody has a comment here ? :-) Not even Mitch ? Been wanting too.. a

Re: LITE5200 configuration

2009-08-28 Thread Grant Likely
-tx_dmatsk); -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC] Clock binding

2009-08-28 Thread Grant Likely
. kernel.org would be a good host. So would ozlabs or infradead. Or I'd be happy to maintain one on secretlab. What about openfirmware.info? I don't know anything about Core Systems who maintains that site though. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [RFC] Clock binding

2009-08-28 Thread Grant Likely
names makes sense. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V2 3/3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-28 Thread Grant Likely
On Wed, Aug 26, 2009 at 11:46 PM, Benjamin Herrenschmidtb...@kernel.crashing.org wrote: On Wed, 2009-08-26 at 00:07 -0600, Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca The two versions are doing almost exactly the same thing.  No need to maintain them as separate files

[PATCH V3] powerpc/pci: Merge ppc32 and ppc64 versions of phb_scan()

2009-08-28 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca The two versions are doing almost exactly the same thing. No need to maintain them as separate files. This patch also has the side effect of making the PCI device tree scanning code available to 32 bit powerpc machines, but no board ports actually

Re: [RFC] Clock binding

2009-08-28 Thread Grant Likely
. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: PPC PCI bus registers

2009-09-02 Thread Grant Likely
On Wed, Sep 2, 2009 at 5:44 PM, Eddie Dawydiuked...@embeddedarm.com wrote: Hello, I have a question regarding reading PCI bus registers from a user space application running on a PPC SBC. Seeing as though the PCI bus is little endian and PPC is big endian is it typical that one must perform a

Re: [RFC] net/fs_enet: send a reset request to the PHY on init

2009-09-03 Thread Grant Likely
be to do this in U-Boot. Otherwise, I think I would rather see it at phy_device probe time. At least then it would be on a per-phy basis, or could be controlled by a property in the device tree so that all boards don't get the same impact. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies

Re: some questions [gpio]

2009-09-09 Thread Grant Likely
that I've actually looked at the binding. :-) g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/boot/dts: drop obsolete 'fsl5200-clocking'

2009-09-10 Thread Grant Likely
On Thu, Sep 10, 2009 at 8:55 AM, Wolfram Sang w.s...@pengutronix.de wrote: The 'fsl5200-clocking'-property was dropped since 0d1cde235874b00905bce23f659690d060ebf475. Remove all occurences in dts-files. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik

[RFC] powerpc/irq: Add generic API for setting up cascaded IRQs

2009-09-11 Thread Grant Likely
From: Grant Likely grant.lik...@secretlab.ca prototype implementation. This probably doesn't work at all right now. Ben, I'm posting this now to get your thoughts before I go too far down this path. Cheers, g. --- arch/powerpc/include/asm/irq.h|3 ++ arch/powerpc/kernel

Re: MPC5200/BestComm functions question

2009-09-12 Thread Grant Likely
if you go down that route. :-( g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC] powerpc/irq: Add generic API for setting up cascaded IRQs

2009-09-12 Thread Grant Likely
On Sat, Sep 12, 2009 at 12:28 AM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Fri, 2009-09-11 at 23:46 -0600, Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca prototype implementation.  This probably doesn't work at all right now. Ben, I'm posting this now

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board uc101

2009-09-14 Thread Grant Likely
+                               device_type = pdsp-display; Drop device_type +                               compatible = pdsp-display; No vendor prefix? +                               reg = 3 0x0060 0x1000; +               }; +       }; + +}; -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Grant Likely
' mpc5200 part? If not, then fsl,mpc5200b-immr also needs to be in this list. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Grant Likely
of removing this comment, replace it with one that tells readers where to look for the encoding documentation. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Grant Likely
On Mon, Sep 14, 2009 at 8:32 AM, Heiko Schocher h...@denx.de wrote: Grant Likely wrote: On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher h...@denx.de wrote: +       soc5...@f000 { +               #address-cells = 1; +               #size-cells = 1; +               compatible = fsl,mpc5200

Re: [PATCH] Xilinx: SPI: Fix bits_per_word for transfers

2009-09-14 Thread Grant Likely
in the transfer that is passed in. Signed-off-by: John Linn john.l...@xilinx.com Looks good to me. Acked-by: Grant Likely grant.lik...@secretlab.ca ---  drivers/spi/xilinx_spi.c |    3 ++-  1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/xilinx_spi.c b/drivers/spi

Re: [spi-devel-general] [PATCH] mpc52xx_psc_spi: enlarge clock range

2009-09-17 Thread Grant Likely
. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Grant Likely
xlnx,xps-usb-host-1.00.a, and the meaning of that binding needs to be documented in Documentation/powerpc/dts-bindings. Having this driver bind against the generic usb-ehci will cause conflicts with the ehci-ppc-of driver. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Grant Likely
On Mon, Sep 21, 2009 at 7:41 AM, Julie Zhu julie@xilinx.com wrote: I have changed the compatible to xlnx,xps-usb-host-1.00.a, thanks for catching this. Where should I put the binding for Xilinx USB host controller? usb-ehci.txt or xilinx.txt? Probably xilinx.txt. g. -- Grant Likely

Re: [PATCH] [V1] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Grant Likely
Likely grant.lik...@secretlab.ca Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] [V2] USB: Add support for Xilinx USB host controller

2009-09-21 Thread Grant Likely
. This driver has been tested with usbtest using the NET2280 PCI card. Signed-off-by: Julie Zhu julie@xilinx.com Signed-off-by: John Linn john.l...@xilinx.com Acked-by: Grant Likely grant.lik...@secretlab.ca -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] net: xilinx_emaclite: Fix problem with first incoming packet

2009-09-22 Thread Grant Likely
Acked-by: John Linn john.l...@xilinx.com John, Since this patch is being *sent* by you, then you should use a signed-off-by tag instead because it actually passed through your hands. Oh, and: Acked-by: Grant Likely grant.lik...@secretlab.ca ---  drivers/net/xilinx_emaclite.c |    7 ++-  1

Re: [PATCH] powerpc/5200: add LocalPlus bus FIFO device driver

2009-09-29 Thread Grant Likely
-by: Grant Likely grant.lik...@secretlab.ca Signed-off-by: John Bonesio bo...@secretlab.ca Let me know if anyone has comments on this. Since it is a new driver, I'll probably try to merge it for 2.6.32 in the next week or so even though the merge window has closed. Cheers, g. --- This driver

Re: [PATCH v2] mpc5200: support for the MAN mpc5200 based board uc101

2009-10-05 Thread Grant Likely
a documentation patch for it and post it to devicetree-discuss for review. Make sure you cc: both me and Wolfram when you post it. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: Help with SPI node

2009-10-05 Thread Grant Likely
is there, then it means that the driver is bound to the device. Most likely it means that the compatible value in the node doesn't match what the driver is looking for. Look at those things and report back. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

[RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-06 Thread Grant Likely
. This first batch isn't anything exciting, just a merge of common code --- Grant Likely (12): of: merge of_find_all_nodes() implementations of: merge other miscellaneous prototypes of: merge of_*_flat_dt*() functions of: merge of_node_get(), of_node_put() and of_find_all_nodes

[RFC PATCH 01/12] of: Rework linux/of.h and asm/prom.h include ordering

2009-10-06 Thread Grant Likely
of the prom.h files *above* the multi-include protection macros to ensure that linux/of.h can define things before prom.h gets processed. At the end of the merge the cross dependencies between the files should be gone and a sane #include scheme can be restored. Signed-off-by: Grant Likely grant.lik

[RFC PATCH 02/12] of: merge phandle, ihandle and struct property

2009-10-06 Thread Grant Likely
Merge of common code duplicated between Sparc, PowerPC and Microblaze Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 10 -- arch/powerpc/include/asm/prom.h| 12 arch/sparc/include/asm/prom.h | 12

[RFC PATCH 03/12] of: merge struct device_node

2009-10-06 Thread Grant Likely
Merge of common code duplicated between Sparc, PowerPC and Microblaze Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 20 arch/powerpc/include/asm/prom.h| 20 arch/sparc/include/asm/prom.h

[RFC PATCH 04/12] of: Move OF_IS_DYNAMIC and OF_MARK_DYNAMIC macros to of.h

2009-10-06 Thread Grant Likely
Merge of common code duplicated between Sparc, PowerPC and Microblaze Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/sparc/include/asm/prom.h |3 --- include/linux/of.h|3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/sparc/include

[RFC PATCH 05/12] of: add common header for flattened device tree representation

2009-10-06 Thread Grant Likely
Add a common header file for working with the flattened device tree data structure and merge the shared data tags used by Microblaze and PowerPC Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 12 +--- arch/powerpc/include/asm/prom.h

[RFC PATCH 06/12] of: merge struct boot_param_header from Microblaze and PowerPC

2009-10-06 Thread Grant Likely
Merge common code for working with Flattened Device Tree data structure Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 30 -- arch/powerpc/include/asm/prom.h| 31 --- include/linux

[RFC PATCH 07/12] of: merge of_node_*_flag() and set_node_proc_entry()

2009-10-06 Thread Grant Likely
Merge common code between PowerPC and Microblaze Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 16 arch/powerpc/include/asm/prom.h| 17 - include/linux/of.h | 16 3 files

[RFC PATCH 08/12] of: merge of_read_number() an of_read_ulong()

2009-10-06 Thread Grant Likely
Merge common code between Microblaze and PowerPC Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 12 arch/powerpc/include/asm/prom.h| 20 include/linux/of.h | 23 +++ 3

[RFC PATCH 09/12] of: merge of_node_get(), of_node_put() and of_find_all_nodes()

2009-10-06 Thread Grant Likely
Merge common code between Sparc, PowerPC and Microblaze. Sparc differs in the implementation at this point, so this patch uses a #ifdef to handle sparc differently for now. The merging of implementations will occur in a later patch Signed-off-by: Grant Likely grant.lik...@secretlab.ca

[RFC PATCH 10/12] of: merge of_*_flat_dt*() functions

2009-10-06 Thread Grant Likely
Merge common flattened device tree code between Microblaze and PowerPC Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 11 --- arch/powerpc/include/asm/prom.h| 10 -- include/linux/of_fdt.h | 14

[RFC PATCH 11/12] of: merge other miscellaneous prototypes

2009-10-06 Thread Grant Likely
Merge common prototypes used by Microblaze and PowerPC Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/include/asm/prom.h | 12 arch/powerpc/include/asm/prom.h| 14 -- include/linux/of_fdt.h | 13 + 3 files

[RFC PATCH 12/12] of: merge of_find_all_nodes() implementations

2009-10-06 Thread Grant Likely
Merge common code between Microblaze and PowerPC, and make it available to Sparc Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- arch/microblaze/kernel/prom.c | 23 --- arch/powerpc/kernel/prom.c| 23 --- drivers/of/base.c

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-06 Thread Grant Likely
On Tue, Oct 6, 2009 at 10:29 PM, Grant Likely grant.lik...@secretlab.ca wrote: Well, I've got to start somewhere... So here goes.  I've begun the work to merge and clean up the OF device tree handling code and this is my first set of patches.  Not fully tested yet, but I'm getting them out

Re: [microblaze-uclinux] Re: [RFC PATCH 05/12] of: add common header for flattened device tree representation

2009-10-07 Thread Grant Likely
On Wed, Oct 7, 2009 at 6:14 AM, Michal Simek mon...@monstr.eu wrote: Stephen Rothwell wrote: Hi Grant, Just first obvious thing: On Tue, 06 Oct 2009 22:30:59 -0600 Grant Likely grant.lik...@secretlab.ca wrote: diff --git a/arch/microblaze/include/asm/prom.h b/arch/microblaze/include

Re: [RFC PATCH 05/12] of: add common header for flattened device tree representation

2009-10-07 Thread Grant Likely
On Tue, Oct 6, 2009 at 11:14 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Tue, 2009-10-06 at 22:30 -0600, Grant Likely wrote: --- /dev/null +++ b/include/linux/of_fdt.h @@ -0,0 +1,30 @@ +/* + * Definitions for working with the Flattened Device Tree data format

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-07 Thread Grant Likely
On Wed, Oct 7, 2009 at 1:09 AM, Rob Landley r...@landley.net wrote: On Tuesday 06 October 2009 23:49:04 Grant Likely wrote: However, I've completely devoted to this work for at least the next two months, so there are plenty more patches to follow.  Once I've got all the common code merged

Re: Nested function in drivers/of/of_mdio.c

2009-10-07 Thread Grant Likely
; -       } -        if (!phy_np)                return NULL; What do you think about it? Best regards, -- Jérôme Pouiller (jezz AT sysmic DOT org) -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Grant Likely
returned by it. It will take a bit of experimentation to come up with the best form for the pdata fetching function, but it will be better contained if it is all at a single place. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Grant Likely
to write anything more than a tiny function to populate pdata from the device tree. Managing that pdata instance needs to be done with common infrastructure (but I don't have a firm idea about how it should look yet). In the mean time I think Wolfram's approach has lower impact. g. -- Grant Likely

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Grant Likely
On Thu, Oct 8, 2009 at 9:10 AM, Anton Vorontsov avoront...@ru.mvista.com wrote: On Thu, Oct 08, 2009 at 08:53:46AM -0600, Grant Likely wrote: [...] Please don't.  It is such a small amount of code, It's *always* a small amound of code, at a start. Then we get floppy disk drivers and the tty

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Grant Likely
function, but it will be better contained if it is all at a single place. I might have a try :) :-) -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-08 Thread Grant Likely
you please post the device tree fragment that you're using to describe this chip? I want to make sure we don't get stuck with things in the kernel that will be hard to maintain in the long term. Thanks, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-09 Thread Grant Likely
On Thu, Oct 8, 2009 at 4:20 PM, Anton Vorontsov avoront...@ru.mvista.com wrote: On Thu, Oct 08, 2009 at 09:48:50AM -0600, Grant Likely wrote: But the focus is still on creating pdata.  If a translator gets too big, then sure, split it into a separate file.  Until then, there I see no good

Re: [RFC PATCH 10/12] of: merge of_*_flat_dt*() functions

2009-10-09 Thread Grant Likely
On Fri, Oct 9, 2009 at 12:36 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Tue, Oct 06, 2009 at 10:32:02PM -0600, Grant Likely wrote: Merge common flattened device tree code between Microblaze and PowerPC And I guess another question is do we want to replace these with a libfdt based

Re: [RFC PATCH 05/12] of: add common header for flattened device tree representation

2009-10-09 Thread Grant Likely
On Fri, Oct 9, 2009 at 12:35 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Tue, Oct 06, 2009 at 10:30:59PM -0600, Grant Likely wrote: Add a common header file for working with the flattened device tree data structure and merge the shared data tags used by Microblaze and PowerPC

Re: [RFC] scripts/get_maintainer: add emails based on keywords in the patch

2009-10-09 Thread Grant Likely
can happen anywhere and so there is no fitting fileglob, this keyword based approach is proposed. Nice. I cannot comment on the implementation, but I like the approach. g. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Joe Perches j...@perches.com Cc: Grant Likely grant.lik

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-09 Thread Grant Likely
On Fri, Oct 9, 2009 at 8:01 AM, Nate Case nc...@xes-inc.com wrote: On Thu, 2009-10-08 at 23:40 -0600, Grant Likely wrote: For your future reference, patches that look at the device tree should also cc: devicetree-disc...@lists.ozlabs.org so that new bindings can be reviewed and common mistakes

Re: [RFC] misc/at24: add experimental OF support for the generic eeprom driver

2009-10-09 Thread Grant Likely
, Wolfram's and your work things are going the right way. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] of/platform: Implement support for dev_pm_ops

2009-10-12 Thread Grant Likely
(bus);  } -- 1.6.3.3 -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: MPC5200B panics with high ethernet rx traffic

2009-10-14 Thread Grant Likely
familiar. Look in drivers/net/fec_mpc52xx.c and find the function mpc52xx_fec_reset(). Remove the calls to phy_stop(), phy_write() and phy_start(). See if that helps. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing

[PATCH] net/fec_mpc52xx: Fix kernel panic on FEC error

2009-10-14 Thread Grant Likely
. Resetting the PHY on an FEC error isn't even necessary. This patch solves the problem by removing the PHY reset entirely. Signed-off-by: John Bonesio bone...@secretlab.ca Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- Hi David, This patch is a bug fix that definitely needs to go

[PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

2009-10-14 Thread Grant Likely
. Resetting the PHY on an FEC error isn't even necessary. This patch solves the problem by removing the PHY reset entirely. Signed-off-by: John Bonesio bo...@secretlab.ca Signed-off-by: Grant Likely grant.lik...@secretlab.ca --- v2: fixed stupid misspelling of John's email address. No changes

Re: MPC5200B and USB

2009-10-14 Thread Grant Likely
for this list. You should refer to the USB standards documentation or look for a USB specific mailing list. Please don't ask non-Linux questions on a Linux mailing list. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing

Re: [PATCH 2/6] powerpc/pseries: Use irq_has_action() in eeh_disable_irq()

2009-10-14 Thread Grant Likely
it as an indicator that the irq is in use. disable_irq_nosync() will take the descriptor lock before doing anything also. Signed-off-by: Michael Ellerman mich...@ellerman.id.au Looks good to me Acked-by: Grant Likely grant.lik...@secretlab.ca ---  arch/powerpc/platforms/pseries/eeh_driver.c |   18

Re: [PATCH 4/6] powerpc: Make virq_debug_show() cope with sparse irq_descs

2009-10-14 Thread Grant Likely
On Tue, Oct 13, 2009 at 11:44 PM, Michael Ellerman mich...@ellerman.id.au wrote: Signed-off-by: Michael Ellerman mich...@ellerman.id.au Acked-by: Grant Likely grant.lik...@secretlab.ca ---  arch/powerpc/kernel/irq.c |    5 -  1 files changed, 4 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 5/6] powerpc: Rearrange and fix show_interrupts() for sparse irq_descs

2009-10-14 Thread Grant Likely
. Signed-off-by: Michael Ellerman mich...@ellerman.id.au Looks reasonable to me Acked-by: Grant Likely grant.lik...@secretlab.ca ---  arch/powerpc/kernel/irq.c |   64 ++---  1 files changed, 37 insertions(+), 27 deletions(-) diff --git a/arch/powerpc/kernel

Re: [PATCH 6/6] powerpc: Enable sparse irq_descs on powerpc

2009-10-14 Thread Grant Likely
@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/6] powerpc: Make NR_IRQS a CONFIG option

2009-10-14 Thread Grant Likely
controller */  #define NUM_ISA_INTERRUPTS     16 -- 1.6.2.1 ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH 3/6] powerpc: Remove get_irq_desc()

2009-10-14 Thread Grant Likely
-by: Michael Ellerman mich...@ellerman.id.au Acked-by: Grant Likely grant.lik...@secretlab.ca ---  arch/powerpc/include/asm/irq.h                  |    2 -  arch/powerpc/kernel/crash.c                     |    2 +-  arch/powerpc/kernel/irq.c                       |   28

Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

2009-10-14 Thread Grant Likely
On Wed, Oct 14, 2009 at 1:11 PM, Wolfgang Grandegger w...@grandegger.com wrote: Grant Likely wrote: From: John Bonesio bo...@secretlab.ca The MDIO bus cannot be accessed at interrupt context, but on an FEC error, the fec_mpc52xx driver reset function also tries to reset the PHY.  Since

Re: [PATCH 6/6] powerpc: Enable sparse irq_descs on powerpc

2009-10-14 Thread Grant Likely
On Wed, Oct 14, 2009 at 5:51 PM, Michael Ellerman mich...@ellerman.id.au wrote: On Wed, 2009-10-14 at 12:44 -0600, Grant Likely wrote: Why not make sparse IRQs manditory for all platforms?  Is there a performance concern with doing so?  From a maintenance perspective, I'd rather see IRQ descs

Please pull mpc5200 and OF changes

2009-10-15 Thread Grant Likely
repository at: git://git.secretlab.ca/git/linux-2.6 merge Grant Likely (1): powerpc/5200: Update defconfigs Heiko Schocher (2): mpc5200: support for the MAN mpc5200 based board uc101 mpc5200: support for the MAN mpc5200 based board mucmc52 Julia Lawall (1): drivers/serial

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-15 Thread Grant Likely
On Wed, Oct 14, 2009 at 7:00 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Grant, On Tue, 06 Oct 2009 22:29:57 -0600 Grant Likely grant.lik...@secretlab.ca wrote: Well, I've got to start somewhere... So here goes.  I've begun the work to merge and clean up the OF device tree

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-15 Thread Grant Likely
On Thu, Oct 15, 2009 at 5:38 PM, Stephen Rothwell s...@canb.auug.org.au wrote: Hi Grant, On Thu, 15 Oct 2009 11:06:15 -0600 Grant Likely grant.lik...@secretlab.ca wrote: In the mean time, I've pushed out the current series with acked-bys added to my git server.  I think I'm ready

Re: Linux for MPC5554 or MPC5534 (core e200z6)?

2009-10-21 Thread Grant Likely
with these controllers or with the e200z6 core? I'm pretty sure nobody has done a Linux port to any of these chips. Nor do I know of any work having been done in the past. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev

Re: [PATCH v4] powerpc/5200: Add mpc5200-spi (non-PSC) device driver

2009-10-21 Thread Grant Likely
On Wed, Oct 21, 2009 at 10:17 PM, Wolfram Sang w.s...@pengutronix.de wrote: Hi Grant, On Wed, Jun 17, 2009 at 08:55:01PM -0600, Grant Likely wrote: From: Grant Likely grant.lik...@secretlab.ca Adds support for the dedicated SPI device on the Freescale MPC5200(b) SoC. Signed-off-by: Grant

Re: Please pull mpc5200 and OF changes

2009-10-27 Thread Grant Likely
Hey Ben, I don't see these pulled into your tree yet. Can you please this tree into your merge branch? Thanks, g. On Thu, Oct 15, 2009 at 10:46 AM, Grant Likely grant.lik...@secretlab.ca wrote: Hi Ben. Here are some OF and MPC5200 changes needed for 2.6.32.  Mostly defconfig updates

Re: Micrel PHY KSZ8001 on MPC5200B FEC

2009-10-27 Thread Grant Likely
, but not a micrel one. If the generic phy driver doesn't work for you, then yes, add a new micrel driver. To hook it up to the MPC5200 FEC, you just need to have the correct PHY address in your board's .dts file. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-10-31 Thread Grant Likely
bus directly (just like how OF support works for i2c, spi, etc). I'd rather not refactor the driver until I'm certain of the direction that things are going to go. Cheers, g. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Kári Davíðsson kari.davids...@marel.com Cc: Grant Likely grant.lik

Re: [PATCH] spi/mpc52xx: check for invalid PSC usage

2009-10-31 Thread Grant Likely
to work. Besides, the MPC5200 common code already checks for an invalid PSC number when setting the clock divisor. Have you seen cases of users trying to do the wrong thing with the crippled PSCs? g. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Cc: Grant Likely grant.lik...@secretlab.ca Cc

Re: [PATCH/v2] powerpc/5200: make BestComm gen_bd microcode exchangeable

2009-11-01 Thread Grant Likely
On Mon, Oct 5, 2009 at 1:42 PM, Albrecht Dreß albrecht.dr...@arcor.de wrote: Am 05.10.09 20:16 schrieb(en) Grant Likely: Hmmm.  I've not been comfortable with this change, but it took me a while to put my finger on exactly why.  In principle, I think it is a good idea.  However, I don't want

Re: [PATCH 1/1] powerpc/40x: Add new PPC440EPx based board HCU5 of Netstal Maschinen

2009-11-01 Thread Grant Likely
On Fri, Oct 9, 2009 at 2:11 AM, Niklaus Giger niklaus.gi...@member.fsf.org wrote: Adds support for a HCU5 PPC405EPx based board from Netstal Maschinen AG. Signed-off-by: Niklaus Giger niklaus.gi...@member.fsf.org ---  arch/powerpc/boot/dts/hcu5.dts          |  254 +++  

Re: [PATCH] mpc52xx-psc-spi: refactor probe and remove to make use of of_register_spi_devices()

2009-11-02 Thread Grant Likely
for the feedback. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: mpc512x/clock: fix clk_get logic

2009-11-02 Thread Grant Likely
that only apply against a Denx tree that I'm starting to ignore them. Until the bulk of the out-of-tree 5121 support is merged, it would be helpful to specifically mention in the patch description whether or not it should be merged upstream. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab

Re: [PATCH 1/6 v5] Kernel DLPAR Infrastructure

2009-11-02 Thread Grant Likely
On Mon, Nov 2, 2009 at 9:27 AM, Nathan Fontenot nf...@austin.ibm.com wrote: I saw that Grant Likely is doing updates to all of the of_* stuff right now, would it be ok to have these routines here, renamed as dlpar_*, and look to merge them in with Grant's updates when he finishes? No because

  1   2   3   4   5   6   7   8   9   10   >