Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-04-06 Thread Michael Neuling
@@ -263,7 +263,9 @@ long compat_arch_ptrace(struct task_stru ret = ptrace_put_reg(child, numReg, freg); } else { flush_fp_to_thread(child); -((unsigned int *)child-thread.regs)[index] = d ata;

Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-04-06 Thread Michael Neuling
In message 8394.1239000...@neuling.org you wrote: @@ -263,7 +263,9 @@ long compat_arch_ptrace(struct task_stru ret = ptrace_put_reg(child, numReg, freg); } else { flush_fp_to_thread(child); -

Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-03-30 Thread Michael Neuling
So if you're looking fixing 32 bit apps ptracing 64 bit apps, does that mean we can get a single 32 bit GDB that'll ptrace both 64 and 32 bit apps? Currently gdb only supports 32x64 debugging for the SPU. Ok, thanks. @@ -263,7 +263,8 @@ long compat_arch_ptrace(struct task_struct

Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-03-30 Thread Andreas Schwab
Michael Neuling mi...@neuling.org writes: @@ -263,7 +263,9 @@ long compat_arch_ptrace(struct task_stru ret = ptrace_put_reg(child, numReg, freg); } else { flush_fp_to_thread(child); -((unsigned int

Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-03-30 Thread Andreas Schwab
Michael Neuling mi...@neuling.org writes: So if you're looking fixing 32 bit apps ptracing 64 bit apps, does that mean we can get a single 32 bit GDB that'll ptrace both 64 and 32 bit apps? Currently gdb only supports 32x64 debugging for the SPU. @@ -263,7 +263,8 @@ long

Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-03-30 Thread Michael Neuling
In message m2myb32rk8@igel.home you wrote: Michael Neuling mi...@neuling.org writes: @@ -263,7 +263,9 @@ long compat_arch_ptrace(struct task_stru ret = ptrace_put_reg(child, numReg, freg); } else { flush_fp_to_thread(child); -

[PATCH] Fix ptrace compat wrapper for fpu register access

2009-03-29 Thread Andreas Schwab
The ptrace compat wrapper mishandles access to the fpu registers. The PTRACE_PEEKUSR and PTRACE_POKEUSR requests miscalculate the index into the fpr array due to the broken FPINDEX macro. The PPC_PTRACE_PEEKUSR_3264 request needs to use the same formula that the native ptrace interface uses when

Re: [PATCH] Fix ptrace compat wrapper for fpu register access

2009-03-29 Thread Michael Neuling
The ptrace compat wrapper mishandles access to the fpu registers. The PTRACE_PEEKUSR and PTRACE_POKEUSR requests miscalculate the index into the fpr array due to the broken FPINDEX macro. The PPC_PTRACE_PEEKUSR_3264 request needs to use the same formula that the native ptrace interface uses