Re: [PATCH] [V3] net: add Xilinx emac lite device driver

2009-08-20 Thread David Miller
From: John Linn john.l...@xilinx.com Date: Thu, 20 Aug 2009 03:49:51 -0600 This patch adds support for the Xilinx Ethernet Lite device. The soft logic core from Xilinx is typically used on Virtex and Spartan designs attached to either a PowerPC or a Microblaze processor. Signed-off-by:

Re: [PATCH 1/5] ucc_geth: Fix NULL pointer dereference in uec_get_ethtool_stats()

2009-08-30 Thread David Miller
All 5 patches applied to net-next-2.6 I would have liked to have seen at least one powerpc ACK for patch #2 but these were posted more than a week ago, the patch looks pretty reasonable, and we can't wait forever for stuff like this. ___ Linuxppc-dev

Re: [PATCH] [V3] net: add Xilinx emac lite device driver

2009-09-01 Thread David Miller
From: Michal Simek michal.si...@petalogix.com Date: Mon, 31 Aug 2009 15:18:44 +0200 I see that John's patch has wrong file permission -rwxr-xr-xxilinx_emaclite.c ... should be 644. Please fix it in your repo. Done, thanks! ___ Linuxppc-dev

Re: [PATCH 1/3] phy/marvell: Make non-aneg speed/duplex forcing work for 88E1111 PHYs

2009-09-11 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 10 Sep 2009 06:01:30 +0400 According to specs, when auto-negotiation is disabled, Marvell PHYs need a software reset after changing speed/duplex forcing bits. Otherwise, the modified bits have no effect. Signed-off-by: Anton

Re: [PATCH 2/3] ucc_geth: Rearrange some code to avoid forward declarations

2009-09-11 Thread David Miller
From: Timur Tabi ti...@freescale.com Date: Thu, 10 Sep 2009 08:00:48 -0500 Anton Vorontsov wrote: We'll need ugeth_disable() and ugeth_enable() calls earlier in the file, so rearrange some code to avoid forward declarations. The patch doesn't contain any functional changes.

Re: [PATCH v3 3/3] ucc_geth: Fix hangs after switching from full to half duplex

2009-09-11 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Fri, 11 Sep 2009 01:48:12 +0400 MPC8360 QE UCC ethernet controllers hang when changing link duplex under a load (a bit of NFS activity is enough). PHY: m...@e0102120:00 - Link is Up - 1000/Full sh-3.00# ethtool -s eth0 speed 100

Re: [PATCH] net: xilinx_emaclite: Fix problem with first incoming packet

2009-09-22 Thread David Miller
From: John Linn john.l...@xilinx.com Date: Tue, 22 Sep 2009 10:56:27 -0600 Thanks Grant, I wondered about that myself. I've applied this patch, thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-07 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 6 Oct 2009 22:49:04 -0600 Also, I'd like to take on responsibility for maintaining the cross- architecture device tree code. If there are no objections, I'll write a patch to add a device tree section to MAINTAINERS. Feel free. And

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-07 Thread David Miller
From: Chris Newport c...@netunix.com Date: Wed, 7 Oct 2009 21:54:34 +0100 (BST) Sun4c has also been broken for a long time and sun4d has never worked properly. Is it time to also prune these ?. That would leave only Sun4m in the 32bit kernel, which still works and has plenty of ongoing user

Re: [RFC PATCH 00/12] Merge common OpenFirmware device tree code

2009-10-07 Thread David Miller
From: Chris Newport c...@netunix.com Date: Thu, 8 Oct 2009 02:29:25 +0100 (BST) Sun4d has never had SMP support and Wrong. this is apparantly problematic due to Cray interlectual property causing a lack of bus documentation. XBUS documentation is not available, but we fully know how to

Re: [PATCH] Remove nested function

2009-10-08 Thread David Miller
From: Jérôme Pouiller j...@sysmic.org Date: Thu, 8 Oct 2009 10:34:23 +0200 Some toolchains dislike nested function definition, so we define function match outside of of_phy_find_device. Signed-off-by: Jérôme Pouiller j...@sysmic.org Acked-by: David S. Miller da...@davemloft.net

Re: [PATCH][v2] ibm_newemac: Added 16K Tx FIFO size support for EMAC4

2009-10-08 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Fri, 09 Oct 2009 13:15:02 +1100 On Thu, 2009-10-08 at 11:32 -0500, Dave Mitchell wrote: Some of the EMAC V4 implementations support 16K Tx FIFOs. This patch adds support for this functionality and fixes typos in the Tx FIFO size

Re: [PATCH] pasemi_mac: ethtool set settings support

2009-10-12 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Tue, 6 Oct 2009 11:11:23 -0500 On Mon, Oct 05, 2009 at 05:31:24PM +0400, Valentine Barshak wrote: Add ethtool set settings to pasemi_mac_ethtool. Signed-off-by: Valentine Barshak vbars...@ru.mvista.com Acked-by: Olof Johansson o...@lixom.net

Re: [PATCH 0/8] gianfar: Add support for hibernation

2009-10-13 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Mon, 12 Oct 2009 20:00:00 +0400 Here are few patches that add support for hibernation for gianfar driver. Technically, we could just do gfar_close() and then gfar_enet_open() sequence to restore gianfar functionality after hibernation,

Re: [PATCH 0/8] gianfar: Add support for hibernation

2009-10-13 Thread David Miller
From: Andy Fleming aflem...@freescale.com Date: Tue, 13 Oct 2009 12:22:38 -0500 No, it was fine (though made unnecessary by other patches). The BD has a union: struct { u16 status; /* Status Fields */ u16 length; /*

Re: [PATCH] net: Fix OF platform drivers coldplug/hotplug when compiled as modules

2009-10-14 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 8 Oct 2009 16:15:12 +0400 Some OF platform drivers are missing module device tables, so they won't load automatically on boot. This patch fixes the issue by adding proper MODULE_DEVICE_TABLE() macros to the drivers. Signed-off-by:

Re: [PATCH v2] net/fec_mpc52xx: Fix kernel panic on FEC error

2009-10-14 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Wed, 14 Oct 2009 11:43:43 -0600 From: John Bonesio bo...@secretlab.ca The MDIO bus cannot be accessed at interrupt context, but on an FEC error, the fec_mpc52xx driver reset function also tries to reset the PHY. Since the error is detected

Re: [PATCH 1/3] fsl_pq_mdio: Fix compiler/sparse warnings (part 1)

2009-11-08 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:52:56 +0300 commit 1d2397d742b7a2b39b2f09dd9da3b9d1463f55e9 (fsl_pq_mdio: Add Suport for etsec2.0 devices) introduced the following warnings: ... Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com Applied.

Re: [PATCH 2/3] fsl_pq_mdio: Fix compiler/sparse warnings (part 2)

2009-11-08 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:52:57 +0300 This patch fixes following warnings: fsl_pq_mdio.c:112:38: warning: cast adds address space to expression (asn:2) fsl_pq_mdio.c:124:38: warning: cast adds address space to expression (asn:2)

Re: [PATCH 3/3] gianfar: Fix compiler and sparse warnings

2009-11-08 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:53:00 +0300 commit fba4ed030cfae7efdb6b79a57b0c5a9d72c9de83 (gianfar: Add Multiple Queue Support) introduced the following warnings: ... Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com Applied.

Re: [PATCH RFC] gianfar: Make polling safe with IRQs disabled

2009-11-08 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 01:57:11 +0300 When using KGDBoE, gianfar driver spits 'Interrupt problem' messages, which appears to be a legitimate warning, i.e. we may end up calling netif_receive_skb() or vlan_hwaccel_receive_skb() with IRQs disabled.

Re: [PATCH RFC] gianfar: Do not call skb recycling with disabled IRQs

2009-11-08 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 5 Nov 2009 19:57:38 +0300 But that basically means that with skb recycling we can't safely use KGDBoE, though we can add something like this: Please stop adding special logic only to your driver to handle these things. Either it's a

Re: [PATCH 0/6] gianfar: Some fixes

2009-11-11 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Wed, 11 Nov 2009 09:16:41 -0600 On Nov 10, 2009, at 6:10 PM, Anton Vorontsov wrote: Hi all, Here are some fixes for the gianfar driver, patches on the way. Thanks, Acked-by: Kumar Gala ga...@kernel.crashing.org All applied to

Re: [PATCH] net/can: add driver for mscan family mpc52xx_mscan

2009-11-13 Thread David Miller
From: Wolfram Sang w.s...@pengutronix.de Date: Fri, 13 Nov 2009 17:14:52 +0100 Taken from socketcan-svn, fixed remaining todos, cleaned up, tested with a phyCORE-MPC5200B-IO and a custom board. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Applied.

Re: updates to the mscan-driver in net-next

2009-11-17 Thread David Miller
From: Wolfram Sang w.s...@pengutronix.de Date: Mon, 16 Nov 2009 23:57:43 +0100 here are the patches which fix the issues for the mscan mpc52xx_can drivers raised by Wolfgang Grandegger and Grant Likely. They are based on the initial version of the drivers I sent a few days ago.

Re: [PATCH] ibm_newemac: Fix EMACx_TRTR[TRT] bit shifts

2009-11-18 Thread David Miller
From: Stefan Roese s...@denx.de Date: Wed, 18 Nov 2009 11:07:51 +0100 On Wednesday 18 November 2009 01:56:55 Dave Mitchell wrote: The TRT bit shifts were reversed for EMAC4 and non-EMAC4 during the port from ibm_emac to ibm_newemac. This patch corrects that error. Signed-off-by: Dave

Re: [PATCH 11/11] of: unify phandle name in struct device_node

2009-11-24 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 24 Nov 2009 01:20:05 -0700 In struct device_node, the phandle is named 'linux_phandle' for PowerPC and MicroBlaze, and 'node' for SPARC. There is no good reason for the difference, it is just an artifact of the code diverging over a

Re: [PATCH 11/11] of: unify phandle name in struct device_node

2009-11-24 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 24 Nov 2009 13:33:22 -0700 If you prefer, I can change it all to simply '.phandle'. Please do. ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org

Re: [PATCH v2 11/11] of: unify phandle name in struct device_node

2009-11-24 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 24 Nov 2009 15:01:14 -0700 In struct device_node, the phandle is named 'linux_phandle' for PowerPC and MicroBlaze, and 'node' for SPARC. There is no good reason for the difference, it is just an artifact of the code diverging over a

Re: [PATCH 04/11] of/flattree: eliminate cell_t typedef

2009-11-26 Thread David Miller
From: Segher Boessenkool seg...@kernel.crashing.org Date: Thu, 26 Nov 2009 22:36:41 +0100 You're right, it's not, but makes merging less complex, and then I can refactor properly. Still, make them __be32 at least There is no alignment guarantee at all either, better make it all u8 and use

Re: [PATCH/REPOST] net/mpc5200: Fix locking on fec_mpc52xx driver

2009-12-08 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Fri, 04 Dec 2009 21:33:13 -0700 Fix the locking scheme on the fec_mpc52xx driver. This device can receive IRQs from three sources; the FEC itself, the tx DMA, and the rx DMA. Mutual exclusion was handled by taking a spin_lock() in the

Re: [PATCH] gianfar: Fix build with CONFIG_NET_POLL_CONTROLLER=y

2009-12-09 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 9 Dec 2009 13:44:27 +0300 commit 46ceb60ca80fa07703bc6eb8f4651f900dff5a82 (gianfar: Add Multiple group Support) introduced the following build error with CONFIG_NET_POLL_CONTROLLER=y: ... This patch fixes the issue. Reported-by:

Re: Deprecating of_platform, the path from here...

2009-12-09 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Wed, 9 Dec 2009 15:06:29 -0700 1) of_platform will be deprecated in preference of the platform bus. What a shame, it's one of the cleanest driver probing models in the tree. ___ Linuxppc-dev mailing

Re: Deprecating of_platform, the path from here...

2009-12-09 Thread David Miller
From: David Miller da...@davemloft.net Date: Wed, 09 Dec 2009 16:15:50 -0800 (PST) From: Grant Likely grant.lik...@secretlab.ca Date: Wed, 9 Dec 2009 15:06:29 -0700 1) of_platform will be deprecated in preference of the platform bus. What a shame, it's one of the cleanest driver probing

Re: Deprecating of_platform, the path from here...

2009-12-10 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Thu, 10 Dec 2009 13:47:33 -0700 Trying to go the other way around (deprecate platform and encouraging of_platform instead) I don't think will gain much traction; whereas I think bringing of_platform features into platform will be an easier

Re: [PATCH 0/3] ucc_geth: Some more fixes

2009-12-26 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 24 Dec 2009 18:30:34 +0300 Here are some more fixes and one small enhancement for the ucc_geth driver. All 3 patches applied, thanks a lot! ___ Linuxppc-dev mailing list

Re: [PATCH 1/3] phylib: Fix deadlock on resume

2009-12-27 Thread David Miller
From: Anton Vorontsov cbouatmai...@gmail.com Date: Wed, 23 Dec 2009 01:14:47 +0300 Sometimes kernel hangs on resume with the following trace: ... This patch fixes the issue by stopping the state machine on suspend and starting it again on resume. Signed-off-by: Anton Vorontsov

Re: [PATCH 2/3] phylib: Properly reinitialize PHYs after hibernation

2009-12-27 Thread David Miller
From: Anton Vorontsov cbouatmai...@gmail.com Date: Wed, 23 Dec 2009 01:14:51 +0300 Since hibernation assumes power loss, we should fully reinitialize PHYs (including platform fixups), as if PHYs were just attached. This patch factors phy_init_hw() out of phy_attach_direct(), then converts

Re: [PATCH 2/3] phylib: Properly reinitialize PHYs after hibernation

2009-12-27 Thread David Miller
Actually I'm reverting both patches: drivers/net/phy/mdio_bus.c:268: warning: ‘mdio_bus_phy_may_suspend’ defined but not used Please resubmit these two patches with this warning fixed. CONFIG_PM is not always enabled :-) ___ Linuxppc-dev mailing

Re: net: Assorted fixes

2009-12-30 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 30 Dec 2009 21:21:46 +0300 On Sun, Dec 27, 2009 at 09:57:36PM -0800, David Miller wrote: Actually I'm reverting both patches: drivers/net/phy/mdio_bus.c:268: warning: ‘mdio_bus_phy_may_suspend’ defined but not used Please

Re: [PATCH 1/3] ehea: Use net_device_ops structure

2009-01-21 Thread David Miller
From: Thomas Klein tkl...@de.ibm.com Date: Wed, 21 Jan 2009 15:49:00 +0100 Adapt to lately introduced net_device_ops structure. Signed-off-by: Thomas Klein tkl...@de.ibm.com Applied. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org

Re: [PATCH 2/3] ehea: Fix mem allocations which require page alignment

2009-01-21 Thread David Miller
From: Thomas Klein tkl...@de.ibm.com Date: Wed, 21 Jan 2009 15:49:20 +0100 PAGE_SIZE allocations via slab are not guaranteed to be page-aligned. Fixed all memory allocations where page alignment is required by firmware. Signed-off-by: Thomas Klein tkl...@de.ibm.com Applied.

Re: [PATCH 3/3] ehea: Improve driver behaviour in low mem conditions

2009-01-21 Thread David Miller
From: Thomas Klein tkl...@de.ibm.com Date: Wed, 21 Jan 2009 15:49:41 +0100 Reworked receive queue fill policies to make the driver more tolerant in low memory conditions. Signed-off-by: Thomas Klein tkl...@de.ibm.com Applied, but there is an even better way to handle this. You should be

perf_counter vs. oprofile

2009-01-21 Thread David Miller
Paul, I just noticed that right now if perf counter is enabled, the oprofile module load will always fail because the powerpc perf counter support unconditionally grabs the PMC hardware using reserve_pmc_hardware() in an arch_initcall() There really needs to be a way to segregate these multiple

Re: perf_counter vs. oprofile

2009-01-21 Thread David Miller
From: Paul Mackerras pau...@samba.org Date: Thu, 22 Jan 2009 18:06:13 +1100 Out of curiosity, what ppc hardware are you using perf_counters on? A G5? An UltraSPARC-IIIi :-) I just wanted to make sure you realized the conflict, and you obviously do.

Re: [PATCH] phylib: Fix oops in suspend/resume paths

2009-01-22 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Thu, 22 Jan 2009 21:09:30 +0300 Suspend/resume routines check for phydrv != NULL, but that is wrong because phydrv comes from container_of(drv). If drv is NULL, then container_of(drv) will return non-NULL result, and the checks won't work.

Re: [PATCH] gianfar: Fix Wake-on-LAN support

2009-01-29 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 28 Jan 2009 23:35:45 +0300 commit 0f0ca340e57bd7446855fefd07a64249acf81223 (phy: power management support) caused a regression in the gianfar driver. Now phylib turns off PHY power during suspend, and thus WOL doesn't work anymore.

Re: [Patch] 2.6.29-rc3-git2 - Fix net/ipv6/ip6mr.o build break

2009-01-31 Thread David Miller
Thanks for the report, Dave Jones already posted this fix (CC:'d to the correct location, net...@vger.kernel.org) ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH -next 1/2] gianfar: Implement proper, per netdevice wakeup management

2009-02-01 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 28 Jan 2009 23:38:54 +0300 This patch implements wakeup management for the gianfar driver. The driver should set wakeup enable if WOL is enabled, so that phylib won't power off an attached PHY. Signed-off-by: Anton Vorontsov

Re: [PATCH -next 2/2] phylib: Rework suspend/resume code to check netdev wakeup capability

2009-02-01 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 28 Jan 2009 23:39:14 +0300 In most cases (e.g. PCI drivers) MDIO and MAC controllers are represented by the same device. But for SOC ethernets we have separate devices. So, in SOC case, checking whether MDIO controller may wakeup is

Re: [PATCH] gianfar: Fix sparse warnings

2009-02-01 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 28 Jan 2009 23:52:20 +0300 This patch fixes following sparse warnings: ... Signed-off-by: Anton Vorontsov avoront...@ru.mvista.com Also applied, thanks. ___ Linuxppc-dev mailing list

Re: [PATCH] powerpc: Rework I$/D$ coherency (v2)

2009-02-07 Thread David Miller
From: Benjamin Herrenschmidt b...@kernel.crashing.org Date: Mon, 02 Feb 2009 11:10:24 +1100 +/* has to be a macro because of include dependencies */ +static inline int is_exec_fault(void) +{ + return current-thread.regs TRAP(current-thread.regs) == 0x400; +} Nice macro :-)

Re: [PATCH] ehea: Fix: Remove adapter from adapter list in error path

2009-02-11 Thread David Miller
From: Hannes Hering hannes.her...@linux.vnet.ibm.com Date: Wed, 11 Feb 2009 13:29:02 +0100 Remove adapter from adapter list before freeing data structure in error path. Signed-off-by: Hannes Hering heri...@de.ibm.com Applied to net-next-2.6, thanks!

Re: next Feb 10: mm/slqb build break

2009-02-11 Thread David Miller
From: Nick Piggin npig...@suse.de Date: Thu, 12 Feb 2009 02:45:03 +0100 On Tue, Feb 10, 2009 at 01:53:51PM +0200, Pekka Enberg wrote: Actually, that's not the root cause here. You seem to have CONFIG_SMP disabled but CONFIG_NUMA enabled. That's not possible on x86 which makes me think it's

Re: [PATCH] Enable hashdist by default on PowerPC

2009-02-18 Thread David Miller
From: Anton Blanchard an...@samba.org Date: Wed, 18 Feb 2009 16:11:12 +1100 @@ -145,9 +145,10 @@ extern void *alloc_large_system_hash(const char *tablename, #define HASH_EARLY 0x0001 /* Allocating during early boot? */ /* Only NUMA needs hash distribution. - * IA64 and

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-02-18 Thread David Miller
From: Henk Stegeman henk.stege...@gmail.com Date: Wed, 18 Feb 2009 11:41:14 +0100 Please CC: netdev, now added, on all networking reports and patches. Thank you. I discovered the hard way that because linux bridging uses net_device_ops, bridging only works with network drivers that publish

Re: [PATCH] Enable hashdist by default on PowerPC

2009-02-20 Thread David Miller
From: Anton Blanchard an...@samba.org Date: Fri, 20 Feb 2009 16:19:56 +1100 Hi David, I should probably do this on sparc64 too. Why don't we just change this thing to CONFIG_64BIT? I agree. How does this look? Hmmm... my bad, I think you need to keep the CONFIG_NUMA there too as

Re: [PATCH] ehea: Fix memory hotplug handling

2009-02-20 Thread David Miller
From: Thomas Klein tkl...@de.ibm.com Date: Thu, 19 Feb 2009 12:32:11 +0100 Added missing set_bit() to disable data transfer when a memchange notification is handled Signed-off-by: Thomas Klein tkl...@de.ibm.com Applied to net-next-2.6 But this was a real pain because you never tell me what

Re: [PATCH net] gianfar : Do right check on num_txbdfree

2009-02-26 Thread David Miller
From: Rini van Zetten r...@arvoo.nl Date: Thu, 26 Feb 2009 09:56:58 +0100 This patch fixes a wrong check on num_txbdfree. It could lead to num_txbdfree become nagative. Result was that the gianfar stops sending data. Signed-off-by: Rini van Zetten rini at arvoo dot nl Please use

Re: [PATCH] Enable hashdist by default on 64bit NUMA

2009-02-26 Thread David Miller
From: Anton Blanchard an...@samba.org Date: Thu, 26 Feb 2009 22:24:32 +1100 On PowerPC we allocate large boot time hashes on node 0. This leads to an imbalance in the free memory, for example on a 64GB box (4 x 16GB nodes): Free memory: Node 0: 97.03% Node 1: 98.54% Node 2: 98.42% Node

Re: [PATCH v2 net] gianfar : Do right check on num_txbdfree

2009-02-27 Thread David Miller
From: Andy Fleming aflem...@gmail.com Date: Thu, 26 Feb 2009 16:07:16 -0600 On Thu, Feb 26, 2009 at 4:25 AM, Rini van Zetten r...@arvoo.nl wrote: This patch fixes a wrong check on num_txbdfree. It could lead to num_txbdfree become nagative. Result was that the gianfar stops sending data.

Re: leds: Add openfirmware platform device support breaks sparc

2009-03-03 Thread David Miller
From: Sean MacLennan smaclen...@pikatech.com Date: Tue, 3 Mar 2009 19:29:32 -0500 It has been. u carry the two... longer than I want to admit since I worked on a sparc. Would GPIO based LEDS make sense on a sparc platform? Is sparc used much in the embedded world? If yes, the

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-03-10 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 10 Mar 2009 11:13:02 -0600 Hi Henk, Acked-by: Grant Likely grant.lik...@secretlab.ca ... Jeff, after Henk provides his s-o-b line, do you want to pick it up, or should I merge it through my mpc52xx powerpc tree (via benh). Send it to

Re: RX problem in ibm_newemac driver

2009-03-13 Thread David Miller
From: Felix Radensky fe...@embedded-sol.com Date: Wed, 11 Mar 2009 10:56:31 +0200 Benjamin Herrenschmidt wrote: emac: Fix clock control for 405EX and 405EXr chips The EMAC variant in the 405EX and 405EXr chips needs the 440EP type clock control workaround to avoid lockups of the Rx side

Re: [PATCH net-next-2.6] ehea: fix circular locking problem

2009-03-13 Thread David Miller
From: Jan-Bernd Themann ossth...@de.ibm.com Date: Thu, 12 Mar 2009 16:20:18 +0100 This patch fixes the circular locking problem by changing the locking strategy concerning the logging of firmware handles. Signed-off-by: Jan-Bernd Themann them...@de.ibm.com Applied, thanks.

Re: [PATCH 9/9] net/fs_enet: Rework fs_enet driver to use of_mdio infrastructure

2009-03-18 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Wed, 18 Mar 2009 23:07:35 -0600 RFC, please don't apply yet. You know, if you have posted a 0/9 patch explaining the purpose and intent of the patch series, you'd only need to re-shit into my inbox one time to say this stuff is RFC and don't

Re: [PATCH] gianfar: pass the proper dev to DMA ops

2009-03-19 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Tue, 17 Mar 2009 11:16:07 -0500 We need to be passing the of_platform device struct into the DMA ops as its the one that has the archdata setup to know which low-level DMA ops we should be using (not the net_device one). This isn't an issue

Re: [PATCH -next] gianfar, ucc_geth: Use proper address translation for MDIO buses

2009-03-19 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Wed, 18 Mar 2009 22:21:52 +0300 David, I believe Kumar would like to pick this patch into his tree along with a patch set that adds ranges = properties to the device tree... So would you mind if we take it via powerpc.git? No problem, and

Re: [PATCH -next] gianfar: Fix build with CONFIG_PM enabled

2009-03-21 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Thu, 19 Mar 2009 10:16:26 -0500 On Mar 19, 2009, at 10:12 AM, Anton Vorontsov wrote: commit 4826857f1bf07f9c0f1495e9b05d125552c88a85 (gianfar: pass the proper dev to DMA ops) introduced this build breakage: ... Signed-off-by: Anton

Re: [PATCH -next] fsl_pq_mdio: Revive Gianfar TBI PHY support

2009-03-21 Thread David Miller
From: Andy Fleming aflem...@freescale.com Date: Thu, 19 Mar 2009 10:56:59 -0500 On Mar 19, 2009, at 10:52 AM, Anton Vorontsov wrote: commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 (netdev: Merge UCC and gianfar MDIO bus drivers) broke the TSEC TBI PHY support: the ... Signed-off-by:

Re: [PATCH 2.6.29] ucc_geth: Fix oops when using fixed-link support

2009-03-22 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Sat, 21 Mar 2009 01:34:17 +0300 commit b1c4a9dddf09fe99b8f88252718ac5b357363dc4 (ucc_geth: Change uec phy id to the same format as gianfar's) introduced a regression in the ucc_geth driver that causes this oops when fixed-link is used:

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-23 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Mon, 23 Mar 2009 11:17:39 +0100 Sorry for the WS damaged patch, but my current company mailer cannot handle inline patches. Due to this we are setting up a new mail system but it will be a few days before this is ready. Therefore I am

Re: [PATCH -next] fsl_pq_mdio: Use proper address translation

2009-03-23 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Mon, 23 Mar 2009 11:49:07 -0500 Acked-by: Kumar Gala ga...@kernel.crashing.org David, I'm expecting you to pick this up and put it into net-next. Done, thanks. ___ Linuxppc-dev mailing list

Re: [PATCH] ucc_geth: Fix build breakage caused by a merge

2009-03-24 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Tue, 24 Mar 2009 18:37:34 +0300 This patch fixes following build error: CC ucc_geth.o ucc_geth.c: In function 'ucc_geth_probe': ucc_geth.c:3644: error: implicit declaration of function 'uec_mdio_bus_name' make[2]: *** [ucc_geth.o]

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Tue, 24 Mar 2009 11:37:11 +0100 David Miller da...@davemloft.net wrote on 23/03/2009 19:49:28: From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Mon, 23 Mar 2009 11:17:39 +0100 Sorry for the WS damaged patch, but my

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Tue, 24 Mar 2009 23:45:13 +0100 I don't follow. Are these mandatory now? They were not in the old impl. either. See ether_setup() which is called indirectly via alloc_etherdev(). Yawn... ___

Re: [PATCH] ucc_geth: Convert to net_device_ops

2009-03-24 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Wed, 25 Mar 2009 00:08:53 +0100 David Miller da...@davemloft.net wrote on 24/03/2009 23:49:02: From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Tue, 24 Mar 2009 23:45:13 +0100 I don't follow. Are these mandatory

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Wed, 25 Mar 2009 14:30:49 +0100 From 1c2f23b1f37f4818c0fd0217b93eb38ab6564840 Mon Sep 17 00:00:00 2001 From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Tue, 24 Mar 2009 10:19:27 +0100 Subject: [PATCH] ucc_geth: Move freeing

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread David Miller
From: Eric Dumazet da...@cosmosbay.com Date: Wed, 25 Mar 2009 15:04:26 +0100 Joakim Tjernlund a écrit : + /* Tx event processing */ + spin_lock(ugeth-lock); + for (i = 0; i ug_info-numQueuesTx; i++) { + ucc_geth_tx(ugeth-dev, i); + } + spin_unlock(ugeth-lock);

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-25 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Wed, 25 Mar 2009 16:16:24 +0100 UCC_GETH_DEV_WEIGHT needs to be a bit bigger than the number of RX HW buffers avaliable, otherwise one won't be able to drain the whole queue in one go. Changing weight to something bigger made a big

Re: [PATCH 2/2] ucc_geth: Rework the TX logic.

2009-03-27 Thread David Miller
These patches don't apply to the current tree, could you please respin your final version against at the very least Linus's tree? Thanks. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/2] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-27 Thread David Miller
to process. Increase the RX_BD_RING_LEN if you want to increase UCC_GETH_DEV_WEIGHT. However please also provide the performance comparison for this kind of change. Thanks Bring it up with David Miller. Right I told him to make this very change. Pretty soon the driver's won't be able

Re: [PATCH] ucc_geth: Fix three oopses in PHY {de,}initialization code

2009-03-27 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Fri, 27 Mar 2009 20:40:47 +0300 When there are no free snums, UCC ethernet should gracefully fail, but currently it oopses this way: ... Also, when device tree specifies fixed-link, and CONFIG_FIXED_PHY is disabled, we'll get this oops:

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context.

2009-03-30 Thread David Miller
From: Joakim Tjernlund joakim.tjernl...@transmode.se Date: Mon, 30 Mar 2009 12:01:33 +0200 I don't know. But the question you should ask is: Does the networking code promise this now and for the future? If not, you should fix the driver not to relay on netif_queue_stopped() here. Stop this

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 02:26:43 -0600 David, as I mentioned below, I'd really like to get the core changes (1, 4, 5 6) merged into 2.6.30 (assuming Andy confirms they are okay). No, sorry. We could have worked out the interdependencies before the

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 16:19:42 -0600 On Tue, Mar 31, 2009 at 3:57 PM, David Miller da...@davemloft.net wrote: It therefore didn't get any -next exposure, so it's unreasonable to merge this stuff now. Since when has sitting in a -next tree been

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 19:45:02 -0600 Dammit. Why did you have to go and sound so reasonable when I was all geared up for a pointless flame war. well... alright... but I reserve the right to be grumpy and surly for a few days. :-) Just in case

Re: [PATCH 00/14] Add common OF device tree support for MDIO busses

2009-03-31 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Tue, 31 Mar 2009 22:56:38 -0600 At the very least, please consider picking up patches 2 3. They address a real bug (unrelated to the MDIO rework), and only touch the MPC5200 FEC driver. Please submit them seperately, and I will look them

Re: [PATCH 0/3] Series short description

2009-04-02 Thread David Miller
From: Grant Likely grant.lik...@secretlab.ca Date: Wed, 01 Apr 2009 00:16:46 -0600 Here are the fec_mpc52xx patches which should be picked up for 2.6.29. Patch #1 fixes a dma related BUG_ON() discovered after the merge window opened. #2 #3 were original a single patch posted prior to the

Re: [PATCH 1/2] gianfar: Remove unused header

2009-04-02 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Tue, 31 Mar 2009 08:42:58 -0500 Now that the driver is exclusively an of_platform driver we no longer use the structs and #defines in fsl_devices.h Signed-off-by: Kumar Gala ga...@kernel.crashing.org Applied.

Re: [PATCH 2/2] ucc_geth: Remove unused header

2009-04-02 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Tue, 31 Mar 2009 08:42:59 -0500 Now that the driver is exclusively an of_platform driver we no longer use the structs and #defines in fsl_devices.h Signed-off-by: Kumar Gala ga...@kernel.crashing.org Applied.

Re: [PATCH] ucc_geth: Pass proper device to DMA routines, otherwise oops happens

2009-04-02 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Tue, 31 Mar 2009 22:58:37 +0400 The driver should pass a device that actually specifies internal DMA ops, but currently it passes netdev's device, which is wrong and that causes following oops: ... Fix this by passing of_device's device

Re: [PATCH] fsl_pq_mdio: Revive UCC MDIO support

2009-04-02 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Tue, 31 Mar 2009 22:33:52 +0400 commit 1577ecef766650a57fceb171acee2b13cbfaf1d3 (netdev: Merge UCC and gianfar MDIO bus drivers) introduced a regression so that UCC MDIO buses no longer work. This is because fsl_pq_mdio driver wrongly

Re: [PATCH] fsl_pq_mdio: Fix compile failure

2009-04-02 Thread David Miller
From: Kumar Gala ga...@kernel.crashing.org Date: Thu, 2 Apr 2009 08:45:23 -0500 From: Segher Boessenkool seg...@kernel.crashing.org Add EXPORT_SYMBOL_GPL(fsl_pq_mdio_bus_name) for module builds Signed-off-by: Segher Boessenkool seg...@kernel.crashing.org Signed-off-by: Kumar Gala

Re: [PATCH] powerpc: Add configurable -Werror for arch/powerpc

2009-04-06 Thread David Miller
From: Olof Johansson o...@lixom.net Date: Mon, 6 Apr 2009 21:27:43 -0500 On Tue, Apr 07, 2009 at 12:00:41PM +1000, Michael Ellerman wrote: Add an option, on by default, to build all code under arch/powerpc with -Werror, which causes gcc to treat warnings as errors. The intention is to make

Re: [PATCH] fs_enet: convert to netdev_ops

2009-04-11 Thread David Miller
From: Subrata Modak subr...@linux.vnet.ibm.com Date: Thu, 09 Apr 2009 20:19:48 +0530 On Thu, 2009-04-09 at 18:46 +0400, Alexander Beregalov wrote: Reported-by: Subrata Modak subr...@linux.vnet.ibm.com Signed-off-by: Alexander Beregalov a.berega...@gmail.com Thanks. Adding Sachin in Cc:

Re: [BUILD FAILURE 06/12] Next April 14 : PPC64 randconfig [drivers/net/ehea/ehea_main.c]

2009-04-14 Thread David Miller
From: Alexander Beregalov a.berega...@gmail.com Date: Tue, 14 Apr 2009 22:39:38 +0400 ehea: Fix incomplete conversion to net_device_ops Reported-by: Subrata Modak subr...@linux.vnet.ibm.com Signed-off-by: Alexander Beregalov a.berega...@gmail.com Applied, thanks Alexander.

Re: [PATCH] stop send queue before resetting gianfar

2009-04-15 Thread David Miller
From: Markus Brunner super.firetwis...@googlemail.com Date: Wed, 15 Apr 2009 09:51:23 +0200 After a transmit timed out, the reset task will be called, which will free the allocated resources(stop_gfar). If gfar_poll will be called before the resources get allocated again gfar_clean_tx_ring

Re: ppc32: Don't clobber personality flags on exec

2009-04-16 Thread David Miller
From: Andreas Schwab sch...@linux-m68k.org Date: Thu, 16 Apr 2009 18:22:01 +0200 Now that ppc32 implements address randomization it also wants to inherit personality flags like ADDR_NO_RANDOMIZE across exec, for things like `setarch ppc -R' to work. But the ppc32 version of SET_PERSONALITY

Re: [PATCH] ucc_geth: Move freeing of TX packets to NAPI context

2009-04-21 Thread David Miller
From: Anton Vorontsov avoront...@ru.mvista.com Date: Sat, 18 Apr 2009 02:03:48 +0400 This will make the system alot more responsive while ping flooding the ucc_geth ethernet interface. Also set NAPI weight to 64 as this is a common value. Signed-off-by: Joakim Tjernlund

  1   2   3   4   5   6   7   8   9   10   >