On Mon, 2009-08-03 at 16:10 +0530, Sachin Sant wrote:
Steven Rostedt wrote:
Thanks,
I've seen issues with my PPC box and function graph, but the bugs were
also caused by other changes. I'll boot up my PPC64 box and see if
I see the same issues you have.
Hi Steven,
I can still
On Wed, 2009-09-09 at 11:57 +0530, Sachin Sant wrote:
Steven Rostedt wrote:
I'm going through old email, and I found this. Do you still see this
error. I don't recall seeing it myself.
I can still recreate this with 31-rc9. When i enable tracing
with function_graph i notice
On Thu, 2009-09-10 at 11:02 +0530, Sachin Sant wrote:
Steven Rostedt wrote:
Ah, seems the bug happens to be in the module handling. Does the call
back always have .mod_return_to_handler?
Yes. Every time it ends up in .mod_return_to_handler
BTW, do you have CONFIG_IRQSTACK set
On Thu, 2009-09-10 at 11:02 +0530, Sachin Sant wrote:
Steven Rostedt wrote:
Ah, seems the bug happens to be in the module handling. Does the call
back always have .mod_return_to_handler?
Yes. Every time it ends up in .mod_return_to_handler
Hmm, I still can not reproduce it, and I've
On Wed, 2009-09-09 at 11:57 +0530, Sachin Sant wrote:
Steven Rostedt wrote:
I'm going through old email, and I found this. Do you still see this
error. I don't recall seeing it myself.
I can still recreate this with 31-rc9. When i enable tracing
with function_graph i notice
On Sun, 2009-09-13 at 14:37 +1000, Benjamin Herrenschmidt wrote:
On Sun, 2009-09-13 at 00:07 -0400, Steven Rostedt wrote:
982: R_PPC64_ADDR16_HIGHEST
ftrace_return_to_handler
984: 60 84 00 00 ori r4,r4,0
986: R_PPC64_ADDR16_HIGHER
On Tue, 2009-10-06 at 07:20 +1100, Benjamin Herrenschmidt wrote:
On Mon, 2009-10-05 at 09:25 -0400, Steven Rostedt wrote:
Sachin, can you give me more details on how you built that kernel ? (or
give them again in case I missed them the first time around :-), ie,
what toolchain
On Tue, 2009-10-06 at 13:19 +1100, Anton Blanchard wrote:
This patch adds powerpc specific tracepoints for interrupt entry and exit.
While we already have generic irq_handler_entry and irq_handler_exit
tracepoints there are cases on our virtualised powerpc machines where an
interrupt is
work around by including linux/slab.h before creating
the asm/trace.h tracepoints. I assume we don't see this elsewhere because
any non trivial file includes linux/slab.h somewhere :)
Yeah, you need to have normal includes before adding the
CREATE_TRACE_POINTS macro.
Thanks,
Acked-by: Steven
On Thu, 2009-10-08 at 20:21 +0530, Sachin Sant wrote:
Switch to LOAD_REG_ADDR().
Signed-off-by : Sachin Sant sach...@in.ibm.com
---
diff -Naurp old/arch/powerpc/kernel/entry_64.S
new/arch/powerpc/kernel/entry_64.S
--- old/arch/powerpc/kernel/entry_64.S 2009-10-08 18:37:44.0
+0530
On Wed, 2009-10-14 at 17:15 +1100, Benjamin Herrenschmidt wrote:
On Wed, 2009-10-14 at 11:43 +0530, Sachin Sant wrote:
Tested both the patches. Works fine.
Thanks !
Stephen, you merge these yourself or you need me to pick them up in
-powerpc ?
Ben,
You can either pull from my repo
fine with the name powerpc.
Acked-by: Steven Rostedt rost...@goodmis.org
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
I have no problem with any of these changes. I guess this is up to Ben
and company to decide the rest.
-- Steve
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
On Wed, 2009-11-25 at 10:12 -0600, Will Schmidt wrote:
Tested-by: Will Schmidt will_schm...@vnet.ibm.com
Signed-off-by: Will Schmidt will_schm...@vnet.ibm.com
Isn't it assumed that the one that made the patch also tested it? Well I
would hope that is the norm.
-- Steve
On Fri, 2009-01-30 at 00:34 +0300, Anton Vorontsov wrote:
Hi Steven,
I know 2.6.28-rt isn't yet ready, but I could not resist to try
it anyway. ;-)
Here are few issues and ways to solve them:
Currently the -rt tree doesn't link for arch/powerpc:
LD .tmp_vmlinux1
On Thu, 2009-01-29 at 15:21 -0800, Frank Rowand wrote:
Steven Rostedt wrote:
Your email can at an opportune time for me... I was starting to try
2.6.28-rt on ARM and quickly came to the conclusion that the arch
patches weren't the focus yet. But I'm currently side-tracked with
getting my
On Thu, 29 Jan 2009, Geoff Levand wrote:
//*
ip:d0045aec jumps to d0046340 r2: d0050c00
3d82 398c5740 5740 toc:
On Fri, 2009-01-30 at 20:45 +0300, Anton Vorontsov wrote:
On Thu, Jan 29, 2009 at 06:00:43PM -0500, Steven Rostedt wrote:
[...]
BUG: sleeping function called from invalid context at kernel/rtmutex.c:683
in_atomic(): 1 [0100], irqs_disabled(): 0, pid: 7, name: sirq-net-rx/0
Call
On Mon, 2009-02-02 at 11:35 +1100, Benjamin Herrenschmidt wrote:
On Sat, 2009-01-31 at 22:06 +0300, Anton Vorontsov wrote:
According to this discussion:
http://lkml.org/lkml/2008/7/25/338
http://lkml.org/lkml/2008/7/26/72
Frame pointers do nothing useful on PowerPC, so
On Wed, 4 Feb 2009, Sachin P. Sant wrote:
Hi Stephen,
20090204 randconfig build on powerpc fails with :
CC arch/powerpc/kernel/ftrace.o
arch/powerpc/kernel/ftrace.c: In function __ftrace_make_nop:
arch/powerpc/kernel/ftrace.c:204: error: dereferencing pointer to incomplete
type
On Wed, 2009-02-04 at 16:26 +0100, Frédéric Weisbecker wrote:
2009/2/4 Anton Vorontsov avoront...@ru.mvista.com:
Irqsoff, switch and preempt tracers use CALLER_ADDR macros, so they
should select FRAME_POINTER. Otherwise traces are meaningless.
Signed-off-by: Anton Vorontsov
On Sat, 31 Jan 2009, Arnd Bergmann wrote:
On Saturday 31 January 2009, Geoff Levand wrote:
So I take it that the above showed that the code worked for some?
In my trials it blows up on the first load_module() call, and for my
config that was usbcore:
I looked into it some more
On Thu, 2009-02-05 at 11:31 +1100, Benjamin Herrenschmidt wrote:
On Wed, 2009-02-04 at 18:08 +0300, Anton Vorontsov wrote:
Remove -fno-omit-frame-pointer flag from CFLAGS.
Remove -fno-omit-frame-pointer workarounds.
But what about -pg -requires -fno-omit-frame-pointer ?
I don't think it
On Fri, 2009-02-06 at 13:37 +1100, Michael Neuling wrote:
# CONFIG_MODULES is not set
Those are module references. I never tested with modules turned off.
I'll write up a patch tonight.
Thanks,
-- Steve
___
Linuxppc-dev mailing list
[ forgot to add linuxppc ]
On Fri, 6 Feb 2009, Steven Rostedt wrote:
From: Steven Rostedt srost...@redhat.com
Impact: cleanup
The PowerPC ftrace code uses a hacked up DEBUGP macro for prints.
This patch converts it to the standard pr_debug.
Signed-off-by: Steven Rostedt srost
[ forgot to add linuxppc ]
On Fri, 6 Feb 2009, Steven Rostedt wrote:
From: Steven Rostedt srost...@redhat.com
Michael Neuling reported a compile bug when dynamic ftrace was
configured in and modules were not. This was due to the ftrace
code referencing module specific structures
On Fri, 2009-02-06 at 17:23 +1100, Michael Neuling wrote:
In message 20090206060527.369616...@goodmis.org you wrote:
From: Steven Rostedt srost...@redhat.com
Michael Neuling reported a compile bug when dynamic ftrace was
configured in and modules were not. This was due to the ftrace
below, as well as posted here.
-- Steve
The following patch is in:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
branch: ppc/ftrace
Steven Rostedt (1):
ftrace, powerpc64: fix math to calculate offset in TOC
arch/powerpc/kernel/ftrace.c |5
On Wed, 2009-02-11 at 14:23 +0100, Ingo Molnar wrote:
* Benjamin Herrenschmidt b...@kernel.crashing.org wrote:
On Wed, 2009-02-04 at 22:26 +0100, Ingo Molnar wrote:
+include $(srctree)/arch/$(SRCARCH)/Makefile
+
# arch Makefile may override CC so keep this after arch Makefile is
From: Steven Rostedt srost...@redhat.com
The TOCS used by modules are different than the one used by
the core kernel code. The function graph tracer must save and
restore the TOC whenever it traces a module call. But this
is an added overhead to burden the majority of core kernel
code being
From: Steven Rostedt srost...@redhat.com
This is a port of the function graph tracer that was written by
Frederic Weisbecker for the x86.
This only works for PPC64 at the moment and only for static tracing.
PPC32 and dynamic function graph tracing support will come later.
The trace produces
From: Steven Rostedt srost...@redhat.com
There is nothing really arch specific of the push and pop functions
used by the function graph tracer. This patch moves them to generic
code.
Signed-off-by: Steven Rostedt srost...@redhat.com
---
arch/x86/include/asm/ftrace.h| 25
From: Steven Rostedt srost...@redhat.com
This is the port of the function graph tracer to PowerPC with
dynamic tracing.
Signed-off-by: Steven Rostedt srost...@redhat.com
---
arch/powerpc/Kconfig |2 +-
arch/powerpc/kernel/entry_64.S |8 ++-
arch/powerpc/kernel/ftrace.c
Steven Rostedt (7):
tracing/function-graph-tracer: make arch generic push pop functions
powerpc64: port of the function graph tracer
powerpc64, tracing: add function graph tracer with dynamic tracing
powerpc64, ftrace: save toc only on modules for function graph
From: Steven Rostedt rost...@goodmis.org
This patch ports the function graph tracer for PowerPC, but only
for static function tracing.
Signed-off-by: Steven Rostedt rost...@goodmis.org
---
arch/powerpc/Kconfig |2 +-
arch/powerpc/kernel/entry_32.S | 43
From: Steven Rostedt rost...@gollum.(none)
Impact: clean up
Use a macro to save and restore the registers for PowerPC32,
since that code is duplicated.
This is similar to the work done by Cyrill Gorcunov for the
mcount code in x86_64.
Signed-off-by: Steven Rostedt rost...@gollum.(none
From: Steven Rostedt rost...@gollum.(none)
This patch gets function graph tracing working with dynamic function
tracer on PowerPC32.
Signed-off-by: Steven Rostedt rost...@gollum.(none)
---
arch/powerpc/Kconfig |2 +-
arch/powerpc/kernel/entry_32.S |8 ++--
2 files changed
On Thu, 12 Feb 2009, Frederic Weisbecker wrote:
On Wed, Feb 11, 2009 at 08:10:51PM -0500, Steven Rostedt wrote:
The following set of patches are RFC and not for inclusion
(unless everyone is fine with them as is).
This is the port to PowerPC of the function graph tracer
On Thu, 12 Feb 2009, Frederic Weisbecker wrote:
On Wed, Feb 11, 2009 at 08:10:51PM -0500, Steven Rostedt wrote:
The following set of patches are RFC and not for inclusion
(unless everyone is fine with them as is).
This is the port to PowerPC of the function graph tracer
On Wed, 11 Feb 2009, Steven Rostedt wrote:
The following set of patches are RFC and not for inclusion
(unless everyone is fine with them as is).
This is the port to PowerPC of the function graph tracer that was written
by Frederic Weisbecker for the x86 architecture. It is broken up
On Thu, 12 Feb 2009, Frederic Weisbecker wrote:
Yes of course, I knew most of it was architecture independant but I delayed
this TODO for future ports, and you've done it.
Thanks.
Just a micro detail: the ftrace_push/pop_return_trace are parts of
the core of the entry/return probe,
On Thu, 12 Feb 2009, Geoff Levand wrote:
On 02/11/2009 05:10 PM, Steven Rostedt wrote:
This is the port to PowerPC of the function graph tracer that was written
by Frederic Weisbecker for the x86 architecture. It is broken up
into a series of logical steps.
I added these to my ps3
On Thu, 12 Feb 2009, Geoff Levand wrote:
On 02/12/2009 03:41 PM, Steven Rostedt wrote:
On Thu, 12 Feb 2009, Geoff Levand wrote:
On 02/11/2009 05:10 PM, Steven Rostedt wrote:
This is the port to PowerPC of the function graph tracer that was written
by Frederic Weisbecker for the x86
On Fri, 13 Feb 2009, Benjamin Herrenschmidt wrote:
On Wed, 2009-02-11 at 20:10 -0500, Steven Rostedt wrote:
+# timers used by tracing
+CFLAGS_REMOVE_time.o = -pg -mno-sched-epilog
endif
That means no tracing of the timer interrupts etc... maybe we should
just move the specific
On Fri, 13 Feb 2009, Benjamin Herrenschmidt wrote:
@@ -55,8 +56,9 @@ static unsigned char *ftrace_call_replace(unsigned
long ip, unsigned long addr)
*/
addr = GET_ADDR(addr);
- /* Set to bl addr */
- op = 0x4801 | (ftrace_calc_offset(ip, addr) 0x03fc);
+
Benjamin,
Please pull the latest ppc/ftrace tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
ppc/ftrace
Steven Rostedt (2):
powerpc, ftrace: use unsigned int for instruction manipulation
powerpc, ftrace: use create_branch lib
From: Steven Rostedt srost...@redhat.com
Impact: clean up, remove duplicate code
When ftrace was first ported to PowerPC, there existed a
create_function_call that would create the instruction to make a call
to a given address. Unfortunately, this call expected to write to
the address
From: Steven Rostedt srost...@redhat.com
The original port of ftrace to PowerPC kept a lot of the code used
by x86. Some of this code was to handle x86's 5 byte instruction.
This was handled by using character arrays to manipulate the
code.
PowerPC has a consistent 4 byte instruction. Using
On Sun, 15 Feb 2009, Michael Ellerman wrote:
/* if (link) set op to 'bl' else 'b' */
- op = 0x4800 | (link ? 1 : 0);
- op |= (ftrace_calc_offset(ip, addr) 0x03fc);
+ op = create_branch((unsigned int *)ip, addr, link ? 1 : 0);
If I was feeling nit-picky I'd say
in mainline.
Please pull the latest mainline/function-graph tree, which can be found at:
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git
mainline/function-graph
Steven Rostedt (1):
tracing/function-graph-tracer: make arch generic push pop functions
arch/x86
Ug, My Red Hat email was not being updated. I totally missed this
thread.
On Fri, 2009-03-20 at 20:57 +0100, Ingo Molnar wrote:
* Anton Vorontsov avoront...@ru.mvista.com wrote:
On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote:
* Anton Vorontsov avoront...@ru.mvista.com
Ben,
Can you ACK this patch? Or even take it in your tree?
Thanks,
-- Steve
On Fri, 2009-03-20 at 19:44 +0300, Anton Vorontsov wrote:
This patch introduces ARCH_HAS_NORMAL_FRAME_POINTERS Kconfig symbol.
When defined, the top level Makefile won't add -fno-omit-frame-pointer
cflag (the flag
Ben,
Can you ACK or take this patch too.
Thanks,
-- Steve
On Fri, 2009-03-20 at 19:44 +0300, Anton Vorontsov wrote:
The workarounds aren't needed any longer since the top level Makefile
doesn't pass -fno-omit-frame-pointer cflag for PowerPC.
Signed-off-by: Anton Vorontsov
On Sat, 21 Mar 2009, Ingo Molnar wrote:
* Anton Vorontsov avoront...@ru.mvista.com wrote:
On Fri, Mar 20, 2009 at 08:57:43PM +0100, Ingo Molnar wrote:
* Anton Vorontsov avoront...@ru.mvista.com wrote:
On Fri, Mar 20, 2009 at 08:04:28PM +0100, Ingo Molnar wrote:
*
On Sat, 21 Mar 2009, Ingo Molnar wrote:
Hm, do all the tracers even compile on ppc32 with your patch?
We had periodic build failures on weird, unmaintained architectures
that had no irqflags-tracing support and hence didnt know the
raw_irqs_save/restore primitives ...
welcomed, better implement the
+ # irqflags tracing for your architecture.
+ depends on TRACE_IRQFLAGS_SUPPORT || PPC32
depends on STACKTRACE_SUPPORT
default y
I'm fine with this.
Acked-by: Steven Rostedt srost...@redhat.com
-- Steve
(raw_smp_processor_id());
-
- if (ftrace_push_return_trace(old, calltime,
- self_addr, trace.depth) == -EBUSY) {
+ if (ftrace_push_return_trace(old, self_addr, trace.depth) == -EBUSY) {
This is exactly what I would have done.
Acked-by: Steven Rostedt srost
-by: Steven Rostedt rost...@goodmis.org
Hmm, maybe I'll keep the Git Author as srost...@redhat.com, and change
the signature to my goodmis account. Maybe that would be less confusing.
-- Steve
---
arch/powerpc/kernel/ftrace.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
-by: Michael Ellerman mich...@ellerman.id.au
Acked-by: Steven Rostedt rost...@goodmis.org
-- Steve
---
arch/powerpc/kernel/ftrace.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/ftrace.c b/arch/powerpc/kernel/ftrace.c
index e9d9d38..e1edf5a 100644
On Sun, 2009-04-05 at 23:07 +0200, Sam Ravnborg wrote:
4) The individual HAVE_* members should be sorted alphabetically in the arch
Kconfig file (which they seldomly are :-( )
Note, my first port of Ftrace to PPC sorted the Kconfig HAVE_* macros,
which ended up being reverted :-/
On Sat, 1 Mar 2008, Benjamin Herrenschmidt wrote:
Do we have any indication that it performs better than the C one ?
See below.
Ben.
+_GLOBAL(strncmp)
+ mtctr r5
+ addir5,r3,-1
+ addir4,r4,-1
+1: lbzur3,1(r5)
+ cmpwi 1,r3,0
+ lbzur0,1(r4)
+
Tony,
I'm about to release a new -rt patch based on -rc8. This patch series
blew up totally in trying to get it applied. I'm leaving it out, so after
I release the next series, could you update these patches.
Thanks,
-- Steve
___
Linuxppc-dev
--
On Wed, 26 Sep 2007, Sergei Shtylyov wrote:
Hello.
Steven Rostedt wrote:
Tony,
I'm about to release a new -rt patch based on -rc8. This patch series
blew up totally in trying to get it applied. I'm leaving it out, so after
I release the next series, could you update these patches
On Thu, 2010-04-29 at 10:51 +1000, Anton Blanchard wrote:
Hi,
# gcc -pg -mprofile-kernel
.foo:
0: 7c 08 02 a6 mflrr0
4: f8 01 00 10 std r0,16(r1)
8: 48 00 00 01 bl 8 .foo+0x8 --- call to mcount
c: 7c 08 02 a6 mflrr0
Frederic,
I'm fine with these patches, but since you mainly did the syscall work,
I'll let you take them.
The patches that touch the PowerPC code needs an acked-by from Ben or
Paul.
-- Steve
On Thu, 2010-05-13 at 17:43 +1000, Ian Munsie wrote:
This patch series implements raw system call
callbacks).
I applied this patch which builds (but may be incorrect).
Looks good to me.
Acked-by: Steven Rostedt rost...@goodmis.org
-- Steve
From: Stephen Rothwell s...@canb.auug.org.au
Date: Fri, 28 May 2010 15:05:00 +1000
Subject: [PATCH] tracing: fix for tracepoint API change
Commit
PPC doesn't have the irqs_disabled_flags needed by ftrace.
This patch adds it.
Signed-off-by: Steven Rostedt [EMAIL PROTECTED]
---
include/asm-powerpc/hw_irq.h | 10 ++
1 file changed, 10 insertions(+)
Index: linux-sched-devel.git/include/asm-powerpc/hw_irq.h
The following two patches ports ftrace to PowerPC. I tested this on
both my PPC64 box as well as my 32bit PowerBook G4.
This applies to the latest sched-devel (with some extra hacks to get that
to boot on PPC).
This also depends on the CFLAGS_REMOVE_foo.o patches I sent earlier.
-- Steve
This patch adds full support for ftrace for PowerPC (both 64 and 32 bit).
This includes dynamic tracing and function filtering.
Signed-off-by: Steven Rostedt [EMAIL PROTECTED]
---
arch/powerpc/Kconfig |5
arch/powerpc/kernel/Makefile | 14 ++
arch/powerpc
On Wed, 14 May 2008, David Miller wrote:
From: Steven Rostedt [EMAIL PROTECTED]
Date: Wed, 14 May 2008 23:49:44 -0400
+#ifdef CONFIG_FTRACE
+#ifdef CONFIG_DYNAMIC_FTRACE
+_GLOBAL(mcount)
+_GLOBAL(_mcount)
+ stwur1,-48(r1)
+ stw r3, 12(r1)
+ stw r4, 16(r1
On Wed, 21 May 2008, Michael Ellerman wrote:
On Wed, 2008-05-14 at 23:49 -0400, Steven Rostedt wrote:
plain text document attachment (ftrace-powerpc-port.patch)
This patch adds full support for ftrace for PowerPC (both 64 and 32 bit).
This includes dynamic tracing and function filtering
On Tue, 20 May 2008, Benjamin Herrenschmidt wrote:
Why do we not want to trace early boot? Just because it's not useful?
Not running at the linked address... might be causing trouble.
I figured it was something like that, so I didn't look too deep into it,
and decided that it was best just
This patch cleans up the ftrace code in PowerPC based on the comments from
Michael Ellerman.
Signed-off-by: Steven Rostedt [EMAIL PROTECTED]
---
-0700 |binary
arch/powerpc/kernel/entry_32.S | 11 ++-
arch/powerpc/kernel/ftrace.c|8 +++-
arch
On Mon, 14 Jul 2008, Stephen Rothwell wrote:
Hi Paul, Ben,
Today's linux-next merge of the powerpc tree got a conflict in
arch/powerpc/Kconfig between commit
4e491d14f2506b218d678935c25a7027b79178b1 (ftrace: support for PowerPC)
from the ftrace tree and commit
On Sat, 19 Jul 2008, Benjamin Herrenschmidt wrote:
With the original patch, the pending batch does get flushed
in a non-preemptable region.
I am resending the original with just adding the necesary comments.
Your comment isn't what I meant. What I meant is that if the process
is context
-by: Steven Rostedt [EMAIL PROTECTED]
---
arch/powerpc/kernel/module.c | 15 ---
1 file changed, 15 deletions(-)
Index: linux-tip.git/arch/powerpc/kernel/module.c
===
--- linux-tip.git.orig/arch/powerpc/kernel/module.c 2008-08
Eran Liberty wrote:
After compiling a kernel with ftrace I started to experience all sorts
of crashes.
Just to make sure...
ftrace enables markers too, and RCU has tracing with the markers. This
may not be the problem, but I just want to eliminate as many variables
as possible.
Could you
Mathieu Desnoyers wrote:
Steve ? I just noticed this :
ftrace_modify_code(unsigned long ip, unsigned char *old_code,
unsigned char *new_code)
{
unsigned replaced;
unsigned old = *(unsigned *)old_code;
unsigned new = *(unsigned *)new_code;
int
On Mon, 18 Aug 2008, Scott Wood wrote:
Mathieu Desnoyers wrote:
asm volatile (
1: lwz %1, 0(%2)\n
cmpw%1, %5\n
bne 2f\n
stwu%3, 0(%2)\n
2:\n
On Mon, 18 Aug 2008, Scott Wood wrote:
Mathieu Desnoyers wrote:
asm volatile (
1: lwz %1, 0(%2)\n
cmpw%1, %5\n
bne 2f\n
stwu%3, 0(%2)\n
2:\n
On Mon, 18 Aug 2008, Eran Liberty wrote:
Steven Rostedt wrote:
Eran Liberty wrote:
After compiling a kernel with ftrace I started to experience all sorts of
crashes.
Just to make sure...
ftrace enables markers too, and RCU has tracing with the markers. This may
On Mon, 18 Aug 2008, Scott Wood wrote:
Steven Rostedt wrote:
What syntax to do that with?
lwz %1,0(%U2)
stu %3, 0(%X2)
I'm new to those. (and the above does not compile)
lwz%U2%X2 %1, %2
stw%U2%X2 %3, %2
Thanks, that's new to me.
Why stwu with an offset of zero
On Tue, 19 Aug 2008, Benjamin Herrenschmidt wrote:
On Mon, 2008-08-18 at 14:27 -0400, Steven Rostedt wrote:
On Mon, 18 Aug 2008, Scott Wood wrote:
Mathieu Desnoyers wrote:
asm volatile (
1: lwz %1, 0(%2)\n
cmpw%1
On Tue, 19 Aug 2008, Benjamin Herrenschmidt wrote:
Hmm, this was originally copied from x86, where we did a cmpxchg, but that
is probably not needed since all of this is done in kstop_machine. Also,
only the get is needed. If we don't fault there, we wont fault on the
put (unless we
might want to look at the entry.S mcount code too.
Still, here it is:
Thanks,
powerpc/ftrace: Fix broken assembly for code replacement
Instead, uses __get_user() and __put_user().
Acked-by: Steven Rostedt [EMAIL PROTECTED]
-- Steve
On Mon, 18 Aug 2008, Mathieu Desnoyers wrote:
* Steven Rostedt ([EMAIL PROTECTED]) wrote:
On Tue, 19 Aug 2008, Benjamin Herrenschmidt wrote:
Hmm, this was originally copied from x86, where we did a cmpxchg, but
that
is probably not needed since all of this is done
On Mon, 18 Aug 2008, Mathieu Desnoyers wrote:
Argh. See text_poke(). It's there exactly for this purpose on x86.
Ouch, I just did. text_poke is quite heavy. It would be interesting to see
that performed on 20,000 locations at one time. I could play with it, but
I'm a bit
On Mon, 18 Aug 2008, Mathieu Desnoyers wrote:
* Steven Rostedt ([EMAIL PROTECTED]) wrote:
On Tue, 19 Aug 2008, Benjamin Herrenschmidt wrote:
Hmm, this was originally copied from x86, where we did a cmpxchg, but
that
is probably not needed since all of this is done
On Tue, 19 Aug 2008, Eran Liberty wrote:
Steven Rostedt wrote:
Testing tracer sched_switch: PASSED
Testing tracer ftrace: PASSED
Testing dynamic ftrace: PASSED
Do you have PREEMPT_TRACER enabled, or any other tracer for that matter?
-- Steve
Oops: Exception in kernel
On Tue, 19 Aug 2008, Mathieu Desnoyers wrote:
Ok, there are two cases where it's ok :
1 - in stop_machine, considering we are not touching code executed in
NMI handlers.
2 - when using my replace_instruction_safe() which uses a temporary
breakpoint when doing the instruction replacement.
On Wed, 20 Aug 2008, Eran Liberty wrote:
Steven Rostedt wrote:
On Tue, 19 Aug 2008, Eran Liberty wrote:
Steven Rostedt wrote:
Testing tracer sched_switch: PASSED
Testing tracer ftrace: PASSED
Testing dynamic ftrace: PASSED
Do
On Wed, 20 Aug 2008, Benjamin Herrenschmidt wrote:
Found the problem (or at least -a- problem), it's a gcc bug.
Well, first I must say the code generated by -pg is just plain
horrible :-)
Appart from that, look at the exit of, for example, __d_lookup, as
generated by gcc when ftrace is
On Wed, 20 Aug 2008, Steven Rostedt wrote:
On Wed, 20 Aug 2008, Benjamin Herrenschmidt wrote:
Found the problem (or at least -a- problem), it's a gcc bug.
Well, first I must say the code generated by -pg is just plain
horrible :-)
Appart from that, look at the exit
On Wed, 20 Aug 2008, Eran Liberty wrote:
Steven Rostedt wrote:
On Wed, 20 Aug 2008, Steven Rostedt wrote:
On Wed, 20 Aug 2008, Benjamin Herrenschmidt wrote:
Found the problem (or at least -a- problem), it's a gcc bug.
Well, first I must say the code
On Wed, 20 Aug 2008, Josh Boyer wrote:
Segher was looking at this a bit this morning. He thinks it's really
-fno-omit-frame-pointer that is causing this. That really shouldn't
even be set on PowerPC, but FTRACE uses select which overrides the
depends on stuff in Kconfig.
I can easily
On Wed, 20 Aug 2008, Jon Smirl wrote:
c00bb690: bb 0b ff e0 lmw r24,-32(r11)
c00bb694: 7c 08 03 a6 mtlrr0
c00bb698: 4e 80 00 20 blr
Yep, you have the same bug in your compiler.
-- Steve
Hmm... so whats now?
Is
On Wed, 20 Aug 2008, Eran Liberty wrote:
c00bb670: 41 9e 00 50 beq-cr7,c00bb6c0 __d_lookup+0x13c
c00bb674: 83 de 00 00 lwz r30,0(r30)
c00bb678: 2f 9e 00 00 cmpwi cr7,r30,0
c00bb67c: 40 9e ff 98 bne+cr7,c00bb614
On Wed, 20 Aug 2008, Eran Liberty wrote:
mon X
~ #
And took it for a test drive
~# while [ 1 ] ; do find / /dev/null ; echo . ; done
.
.
.
[ 10 min later ]
.
.
.
Stable! Yeepee.
Eran, thanks a lot for testing this!
So how do we get this to be right in the first place and
On Thu, 21 Aug 2008, Benjamin Herrenschmidt wrote:
As you can see, it restores r1 -before- it pops r24..r31 off
the stack ! I let you imagine what happens if an interrupt happens
just in between those two instructions (mr and lmw). We don't do
redzones on our ABI, so basically, the
I spent the day chasing a bug that would hang PPC on boot up when ftrace
is configured in. I found that it was simply a stupid bug I did to
handle the non MCOUNT_RECORD case. Since I was testing only on x86,
and the MCOUNT_RECORD is automatically set for dynamic ftrace if
it is available, I did
1 - 100 of 563 matches
Mail list logo
