Re: [PATCH v2 2/3] usb: typec: nvidia: drop driver owner assignment

2024-04-03 Thread Heikki Krogerus 
On Sun, Mar 31, 2024 at 11:17:36AM +0200, Krzysztof Kozlowski wrote:
> Core in typec_altmode_register_driver() already sets the .owner, so
> driver does not need to.
> 
> Signed-off-by: Krzysztof Kozlowski 

Reviewed-by: Heikki Krogerus 

> ---
> 
> Changes in v2:
> 1. None
> ---
>  drivers/usb/typec/altmodes/nvidia.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/altmodes/nvidia.c 
> b/drivers/usb/typec/altmodes/nvidia.c
> index c36769736405..fe70b36f078f 100644
> --- a/drivers/usb/typec/altmodes/nvidia.c
> +++ b/drivers/usb/typec/altmodes/nvidia.c
> @@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
>   .remove = nvidia_altmode_remove,
>   .driver = {
>   .name = "typec_nvidia",
> - .owner = THIS_MODULE,
>   },
>  };
>  module_typec_altmode_driver(nvidia_altmode_driver);
> -- 
> 2.34.1

-- 
heikki

[PATCH v2 2/3] usb: typec: nvidia: drop driver owner assignment

2024-03-31 Thread Krzysztof Kozlowski 
Core in typec_altmode_register_driver() already sets the .owner, so
driver does not need to.

Signed-off-by: Krzysztof Kozlowski 

---

Changes in v2:
1. None
---
 drivers/usb/typec/altmodes/nvidia.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/typec/altmodes/nvidia.c 
b/drivers/usb/typec/altmodes/nvidia.c
index c36769736405..fe70b36f078f 100644
--- a/drivers/usb/typec/altmodes/nvidia.c
+++ b/drivers/usb/typec/altmodes/nvidia.c
@@ -35,7 +35,6 @@ static struct typec_altmode_driver nvidia_altmode_driver = {
.remove = nvidia_altmode_remove,
.driver = {
.name = "typec_nvidia",
-   .owner = THIS_MODULE,
},
 };
 module_typec_altmode_driver(nvidia_altmode_driver);
-- 
2.34.1