Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-08 Thread Geert Uytterhoeven
Hi Jiri, On Mon, Apr 8, 2024 at 7:37 AM Jiri Slaby wrote: > On 08. 04. 24, 7:32, Jiri Slaby wrote: > > On 08. 04. 24, 7:29, Michael Ellerman wrote: > >> Many maintainers won't drop Cc: tags if they are there in the submitted > >> patch. So I agree with Andy that we should encourage folks not to

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Greg Kroah-Hartman
On Mon, Apr 08, 2024 at 07:37:22AM +0200, Jiri Slaby wrote: > On 08. 04. 24, 7:32, Jiri Slaby wrote: > > On 08. 04. 24, 7:29, Michael Ellerman wrote: > > > Many maintainers won't drop Cc: tags if they are there in the submitted > > > patch. So I agree with Andy that we should encourage folks not

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Jiri Slaby
On 08. 04. 24, 7:32, Jiri Slaby wrote: On 08. 04. 24, 7:29, Michael Ellerman wrote: Many maintainers won't drop Cc: tags if they are there in the submitted patch. So I agree with Andy that we should encourage folks not to add them in the first place. But fix the docs first. I am personally

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Jiri Slaby
On 08. 04. 24, 7:29, Michael Ellerman wrote: Many maintainers won't drop Cc: tags if they are there in the submitted patch. So I agree with Andy that we should encourage folks not to add them in the first place. But fix the docs first. I am personally not biased to any variant (as in: I don't

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-07 Thread Michael Ellerman
Finn Thain writes: > On Fri, 5 Apr 2024, Michael Ellerman wrote: >> >> > > --- >> >> > (here is a good location for Cc:) >> >> >> >> Documentation/process/submitting-patches.rst indicats that it should >> >> be above the "---" separator together with Acked-by etc. Has this >> >> convention

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Andy Shevchenko
On Fri, Apr 5, 2024 at 6:06 AM Michael Ellerman wrote: > Andy Shevchenko writes: > > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: > >> On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > >> > > Cc: Benjamin Herrenschmidt > >> > > Cc: Michael Ellerman > >> > > Cc: Nicholas Piggin > >> > >

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Andy Shevchenko
On Fri, Apr 5, 2024 at 1:15 AM Finn Thain wrote: > On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > > > > --- > > > > (here is a good location for Cc:) > > > > > > Documentation/process/submitting-patches.rst indicats that it should > > > be above the "---" separator together with Acked-by etc.

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Finn Thain
On Fri, 5 Apr 2024, Michael Ellerman wrote: > >> > > --- > >> > (here is a good location for Cc:) > >> > >> Documentation/process/submitting-patches.rst indicats that it should > >> be above the "---" separator together with Acked-by etc. Has this > >> convention changed recently? > > The

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Michael Ellerman
Andy Shevchenko writes: > On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: >> On Thu, 4 Apr 2024, Andy Shevchenko wrote: > >> > > Cc: Benjamin Herrenschmidt >> > > Cc: Michael Ellerman >> > > Cc: Nicholas Piggin >> > > Cc: Christophe Leroy >> > > Cc: "Aneesh Kumar K.V" >> > > Cc: "Naveen N.

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Finn Thain
On Thu, 4 Apr 2024, Andy Shevchenko wrote: > > > > > --- > > > (here is a good location for Cc:) > > > > Documentation/process/submitting-patches.rst indicats that it should > > be above the "---" separator together with Acked-by etc. Has this > > convention changed recently? > > I see, I

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Andy Shevchenko
On Thu, Apr 4, 2024 at 2:57 AM Finn Thain wrote: > On Thu, 4 Apr 2024, Andy Shevchenko wrote: ... > > > Cc: Benjamin Herrenschmidt > > > Cc: Michael Ellerman > > > Cc: Nicholas Piggin > > > Cc: Christophe Leroy > > > Cc: "Aneesh Kumar K.V" > > > Cc: "Naveen N. Rao" > > > Cc:

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-04 Thread Andy Shevchenko
On Thu, Apr 4, 2024 at 8:07 AM Jiri Slaby wrote: > On 04. 04. 24, 0:29, Andy Shevchenko wrote: > >> Cc: Benjamin Herrenschmidt > >> Cc: Michael Ellerman > >> Cc: Nicholas Piggin > >> Cc: Christophe Leroy > >> Cc: "Aneesh Kumar K.V" > >> Cc: "Naveen N. Rao" > >> Cc:

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-03 Thread Jiri Slaby
On 04. 04. 24, 0:29, Andy Shevchenko wrote: Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: "Aneesh Kumar K.V" Cc: "Naveen N. Rao" Cc: linux-m...@lists.linux-m68k.org Second, please move these Cc to be after the '---' line Sorry, but why?

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-03 Thread Finn Thain
On Thu, 4 Apr 2024, Andy Shevchenko wrote: > ... > > First of all, please read this > https://www.kernel.org/doc/html/latest/process/submitting-patches.html#backtraces-in-commit-messages > and amend the commit message accordingly. > Right -- the call chain is described in the commit log

Re: [PATCH] serial/pmac_zilog: Remove flawed mitigation for rx irq flood

2024-04-03 Thread Andy Shevchenko
Thu, Mar 28, 2024 at 03:11:33PM +1100, Finn Thain kirjoitti: > The mitigation was intended to stop the irq completely. That might have > been better than a hard lock-up but it turns out that you get a crash > anyway if you're using pmac_zilog as a serial console. > > That's because the pr_err()