https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From 08a5dde36450c99137c7b03bec503daca18bc2d2 Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Mon, 4 Mar 2024 23:21:04 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
https://github.com/joker-eph updated
https://github.com/llvm/llvm-project/pull/83702
>From 5f657d872a78af9fb0035fc2f04dfa7ead7abadd Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Mon, 4 Mar 2024 23:21:04 -0800
Subject: [PATCH] Rename llvm::ThreadPool -> llvm::DefaultThreadPool (NFC)
The
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/83702
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
joker-eph wrote:
> One patch ThreadPool->DefaultThreadPool (people get a build error about
> ThreadPool not being the name of anything, find this patch as the root cause,
> and rename all their ThreadPool->DefaultThreadPool)
Gotcha, thanks for elaborating, somehow my brain was slow on a
pogo59 wrote:
> separating them might be marginally better for downstrteamers.
Hear, hear.
https://github.com/llvm/llvm-project/pull/83702
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dwblaikie wrote:
> @dwblaikie : how would you split it? I didn't quite get the two renamings you
> have in mind?
One patch `ThreadPool->DefaultThreadPool` (people get a build error about
`ThreadPool` not being the name of anything, find this patch as the root cause,
and rename all their
joker-eph wrote:
@dwblaikie : how would you split it? I didn't quite get the two renamings you
have in mind?
https://github.com/llvm/llvm-project/pull/83702
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
dwblaikie wrote:
I don't have really firm feelings/justification for this, but I'd have guessed
that doing this as two separate (separated by a few days, maybe a week)
renamings would be better for downstream consumers - they'd get a clear break
without any ambiguity/name reuse.
No strong
https://github.com/aganea approved this pull request.
https://github.com/llvm/llvm-project/pull/83702
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kuhar approved this pull request.
Makes sense to me
https://github.com/llvm/llvm-project/pull/83702
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-mlir
@llvm/pr-subscribers-debuginfo
Author: Mehdi Amini (joker-eph)
Changes
This is a breaking change: clients who use to create a ThreadPool must now
create a DefaultThreadPool.
---
Patch is 38.32 KiB, truncated to 20.00 KiB below, full version:
https://github.com/joker-eph created
https://github.com/llvm/llvm-project/pull/83702
This is a breaking change: clients who use to create a ThreadPool must now
create a DefaultThreadPool.
>From aec355378bcb453adc4d697b02c69af30eb5f0ae Mon Sep 17 00:00:00 2001
From: Mehdi Amini
Date: Tue, 27
12 matches
Mail list logo
