https://github.com/ilya-biryukov approved this pull request.
Went through the changes one more time and they definitely LGTM.
See the two small comments left from my side about documentation and release
notes, I think they're worth fixing before landing this. Otherwise, let's ship
it!
@@ -9304,7 +9299,8 @@ TemplateName
ASTContext::getAssumedTemplateName(DeclarationName Name) const {
TemplateName ASTContext::getQualifiedTemplateName(NestedNameSpecifier *NNS,
bool TemplateKeyword,
@@ -9304,7 +9299,8 @@ TemplateName
ASTContext::getAssumedTemplateName(DeclarationName Name) const {
TemplateName ASTContext::getQualifiedTemplateName(NestedNameSpecifier *NNS,
bool TemplateKeyword,
@@ -804,6 +804,8 @@ Bug Fixes to AST Handling
- Clang now properly preserves ``FoundDecls`` within a ``ConceptReference``.
(#GH82628)
- The presence of the ``typename`` keyword is now stored in
``TemplateTemplateParmDecl``.
- Fixed malformed AST generated for anonymous union
https://github.com/ilya-biryukov commented:
The change makes handling of template names more uniform, which overall looks
like a great change.
However, we are changing the contract of `QualifiedTemplateName` (it can have a
null qualifier now) and this seems both counter-intuitive from the API
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/93433
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
ilya-biryukov wrote:
After endless hours and recompilations, I finally have this to share.
It could probably be smaller, but I decided to share this as soon as it crashed
outside of our monorepo.
[module.tgz](https://github.com/llvm/llvm-project/files/15223606/module.tgz)
^^ If you run
ilya-biryukov wrote:
> Can you export all files into a standalone reproducer? I might be able to
> reduce an example.
Not really, this is why it's taking so long. Our infrastructure in that space
is lacking, the issue is that the root case is not in one compilation step, but
rather in some
ilya-biryukov wrote:
Sorry, still struggling to get a small repro. The build graphs we have are
quite large, unfortunately.
Did any of the stack traces or error message I posted help to find certain
problems? Or is there no hope until we get a smaller repro?
ilya-biryukov wrote:
We have hit quite a few issues when trying this out. I have spent a day trying
to reduce to a small repro that I can share, but haven't not fully succeeded
yet, I will continue tomorrow.
Still wanted to share the error descriptions in case that would allow to make
ilya-biryukov wrote:
Thanks for fixing it quickly, we'll try the new patch and get back with the
results.
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ilya-biryukov wrote:
Sorry for the delay, I had an emergency and took a week off.
We have hit some form of OOM (an infinite loop or some exponential computation
allocating memory?) on the following small example (ready as a test case, also
in [this
ilya-biryukov wrote:
Btw, if I don't respond timely to these requests and you need an urgent
reaction, feel free to ping me via email at ibiryu...@google.com.
We heavily use Clang header modules internally at Google and we are really
interested in helping to discover and prevent the module
ilya-biryukov wrote:
We'll pick this up, I'll get back with the testing results.
(Sorry for the delayed response)
https://github.com/llvm/llvm-project/pull/83237
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
14 matches
Mail list logo
