https://github.com/joker-eph approved this pull request.
https://github.com/llvm/llvm-project/pull/82474
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1002,12 +1002,31 @@ class ModifyOperationRewrite : public OperationRewrite {
: OperationRewrite(Kind::ModifyOperation, rewriterImpl, op),
loc(op->getLoc()), attrs(op->getAttrDictionary()),
operands(op->operand_begin(), op->operand_end()),
-
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/82474
>From 1795b6dcfdc0b6447c5209000332432de49109cc Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Wed, 21 Feb 2024 09:37:48 +
Subject: [PATCH] [mlir][Transforms] Support rolling back properties
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/82474
>From f7a0cc4dd214b9f2b234ea5a61eaecdb19b6b3c4 Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Wed, 21 Feb 2024 09:37:48 +
Subject: [PATCH] [mlir][Transforms] Support rolling back properties
https://github.com/joker-eph edited
https://github.com/llvm/llvm-project/pull/82474
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1002,12 +1002,31 @@ class ModifyOperationRewrite : public OperationRewrite {
: OperationRewrite(Kind::ModifyOperation, rewriterImpl, op),
loc(op->getLoc()), attrs(op->getAttrDictionary()),
operands(op->operand_begin(), op->operand_end()),
-
@@ -1016,13 +1035,20 @@ class ModifyOperationRewrite : public OperationRewrite {
op->setOperands(operands);
for (const auto : llvm::enumerate(successors))
op->setSuccessor(it.value(), it.index());
+if (propertiesStorage) {
+ OpaqueProperties
@@ -1002,12 +1002,31 @@ class ModifyOperationRewrite : public OperationRewrite {
: OperationRewrite(Kind::ModifyOperation, rewriterImpl, op),
loc(op->getLoc()), attrs(op->getAttrDictionary()),
operands(op->operand_begin(), op->operand_end()),
-
@@ -1002,12 +1002,31 @@ class ModifyOperationRewrite : public OperationRewrite {
: OperationRewrite(Kind::ModifyOperation, rewriterImpl, op),
loc(op->getLoc()), attrs(op->getAttrDictionary()),
operands(op->operand_begin(), op->operand_end()),
-
https://github.com/matthias-springer updated
https://github.com/llvm/llvm-project/pull/82474
>From 33f2ae9da319110ca8d2581ec6d66d2db83201cb Mon Sep 17 00:00:00 2001
From: Matthias Springer
Date: Wed, 21 Feb 2024 08:41:44 +
Subject: [PATCH] [mlir][Transforms] Support rolling back properties
@@ -1002,12 +1002,31 @@ class ModifyOperationRewrite : public OperationRewrite {
: OperationRewrite(Kind::ModifyOperation, rewriterImpl, op),
loc(op->getLoc()), attrs(op->getAttrDictionary()),
operands(op->operand_begin(), op->operand_end()),
-
llvmbot wrote:
@llvm/pr-subscribers-mlir-core
Author: Matthias Springer (matthias-springer)
Changes
The dialect conversion rolls back in-place op modifications upon failure.
Rolling back modifications of attributes is already supported, but there was no
support for properties until now.
https://github.com/matthias-springer created
https://github.com/llvm/llvm-project/pull/82474
The dialect conversion rolls back in-place op modifications upon failure.
Rolling back modifications of attributes is already supported, but there was no
support for properties until now.
>From
13 matches
Mail list logo
