Author: Daniil Kovalev
Date: 2024-04-03T03:11:37+03:00
New Revision: fa3df6749e2752ce70d1aa1054be1349a86e2dc9
URL:
https://github.com/llvm/llvm-project/commit/fa3df6749e2752ce70d1aa1054be1349a86e2dc9
DIFF:
Author: Mariya Podchishchaeva
Date: 2024-04-02T15:10:59-07:00
New Revision: c13b7485b87909fcf739f62cfa382b55407433c0
URL:
https://github.com/llvm/llvm-project/commit/c13b7485b87909fcf739f62cfa382b55407433c0
DIFF:
Author: Fangrui Song
Date: 2024-04-01T22:10:23Z
New Revision: f249092ef26d6fe9627b0158c7c15dee241226db
URL:
https://github.com/llvm/llvm-project/commit/f249092ef26d6fe9627b0158c7c15dee241226db
DIFF:
https://github.com/llvm/llvm-project/commit/f249092ef26d6fe9627b0158c7c15dee241226db.diff
LOG:
https://github.com/llvmbot created
https://github.com/llvm/llvm-project/pull/87374
Backport 2950283dddab03c183c1be2d7de9d4999cc86131
Requested by: @ian-twilightcoder
>From 20cb23caea75d1d94e930ce0593eb92770f3c94d Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Tue, 2 Apr 2024 08:14:04
https://github.com/llvmbot milestoned
https://github.com/llvm/llvm-project/pull/87374
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/skatrak created
https://github.com/llvm/llvm-project/pull/87365
This patch updates the definition of `omp.simdloop` to enforce the restrictions
of a wrapper operation. It has been renamed to `omp.simd`, to better reflect
the naming used in the spec.
Some changes to Flang
nga888 wrote:
> Hi @nga888 (or anyone else). If you would like to add a note about this fix
> in the release notes (completely optional). Please reply to this comment with
> a one or two sentence description of the fix.
Fix color handling for buffered formatted_raw_ostream which allows the
https://github.com/skatrak updated
https://github.com/llvm/llvm-project/pull/87253
>From daaf4f7fec79aeebf37b4a1d83d89d19904fb417 Mon Sep 17 00:00:00 2001
From: Sergio Afonso
Date: Mon, 1 Apr 2024 17:05:38 +0100
Subject: [PATCH] [MLIR][OpenMP] Make omp.taskloop into a loop wrapper
This patch
https://github.com/skatrak updated
https://github.com/llvm/llvm-project/pull/87239
>From 4537071171506b17de3727800e3754e412c9a967 Mon Sep 17 00:00:00 2001
From: Sergio Afonso
Date: Mon, 1 Apr 2024 14:08:33 +0100
Subject: [PATCH] [MLIR][OpenMP] Make omp.distribute into a loop wrapper
This
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
@@ -1730,9 +1730,28 @@ LogicalResult LoopNestOp::verify() {
<< "range argument type does not match corresponding IV type";
}
+ auto wrapper =
+ llvm::dyn_cast_if_present((*this)->getParentOp());
+
+ if (!wrapper || !wrapper.isWrapper())
+return
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
https://github.com/skatrak updated
https://github.com/llvm/llvm-project/pull/87232
>From 2452bc75a7f2efb67a0522bbe8b0e7ba5bc3365b Mon Sep 17 00:00:00 2001
From: Sergio Afonso
Date: Mon, 1 Apr 2024 13:04:14 +0100
Subject: [PATCH 1/2] [MLIR][OpenMP] Introduce the LoopWrapperInterface
This patch
skatrak wrote:
Thank you @kparzysz for sharing your thoughts. I think it's a reasonable
solution, so it's fine by me. I'll leave it to someone more familiar with the
directive emitter to approve the PR though.
https://github.com/llvm/llvm-project/pull/87247
kparzysz wrote:
We can switch to ArrayRef in another PR.
https://github.com/llvm/llvm-project/pull/87086
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kparzysz edited
https://github.com/llvm/llvm-project/pull/87247
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
xingxue-ibm wrote:
> Hi @xingxue-ibm (or anyone else). If you would like to add a note about this
> fix in the release notes (completely optional). Please reply to this comment
> with a one or two sentence description of the fix.
Thank you very much, @tstellar! We don't have anything specific
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/87247
>From 291dc48d5e0b7e0ee39681a1276bd1d63f456b01 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Mon, 1 Apr 2024 10:07:45 -0500
Subject: [PATCH 1/2] [Frontend][OpenMP] Refactor getLeafConstructs, add
@@ -0,0 +1,41 @@
+//===- llvm/unittests/Frontend/OpenMPComposeTest.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/kparzysz edited
https://github.com/llvm/llvm-project/pull/87247
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/kparzysz commented:
I have considered putting more information in the .td file, but I decided
against it. The main reason was that TableGen would need to have a lot more
knowledge about OMP directives than it does now:
- It would need to be aware of OpenMP's definitions of
@@ -8,12 +8,74 @@
#include "llvm/Frontend/OpenMP/OMP.h"
+#include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/ErrorHandling.h"
@@ -8,12 +8,74 @@
#include "llvm/Frontend/OpenMP/OMP.h"
+#include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/ErrorHandling.h"
https://github.com/skatrak approved this pull request.
Thank you, based on the current proposal in #87247 this LGTM. If that changes,
this will need another review.
https://github.com/llvm/llvm-project/pull/87258
___
llvm-branch-commits mailing list
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/87247
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,41 @@
+//===- llvm/unittests/Frontend/OpenMPComposeTest.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/skatrak commented:
I think this looks reasonable if we want to both split a construct into leaf
constructs and also merge multiple constructs into a single compound one, if it
exists. I'm just wondering if we need that much flexibility (and complexity
associated with it).
@@ -8,12 +8,74 @@
#include "llvm/Frontend/OpenMP/OMP.h"
+#include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/ErrorHandling.h"
@@ -8,12 +8,74 @@
#include "llvm/Frontend/OpenMP/OMP.h"
+#include "llvm/ADT/ArrayRef.h"
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallVector.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/ErrorHandling.h"
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/87247
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/nicolasvasilache approved this pull request.
https://github.com/llvm/llvm-project/pull/84865
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
@@ -58,17 +58,15 @@ void gatherFuncAndVarSyms(
const ObjectList , mlir::omp::DeclareTargetCaptureClause clause,
llvm::SmallVectorImpl );
+int64_t getCollapseValue(const List );
skatrak wrote:
It looks like this function is only used within
@@ -2357,44 +2332,44 @@ genOMP(Fortran::lower::AbstractConverter ,
converter.genLocation(beginBlockDirective.source);
const auto origDirective =
std::get(beginBlockDirective.t).v;
- const auto =
- std::get(beginBlockDirective.t);
- const auto =
-
@@ -49,9 +49,8 @@ class ClauseProcessor {
public:
ClauseProcessor(Fortran::lower::AbstractConverter ,
Fortran::semantics::SemanticsContext ,
- const Fortran::parser::OmpClauseList )
- : converter(converter), semaCtx(semaCtx),
-
https://github.com/skatrak edited
https://github.com/llvm/llvm-project/pull/87086
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/skatrak approved this pull request.
Thank you Krzysztof, LGTM. I have a couple of suggestions, but this should be
ready if you don't agree with them.
https://github.com/llvm/llvm-project/pull/87086
___
llvm-branch-commits mailing
@@ -597,14 +599,11 @@ static void removeStoreOp(mlir::Operation *reductionOp,
mlir::Value symVal) {
// TODO: Generate the reduction operation during lowering instead of creating
// and removing operations since this is not a robust approach. Also, removing
// ops in the
https://github.com/Meinersbur approved this pull request.
https://github.com/llvm/llvm-project/pull/87239
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/Meinersbur approved this pull request.
https://github.com/llvm/llvm-project/pull/87253
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
@@ -1730,9 +1730,28 @@ LogicalResult LoopNestOp::verify() {
<< "range argument type does not match corresponding IV type";
}
+ auto wrapper =
+ llvm::dyn_cast_if_present((*this)->getParentOp());
+
+ if (!wrapper || !wrapper.isWrapper())
+return
@@ -69,6 +69,74 @@ def ReductionClauseInterface :
OpInterface<"ReductionClauseInterface"> {
];
}
+def LoopWrapperInterface : OpInterface<"LoopWrapperInterface"> {
+ let description = [{
+OpenMP operations that can wrap a single loop nest. When taking a wrapper
+
@@ -212,19 +185,13 @@ body: |
; CHECK-NEXT: $v7 = VMV1R_V $v14
; CHECK-NEXT: $v8 = VMV1R_V $v15
; CHECK-NEXT: $v9 = VMV1R_V $v16
-; CHECK-NEXT: $v4 = VMV1R_V $v10
-; CHECK-NEXT: $v5 = VMV1R_V $v11
-; CHECK-NEXT: $v6 = VMV1R_V $v12
-;
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/84455
>From 35d0ea085b43a67c092e6263e6ec9d34e66e1453 Mon Sep 17 00:00:00 2001
From: Wang Pengcheng
Date: Tue, 12 Mar 2024 17:31:47 +0800
Subject: [PATCH 1/6] Reduce copies
Created using spr 1.3.4
---
lhunloh wrote:
> @lhunloh (or anyone else). If you would like to add a note about this fix in
> the release notes (completely optional). Please reply to this comment with a
> one or two sentence description of the fix.
"`transform.structured.convert_to_loops` now properly deletes its target
@@ -212,19 +185,13 @@ body: |
; CHECK-NEXT: $v7 = VMV1R_V $v14
; CHECK-NEXT: $v8 = VMV1R_V $v15
; CHECK-NEXT: $v9 = VMV1R_V $v16
-; CHECK-NEXT: $v4 = VMV1R_V $v10
-; CHECK-NEXT: $v5 = VMV1R_V $v11
-; CHECK-NEXT: $v6 = VMV1R_V $v12
-;
@@ -212,19 +185,13 @@ body: |
; CHECK-NEXT: $v7 = VMV1R_V $v14
; CHECK-NEXT: $v8 = VMV1R_V $v15
; CHECK-NEXT: $v9 = VMV1R_V $v16
-; CHECK-NEXT: $v4 = VMV1R_V $v10
-; CHECK-NEXT: $v5 = VMV1R_V $v11
-; CHECK-NEXT: $v6 = VMV1R_V $v12
-;
51 matches
Mail list logo
