Re: [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header

2012-01-26 Thread Markos Chandras
On 01/09/2012 10:57 AM, Markos Chandras wrote: The tst_print function is using the TEST_ERRNO symbol which is declared as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int' when this macro is not defined. We need to include this header on float and echoes tests to

Re: [LTP] [PATCH] {tcp_cmds/echo, math/float}: Include missing usctest.h header

2012-01-26 Thread Cyril Hrubis
Hi! The tst_print function is using the TEST_ERRNO symbol which is declared as 'extern int' on usctest.h header when _USC_LIB_ macro is used and as 'int' when this macro is not defined. We need to include this header on float and echoes tests to ensure that TEST_ERRNO has been defined

Re: [LTP] [PATCH] mount1234: invert the logic in handling failures

2012-01-26 Thread Cyril Hrubis
Hi! mount is expected to fail if the device is a 'tty', so it seems that the original idea of this testcase were to test mount failures. If this is true, then the logic to handle the test results has to be inverted and consider the test case as PASSED if mount fails, while FAILED if mount

Re: [LTP] Strange output of fork13 testcase

2012-01-26 Thread Cyril Hrubis
Hi! The following patch fixes the problem but I'm not very knowledgeable on what fork13 does so this patch might not be a good approach. Can someone more knowledgeable on it let me know if this is a valid approach? Strange indeed. I could see the same errors in the log as well. I'll look

Re: [LTP] Strange output of fork13 testcase

2012-01-26 Thread Cyril Hrubis
Hi! The following patch fixes the problem but I'm not very knowledgeable on what fork13 does so this patch might not be a good approach. Can someone more knowledgeable on it let me know if this is a valid approach? Strange indeed. I could see the same errors in the log as well. I'll

Re: [LTP] [PATCH] mount1234: invert the logic in handling failures

2012-01-26 Thread Carmelo AMOROSO
On 26/01/2012 16.12, Cyril Hrubis wrote: Hi! mount is expected to fail if the device is a 'tty', so it seems that the original idea of this testcase were to test mount failures. If this is true, then the logic to handle the test results has to be inverted and consider the test case as PASSED

[LTP] [PATCH 2/5] hugemmap02: code cleanups

2012-01-26 Thread Wanlong Gao
cleanup the coding style Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- testcases/kernel/mem/hugetlb/hugemmap/hugemmap02.c | 132 +-- 1 files changed, 63 insertions(+), 69 deletions(-) diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap02.c

[LTP] [PATCH 0/5] hugemmap code cleanups

2012-01-26 Thread Wanlong Gao
Hi Cyril: This series just do a code cleanups, after you applied, I'll rebase my fix patches. Thanks --- Wanlong Gao (5): hugemmap01: code cleanups hugemmap02: code cleanups hugemmap03: code cleanups hugemmap04: code cleanups hugemmap05: code cleanups

[LTP] [PATCH 3/5] hugemmap03: code cleanups

2012-01-26 Thread Wanlong Gao
Cleanup the coding style Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c | 89 ++-- 1 files changed, 45 insertions(+), 44 deletions(-) diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap03.c

[LTP] [PATCH 4/5] hugemmap04: code cleanups

2012-01-26 Thread Wanlong Gao
Cleanup the coding style Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c | 144 ++-- 1 files changed, 71 insertions(+), 73 deletions(-) diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap04.c

[LTP] [PATCH 1/5] hugemmap01: code cleanups

2012-01-26 Thread Wanlong Gao
Just cleanup the code Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- testcases/kernel/mem/hugetlb/hugemmap/hugemmap01.c | 123 ++-- 1 files changed, 59 insertions(+), 64 deletions(-) diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap01.c

[LTP] [PATCH 5/5] hugemmap05: code cleanups

2012-01-26 Thread Wanlong Gao
Cleanup the coding style Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com --- testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c | 22 ++- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/testcases/kernel/mem/hugetlb/hugemmap/hugemmap05.c