Re: [LTP] [PATCH] clock_settime03: don't test PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID

2013-06-26 Thread Garrett Cooper
On Wed, Jun 26, 2013 at 8:43 PM, Wanlong Gao gaowanl...@cn.fujitsu.comwrote: PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID are not supported before kernel 2.6.12, and changed back since 2.6.38. And they are thought improper supported on Linux, so we just remove them from the test of clock_settime

Re: [LTP] [PATCH] clock_settime03: don't test PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID

2013-06-26 Thread Garrett Cooper
On Wed, Jun 26, 2013 at 8:47 PM, Garrett Cooper yaneg...@gmail.com wrote: On Wed, Jun 26, 2013 at 8:43 PM, Wanlong Gao gaowanl...@cn.fujitsu.comwrote: PROCESS_CPUTIME_ID and THREAD_CPUTIME_ID are not supported before kernel 2.6.12, and changed back since 2.6.38. And they are thought improper

Re: [LTP] Regarding LTP contribution

2013-05-18 Thread Garrett Cooper
On May 16, 2013, at 2:41 AM, Jungsoo Son jungsoo@lge.com wrote: Hello, My name is jungsoo son who is in charge of kernel development on my company. I want to send my patch to upstream of Linux Test Project. Could you give me some information about how to push git commit ? Hi jungsoo

Re: [LTP] [PATCH] aio_fsync/2-1.c: fix race at exit, check if write completed

2013-01-25 Thread Garrett Cooper
Error code printing would be helpful... Thanks, -Garrett Sent from my iPhone On Jan 25, 2013, at 4:15 AM, Jan Stancek jstan...@redhat.com wrote: This is same issue as: commit 4558bfae923a715ac78b5b3d3ecdfa16f9424808 Author: Jan Stancek jstan...@redhat.com Date: Wed Dec 5 12:49:47 2012

Re: [LTP] Tarballs in Files section @ sf.net

2013-01-16 Thread Garrett Cooper
On Jan 16, 2013, at 5:43 AM, Sedat Dilek sedat.di...@gmail.com wrote: Hi, why do you name your BZ2-tarballs with the right and common file-extensions .tar.bz2? $ file ltp-full-20130109.bz2 ltp-full-20130109.bz2: bzip2 compressed data, block size = 900k $ bunzip2 ltp-full-20130109.bz2

Re: [LTP] Getting User input data not working

2013-01-07 Thread Garrett Cooper
On Mon, Jan 7, 2013 at 5:23 PM, subashchandra.b...@wipro.com wrote: Hello Cyril, What about physically plugging the output cable to the capture input? Hardware changes are required to perform this plugging. not sure if this changes can be done in our setup. Exact matching would be

Re: [LTP] Getting User input data not working

2013-01-06 Thread Garrett Cooper
On Jan 3, 2013, at 3:23 AM, chru...@suse.cz wrote: Hi! I am using LTP drop released on ltp-full-20120104 version. I have written a testcase to get user input data and call that testcase using runltp, the command I use to get user input data is read -t 10 response But, when enter user

Re: [LTP] [PATCH] open_posix_testsuite/.../sigset/{6, 7}-1.c: fix error handling

2012-12-04 Thread Garrett Cooper
; } -rc = sigset(SIGCHLD, SIG_HOLD); -if (rc 0) { -ERR_MSG(sigset(), rc); +if (sigset(SIGCHLD, SIG_HOLD) == SIG_ERR) { +perror(Unexpected error while using sigset()); return PTS_UNRESOLVED; } Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] [QUESTION] ltp stress test for RHEL5 and NFS local mount

2012-09-02 Thread Garrett Cooper
On Sat, Sep 1, 2012 at 10:30 PM, gchen gang.c...@asianux.com wrote: Hello ltp-list@lists.sourceforge.net Question: Use ltp stress test (/opt/ltp/ltpstress.sh) with ltp-full-20100331.gz to test RHEL5 (kernel-2.6.18-308.4.1.el5) for 72 hours. Not give any more configurations for NFS (using

Re: [LTP] [PATCH 1/1] capability: fix sys/capability.h compile error

2012-08-08 Thread Garrett Cooper
On Tue, Aug 7, 2012 at 10:32 PM, Caspar Zhang cas...@casparzhang.com wrote: On 08/03/2012 12:22 AM, Simon Xu wrote: Capability testcases fail to compile with sys/capability.h of libcap-devel in RHEL5-like distros: In file included from /usr/include/sys/capability.h:34, from

Re: [LTP] [PATCH] syscalls/numa: check syscall availability

2012-08-08 Thread Garrett Cooper
On Aug 8, 2012, at 2:29 AM, Caspar Zhang wrote: On 07/31/2012 11:57 AM, Garrett Cooper wrote: On Mon, Jul 30, 2012 at 7:53 PM, Caspar Zhang cas...@casparzhang.com wrote: some NUMA related syscalls: mbind, get_mempolicy are not supported on some arches (e.g. i386), I use TEST macro to test

Re: [LTP] [PATCH 1/1] runltp: fix -d option processing

2012-08-07 Thread Garrett Cooper
to get absolute path. Signed-off-by: Simon Xu xu.si...@oracle.com Reviewed-by: Garrett Cooper yaneg...@gmail.com Pushed to the repo. Thanks! -Garrett -- Live Security Virtual Conference Exclusive live event will cover all

Re: [LTP] LTP on ARMV7

2012-08-01 Thread Garrett Cooper
On Wed, Aug 1, 2012 at 1:47 PM, Mike Frysinger vap...@gentoo.org wrote: On Monday 02 July 2012 11:27:45 Vanni Genua wrote: anybody know if LTP support ARMv7 and not only x86 architecture? LTP doesn't really care about the architecture. it works on any CPU. - You may run into ARM bugs (in

Re: [LTP] [PATCH] syscalls/numa: check syscall availability

2012-07-30 Thread Garrett Cooper
On Mon, Jul 30, 2012 at 7:53 PM, Caspar Zhang cas...@casparzhang.com wrote: some NUMA related syscalls: mbind, get_mempolicy are not supported on some arches (e.g. i386), I use TEST macro to test the syscall in setup() function, if the syscall is not implemented on the system, a TCONF message

Re: [LTP] [PATCH/RFE 2/2] mm: use new numa_helper

2012-07-30 Thread Garrett Cooper
On Mon, Jul 30, 2012 at 7:57 PM, Caspar Zhang cas...@casparzhang.com wrote: This patch makes the tests in mem/ dir use numa_helper in libkerntest. Signed-off-by: Caspar Zhang cas...@casparzhang.com Inline patches are easier to review... - tst_brkm(TCONF, NULL, required a NUMA

Re: [LTP] [PATCH] file: use the grep -q option instead of redirection

2012-07-25 Thread Garrett Cooper
On Wed, Jul 25, 2012 at 8:03 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: Use grep -q option instead, as Cooper suggested. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] [PATCH 2/2] open_posix:aio_fsync:14-1: wait for aio_write completion

2012-07-23 Thread Garrett Cooper
Sent from my iPhone On Jul 23, 2012, at 9:02 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 07/24/2012 11:49 AM, Caspar Zhang wrote: On 07/24/2012 10:58 AM, Wanlong Gao wrote: Wait for aio_write() completion. If aio_fsync() sync the fd without the previous aio_write() completion, it

Re: [LTP] [PATCH] runltp: fix the wrong parsing -b option

2012-06-28 Thread Garrett Cooper
On Tue, Jun 26, 2012 at 1:26 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 06/22/2012 10:35 AM, Wanlong Gao wrote: Maybe a typo when replacing DEVICE_FS_TYPE. Objections, Cooper? There isn't any other places have this odd statement in this file like here. LGTM. Reviewed-by: Garrett

Re: [LTP] [bug report] a typo in runltp script

2012-06-21 Thread Garrett Cooper
On Thu, Jun 21, 2012 at 12:27 AM, Li, Jin jin...@windriver.com wrote: Hi, When I use runltp with the option [-b DEVICE], notice the typo as follows: sed -i -e s|DEVICE_FS_TYPE|$DEVICE_FS_TYPE|  ${TMP}/alltests The runltp will hit error and exit. Is it a typo or I miss something else ?

Re: [LTP] [PATCH 1/4] add libnuma_helper

2012-05-28 Thread Garrett Cooper
On Mon, May 28, 2012 at 4:39 AM, Jan Stancek jstan...@redhat.com wrote: A library to share NUMA helper functions shared by multiple testcases. Signed-off-by: Jan Stancek jstan...@redhat.com One comment... + tst_resm(TFAIL, get_allowed_nodes, i = num_allowed_nodes: +

Re: [LTP] [PATCH 2/4] mbind01: dont use hardcoded NUMA node ids

2012-05-28 Thread Garrett Cooper
On Mon, May 28, 2012 at 4:39 AM, Jan Stancek jstan...@redhat.com wrote: Signed-off-by: Jan Stancek jstan...@redhat.com ---  testcases/kernel/syscalls/mbind/Makefile  |    3 +--  testcases/kernel/syscalls/mbind/mbind01.c |   10 --  2 files changed, 9 insertions(+), 4 deletions(-) +

Re: [LTP] [PATCH 4/4] move_pages: dont use hardcoded NUMA node ids

2012-05-28 Thread Garrett Cooper
On Mon, May 28, 2012 at 4:39 AM, Jan Stancek jstan...@redhat.com wrote: Signed-off-by: Jan Stancek jstan...@redhat.com My comment about TERRNO from the other patch applies to this as well, but this looks ok. -Garrett

Re: [LTP] [PATCH] Fix the fork/11-1 conformance testcase

2012-05-27 Thread Garrett Cooper
On Sun, May 27, 2012 at 12:33 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/26/2012 10:15 PM, Garrett Cooper wrote: The testcase tests to see whether or not locks are successfully inherited across forking processes, as the requirements for fork state that they should

Re: [LTP] [PATCH] Fix the fork/11-1 conformance testcase

2012-05-27 Thread Garrett Cooper
On Sun, May 27, 2012 at 1:14 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/27/2012 04:00 PM, Garrett Cooper wrote: On Sun, May 27, 2012 at 12:33 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/26/2012 10:15 PM, Garrett Cooper wrote: The testcase tests to see whether

Re: [LTP] [PATCH] Fix the fork/11-1 conformance testcase

2012-05-27 Thread Garrett Cooper
On Sun, May 27, 2012 at 2:06 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/27/2012 04:23 PM, Garrett Cooper wrote: On Sun, May 27, 2012 at 1:14 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/27/2012 04:00 PM, Garrett Cooper wrote: On Sun, May 27, 2012 at 12:33 AM, Wanlong

[LTP] [PATCH] Fix the fork/11-1 conformance testcase

2012-05-26 Thread Garrett Cooper
failure as OUTPUT goes to /dev/stdout and the test hangs. Signed-off-by: Garrett Cooper yaneg...@gmail.com diff --git a/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c b/testcases/open_posix_testsuite/conformance/interfaces/fork/11-1.c index 125..632b0db 100644

[LTP] [PATCH] Fix clock_settime/4-2

2012-05-26 Thread Garrett Cooper
1. The threshold was too low; setting it to 10 seconds and adding an overlap of 5 seconds ensures that the SIGALRM handler fires. 2. Add a perror call when clock_settime fails. 3. Remove spurious newlines in perror calls. Signed-off-by: Garrett Cooper yaneg...@gmail.com --- .../conformance

Re: [LTP] [PATCH 1/2] move_pages_support: use only allowed nodes

2012-05-25 Thread Garrett Cooper
On Fri, May 25, 2012 at 2:12 AM, Jan Stancek jstan...@redhat.com wrote: Some setups can lack memory on arbitrary nodes, use only nodes returned by get_mempolicy(..., MPOL_F_MEMS_ALLOWED). Signed-off-by: Jan Stancek jstan...@redhat.com ---  .../syscalls/move_pages/move_pages_support.c      

Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check

2012-05-21 Thread Garrett Cooper
On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: Now, kernel version up to 3.x, check for 2.6.x is useless. I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2 years after 3.x's inception. Additionally, we already checked the kernel version in the program

Re: [LTP] [PATCH] getcpu: remove the useless and improper kernel version check

2012-05-21 Thread Garrett Cooper
On May 21, 2012, at 2:01 AM, Wanlong Gao wrote: On 05/21/2012 04:55 PM, Garrett Cooper wrote: On May 21, 2012, at 1:38 AM, Wanlong Gao wrote: Now, kernel version up to 3.x, check for 2.6.x is useless. I don't agree with this statement. LTP needs to be usable on 2.6.x for at least 2

[LTP] more-syscalls branch

2012-05-21 Thread Garrett Cooper
In order to get LTP more up to date and expand breadth of syscall requirements testing, I'm going to be working on adding more syscall tests to LTP over the next couple weeks. I started out with inotify(7), but I want to move on to newer syscalls that exercise MI (machine independent)

Re: [LTP] [PATCH 2/2] Replace struct event_t with struct inotify_event

2012-05-18 Thread Garrett Cooper
On May 3, 2012, at 5:46 AM, Cyril Hrubis wrote: Hi! Yeah... let me get back to you on that... Any update on this? I'm moving from CA to WA, but I'll try to get back to you sometime mid next week once I get settled in. That's great! I wonder what do CA and WA stand for? I

Re: [LTP] [PATCH] Add a functional test for the IN_DELETE_SELF event

2012-05-18 Thread Garrett Cooper
On May 18, 2012, at 5:59 AM, Cyril Hrubis wrote: Hi! +/ + * NAME + * inotify04 + * + * DESCRIPTION + * verify that IN_DELETE_SELF functions as expected + * + * ALGORITHM + * Create a temporary

Re: [LTP] [PATCH v2] ltp-pan.c: fix error of Total Tests

2012-05-16 Thread Garrett Cooper
On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/17/2012 09:59 AM, Peng Haitao wrote: When execvp() fails, the testcases is counted in Total Tests, but not added in logfile. In fact the testcases result should be added in logfile. I prefer adding this for

Re: [LTP] [PATCH v2] ltp-pan.c: fix error of Total Tests

2012-05-16 Thread Garrett Cooper
On Wed, May 16, 2012 at 7:33 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/17/2012 10:31 AM, Garrett Cooper wrote: On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/17/2012 09:59 AM, Peng Haitao wrote: When execvp() fails, the testcases is counted

Re: [LTP] [PATCH v2] ltp-pan.c: fix error of Total Tests

2012-05-16 Thread Garrett Cooper
On Wed, May 16, 2012 at 7:39 PM, Garrett Cooper yaneg...@gmail.com wrote: On Wed, May 16, 2012 at 7:33 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/17/2012 10:31 AM, Garrett Cooper wrote: On Wed, May 16, 2012 at 7:12 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 05/17/2012

Re: [LTP] [PATCH v2] ltp-pan.c: fix error of Total Tests

2012-05-16 Thread Garrett Cooper
On Wed, May 16, 2012 at 7:47 PM, Peng Haitao pen...@cn.fujitsu.com wrote: Garrett Cooper said the following on 2012-5-17 10:40: You can easily trigger this problem with the following spoofed runtest scenario: aok echo hello donotexist donotexist exit_quickly exit 1 true true The test

Re: [LTP] [PATCH v2] ltp-pan.c: fix error of Total Tests

2012-05-16 Thread Garrett Cooper
On Wed, May 16, 2012 at 10:04 PM, Peng Haitao pen...@cn.fujitsu.com wrote: Garrett Cooper said the following on 2012-5-17 12:39: test_start tag=exit_quickly stime=1337251363 cmdline=exit 1 contacts= analysis=exit test_output execution_status initiation_status=pan(17520): execvp of 'exit

Re: [LTP] Test for linux syscall 240 cc sys_futex

2012-05-03 Thread Garrett Cooper
On Thu, May 3, 2012 at 6:12 AM, Cyril Hrubis chru...@suse.cz wrote: Hi! Sorry I'm not aware of any tests directly for futex systcall in LTP. I guess that these are covered indirectly by glibc mutex and lock tests. But it would be good to have tests that cover the individual requirements...

Re: [LTP] Porting of LTP on Android - Patch

2012-05-02 Thread Garrett Cooper
On Wed, May 2, 2012 at 7:42 AM, Cyril Hrubis chru...@suse.cz wrote: Hi! We have ported LTP open source (Version: ltp-full-20110228) on Android 2.2 Froyo. It will validate the reliability, robustness, and stability of Android. We want to submit the same to open source community.  PFA patch for

Re: [LTP] [PATCH 2/3] syscalls/move_pages: modified HAS_NUMA_H as HAVE_NUMA_H

2012-04-28 Thread Garrett Cooper
On Apr 28, 2012, at 12:48 AM, Zhouping Liu wrote: HAS_NUMA_H should be HAVE_NUMA_H, and most functions are defined in numa.h and numaif.h, so added the include headers into move_pages_support.h Signed-off-by: Zhouping Liu z...@redhat.com Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] [PATCH 1/2] Clean up inotify(7) wrappers

2012-04-11 Thread Garrett Cooper
On Apr 10, 2012, at 7:52 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 04/05/2012 09:52 AM, Mike Frysinger wrote: On Wednesday 04 April 2012 20:38:31 Garrett Cooper wrote: +/* + * ``junk`` is needed to make the macro function like a void argument + * function. + */ +#define

Re: [LTP] Need help in cross compiling LTP for android

2012-04-11 Thread Garrett Cooper
Not enough context was provided to determine why linking failed. On Apr 2, 2012, at 2:33 AM, Rejish Rajagopala rejish.rajagop...@sasken.com wrote: Hi Maxin, I could resolve the configuration issue and I could cross compile on of the LTP modules (pty) for Android. Now I am trying to cross

Re: [LTP] [PATCH 2/2] Replace struct event_t with struct inotify_event

2012-04-11 Thread Garrett Cooper
On Apr 10, 2012, at 7:53 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 04/05/2012 10:10 AM, Garrett Cooper wrote: On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 04/05/2012 08:42 AM, Garrett Cooper wrote: Replace struct event_t with struct

Re: [LTP] [PATCH 0/4] Replace commonly used perl tools with awk equivalents

2012-04-05 Thread Garrett Cooper
On Wed, Apr 4, 2012 at 6:49 PM, Mike Frysinger vap...@gentoo.org wrote: On Wednesday 04 April 2012 20:33:40 Garrett Cooper wrote: On Wed, 4 Apr 2012, Mike Frysinger wrote: On Wednesday 04 April 2012 15:18:53 Garrett Cooper wrote: On Wed, Apr 4, 2012 at 10:54 AM, Mike Frysinger wrote

Re: [LTP] [PATCH 2/4] Install .awk files

2012-04-04 Thread Garrett Cooper
On Wed, Apr 4, 2012 at 10:20 AM, Mike Frysinger vap...@gentoo.org wrote: On Wednesday 04 April 2012 01:22:25 Garrett Cooper wrote: --- a/tools/Makefile +++ b/tools/Makefile -INSTALL_TARGETS              := *.pl *.sh html_report_header.txt +INSTALL_TARGETS              := *awk *.pl *.sh

Re: [LTP] [PATCH 0/4] Replace commonly used perl tools with awk equivalents

2012-04-04 Thread Garrett Cooper
On Wed, Apr 4, 2012 at 10:22 AM, Mike Frysinger vap...@gentoo.org wrote: On Wednesday 04 April 2012 01:23:43 Garrett Cooper wrote: The intent behind these changes are to remove unnecessary perl dependencies in LTP by using awk in its stead. It was something that was discussed a while ago

[LTP] [PATCH 2/4 v2]

2012-04-04 Thread Garrett Cooper
Install .awk files The previous patch would have globbed all files that ended in ``awk``. Signed-off-by: Garrett Cooper yaneg...@gmail.com --- tools/Makefile |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) --1.7.2.5 Content-Type: text/x-patch; name=0001-Install-.awk

[LTP] [PATCH 0/2] Minor inotify(7) testcase cleanup

2012-04-04 Thread Garrett Cooper
The attached changes consolidate some duplicated wrapper APIs and remove a homegrown struct for dealing with inotify events. Garrett Cooper (2): Clean up inotify(7) wrappers Replace struct event_t with struct inotify_event testcases/kernel/syscalls/inotify/inotify.h | 45

[LTP] [PATCH 1/2] Clean up inotify(7) wrappers

2012-04-04 Thread Garrett Cooper
Clean up inotify(7) wrappers As a side-effect this also fixes the return code passed back by the wrappers as the value should be an integer, not longs [this fixes compile errors on platforms where sizeof(int) != sizeof(long)]. Signed-off-by: Garrett Cooper yaneg...@gmail.com --- testcases

[LTP] [PATCH 2/2] Replace struct event_t with struct inotify_event

2012-04-04 Thread Garrett Cooper
Replace struct event_t with struct inotify_event Also do some minor whitespace cleanup while I'm in the neighborhood. Signed-off-by: Garrett Cooper yaneg...@gmail.com --- testcases/kernel/syscalls/inotify/inotify02.c | 13 - 1 files changed, 4 insertions(+), 9 deletions

Re: [LTP] [PATCH] at_deny01: fix a bug of /etc/init.d/atd is nonexistent

2012-04-04 Thread Garrett Cooper
On Wed, Apr 4, 2012 at 6:02 PM, Peng Haitao pen...@cn.fujitsu.com wrote: /etc/init.d/atd is nonexistent in fedora16, so should use systemctl. Signed-off-by: Peng Haitao pen...@cn.fujitsu.com Reviewed-by: Garrett Cooper yaneg...@gmail.com

[LTP] [PATCH] Add a functional test for the IN_DELETE_SELF event

2012-04-04 Thread Garrett Cooper
Add a functional test for the IN_DELETE_SELF event This tests that IN_DELETE_SELF functions for both files and directories by creating a temporary file and directory, ensuring the inotify(7) events are relayed properly, watchpoints are removed, etc. Signed-off-by: Garrett Cooper yaneg

Re: [LTP] [PATCH 2/2] Replace struct event_t with struct inotify_event

2012-04-04 Thread Garrett Cooper
On Wed, Apr 4, 2012 at 6:39 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 04/05/2012 08:42 AM, Garrett Cooper wrote: Replace struct event_t with struct inotify_event Also do some minor whitespace cleanup while I'm in the neighborhood. there's something wrong with this patch, please

[LTP] [PATCH 1/4] Replace create_valgrind_check.pl with an awk equivalent

2012-04-03 Thread Garrett Cooper
Replace create_valgrind_check.pl with an awk equivalent Signed-off-by: Garrett Cooper yaneg...@gmail.com --- runltp | 22 tools/create_valgrind_check.awk | 42 tools/create_valgrind_check.pl | 106

[LTP] [PATCH 2/4] Install .awk files

2012-04-03 Thread Garrett Cooper
Install .awk files Signed-off-by: Garrett Cooper yaneg...@gmail.com --- tools/Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --1.7.9.4 Content-Type: text/x-patch; name=0002-Install-.awk-files.patch Content-Transfer-Encoding: 8bit Content-Disposition: attachment

[LTP] [PATCH 0/4] Replace commonly used perl tools with awk equivalents

2012-04-03 Thread Garrett Cooper
The intent behind these changes are to remove unnecessary perl dependencies in LTP by using awk in its stead. It was something that was discussed a while ago on ltp-list@. Garrett Cooper (4): Replace create_valgrind_check.pl with an awk equivalent Install .awk files Replace

[LTP] [PATCH 3/4] Replace create_dmesg_entries_for_each_test.pl with an awk equivalent

2012-04-03 Thread Garrett Cooper
Replace create_dmesg_entries_for_each_test.pl with an awk equivalent Signed-off-by: Garrett Cooper yaneg...@gmail.com --- runltp |4 +- tools/create_dmesg_entries_for_each_test.awk | 32 +++ tools/create_dmesg_entries_for_each_test.pl | 74

[LTP] [PATCH 4/4]

2012-04-03 Thread Garrett Cooper
Replace create_kernel_faults_in_loops_and_probability.pl with an awk equivalent Signed-off-by: Garrett Cooper yaneg...@gmail.com --- runltp | 24 +++-- ...eate_kernel_faults_in_loops_and_probability.awk | 40

Re: [LTP] [PATCH 4/4] Replace create_kernel_faults_in_loops_and_probability.pl with an awk equivalent

2012-04-03 Thread Garrett Cooper
On Tue, Apr 3, 2012 at 10:27 PM, Garrett Cooper yaneg...@gmail.com wrote: Replace create_kernel_faults_in_loops_and_probability.pl with an awk equivalent Signed-off-by: Garrett Cooper yaneg...@gmail.com ---  runltp                                             |   24

Re: [LTP] [PATCH 1/4] hugetlb: add lib-clean in makefile

2012-04-02 Thread Garrett Cooper
On Mon, Apr 2, 2012 at 1:40 AM, Caspar Zhang cas...@casparzhang.com wrote: On 04/02/2012 04:34 PM, Wanlong Gao wrote: make sure we can do lib-clean in hugetlb. Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com Acked-by: Caspar Zhang cas...@casparzhang.com Reviewed-by: Garrett Cooper

Re: [LTP] [PATCH] cron02: fix a bug of /etc/init.d/crond is nonexistent

2012-03-29 Thread Garrett Cooper
On Thu, Mar 29, 2012 at 2:58 AM, Peng Haitao pen...@cn.fujitsu.com wrote: /etc/init.d/crond is nonexistent in fedora16, so should be replaced with systemctl. Signed-off-by: Peng Haitao pen...@cn.fujitsu.com ---  testcases/commands/cron/cron02 |   14 ++  1 file changed, 14

Re: [LTP] [PATCH v2] cron02: fix a bug of /etc/init.d/crond is nonexistent

2012-03-29 Thread Garrett Cooper
$crond.service +                               break +                       fi +               done        else                echo Could not determine cron init.d script.                exit 1 Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] [PATCH v4] aio_read:8-1.c: Forget initializing struct aiocb before using it

2012-03-16 Thread Garrett Cooper
On Mar 16, 2012, at 1:04 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 03/16/2012 03:58 PM, Peng Haitao wrote: There are 2 changes in this patch. 1. Initialize the aiocb struct before using it. 2. If Prioritized Input and Output option is supported, submit the aiocb with invalid

Re: [LTP] [RFC] make mce-test a submodule

2012-03-16 Thread Garrett Cooper
On Mar 16, 2012, at 12:27 AM, Caspar Zhang cas...@casparzhang.com wrote: Hi all, I'll merge this change to master if I don't hear any objections from you by today. On 03/09/2012 08:25 AM, Wanlong Gao wrote: On 03/09/2012 12:50 AM, Caspar Zhang wrote: Hi Garrett, Andi, and all: When

Re: [LTP] [PATCH] sched_getaffinity: fix possible fail in negative case

2012-03-08 Thread Garrett Cooper
On Mar 8, 2012, at 9:28 PM, Caspar Zhang wrote: in negative case: QUICK_TEST(sched_getaffinity(getpid()+1, len, mask)); sometimes getpid()+1 will exist if there're other processes running. This patch uses a different way to make sure the required pid doesn't exist by forking a child

Re: [LTP] [PATCH] runltp: Remove excess quotes from final message

2012-03-06 Thread Garrett Cooper
.             LTP Version:  $version_date -       ### +       ###        EOF     } Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] newbee needs a good pdf lecture

2012-02-20 Thread Garrett Cooper
On Feb 20, 2012, at 7:58 AM, Samuja i.am.sam...@googlemail.com wrote: Hi, i am new on this, is there a book about linux test project ? i am trying to manage it, but HOWTO is a bit to old, and there is no good book on amazon... or is there some other good systemtest automated tool

Re: [LTP] [PATCH] syscalls/xattr: fix compile when xattr.h not exist

2012-01-09 Thread Garrett Cooper
On Mon, Jan 9, 2012 at 1:54 AM, Markos Chandras markos.chand...@imgtec.com wrote: On 01/09/2012 09:44 AM, Caspar Zhang wrote: ifattr/xattr.h  doesn't exist, compliation will fail. Fix it in autotools level. Signed-off-by: Caspar Zhangcas...@casparzhang.com ---   configure.ac                

Re: [LTP] [PATCH] syscalls/xattr: fix compile when xattr.h not exist

2012-01-09 Thread Garrett Cooper
On Mon, Jan 9, 2012 at 2:51 AM, Eryu Guan eg...@redhat.com wrote: On Mon, Jan 09, 2012 at 05:44:35PM +0800, Caspar Zhang wrote: if attr/xattr.h doesn't exist, compliation will fail. Fix it in autotools level. Tested on system without xattr.h and everything worked fine. Thanks for fixing

Re: [LTP] [PATCH] syscalls/xattr: fix compile when xattr.h not exist

2012-01-09 Thread Garrett Cooper
On Mon, Jan 9, 2012 at 9:23 AM, Mike Frysinger vap...@gentoo.org wrote: On Monday 09 January 2012 12:11:50 Garrett Cooper wrote: On Mon, Jan 9, 2012 at 2:51 AM, Eryu Guan eg...@redhat.com wrote: On Mon, Jan 09, 2012 at 05:44:35PM +0800, Caspar Zhang wrote: if attr/xattr.h doesn't exist

Re: [LTP] Split UCLIBC and UCLINUX test cases

2012-01-09 Thread Garrett Cooper
On Mon, Jan 9, 2012 at 9:19 AM, Mike Frysinger vap...@gentoo.org wrote: On Monday 09 January 2012 06:08:48 Markos Chandras wrote: Right now the use of UCLINUX implies the use of __UCLIBC__ as well. Even though this is true from UCLINUX's perspective, it is not valid from the uclibc's one. A

Re: [LTP] [PATCH] ChangeLog should be replaced with VERSION

2012-01-08 Thread Garrett Cooper
On Jan 8, 2012, at 6:58 PM, Peng Haitao wrote: ChangeLog is deleted, so ChangeLog should be replaced with VERSION. Signed-off-by: Peng Haitao pen...@cn.fujitsu.com Good catch -- cheers! Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] [PATCH 09/21] realtime/lib/Makefile: Fix path for config.mk

2012-01-04 Thread Garrett Cooper
On Wed, Jan 4, 2012 at 3:20 AM, Markos Chandras markos.chand...@imgtec.com wrote: On 01/03/2012 07:24 PM, Garrett Cooper wrote: On Tue, Jan 3, 2012 at 3:08 AM, Markos Chandras markos.chand...@imgtec.com  wrote: Hi, please review the attached patch No -- this breaks out-of-tree compiles

Re: [LTP] [PATCH 03/21] test.h/tst_brkm: Drop __attribute__((noreturn)) since tst_brk can return to caller

2012-01-04 Thread Garrett Cooper
On Wed, Jan 4, 2012 at 5:46 AM, Cyril Hrubis chru...@suse.cz wrote: Hi! the tst_brk() API has gotten annoying.  it is designed to not return to the original caller which is why it had the noreturn attribute.  but Garret re- rewrote it to be re-entrant presumably so the cleanup() func could

Re: [LTP] [PATCH] redefine NCPU = sysconf(_SC_NPROCESSORS_CONF)

2012-01-04 Thread Garrett Cooper
On Wed, Jan 4, 2012 at 7:13 AM, Cyril Hrubis chru...@suse.cz wrote: Hi! since this patch is against the open_posix_testsuite, we need to stick to POSIX APIs (although, the forking of open_posix_testsuite in ltp is pretty awful in general).  if it were against a different tree, then not

Re: [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Converting the function to tst_brkm and removing the tst_exit call below it would be better. Thanks! -Garrett

Re: [LTP] [PATCH 02/21] lib/self_exec: Remove extra argument from tst_resm function call

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 2:40 AM, Markos Chandras markos.chand...@imgtec.com wrote: On 01/03/2012 09:57 AM, Markos Chandras wrote: On 01/03/2012 09:50 AM, Garrett Cooper wrote: On Tue, Jan 3, 2012 at 1:35 AM, Markos Chandras markos.chand...@imgtec.com   wrote: Hi, please review the attached

Re: [LTP] [PATCH 07/21] cgroup/getdelays: Squish uninitialized variable warning for old GCC compilers

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:02 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch. It is a trivial fix for slightly old GCC versions. It would be better to set it below the declarations. Although this isn't part of check_patch.pl, it's a BSD style(9)'ism

Re: [LTP] [PATCH 20/21] nfs/nfsstress/make_tree: Replace integer cast to pointer with 0

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 5:25 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch It would be better if it was strtoll, but this works for now. Thanks! -Garrett Reviewed-by: Garrett Cooper yaneg...@gmail.com

Re: [LTP] [PATCH 19/21] nfs/nfsstress/make_tree: Fix erroneous cast to void pointer

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 5:24 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools

Re: [LTP] [PATCH 18/21] network/lib6/asapi_06: pcmsg-cmsg_len is of type size_t

2012-01-03 Thread Garrett Cooper
printf(3) implementations. Thanks, -Garrett Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools to simplify cross-platform app development. Create new or port existing apps

Re: [LTP] [PATCH 05/21] syscalls: Cast st_nlink variables to proper integers

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 2:42 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Too bad it is a longtype, unlike BSD. Maybe you want to make this into a zu format string qualifier instead? Thanks! -Garrett

Re: [LTP] [PATCH 08/21] syscalls/remap_file_pages: unsigned int is always greater to zero

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:04 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools

Re: [LTP] [PATCH 06/21] syscalls/unshare02: Replace ((int)NULL) with 0

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 2:44 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools

Re: [LTP] [PATCH 10/21] lib/parse_opts: Multiple fixes

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:10 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools

Re: [LTP] [PATCH 17/21] network/lib6/asapi_04: Cast pointer arithmetic to proper integer

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 5:22 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch %p is better. Thanks, -Garrett -- Write once. Port to many. Get the SDK and tools to simplify

Re: [LTP] [PATCH 11/21] process_stress/process: Fix dprt() function definition when DEBUG macro is used

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:12 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools

Re: [LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:18 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch Reviewed-by: Garrett Cooper yaneg...@gmail.com -- Write once. Port to many. Get the SDK and tools

Re: [LTP] [PATCH 13/21] Build system: Always append CFLAGS at the end

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:22 AM, Markos Chandras markos.chand...@imgtec.com wrote: Hi, please review the attached patch I'm going to think about this proposed change for a while because it might break certain scenarios. Please test this change and other build changes via the

Re: [LTP] [PATCH 12/21] syscalls/{getcontext, profil}: Move test.h header and TCID variable to the top

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 12:21 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 03 January 2012 06:18:56 Markos Chandras wrote: Hi, please review the attached patch the test.h header should be after all system includes.  moving it before them is not a good idea.  so NAK this patch. Good

Re: [LTP] [PATCH 05/21] syscalls: Cast st_nlink variables to proper integers

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 12:37 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 03 January 2012 05:42:55 Markos Chandras wrote: Hi, please review the attached patch casting to a (long) would be better Or uintmax_t... -Garrett

Re: [LTP] [PATCH 05/21] syscalls: Cast st_nlink variables to proper integers

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 12:57 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 03 January 2012 15:51:52 Garrett Cooper wrote: On Tue, Jan 3, 2012 at 12:37 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 03 January 2012 05:42:55 Markos Chandras wrote: Hi, please review

Re: [LTP] [PATCH 04/21] syscalls: Use %zu modifier to print variables of type size_t

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 12:29 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 03 January 2012 04:41:10 Markos Chandras wrote: Hi, please review the attached patch using %zu for size_t is good +1. Thanks, -Garrett

Re: [LTP] [PATCH 05/21] syscalls: Cast st_nlink variables to proper integers

2012-01-03 Thread Garrett Cooper
On Tue, Jan 3, 2012 at 3:34 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 03 January 2012 17:19:25 Garrett Cooper wrote: The 'solution' for the issues with format strings and long integers is generally cast to [u]intmax_t, then use %zd or %zu. eek, almost ;) ssize_t - %zd size_t

Re: [LTP] [PATCH] redefine NCPU = sysconf(_SC_NPROCESSORS_CONF)

2011-12-22 Thread Garrett Cooper
On Dec 22, 2011, at 2:11 AM, Cyril Hrubis wrote: Hi! testcase create NCPU=4 threads running with a high priority with the same sched policy and one with a low-priority. The low-priority thread should not run until the other threads stop running, unless the machine has more than NCPU

Re: [LTP] [PATCH v2 2/2] pipeio: prevent race between SIGCHLD and open()

2011-12-15 Thread Garrett Cooper
On Thu, Dec 15, 2011 at 1:35 AM, Jan Stancek jstan...@redhat.com wrote: This test occasionally hangs on some machines. The hang has been observed mostly on single CPU ones. pipeio code is using signal(2), setting by default SA_RESTART flag, which is also the case for SIGCHLD. If last child

Re: [LTP] [PATCH] memcg_function:fix the wrong use of mlock

2011-12-14 Thread Garrett Cooper
On Wed, Dec 14, 2011 at 7:04 PM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 12/15/2011 10:46 AM, Peng Haitao wrote: mlock and munmap will return -1 when ERROR. Signed-off-by: Peng Haitao pen...@cn.fujitsu.com Reviewed-by: Wanlong Gao gaowanl...@cn.fujitsu.com Committed -- thanks!

Re: [LTP] Patches for POSIX test cases

2011-12-12 Thread Garrett Cooper
On Fri, Dec 9, 2011 at 12:52 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 12/09/2011 04:28 PM, Kang Kai wrote: Hi All, These two patches are for POSIX test suite, and could anyone give some comments? Thanks. And is there a irc channel for ltp/posix, I need some help about POSIX

Re: [LTP] [PATCH 2/2] pthread_rwlock_unlock/4-2: remove local var 'rc'

2011-12-12 Thread Garrett Cooper
On Fri, Dec 9, 2011 at 1:18 AM, Wanlong Gao gaowanl...@cn.fujitsu.com wrote: On 12/09/2011 04:28 PM, Kang Kai wrote: Local var 'rc' in function main hides the global one. In child thread it sets global var 'rc' with funtion return value. But in function main, test var 'rc' always succeeds

  1   2   3   4   5   6   7   8   9   10   >