good.
Reviewed-by: Masatake YAMATO yam...@redhat.com
--
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce
Another small patch to complete the test cases for *16.
Put compat_16.h to testcases/kernel/syscalls/geteuid.
Signed-off-by: Masatake YAMATO yam...@redhat.com
Index: testcases/kernel/syscalls/geteuid/Makefile
===
RCS file: /cvsroot
/kernel/syscalls/utils/compat_uid.h.
Put compat_16.h. at testcases/kernel/syscalls/getuid/compat_16.h.
Signed-off-by: Masatake YAMATO yam...@redhat.com
Index: testcases/kernel/syscalls/getuid/Makefile
===
RCS file: /cvsroot/ltp/ltp
Garrett has this fixed in his pending build patch. i dont think this fix is
critical, so it can be merged when Garrett commits his changes (hopefully
soon). it'll make his life easier as it'll avoid conflicts (which suck with
CVS).
Oh, thank you. Yes, it is not critical.
Masatake
is needed to update.
Masatake YAMATO
--
Enter the BlackBerry Developer Challenge
This is your chance to win up to $100,000 in prizes! For a limited time,
vendors submitting new applications to BlackBerry App World(TM
Hi,
--static for gcc is really needed? I cannot find strong reason for
it.
Signed-off-by: Masatake YAMATO yam...@redhat.com
Index: aio/aio02/Makefile
===
RCS file: /cvsroot/ltp/ltp/testcases/kernel/io/aio/aio02/Makefile,v
Did you run configure?
--
___
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
;
}
I think following line:
if ((unsigned) which_clock = MAX_CLOCKS)
return 1;
should be
if ((unsigned) which_clock = MAX_CLOCKS)
return 0;
Sorry, I don't have much time to dig more.
Masatake YAMATO
5. config.log
Masatake YAMATO
--
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation
Please, use configure.
I am following these steps:
1 tar xzf ltp-full-20090228.tgz
2 cd ltp
3 touch include/config.h.default
4 make config.h ( o/p: *cp include/config.h.default include/config.h* )
5 make
Following is the output of make:
, I think I'll Ack this patch below. Then, I
will provide another patch to address the rest of issues on the top of
it.
Thank you.
Masatake YAMATO
--
Open Source Business Conference (OSBC), March 24-25, 2009, San
+dnl Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307
+dnl USA
+dnl
+dnl Author: Masatake YAMATO yam...@redhat.com
+dnl
+
+# LTP_CHECK_LIB(/LIBRARY/,/FUNCTIONS/,[/OTHER-LIBRARIES/])
+# --
+# LTP_CHECK_LIB works like
])=-l$1 $3],,$3)
+AC_SUBST(AS_TR_CPP([$1_LIBS]))])
With or without libselinux-devel, the messages from ./configure script
does not look good.
Sorry it was broken. LIBRARY_LIBS was not needed.
I've reflected all your comment to new patch.
It becomes simpler.
Signed-off-by: Masatake YAMATO yam
is not.
My proposals to avoid *compile time error*:
Under 1 let is_lsm_enabled return 0.
Under 2 provide the declaration for is_selinux_enabled.
Could you review again?
Signed-off-by: Masatake YAMATO yam...@redhat.com
diff -ruN old/m4/ltp-common.m4 new/m4/ltp-common.m4
--- old/m4/ltp-common.m4
fadvise cases should check TEST_ERRNO instead of TEST_RETURN.
Do you mean man page is incorrect?
man fadvise:
POSIX_FADVISE(2) Linux Programmer’s Manual
POSIX_FADVISE(2)
...
RETURN VALUE
On success, zero is returned. On error, an error number is
. LTP_CHECK_SELINUX uses LTP_CHECK_LIB.
I think `lsm_should_work' in proc01.c is not guarded with
HAVE_SELINUX_SELINUX_H. Do you afraid the binary size?
Signed-off-by: Masatake YAMATO yam...@redhat.com
--- m4/ltp-common.m41970-01-01 09:00:00.0 +0900
+++ m4/ltp-common.m42009-02-06 15:35
This is a patch inspired by numerous whining recently seen on ltp-list
concerning compile failures when libaio is not present.
This includes changes:
- add stubs to the aio tests
- remove -laio from doio and pipeio makefile, as it was superfluous
Looks good.
Reviewed-by: Masatake
Removed check_header from Makefile of io_* testcases
and use autoconf instead of the macro.
Signed-off-by: Masatake YAMATO yam...@redhat.com
Index: testcases/kernel/syscalls/io_cancel/Makefile
===
RCS file: /cvsroot/ltp/ltp
On Sunday 18 January 2009 22:52:51 Masatake YAMATO wrote:
Today I tried to build ltp as explain in
`make help` and INSTALL file but I got following errors:
[yam...@localhost ltp]$ make autoconf
aclocal -I m4
autoconf
[yam...@localhost ltp]$ ./configure
Signed-off-by: Masatake YAMATO yam...@redhat.com
patch looks fine ... if Subrata doesnt merge it, i'll get around to it some
point this weekend
actually, i lie ... your patch was damaged by your e-mailer (it converted
long
lines). can you fix that up ?
-mike
Is this ok?
diff
...@localhost ltp]$
Could you update docuemtns(`make help` and INSTALL) or
fix a bug in the code?
Masatake YAMATO
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http
On Thu, 2009-01-15 at 10:31 -0500, Mike Frysinger wrote:
On Thursday 15 January 2009 01:56:47 Masatake YAMATO wrote:
--- a/Makefile
+++ b/Makefile
not sure we want to encourage documentation-in-the-build-system. could
you
add this stuff to INSTALL instead ? when people think
On Fri, 2009-01-16 at 14:07 +0900, Masatake YAMATO wrote:
Subrata,
Thank you for sending the files.
I found my mistake in m4/ltp-eventfd.m4.
To use AC_TRY_LINI, 'main' function is not needed.
Here is the revised patch:
Signed-off-by: Masatake YAMATO yam...@redhat.com
Subrata,
Thank you for sending the files.
I found my mistake in m4/ltp-eventfd.m4.
To use AC_TRY_LINI, 'main' function is not needed.
Here is the revised patch:
Signed-off-by: Masatake YAMATO yam...@redhat.com
diff --git a/config.mk.in b/config.mk.in
new file mode 100644
index 000
down these conversions used in LTP to toplevel Makefile or
somewhere? I was confused CFLAGS and CPPFLAGS.
Masatake YAMATO
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http
do you mean conventions rather than conversions ?
-mike
Sorry. I mean conventions.
Masatake
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
On Wednesday 14 January 2009 04:09:16 Masatake YAMATO wrote:
yes, there has been too much put all CPPFLAGS into CFLAGS and dont use
CPPFLAGS in the tree. it isnt a critical issue, but one we should be
fixing as we go rather than introducing more of the same.
as for LOADLIBES vs
On Wednesday 14 January 2009 04:09:16 Masatake YAMATO wrote:
yes, there has been too much put all CPPFLAGS into CFLAGS and dont
use CPPFLAGS in the tree. it isnt a critical issue, but one we
should be fixing as we go rather than introducing more of the same
returned 1 exit status
make[4]: *** [eventfd01] Error 1
Strange. Could you send me
- the output of ./configure
- include/config.h
- config.mk
- config.log
Regards,
Masatake YAMATO
--
This SF.net email is sponsored
Sorry,
Can you please resend me the patch ?
Yes. Please, try.
Signed-off-by: Masatake YAMATO yam...@redhat.com
diff --git a/config.mk.in b/config.mk.in
new file mode 100644
index 000..22bad68
--- /dev/null
+++ b/config.mk.in
@@ -0,0 +1 @@
+AIO_LIBS = @AIO_LIBS@
diff --git
we don't have any proof it is *NOT* kernel bug.
Masatake YAMATO
--
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
Sorry,
Can you please resend me the patch ?
Yes. Please, try.
Signed-off-by: Masatake YAMATO yam...@redhat.com
Yes, even with today´s CVS snapshot, i get the same error again:
cc -Wall -I../../include -g -Wall -I../../../../include -Wall
eventfd01.c -L
of libaio in configure for
testcases/kernel/syscalls/eventfd. It may be useful for
testcases/kernel/fs/doio. If you have interest, let me know.
I'd like to work with you.
Masatake YAMATO
-by: Masatake YAMATO yam...@redhat.com
--
___
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
Signed-off-by: Masatake YAMATO yam...@redhat.com
diff --git a/testcases/kernel/syscalls/inotify/inotify03.c
b/testcases/kernel/syscalls/inotify/inotify03.c
index 967082e..968f5ba 100644
--- a/testcases/kernel/syscalls/inotify/inotify03.c
+++ b/testcases/kernel/syscalls/inotify/inotify03.c
. Could you send me
- the output of ./configure
- include/config.h
- config.mk
- config.log
Regards,
Masatake YAMATO
--
___
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
Introducing autoconf still causes a troble.
Shooting the trouble may not be so difficult. However,
some information is needed. I'll write them on INSTALL
file.
Signed-off-by: Masatake YAMATO yam...@redhat.com
diff --git a/INSTALL b/INSTALL
index ad50711..f7c9654 100644
--- a/INSTALL
+++ b
, Boston, MA 02111-1307 USA
+dnl
+dnl Author: Masatake YAMATO yam...@redhat.com
+dnl
+
+dnl
+dnl LTP_CHECK_SYSCALL_EVENTFD
+dnl
+dnl
+AC_DEFUN([LTP_CHECK_SYSCALL_EVENTFD],
+[dnl
+AH_TEMPLATE(HAVE_IO_SET_EVENTFD,
+[Define to 1 if you have the `io_set_eventfd' function
Could you retry new patch?
Sorry I forgot to put my Signed-off-by line to the patch.
Signed-off-by: Masatake YAMATO yam...@redhat.com
diff --git a/config.mk.in b/config.mk.in
new file mode 100644
index 000..22bad68
--- /dev/null
+++ b/config.mk.in
@@ -0,0 +1 @@
+AIO_LIBS = @AIO_LIBS@
diff
?
As far as source code in subversion repository,
nothing is changed.
Masatake YAMATO
--
___
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net
Did you run configure?
If yes, please send config.log generated by configure.
Masatake YAMATO
FYI:
It looks like ltp-full-20081130.tgz added some signalfd testcases which
break compilation on RHEL5.3 for s390x arch.
make[4]: Entering directory
`/root/ltp-full-20081130/testcases
install
I will document that shortly in LTP README.
I've added small help target to Makefile.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/Makefile b/Makefile
index 12c942d..7fab4e8 100644
--- a/Makefile
+++ b/Makefile
@@ -126,3 +126,29 @@ ac-clean:
ac-distclean: ac-clean
ac
Did you run configure?
Hi Subrata
signalfd build fails on x3850 platform with 2.6.18-124.el5 kernel.
Same here. Machine info..
[EMAIL PROTECTED] ltp-full-20081130]# uname -a
Linux e325b.in.ibm.com 2.6.28-rc7 #1 SMP Fri Dec 5 08:53:28 IST 2008
i686 athlon i386 GNU/Linux
[EMAIL
-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/Makefile b/Makefile
index 12c942d..7fab4e8 100644
--- a/Makefile
+++ b/Makefile
@@ -126,3 +126,29 @@ ac-clean:
ac-distclean: ac-clean
ac-maintainer-clean: ac-distclean
rm -f configure
+
+#
+# Help
+#
+.PHONY: help
+help:
+ @echo
you know how to add license code to the
source files? At least the write-access to cvs repository is needed.
Do you have it?
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build
by : KONGHAO 2007.06
#
However, no mail address to contact with.
I'm not sure s/he is on crackerjack-devel list.
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build
On Wed, 2008-11-19 at 15:51 +0530, Subrata Modak wrote:
On Tue, 2008-11-18 at 22:15 +0900, Masatake YAMATO wrote:
Hi,
As I promised I've improved modify_ldt test cases.
Instead of using cond.mk, I've used autoconf.
Could you run modify_ldt test cases on ppc64?
And here
: redefinition of ‘struct
flock64’
make[4]: *** [signalfd01] Error 1
I'll look.
BTW, Maybe following patch is nothing to do with the bug you reported but
could you apply following patch?
Signed-off-by: Masatake YAMATO[EMAIL PROTECTED]
index 083e9ab..9b6380d 100644
--- a/m4/ltp-signalfd.m4
+++ b/m4
syscall.
Signed-of-by: Masatake YAMATO[EMAIL PROTECTED]
diff --git a/testcases/kernel/syscalls/modify_ldt/run-modify_ldt01.sh
b/testcases/kernel/syscalls/modify_ldt/run-modify_ldt01.sh
index 083e9ab..112e258 100644
--- a/m4/ltp-signalfd.m4
+++ b/m4/ltp-signalfd.m4
@@ -58,12 +58,13 @@ dnl
dnl
On Thu, Nov 20, 2008 at 01:44:47PM +0530, Subrata Modak wrote:
To check if unshare is supported or not, we can add code to the Makefile
itself. Even adding code to check Kernel Version in Makefile will be
better in my opinion.
Veerendra ?
See
Hi,
As I promised I've improved modify_ldt test cases.
Instead of using cond.mk, I've used autoconf.
Could you run modify_ldt test cases on ppc64?
I'll work on following test cases next:
- io_*
- eventfd
- inotify
Masatake YAMATO
Hi YAMATO,
I complete agree with you
Hi,
I've introduced autoconf to modify_ldt test cases.
The modification is very similar to the modification to signalfd.
Signed-off-by: Masatake YAMATO[EMAIL PROTECTED]
diff --git a/configure.ac b/configure.ac
index 3edc6cd..05df57d 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6,5 +6,8
However, I cannot
test it, because I get this:
[EMAIL PROTECTED]:/tmp/ltp$ make
autoheader
/usr/bin/m4:configure.ac:5: cannot open `m4/ltp-signalfd.m4': No such file
or directory
your checkout is incomplete ? you need the m4/ dir ...
Maybe -d option is needed like:
$ cvs
that may be used before `AC_INIT', but
for consistency, you are invited not to do so.
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications
Hi,
In today´s CVS snapshot, signalfd01.c failed to compile. Did i mess up
somewhere during patch application ?
cc -Wall -I../../include -g -Wall -I../../../../include -Wall
signalfd01.c -L../../../../lib -lltp -o signalfd01
../../include/linux_syscall_numbers.h:19: warning: ‘cleanup’
`install'.
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK win great prizes
Grand prize is a trip for two to an Open Source
their business, but it shouldnt be a requirement here. assuming the
m4 will only be used inside of the LTP build tree should make things
easier.
I see. Plesae, apply the following patch.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/Makefile b/Makefile
index 6f0e4c1..b01ca1b
However, i wanted:
make clean
to do all that stuff. So, updated accordingly.
I guess this will make people familiar with autoconf
confusing.
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
and config.status.
- maintainer-clean, a new make target, removes configure and
config.h.in.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/Makefile b/Makefile
index de0e5c8..0a48ee8 100644
--- a/Makefile
+++ b/Makefile
@@ -44,7 +44,8 @@ export CC AR RANLIB CPPFLAGS LDFLAGS HAS_NUMA
-include
case in ltp is
good enough.
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK win great prizes
Grand prize is a trip
And another thing to point out. Shouldn´t:
make clean
be removing stuff like configure, config.status, config.log,
autom4te.cache from the sources. It is retaining them. Is it expected ?
I would like them to clean up on make clean.
Regards--
Subrata
Currently I have no idea about the
.)
- Makefile becomes simple.
- #ifdef/#endif of signalfd01.c becomes readable.
- signalfd.m4 can use other program than ltp.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/configure.ac b/configure.ac
new file mode 100644
index 000..977b49b
--- /dev/null
+++ b/configure.ac
kernel headers can be older than the kernel version. A very important,
but subtle point...
[EMAIL PROTECTED] ~ $ esearch linux-headers
[ Results for search key : linux-headers ]
[ Applications found : 1 ]
* sys-kernel/linux-headers
Latest version available: 2.6.23-r3
;
+
iocb64 = compat_alloc_user_space(nr * sizeof(*iocb64));
ret = copy_iocb(nr, iocb, iocb64);
if (!ret)
For A I've revised the patch.
Signed-off-by: Sridhar Vinay [EMAIL PROTECTED]
Signed-off-by: Jin Bing Guo [EMAIL PROTECTED]
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED
time. However, if we
introduce autoconf carefully, our configure macro set may be product;
it will be resalable on applications on GNU/Linux.
Introducing autoconf may be big job. So we have to find something
incremental way for introducing.
Masatake YAMATO
# ./testcases/bin/setgroups01_16
setgroups01_161 FAIL : setgroups(65536, list) Failed, errno=14 :
Bad address
I'll check this, too.
Sorry for inconvenience.
Masatake YAMATO
-
This SF.Net email is sponsored
Hi,
Can you please look into some compilation error(s) reported on the
following machine at today´s snapshot.
Sorry to be late. Bit busy now. I'll check both signalfd01 and io_submit
in soon.
Regards,
Masatake YAMATO
This patch introduces new check_header defined in utils/cond.mk
to Makefile for modify_ldt test cases.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
--- ltp/testcases/kernel/syscalls/modify_ldt/Makefile 2006-08-21
15:58:41.0 +0900
+++ ltp-hacked/testcases/kernel/syscalls
- inotify
Regards,
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK win great prizes
Grand prize is a trip for two to an Open
);
break;
case 0x11:
ret = write_ldt(ptr, bytecount, 0);
break;
}
return ret;
}
Before working on Makefile related thing, I have to fix ...somehwere glibc, man
page, and modify_ldt0[12].c.
Masatake YAMATO
Hi YAMATO,
On my ppc64 machines, the io_submit01 returns error. Could you please have
a look at it?
Could you try this patch?
Masatake
*** io_submit01.c 21 Jul 2008 19:55:35 +0900 1.2
--- io_submit01.c 30 Sep 2008 23:10:53 +0900
***
*** 128,134
This patch introduces new check_header defined in utils/cond.mk
to Makefile for modify_ldt test cases.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
--- ltp/testcases/kernel/syscalls/modify_ldt/Makefile 2006-08-21
15:58:41.0 +0900
+++ ltp-hacked/testcases/kernel/syscalls
This patch introduces new check_header defined in utils/cond.mk
to Makefile for eventfd test cases.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
--- ltp/testcases/kernel/syscalls/eventfd/Makefile 2008-08-20
20:28:51.0 +0900
+++ ltp-hacked/testcases/kernel/syscalls/eventfd
This patch introduces new check_header defined in utils/cond.mk
to Makefile for inotify test cases.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff -ruN ltp/testcases/kernel/syscalls/inotify/Makefile
ltp-hacked/testcases/kernel/syscalls/inotify/Makefile
--- ltp/testcases/kernel
Added runtest/syscalls entry for signalfd.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff -ruN ltp/runtest/syscalls ltp-hacked/runtest/syscalls
--- ltp/runtest/syscalls2008-09-26 23:31:30.0 +0900
+++ ltp-hacked/runtest/syscalls 2008-09-26 23:31:44.0 +0900
The attached patch moves getgid02.c to getegid02.c.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
--- ltp-git-tmp/runtest/syscalls2008-09-22 12:43:00.0 +0900
+++ ltp-git/runtest/syscalls2008-09-22 12:32:33.0 +0900
@@ -265,12 +265,17 @@
getegid01 getegid01
\
./eventfd/Makefile:38:HAS_LIBAIO = $(call check_header,libaio.h)
Regards,
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK
We also needed the following here to fix the build break else would have
introduced:
then echo $${FOUND} ;fi)
Thanks. I have taken care.
Sorry, I took a mistake. Could you apply following patch?
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/testcases
and linux/signalfd.h.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/testcases/kernel/syscalls/signalfd/Makefile
b/testcases/kernel/syscalls/signalfd/Makefile
index be34bb1..93517da 100644
--- a/testcases/kernel/syscalls/signalfd/Makefile
+++ b/testcases/kernel/syscalls/signalfd
Hi,
On Thu, 2008-09-11 at 21:47 +0900, Masatake YAMATO wrote:
Finally i tested them and were satisfied with the way it built,
installed and ran on 4 arch i tested. But, i am puzzled by one thing. On
all systems (even on kernel 2.6.26 for i386, ppc64, x86_64) it gave me
the following
this kind of effort?
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
diff --git a/testcases/kernel/syscalls/signalfd/Makefile
b/testcases/kernel/syscalls/signalfd/Makefile
index be34bb1..db37fd4 100644
--- a/testcases/kernel/syscalls/signalfd/Makefile
+++ b/testcases/kernel/syscalls/signalfd
Subrata,
Sorry making you confusing.
My patch is based on Roy's. In my patch my comment is reflected on my
patch. My comment is applicable to both compat_16.mk and
newer_64.mk. So I submitted them in one post. Roy asked me to rewrite
the original one and submit it. So I did.
I already
of command line do you use to generate this kind of output?
Newly added files are included in my patch. I cannot find good option
in cvs diff for such purpose. All peope moved to git already?
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
---
signalfd/Makefile | 35 +
signalfd/signalfd01.c
tree and invoke diff command by hand. Very painful.
Newly added files are included in my patch. I cannot find good option
in cvs diff for such purpose. All peope moved to git already?
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
This works for me. I can now apply directly by saving
Yamato,
Send these series (1-3) as a patch either embedded in the mail, or, as
an attachment. But, as Vijay wants it in mail, better embed in mail.
What you have done is just pasted the code. Instead, create patches and
then paste patch(s) like the following:
Like this?
What kind
?
Here after I'd like to use the compat_gid.h in newly ported test cases.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
/*
*
* Copyright (c) Red Hat Inc., 2008
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public
you to modify
ltp/testcases/kernel/syscalls/utils/compat_16.mk like:
From:
TARGETS_16 = $(patsubst %.c,%_16,$(SRCS))
TARGETS += $(TARGETS_16)
To:
TARGETS_16 = $(patsubst %.c,%_16,$(SRCS))
if XXX
TARGETS += $(TARGETS_16)
endif
Regards,
Masatake YAMATO
Vijay, thank you for reviweing.
In the Makefile of signalfd, -DHAS_SIGNALFD_H is added to CFLAGS if
sys/signalfd.h exists. If it doesn't exist, following code is compiled
as signalfd01 test case:
#include stdio.h
int
main(int argc, char** argv)
{
printf(%s 0
Hi,
Currently, the newer_64 testcases are built and run by default
This causes some unnecessary failed cases on machines which
don't support them.
This patch adds build time switches for turn off those tests.
Usage example:
make TST_NEWER_64=no
I think the patch is O.K.
I
Hi,
I'll send revised a test case for signalfd based on input from Vijay.
Consider the current working directory is at ltp/testcases/kernel/syscalls.
[patch 1/3]: utils/cond.mk
[patch 2/3]: signalfd/Makefile
[patch 3/3]: signalfd/signalfd01.c
signalfd/Makefile uses check_header macro defined
check_header is defined in cond.mk.
Makefiles in other test cases can use the macro.
signalfd/Makefile is the first applicant to use it.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
# cond.mk --- useful functions to write conditions
#
# Copyright (c) International Business Machines Corp
Hi,
On Mon, 2008-09-01 at 13:39 +0900, Masatake YAMATO wrote:
Hi,
I've written a testcase for signalfd.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
Thanks for writing these tests afresh. But, there seems to be some
inherent problem in it´s compilation. It fails in all
Hi,
Currently, the compat_16 testcases are built and run by default
This causes some unnecessary failed cases on machines which
don't support them.
This patch added build time switches for turn on/off those tests.
(default: all off)
Usage example:
make
Hi,
I extended getegid testcase to test getegid16, too.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
Index: runtest/syscalls
===
RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
retrieving revision 1.211
diff -c -r1.211 syscalls
Hi,
I've written a testcase for signalfd.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
Index: runtest/syscalls
===
RCS file: /cvsroot/ltp/ltp/runtest/syscalls,v
retrieving revision 1.211
diff -c -r1.211 syscalls
*** runtest
Sorry, I found one typo in my code.
Please apply following patch.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
Index: testcases/kernel/syscalls/utils/newer_64.mk
===
RCS file: /cvsroot/ltp/ltp/testcases/kernel/syscalls/utils
or
something like ltp/testcases/kernel/syscalls/common because there
are manyh _16 and _64 system calls. I don't want to make many copies.
Signed-off-by: Masatake YAMATO [EMAIL PROTECTED]
compat_16.mk
#
# Copyright (c) Red Hat Inc., 2008
#
# This program is free software; you can redistribute
, let's add
code snippets which make people easier to
follow the rule to LTP.
How do you think?
Masatake YAMATO
-
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based
Thanks for making the changes Masatake-san. This'll make my life
a lot easier in terms of porting crackjack to the new makefile
infrastructure, and it's a lot easier / scalable than using cp / echo
to add your necessary defines to files :). Plus it lowers the
probability of cluttering
How about introducing TCID_DEFINE?
I'm not sure puttint TCID_DEFINE macro to test.h.
I'm not sure using a symbol as an argument for TCID_DEFINE macro
is better than using a string. (I had strong lisp backgroud:-)
If this acceptable, I'll update related documents and
1 - 100 of 136 matches
Mail list logo
