Re: [LTP] Running only kernel syscall tests

2011-08-02 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Mon, Aug 1, 2011 at 9:28 PM, Shakthi Kannan skan...@redhat.com wrote: Hi, Are there any options to runltp or any other means to just run the kernel syscall tests? runltp -f syscalls How long does it take to run the runalltests.sh on

Re: [LTP] pidns errors

2011-03-09 Thread Serge E. Hallyn
Quoting Cyril Hrubis (chru...@suse.cz): Hi! Are there still known issues with the pidns tests and 20110228 stable release? I've got the same failure on 2 unrelated pieces of hardware but both running SLE11SP1 (2.6.32) kernel. The pidns tests just hang with multiple child processes. I

Re: [LTP] [PATCH] unshare01.c: TEST_RETURN is used wrong

2011-02-15 Thread Serge E. Hallyn
Quoting Peng Haitao (pen...@cn.fujitsu.com): Hi Garrett, Signed-off-by: Peng Haitao pen...@cn.fujitsu.com --- testcases/kernel/syscalls/unshare/unshare01.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/testcases/kernel/syscalls/unshare/unshare01.c

Re: [LTP] About Community discussion

2010-12-13 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): That being said, it still puzzles me why other folks attached to the project have been largely silent over the past couple months or years (in particular the official maintainers), as I would figure that they would have a vested interest in

Re: [LTP] networkstress tests

2010-11-30 Thread Serge E. Hallyn
Quoting ARJIT SHARMA (joyar...@gmail.com): broken_ip4-version010 TINFO : - Test duration is 3600 [sec] cut: option requires an argument -- 'f' Try `cut --help' for more information. What distribution are you using? Looks like the tests will need to be tweaked to accomodate your version

Re: [LTP] networkstress tests

2010-11-30 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (serge.hal...@canonical.com): Quoting ARJIT SHARMA (joyar...@gmail.com): broken_ip4-version010 TINFO : - Test duration is 3600 [sec] cut: option requires an argument -- 'f' Try `cut --help' for more information. What distribution are you using? Looks like

Re: [LTP] networkstress tests

2010-11-29 Thread Serge E. Hallyn
Quoting ARJIT SHARMA (joyar...@gmail.com): Hi, I was trying to run network stress tests on my side, but none of them is passing. it is not able to find the harware address at remote host, altough the settings and configurations are as required and as mentioned in README and

[LTP] [PATCH 1/1] securebits: fix running of testcases

2010-10-20 Thread Serge E. Hallyn
Exit as soon as one breaks. Heck, clean it up by letting set -e do it for me. Signed-off-by: Serge Hallyn serge.hal...@canonical.com --- .../kernel/security/securebits/run_securebits.sh | 18 +- 1 files changed, 5 insertions(+), 13 deletions(-) diff --git

Re: [LTP] Current state of the selinux tests in ltp-full-20100831

2010-10-06 Thread Serge E. Hallyn
Quoting Jeffrey Burke (jbu...@redhat.com): Folks, It has been a while since I update LTP for selinux testing. I am currently trying to use ltp-full-20100831 on RHEL5.6. I don't believe the procedure has changed at least according to the README. But here are the steps I followed. 1.) tar

Re: [LTP] [PATCH] Compilation Error Fixed in filecaps.

2010-10-04 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): So I'm not sure what Serge was looking at... Not me. -serge -- Virtualization is moving to the mainstream and overtaking non-virtualized environment for deploying

Re: [LTP] [PATCH] securebits: add secure_keepcaps testcases

2010-10-04 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): Looks fine to be,i just need a little documentation file which would say: What securebits is all about (some pointers/links)? Any specific configuration required to run these tests, etc ? Serge, Can you also provide me this ? I

Re: [LTP] [PATCH] securebits: add secure_keepcaps testcases

2010-10-04 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): Hi Serge, Some comments about your provided code. Thanks. +AC_DEFUN([LTP_CHECK_SECUREBITS], +AC_CHECK_HEADERS(linux/securebits.h,[ +       LTP_SECUREBITS=yes +]) +) Some checks should probably be added for versioning as well as

Re: [LTP] [PATCH] securebits: add secure_keepcaps testcases

2010-10-04 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Mon, Oct 4, 2010 at 7:06 AM, Serge E. Hallyn serge.hal...@canonical.com wrote: Quoting Garrett Cooper (yaneg...@gmail.com): Hi Serge,     Some comments about your provided code. Thanks. +AC_DEFUN([LTP_CHECK_SECUREBITS

Re: [LTP] [PATCH] Compilation Error Fixed in filecaps.

2010-09-27 Thread Serge E. Hallyn
Quoting Sravan V Dodla (sra...@linux.vnet.ibm.com): Hello, I have been facing an compilation issue with the latest version of LTP. After some debugging I found out that the I don't see that code in current ltp head. It checks HAVE_LIBCAP. What code are you looking at? flag

Re: [LTP] ima

2010-09-14 Thread Serge E. Hallyn
Quoting ARJIT SHARMA (joyar...@gmail.com): hi, in ima testcase all the 4 testcases are failing because of error as cannot mount security fs Why is this error coming..please tell me. Do you have CONFIG_SECURITYFS=y ? -serge

Re: [LTP] [RFC] New Test Cases has dried up

2010-07-28 Thread Serge E. Hallyn
-0500, Serge E. Hallyn wrote: Quoting Subrata Modak (subr...@linux.vnet.ibm.com): Hello everybody, We completed 4 months of 2010, but, i do not find major activity in creating/writing/contributing new tests to LTP. Can we restart contributing new tests to LTP ? I am sure

Re: [LTP] selinux testsuite

2010-07-01 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): On Thu, 2010-07-01 at 22:36 +0530, Subrata Modak wrote: On Wed, 2010-06-30 at 10:52 -0400, Stephen Smalley wrote: On Wed, 2010-06-30 at 17:43 +0530, Subrata Modak wrote: Hi Serge, On Tue, 2010-06-29 at 14:52 -0500, Serge E. Hallyn

Re: [LTP] [PATCH] NetNS test fixes

2010-05-07 Thread Serge E. Hallyn
debugging. Changes in v2: - Initialize status=0 at the top of child_1.sh to prevent overshadowing a (meaningless) sshd failure Signed-off-by: Dan Smith da...@us.ibm.com Acked-by: Serge E. Hallyn se...@us.ibm.com thanks, -serge

Re: [LTP] [04/12 FAILURE] LTP? sysctl03 test fails

2010-05-06 Thread Serge E. Hallyn
. The thing that should scare us is if the call succeeds. If we give any false positives, then true positives will seem less scary. -serge From 2cf7797329275126cc3f80a24bfb8bb2e3f44747 Mon Sep 17 00:00:00 2001 From: Serge E. Hallyn se...@us.ibm.com Date: Thu, 6 May 2010 08:30:52 -0500 Subject: [PATCH 1

Re: [LTP] [PATCH] Fix FILECAPS test hanging for more than 12 hours

2010-05-06 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On May 5, 2010, at 7:18 AM, Serge E. Hallyn wrote: Quoting Garrett Cooper (yaneg...@gmail.com): p = index(buf, '.')+1; Jinkeys! The intertubes archives insist I wrote that, but I'm finding it hard to believe

[LTP] [PATCH v2] make filecaps tests succeed

2010-05-06 Thread Serge E. Hallyn
: may 4: address Garrett's feedback 1. single return 0 in print_caps.c 2. use $TMP if defined for location of caps_fifo 3. use tst_brkm in place of tst_resm. may 5: address Garrett's comment: don't add 1 to null pointer and then check for 1 Signed-off-by: Serge E. Hallyn se...@us.ibm.com

Re: [LTP] [04/12 FAILURE] LTP? sysctl03 test fails

2010-05-06 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Thu, May 6, 2010 at 6:53 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper (yaneg...@gmail.com): On May 5, 2010, at 11:56 PM, Subrata Modak wrote: Subject: LTPś sysctl03 test fails Issues Description Below

Re: [LTP] [04/12 FAILURE] LTP? sysctl03 test fails

2010-05-06 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Thu, May 6, 2010 at 10:55 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper (yaneg...@gmail.com): So since we're all member of the doc team, send a patch for sysctl(2) manpage ERRORS section :) (mtk cc:d

Re: [LTP] ltp sysctl03 testcase failed in version of 20100228

2010-05-05 Thread Serge E. Hallyn
Quoting Henry xu (feng...@windriver.com): Hi,all I test sysctl03 in x86 and ppc platform and product the same fails as below. r...@z530:/opt/ltp-full/testcases/bin ./sysctl03 sysctl031 TFAIL : Expected EPERM (1), got 13: Permission denied sysctl032 TFAIL : Expected EPERM,

Re: [LTP] [PATCH] Fix FILECAPS test hanging for more than 12 hours

2010-05-05 Thread Serge E. Hallyn
whether or not index returns NULL instead of accessing memory like that? Other than that, patch looks good. From: Serge E. Hallyn se...@us.ibm.com Date: Wed, 5 May 2010 02:59:05 -0500 Subject: [PATCH 1/1] check for index(3) returning NULL Signed-off-by: Serge E. Hallyn se...@us.ibm.com

Re: [LTP] [PATCH] Fix FILECAPS test hanging for more than 12 hours

2010-05-04 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): Serge, please add a Sign-off. It's there in the patch in your attachment... -serge -- ___ Ltp-list mailing list

Re: [LTP] mqns tests are failing

2010-04-28 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Wed, Apr 28, 2010 at 1:54 AM, Munipradeep Beerakam mprad...@linux.vnet.ibm.com wrote: Hi, I noticed that mqns test cases are failing. I am using March 2010 LTP. After changing mq_open syscall in mqns_01.c file, test is passing. Same thing

Re: [LTP] mqns tests are failing

2010-04-28 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Wed, Apr 28, 2010 at 6:42 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper (yaneg...@gmail.com): On Wed, Apr 28, 2010 at 1:54 AM, Munipradeep Beerakam mprad...@linux.vnet.ibm.com wrote: Hi, I noticed that mqns test

[LTP] [PATCH 2/4] pidns30: strip leading / from name passed to mq_open

2010-04-28 Thread Serge E. Hallyn
Signed-off-by: Serge Hallyn se...@us.ibm.com --- testcases/kernel/containers/pidns/pidns30.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testcases/kernel/containers/pidns/pidns30.c b/testcases/kernel/containers/pidns/pidns30.c index ea8c54c..5975b53 100644 ---

[LTP] [PATCH ltp] make filecaps tests succeed

2010-04-28 Thread Serge E. Hallyn
Most of these are belated cleanup after the move to using /opt/ltp. Also undoing an ill-advised replacement of return with tst_exit. All filecaps tests now succeed on fedora 10. Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- testcases/kernel/security/filecaps/filecapstest.sh |9

Re: [LTP] [PATCH ltp] make filecaps tests succeed

2010-04-28 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Wed, Apr 28, 2010 at 3:47 PM, Serge E. Hallyn se...@us.ibm.com wrote: Most of these are belated cleanup after the move to using /opt/ltp. Also undoing an ill-advised replacement of return with tst_exit.  All filecaps tests now succeed

Re: [LTP] [PATCH 1/4] mqns: strip leading / from mq names

2010-04-28 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Wed, Apr 28, 2010 at 2:09 PM, Serge E. Hallyn se...@us.ibm.com wrote: So the tests can pass Signed-off-by: Serge Hallyn se...@us.ibm.com ---  testcases/kernel/containers/mqns/mqns.h    |    2 ++  testcases/kernel/containers/mqns/mqns_01

Re: [LTP] cap_bset_inh_bounds.c build failure

2010-04-07 Thread Serge E. Hallyn
Quoting Mitani (mit...@ryobi.co.jp): Hi, -Original Message- From: Serge E. Hallyn [mailto:se...@us.ibm.com] Sent: Monday, April 05, 2010 10:22 PM To: Mitani Cc: ltp-list@lists.sourceforge.net Subject: Re: [LTP] cap_bset_inh_bounds.c build failure Quoting Mitani (mit

Re: [LTP] cap_bounds_r.c build failure

2010-04-05 Thread Serge E. Hallyn
Quoting Mitani (mit...@ryobi.co.jp): Hi, I tired to upgrade libcap from libcap-1.0-20 to libcap-2.11. My system is RHEL4.8 (x86) and kernel version is 2.6.9-89.ELsmp. Oh, I'm sorry, I misunderstood from the first. I thought you wanted to test a modern kernel on an older distro. So the

Re: [LTP] cap_bset_inh_bounds.c build failure

2010-04-05 Thread Serge E. Hallyn
Quoting Mitani (mit...@ryobi.co.jp): Hi, I tried to build by using yesterday's git in my system (RHEL4.8 x86). (ltp-dev-4837fee8a7c2de6a83c8927a574c792ca6dabe4e.tar.gz) But build failed in cap_bset_inh_bounds.c with following message. This is different from cap_bounds_r.c's problem

Re: [LTP] cap_bounds_r.c build failure

2010-04-01 Thread Serge E. Hallyn
Quoting Mitani (mit...@ryobi.co.jp): Hi Rishi, I installed libcap-devel, but after configure, build failed, too. [r...@rhel4-8 mitani]# rpm -qa | grep libcap libcap-devel-1.10-20 libcap-1.10-20 [r...@rhel4-8 mitani]# libcap-1.10-20 version is normal version

Re: [LTP] [PATCH ltp] fix detection of setcap for filecaps test

2010-03-23 Thread Serge E. Hallyn
-ne 0 ]; then exit_code=$tmp fi +unlink caps_fifo exit $exit_code -Rishi On Sat, Mar 20, 2010 at 08:10:04PM -0500, Serge E. Hallyn wrote: Remove the run-time checks and just have autoconf check for libcap and setcap presence. ( applies on top of the patch I sent

[LTP] [PATCH ltp] fix up filecaps and cap_bound testcases

2010-03-20 Thread Serge E. Hallyn
. (I'm sure there is an AC_ macro for finding a command) Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- configure.ac |1 + m4/ltp-cap.m4 | 16 + m4/ltp-prctl.m4| 31

[LTP] [PATCH ltp] fix detection of setcap for filecaps test

2010-03-20 Thread Serge E. Hallyn
Remove the run-time checks and just have autoconf check for libcap and setcap presence. ( applies on top of the patch I sent this morning ) After this, filecaps tests compile, install, and pass on f10 at least. Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- m4/ltp-cap.m4

Re: [LTP] LTP's filecaps test gives false positive results

2010-03-03 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Tue, Mar 2, 2010 at 9:56 PM, Rishikesh K Rajak risra...@linux.vnet.ibm.com wrote: On Tue, Mar 02, 2010 at 10:25:23AM -0800, Garrett Cooper wrote: On Mar 2, 2010, at 9:35 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper

Re: [LTP] LTP's filecaps test gives false positive results

2010-03-02 Thread Serge E. Hallyn
Quoting Iranna D Ankad (iranna.an...@in.ibm.com): LTP reports setcap is installed, but actually, my system has setcap installed, along with all required libcap related rpms. mx3950:/opt/ltp # setc setcap setconsole setctsid mx3950:/opt/ltp # mx3950:/opt/ltp # rpm -qa | grep cap

Re: [LTP] LTP's filecaps test gives false positive results

2010-03-02 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): Sent from my iPhone On Mar 2, 2010, at 7:21 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Iranna D Ankad (iranna.an...@in.ibm.com): LTP reports setcap is installed, but actually, my system has setcap installed, along with all required

Re: [LTP] pidns17 problem in 2010-02-11 cvs

2010-02-12 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Fri, Feb 12, 2010 at 11:17 AM, Garrett Cooper yaneg...@gmail.com wrote: On Fri, Feb 12, 2010 at 9:51 AM, Serge E. Hallyn se...@us.ibm.com wrote: Right, the test is checking whether kill -1 inside a private pidns kills all processes besides

Re: [LTP] pidns17 problem in 2010-02-11 cvs

2010-02-12 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Fri, Feb 12, 2010 at 9:51 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Mitani (mit...@ryobi.co.jp): Hi, I tried to test with 2010-02-11 cvs in RHEL5.4 system. But the test brings termination of connection. I examined

Re: [LTP] container_test.sh failure

2010-02-11 Thread Serge E. Hallyn
Quoting Michal Simek (michal.si...@petalogix.com): Serge E. Hallyn wrote: Quoting Rishikesh (risra...@linux.vnet.ibm.com): Hi Garret, With today's cvs getting following error while running the container What about today's *git* ? What git repo do you mean? The one Rishi is about

Re: [LTP] container_test.sh failure

2010-02-09 Thread Serge E. Hallyn
Quoting Rishikesh (risra...@linux.vnet.ibm.com): Hi Garret, With today's cvs getting following error while running the container What about today's *git* ? -serge -- The Planet: dedicated and managed hosting, cloud

Re: [LTP] regression: selinux testsuite broken since October

2010-01-13 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): On Wed, 2010-01-13 at 11:37 -0800, Garrett Cooper wrote: Yeah, you're right. I was trying to beat around this bush by not copying these over, but it's better to have the test running and be improperly designed than it is for regressions to leak

Re: [LTP] regression: selinux testsuite broken since October

2010-01-12 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Mon, Jan 11, 2010 at 1:00 PM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Stephen Smalley (s...@tycho.nsa.gov): On Mon, 2010-01-11 at 13:50 -0600

Re: [LTP] regression: selinux testsuite broken since October

2010-01-11 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): On Fri, 2010-01-08 at 23:27 -0800, Garrett Cooper wrote: On Fri, Jan 8, 2010 at 2:08 PM, Garrett Cooper yaneg...@gmail.com wrote: On Fri, Jan 8, 2010 at 2:00 PM, Stephen Smalley s...@tycho.nsa.gov wrote: On Fri, 2010-01-08 at 13:38 -0800,

Re: [LTP] regression: selinux testsuite broken since October

2010-01-11 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): On Mon, 2010-01-11 at 13:50 -0600, Serge E. Hallyn wrote: Fails with: cp: cannot stat `/home/sds/ltp/testcases/kernel/security/selinux-testsuite/refpolicy/policy_files/generic/test_policy.*': No such file or directory You ran /home

Re: [LTP] regression: selinux testsuite broken since October

2010-01-11 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Stephen Smalley (s...@tycho.nsa.gov): On Mon, 2010-01-11 at 13:50 -0600, Serge E. Hallyn wrote: Fails with: cp: cannot stat `/home/sds/ltp/testcases/kernel/security/selinux-testsuite/refpolicy/policy_files/generic/test_policy

Re: [LTP] regression: selinux testsuite broken since October

2010-01-11 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Stephen Smalley (s...@tycho.nsa.gov): On Mon, 2010-01-11 at 13:50 -0600, Serge E. Hallyn wrote: Fails with: cp: cannot stat `/home/sds/ltp/testcases/kernel/security/selinux

Re: [LTP] regression: selinux testsuite broken since October

2010-01-11 Thread Serge E. Hallyn
Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Serge E. Hallyn (se...@us.ibm.com): Quoting Stephen Smalley (s...@tycho.nsa.gov): On Mon, 2010-01-11 at 13:50 -0600, Serge E. Hallyn wrote: Fails with: cp: cannot stat `/home

Re: [LTP] regression: selinux testsuite broken since October

2010-01-06 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): It seems the Makefile rewrite last October broke the selinux testsuite. Is it unreasonable to expect that someone who rewrote the Makefile would actually try running the testsuite? Please, revert the changes or fix them. See

Re: [LTP] regression: selinux testsuite broken since October

2010-01-06 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): It seems the Makefile rewrite last October broke the selinux testsuite. Is it unreasonable to expect that someone who rewrote the Makefile would actually try running the testsuite? Please, revert the changes or fix them. See

Re: [LTP] [PATCH 1/1] say FAIL not PASS when we failed

2010-01-05 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Jan 4, 2010, at 3:36 PM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper (yaneg...@gmail.com): On Jan 4, 2010, at 9:16 AM, Serge E. Hallyn se...@us.ibm.com wrote: Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- testcases

Re: [LTP] [PATCH 1/1] say FAIL not PASS when we failed

2010-01-05 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): Sent from my iPhone On Jan 5, 2010, at 8:30 AM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper (yaneg...@gmail.com): On Jan 4, 2010, at 3:36 PM, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Garrett Cooper (yaneg

Re: [LTP] [PATCH 1/1] say FAIL not PASS when we failed

2010-01-05 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): Ok, so before I commit I just want to make sure that this makes sense with you: The differences are: 1. The id -?r?u use. Either one can be fooled, neither should be... 2. The while [ ! ... -a ... ] vs until [ ... -o ... ] logic (is more

Re: [LTP] clone tests fails

2010-01-05 Thread Serge E. Hallyn
Quoting Jiri Palecek (jpale...@web.de): Serge E. Hallyn napsal(a): Quoting Michal Simek (michal.si...@petalogix.com): Serge E. Hallyn wrote: Quoting Michal Simek (michal.si...@petalogix.com): Hi Mike, I have one question about one your big patch http://git.kernel.org/?p=linux/kernel/git

Re: [LTP] [PATCH ltp] p9auth: add missing checkp9auth.sh script

2010-01-04 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): Hi Serge, When do this script need to be run? Before compiling or before / while running? -Garrett Hi, Either could do, but there's reason to do it at both. It doesn't need to be run before each test, but has to load the module and set up

Re: [LTP] clone tests fails

2010-01-04 Thread Serge E. Hallyn
Quoting Michal Simek (michal.si...@petalogix.com): Hi Mike, I have one question about one your big patch http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h=391dc18fe3271fbf2ca1864a5299f091c31e0018 My question is why you add -1 in lib/cloner.c:65 + ret =

[LTP] [PATCH 1/1] say FAIL not PASS when we failed

2010-01-04 Thread Serge E. Hallyn
Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- testcases/kernel/security/p9auth/p9priv.sh |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/testcases/kernel/security/p9auth/p9priv.sh b/testcases/kernel/security/p9auth/p9priv.sh index ad2eead..c1a14d0 100755

Re: [LTP] clone tests fails

2010-01-04 Thread Serge E. Hallyn
Quoting Michal Simek (michal.si...@petalogix.com): Serge E. Hallyn wrote: Quoting Michal Simek (michal.si...@petalogix.com): Hi Mike, I have one question about one your big patch http://git.kernel.org/?p=linux/kernel/git/galak/ltp.git;a=commitdiff;h

Re: [LTP] [PATCH] containers: mqns: use libc's mq_open, not syscall(__NR_mq_open

2009-12-23 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Tue, Dec 22, 2009 at 9:11 AM, Serge E. Hallyn se...@us.ibm.com wrote: The glibc version removes the leading '/' from the message queue name. Not doing so makes the system call fail.  We could just remove the '/' from SLASH_MQ1, if for some

[LTP] [PATCH] containers: mqns: use libc's mq_open, not syscall(__NR_mq_open

2009-12-22 Thread Serge E. Hallyn
The glibc version removes the leading '/' from the message queue name. Not doing so makes the system call fail. We could just remove the '/' from SLASH_MQ1, if for some reason that were preferred, but using glibc functions when possible seems cleaner to me. Signed-off-by: Serge Hallyn

Re: [LTP] [PATCH] testcase pidns20, pidns21 on pid namespace

2009-11-10 Thread Serge E. Hallyn
Quoting Rishikesh (risra...@linux.vnet.ibm.com): Subrata Modak wrote: On Mon, 2009-02-16 at 10:59 +0530, Subrata Modak wrote: Thanks Suka, On Sat, 2009-02-14 at 12:31 -0800, Sukadev Bhattiprolu wrote: Subrata Modak [subr...@linux.vnet.ibm.com] wrote: | | pidns21: |

[LTP] [PATCH 1/1] define and use common clone helpers (v2)

2009-09-29 Thread Serge E. Hallyn
arguments are always consistent. Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- include/test.h | 10 ++ lib/cloner.c | 102 testcases/kernel/containers/libclone/libclone.c| 32

Re: [LTP] [PATCH RFC] ltp: define and use common clone helpers

2009-09-27 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Tue, 2009-09-22 at 23:05 -0500, Serge E. Hallyn wrote: Quoting Mike Frysinger (vap...@gentoo.org): On Monday 21 September 2009 19:06:44 Serge E. Hallyn wrote: Define ltp_clone() and ltp_clone_malloc() in libltp, and convert

Re: [LTP] [PATCH RFC] ltp: define and use common clone helpers

2009-09-22 Thread Serge E. Hallyn
Quoting Mike Frysinger (vap...@gentoo.org): On Monday 21 September 2009 19:06:44 Serge E. Hallyn wrote: Define ltp_clone() and ltp_clone_malloc() in libltp, and convert existing clone usages to them. (clone04 can't use it bc it wants to pass NULL, which ltp_clone() will for many arches

[LTP] [PATCH] Create testcase for p9auth kernel module (v2)

2009-09-21 Thread Serge E. Hallyn
the openssl check to checkp9auth.sh. Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- README |9 ++ runtest/p9auth |2 + testcases/kernel/security/Makefile |2 +- testcases/kernel/security/p9auth

[LTP] [PATCH RFC] ltp: define and use common clone helpers

2009-09-21 Thread Serge E. Hallyn
considering applying. Signed-off-by: Serge E. Hallyn se...@us.ibm.com --- include/test.h |8 ++ lib/cloner.c | 92 testcases/kernel/containers/libclone/libclone.c| 32 +--- testcases

[LTP] [LTP PATCH] Create testcase for p9auth kernel module

2009-09-16 Thread Serge E. Hallyn
sure we can setuid when there is a valid hash 3. make sure we cannot setuid if there is a valid hash, but our original uid isn't the one specified in the token. Run the testcase using ./runltp -f p9auth Signed-off-by: Serge E. Hallyn se...@us.ibm.com

Re: [LTP] [PATCH 1/1] Containers: Pass a valid stack address to clone

2009-09-07 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Wed, 2009-09-02 at 16:13 -0400, Mike Frysinger wrote: On Wednesday 02 September 2009 10:10:27 Serge E. Hallyn wrote: Also fix the libnetns helper to, like the libclone one, special-case hppa and pass the bottom of the stack to clone2

[LTP] [PATCH 1/1] netns: don't run sysfsview testcase

2009-08-25 Thread Serge E. Hallyn
It can't pass right now, and leaves the system in a bad state on its inevitable failure. Leave the testcase there though since one day we will hopefully support it. Signed-off-by: Serge Hallyn se...@us.ibm.com --- testcases/kernel/containers/netns/runnetnstest.sh | 25 1

Re: [LTP] clone01 -c 10 on x86

2009-08-04 Thread Serge E. Hallyn
Quoting Michal Simek (michal.si...@petalogix.com): Subrata Modak wrote: On Mon, 2009-08-03 at 10:14 -0500, Serge E. Hallyn wrote: Quoting Michal Simek (michal.si...@petalogix.com): Hi All, can you please to run clone01 syscall test on any x86 machine? I am getting fault

Re: [LTP] Fix digsig so it passes -Wshadow

2009-08-03 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Fri, 2009-07-31 at 09:36 -0500, Serge E. Hallyn wrote: Quoting Garrett Cooper (yaneg...@gmail.com): On Thu, Jul 30, 2009 at 11:33 PM, Garrett Cooperyaneg...@gmail.com wrote: clone(2) is externally defined in sched.h

Re: [LTP] clone01 -c 10 on x86

2009-08-03 Thread Serge E. Hallyn
Quoting Michal Simek (michal.si...@petalogix.com): Hi All, can you please to run clone01 syscall test on any x86 machine? I am getting fault there when I run it 10 times for example. The same problem I have on Microblaze. ./clone01 -c 10 clone01 1 TPASS : clone() returned 22738

Re: [LTP] Fix digsig so it passes -Wshadow

2009-07-31 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): clone(2) is externally defined in sched.h, and as such testcases/kernel/security/digsig/writeexec/libwritetest.c fails to compile with -Wall due to a shadowed declaration. Signed-off-by: Garrett Cooper yaneg...@gmail.com Index:

Re: [LTP] Fix digsig so it passes -Wshadow

2009-07-31 Thread Serge E. Hallyn
Quoting Garrett Cooper (yaneg...@gmail.com): On Thu, Jul 30, 2009 at 11:33 PM, Garrett Cooperyaneg...@gmail.com wrote: clone(2) is externally defined in sched.h, and as such testcases/kernel/security/digsig/writeexec/libwritetest.c fails to compile with -Wall due to a shadowed declaration.

Re: [LTP] [PATCH] Fix pidns14 test case

2009-07-03 Thread Serge E. Hallyn
Quoting M. Mohan Kumar (mo...@in.ibm.com): [PATCH] pidns14 Container-init may be immune to unhandled fatal signals (like SIGUSR1) even if they are from ancestor namespace. SIGKILL/SIGSTOP are the only reliable signals to a container-init from ancestor namespace. Make sure that

Re: [LTP] Report - make error of ltp-full-20090531.tgz

2009-06-17 Thread Serge E. Hallyn
Quoting GeunSik Lim (leem...@gmail.com): On Wed, Jun 17, 2009 at 9:22 PM, Steve Grubbsgr...@redhat.com wrote: I am not the maintainer, so I don't have that ability. I did record a successful test message in bodhi on LTP's behalf to encourage the maintainer to ask for it to be marked stable

Re: [LTP] Report - make error of ltp-full-20090531.tgz

2009-06-16 Thread Serge E. Hallyn
a look in the morning, but Andrew do you know offhand what the problem is with capability.h (in F11 I gather) that would cause: Serge E. Hallyn, Thanks for your opinion about this report that I posted. Yes. My below patch is private patch to solve make error on Fedora 11 distribution

Re: [LTP] Report - make error of ltp-full-20090531.tgz

2009-06-16 Thread Serge E. Hallyn
Quoting Steve Grubb (sgr...@redhat.com): On Tuesday 16 June 2009 12:19:49 pm Serge E. Hallyn wrote: Quoting GeunSik Lim (leem...@gmail.com): On Tue, Jun 16, 2009 at 1:24 PM, Serge E. Hallynse...@us.ibm.com wrote: Quoting GeunSik Lim (leem...@gmail.com): I made patch file to solve

Re: [LTP] Report - make error of ltp-full-20090531.tgz

2009-06-16 Thread Serge E. Hallyn
Quoting Steve Grubb (sgr...@redhat.com): On Tuesday 16 June 2009 12:19:49 pm Serge E. Hallyn wrote: Quoting GeunSik Lim (leem...@gmail.com): On Tue, Jun 16, 2009 at 1:24 PM, Serge E. Hallynse...@us.ibm.com wrote: Quoting GeunSik Lim (leem...@gmail.com): I made patch file to solve

Re: [LTP] Report - make error of ltp-full-20090531.tgz

2009-06-15 Thread Serge E. Hallyn
Quoting GeunSik Lim (leem...@gmail.com): I made patch file to solve below problem. well, NAK to the patch, but this is a real problem that needs to be fixed. I'll take a look in the morning, but Andrew do you know offhand what the problem is with capability.h (in F11 I gather) that would cause:

Re: [LTP] [PATCH] Synchronization between two processes

2009-05-25 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): Signed-off-by: Gui Xiaohua gu...@cn.fujitsu.com Serge, Your view on this new solution ? Oops, i forgot to officially note: Acked-by: Serge Hallyn se...@us.ibm.com thanks, -serge

Re: [LTP] [PATCH] Synchronization between two processes

2009-05-18 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Fri, 2009-05-15 at 08:45 -0500, Serge E. Hallyn wrote: Quoting Gui Xiaohua (gu...@cn.fujitsu.com): The child-process wait SIGUSR1 which would be sended by parent-process, if the child-process execute sigtimedwait() after parent

Re: [LTP] [PATCH] Synchronization between two processes

2009-05-15 Thread Serge E. Hallyn
Quoting Gui Xiaohua (gu...@cn.fujitsu.com): The child-process wait SIGUSR1 which would be sended by parent-process, if the child-process execute sigtimedwait() after parent-process send the signal, it would never receive the SIGUSR1 from parent-process. I cann't make sure the SIGUSR1 be

Re: [LTP] [PATCH] Update the ltp selinux testsuite README

2009-05-12 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Mon, 2009-05-11 at 09:06 -0400, Stephen Smalley wrote: On Mon, 2009-05-11 at 14:47 +0530, Subrata Modak wrote: Thanks. With this, i think all the patches sent by you has been merged. Please let me know if i had missed something.

Re: [LTP] [PATCH] Update the ltp selinux testsuite README

2009-05-12 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): On Tue, 2009-05-12 at 07:04 -0500, Serge E. Hallyn wrote: Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Mon, 2009-05-11 at 09:06 -0400, Stephen Smalley wrote: On Mon, 2009-05-11 at 14:47 +0530, Subrata Modak wrote: Thanks

Re: [LTP] [PATCH] Update the ltp selinux testsuite README

2009-05-12 Thread Serge E. Hallyn
Quoting Stephen Smalley (s...@tycho.nsa.gov): On Tue, 2009-05-12 at 07:04 -0500, Serge E. Hallyn wrote: Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Mon, 2009-05-11 at 09:06 -0400, Stephen Smalley wrote: On Mon, 2009-05-11 at 14:47 +0530, Subrata Modak wrote: Thanks

Re: [LTP] [PATCH] Fix selinux_capable_file.sh

2009-05-07 Thread Serge E. Hallyn
Hi Stephen, I'm trying to test all of your patches. But I'm having the (lately usual) static libs problem. tests/inherit/Makefile specifies that selinux_inherit_* should be compiled -static and -lselinux, but libselinux.a is not installed. What did you do about this - did you compile

Re: [LTP] [PATCH 1/1] add capability bounding set testcases

2009-04-28 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): On Wed, 2009-04-22 at 18:11 -0500, Serge E. Hallyn wrote: Add capability bounding set testcases, to verify the following: 1. prctl(CAP_BSET_READ, 0..NCAPS) returns 1 2. prctl(CAP_BSET_READ, -1|NCAPS+1) return -1

Re: [LTP] [PATCH] ima update openssl-devel existence test

2009-04-28 Thread Serge E. Hallyn
Quoting Mimi Zohar (zo...@linux.vnet.ibm.com): On Tue, 2009-04-28 at 18:04 -0500, Serge E. Hallyn wrote: Quoting Mimi Zohar (zo...@linux.vnet.ibm.com): Verify the existence of openssl/sha.h not libcrypto, which is included in multiple packages, to determine if openssl-devel

Re: [LTP] [PATCH] ima update openssl-devel existence test

2009-04-28 Thread Serge E. Hallyn
Quoting Mimi Zohar (zo...@linux.vnet.ibm.com): Verify the existence of openssl/sha.h not libcrypto, which is included in multiple packages, to determine if openssl-devel is installed. Signed-off-by: Mimi Zohar zo...@us.ibm.com Acked-by: Serge Hallyn se...@us.ibm.com This stops trying to

Re: [LTP] [PATCH] Fix running of the selinux tests

2009-04-27 Thread Serge E. Hallyn
Quoting Jiri Palecek (jirka@debian.POK.IBM.COM): Hello, while running the ltp selinux tests on Debian, I found some problems: 1) the testdomain attribute cannot have setcurrent permission to itself. This is because in Debian refpolicy, only domains with attribute set_curr_context can

[LTP] [PATCH 1/1] add capability bounding set testcases

2009-04-22 Thread Serge E. Hallyn
Add capability bounding set testcases, to verify the following: 1. prctl(CAP_BSET_READ, 0..NCAPS) returns 1 2. prctl(CAP_BSET_READ, -1|NCAPS+1) return -1 3. prctl(CAP_BSET_DROP, -1|NCAPS+1) returns -1 4. prctl(CAP_BSET_DROP, 0..NCAPS) returns 1 4b.

Re: [LTP] Fwd: [PATCH] Create $SELINUXTMPDIR in each of the tests

2009-04-20 Thread Serge E. Hallyn
Quoting Jiří Paleček (jpale...@web.de): On Mon, 20 Apr 2009 03:32:43 +0200, Serge E. Hallyn se...@us.ibm.com wrote: Quoting Subrata Modak (subr...@linux.vnet.ibm.com): Stephen, Would you like to say something about the following Patch ? If the motivation is to support multiple

[LTP] [RFC PATCH 1/1] add capability bounding set testcases

2009-04-20 Thread Serge E. Hallyn
Hi, I had intended to write the keepcaps and securebits testcases, but given that prctl(CAPBSET_READ) was broken for quite awhile in mainline, I figured I'd start there. I inted to write the remaining testcases soon. These are CERTAINLY NOT ready to be applied. I first need to write the

Re: [LTP] Fwd: [PATCH] Fix an errorneous using of a different return value in selinux_entrypoint test

2009-04-19 Thread Serge E. Hallyn
Quoting Subrata Modak (subr...@linux.vnet.ibm.com): Stephen ?? Heh, this isn't an selinux issue, just trivially correct. Acked-by: Serge Hallyn se...@us.ibm.com -serge Forwarded Message From: Jiri Palecek ji...@debian.pok.ibm.com Cc: ltp-list@lists.sourceforge.net

  1   2   3   >