Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-19 Thread Subrata Modak
On Mon, 2009-01-19 at 10:01 +0900, Seiichi Ikarashi wrote: Subrata Modak wrote: I am not feeling good (after being overwhelmed by the effort you have put in) to say that the patch is not applying fine. patching file testcases/kernel/containers/libclone/libclone.c patching file

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-18 Thread Seiichi Ikarashi
Subrata Modak wrote: I am not feeling good (after being overwhelmed by the effort you have put in) to say that the patch is not applying fine. patching file testcases/kernel/containers/libclone/libclone.c patching file testcases/kernel/containers/libclone/libclone.h patching file

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-16 Thread Subrata Modak
On Thu, 2009-01-15 at 21:25 -0600, Serge E. Hallyn wrote: Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Serge E. Hallyn wrote: Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Like this? Cool, thanks, and thanks for fixing up the do_clone_tests(). However, you pass

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-15 Thread Mike Frysinger
On Thursday 15 January 2009 02:17:27 Seiichi Ikarashi wrote: +#ifdef __ia64__ +   ret = clone2(fn1, childstack, getpagesize(), clone_flags, arg1, NULL, NULL, NULL); +#else +   ret = clone(fn1, childstack, clone_flags, arg1); +#endif look at the clone testcases under kernel syscalls

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-15 Thread Seiichi Ikarashi
Mike Frysinger さんは書きました: On Thursday 15 January 2009 02:17:27 Seiichi Ikarashi wrote: +#ifdef __ia64__ + ret = clone2(fn1, childstack, getpagesize(), clone_flags, arg1, NULL, NULL, NULL); +#else + ret = clone(fn1, childstack, clone_flags, arg1); +#endif look at the clone

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-15 Thread Mike Frysinger
On Thursday 15 January 2009 04:04:22 Seiichi Ikarashi wrote: Mike Frysinger さんは書きました: On Thursday 15 January 2009 02:17:27 Seiichi Ikarashi wrote: +#ifdef __ia64__ + ret = clone2(fn1, childstack, getpagesize(), clone_flags, arg1, NULL, NULL, NULL); +#else + ret = clone(fn1,

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-15 Thread Serge E. Hallyn
Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Mike Frysinger さんは書きました: On Thursday 15 January 2009 02:17:27 Seiichi Ikarashi wrote: +#ifdef __ia64__ + ret = clone2(fn1, childstack, getpagesize(), clone_flags, arg1, NULL, NULL, NULL); +#else + ret = clone(fn1,

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-15 Thread Seiichi Ikarashi
Serge E. Hallyn wrote: Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Like this? Cool, thanks, and thanks for fixing up the do_clone_tests(). However, you pass the bottom instead of the top of the stack to clone. See the use of 'childstack' in the original do_clone_tests(). I just

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-15 Thread Serge E. Hallyn
Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Serge E. Hallyn wrote: Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Like this? Cool, thanks, and thanks for fixing up the do_clone_tests(). However, you pass the bottom instead of the top of the stack to clone. See the

[LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Seiichi Ikarashi
Hi, I report ia64-specific build failures and a patch for them. Since ia64 glibc does not have the clone() function call, building testcases/kernel/containers/pidns/pidns12.c fails as follows. $ make : make[4]: Entering directory

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Mike Frysinger
On Wednesday 14 January 2009 03:27:51 Seiichi Ikarashi wrote: Since ia64 glibc does not have the clone() function call, building testcases/kernel/containers/pidns/pidns12.c fails as follows. this clone garbage is out of hand. we need to unify it in the toplevel includes already. your patch

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Serge E. Hallyn
Quoting Mike Frysinger (vap...@gentoo.org): On Wednesday 14 January 2009 03:27:51 Seiichi Ikarashi wrote: Since ia64 glibc does not have the clone() function call, building testcases/kernel/containers/pidns/pidns12.c fails as follows. this clone garbage is out of hand. we need to unify it

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Seiichi Ikarashi
Serge E. Hallyn wrote: Quoting Mike Frysinger (vap...@gentoo.org): On Wednesday 14 January 2009 03:27:51 Seiichi Ikarashi wrote: Since ia64 glibc does not have the clone() function call, building testcases/kernel/containers/pidns/pidns12.c fails as follows. this clone garbage is out of hand.

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Mike Frysinger
On Wednesday 14 January 2009 21:55:53 Seiichi Ikarashi wrote: Serge E. Hallyn wrote: Quoting Mike Frysinger (vap...@gentoo.org): On Wednesday 14 January 2009 03:27:51 Seiichi Ikarashi wrote: Since ia64 glibc does not have the clone() function call, building

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Serge E. Hallyn
Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Serge E. Hallyn wrote: Quoting Mike Frysinger (vap...@gentoo.org): On Wednesday 14 January 2009 03:27:51 Seiichi Ikarashi wrote: Since ia64 glibc does not have the clone() function call, building

Re: [LTP] [PATCH] Fix build failures of pidns on ia64 arch

2009-01-14 Thread Seiichi Ikarashi
Serge E. Hallyn wrote: Quoting Seiichi Ikarashi (s.ikara...@jp.fujitsu.com): Serge E. Hallyn wrote: Quoting Mike Frysinger (vap...@gentoo.org): On Wednesday 14 January 2009 03:27:51 Seiichi Ikarashi wrote: Since ia64 glibc does not have the clone() function call, building