Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan This still has the problem of needing to build po/POTFILES.in
Allan from a dist rather than from a CVS tree -- and this should
Allan preferably be automated or at least automatable so that
Allan Kayvan's autogenerated rpms can still be built.
On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan This still has the problem of needing to build po/POTFILES.in
Allan from a dist rather than from a CVS tree -- and this should
Allan preferably be automated or at least automatable so that
Allan
This moves almost everything math related from BufferView_pimpl to mathed
and introduces a new LyXfunc 'math-import-selection' for later use.
This also removes the #include dependencies of BufferView_pimpl.C from
files in src/mathed. I had to make open_new_inset publicly accessible
for this to
On Thu, 5 Jul 2001, Eran Tromer wrote:
[snip]
Let me try to explain the more strategic parts of the LyX development
effort at this moment:
[snip]
Thanks for the explanations! This really cleared things up for me,
especially about what you were all up to in Italy... Now where's LDN
when
On 04-Jul-2001 Andre Poenitz wrote:
If BufferViewPimpl::open_new_inset were publicly available in
BufferView, I could move all the MATH_* action handling from
BufferView_pimpl.C to mathed/formula.C
I think this would benefit encapsulation...
Why do you need that? I have insets in insets
On 05-Jul-2001 Andre Poenitz wrote:
This also removes the #include dependencies of BufferView_pimpl.C from
files in src/mathed. I had to make open_new_inset publicly accessible
for this to work, but I consider this a small price.
As I told you in my earlier mail this is the wrong way to
On 04-Jul-2001 Andre Poenitz wrote:
If BufferViewPimpl::open_new_inset were publicly available in
BufferView, I could move all the MATH_* action handling from
BufferView_pimpl.C to mathed/formula.C
I think this would benefit encapsulation...
Why do you need that?
Why do you need that? I have insets in insets without the need to use
that function. Did you have a look at the functions InsetInsertAllowed
and insertInset()?
open_new_inset uses insertInset.
Would you be satified if I simply duplicated the code?
Andre'
--
André Pönitz
Ok. I duplicated open_new_inset. Buffer*.h is _not_ touched anymore.
I think it is stupid. And it is even more stupid to waste time in such
effort...
Andre'
--
André Pönitz . [EMAIL PROTECTED]
Index: BufferView_pimpl.C
On 05-Jul-2001 Andre Poenitz wrote:
open_new_inset uses insertInset.
Would you be satified if I simply duplicated the code?
Well I had a look at your patch and I really think you should just let it
there! This is only the creation of the outermost Inset and all this stuff
is there, or
On 05-Jul-2001 Andre Poenitz wrote:
Ok. I duplicated open_new_inset. Buffer*.h is _not_ touched anymore.
I think it is stupid. And it is even more stupid to waste time in such
effort...
Well if you just waited a moment for my reply you probably would have
not wasted time ;) Come on I'm not
Would you be satified if I simply duplicated the code?
Well I had a look at your patch and I really think you should just let it
there!
This sounds suspiciously like admitting that you criticized the patch
before reading it.
Maybe I am overreacting a bit currently...
This is only the
On 04-Jul-2001 Eran Tromer wrote:
Addenum:
Attached is a further simplified case that still exhibits the crash (but
not the rendering problem). The 3x3 table is now empty, but deleting its
first row causes a crash.
Yes and this is thanks to Lars LyXAssert() in getLyXText() which made me
On 05-Jul-2001 Andre Poenitz wrote:
This sounds suspiciously like admitting that you criticized the patch
before reading it.
I did yes :)
Putting everything in the big switch _and doing part of the work there_
is stupid. I don't want mathed to participate in such stupidities...
bla, bla,
Hi,
Todays (July 5th) CVS complains about missing config/ltconfig:
$ ./autogen.sh
Locating GNU m4... found: m4
Generate acinclude.m4... done.
Building macros...
.
lib/reLyX
sigc++
done.
Building config header template...
.
sigc++
done.
Building Makefile
On 05-Jul-2001 Allan Rae wrote:
http://www.devel.lyx.org/~rae/www-user/?traditional=1
Looks good to me ;)
http://www.devel.lyx.org/~rae/www-user/browser.php3
Mozilla/5.0 (compatible; Konqueror/2.1.2; X11)
Jürgen
--
On Tue, Jul 03, 2001 at 07:15:34PM +0200, Andre Poenitz wrote:
//*- If I mark some text, e.g. abc, and then press M-m s (square root), then
// the marked text is deleted, and an empty root appears.
// The old behavior was to create \sqrt{abc}.
//The same happens with \frac
The
Well what you're hiding is the creation of an inset and inserting it in
BufferViews LyXText, I don't think this is really mathed stuff, is it?
Since it needs to call the inset's constructors (and do things like don't
start with numbered displayed formalae) it certainly is.
Then you probably
I just discovered that when loading a file containing a tabular and inserting
stuff inside this tabular, the undo is working great, but when I'm opening
LyX and create a New File and then starting to type inside the tabular then
as soon as I get the message:
Actcell not equal to actual cell!
Perhaps a compromise: logo but in the new (approx) website's color...
LyXBannerjugbg3.gif
On 05-Jul-2001 Andre Poenitz wrote:
Sure. But I'd rather call it
struct MathInitializer()
{
MathInitializer() {
big_lyxfunc_switch-register(LFUN_MATH_INSERT, my_math_insert);
big_lyxfunc_switch-register(LFUN_MATH_DISPLAY, my_math_display);
...
}
};
Sure and as soon as we can register lyx-funcs to the Dispatcher (or
LyXAction then we all will do as you, but in the time being we should
wait until Lars has the time to do it and concentrate on fixing stuff
instead of inserting lot's and lot's of new stuff or shuffle stuff around
which is
Am Donnerstag, 5. Juli 2001 10:16 schrieb Allan Rae:
I'll fix up the cookie business after dinner... probably call it
lographics or something unless I get a better suggestion.
Why not call it: last century edition ;-)
Jürgen
On Thu, 5 Jul 2001, Jürgen Spitzmüller wrote:
Am Donnerstag, 5. Juli 2001 10:16 schrieb Allan Rae:
I'll fix up the cookie business after dinner... probably call it
lographics or something unless I get a better suggestion.
Why not call it: last century edition ;-)
I figured slow would be
Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan Lars, Juergen, JMarc, Kathryn and whoever else, is this
Allan satisfactory?
And could we have the same in blue? :p (actually I tried to see
whether imagemagick is able to perform this kind of trick, but I did
not find the right function).
Andre Poenitz [EMAIL PROTECTED] writes:
| but I must admit that I have confused clipbuffer and selection a bit.
|
| If you tell me how to access the (external) X selection properly
| you can have 'math-import-externalselection' in a few minutes...
WorkArea has a
string const getClipboard()
Andre Poenitz [EMAIL PROTECTED] writes:
| Putting everything in the big switch _and doing part of the work there_
| is stupid. I don't want mathed to participate in such stupidities...
Use the main switch for now, all this will change for _all_ dispatch
methods later not just for mathed.
|
Andre Poenitz [EMAIL PROTECTED] writes:
| Well what you're hiding is the creation of an inset and inserting it in
| BufferViews LyXText, I don't think this is really mathed stuff, is it?
|
| Since it needs to call the inset's constructors (and do things like don't
| start with numbered
On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
I fixed such a problem recently which was due to the fat that
GetCellInset(int, int) did not update cur_cell. You probably have this
fix in, I guess? [BTW, there is also a nice comment for you in this method]
Well I run update every time I see some
Juergen == Juergen Vigna [EMAIL PROTECTED] writes:
What about puting a break on the line where this debug message is
issued and then looking at the backtrace? Or just send the
backtrace to the list.
Juergen No this has to be somewhere else! This cur_cell stuff only
Juergen works if we are
Mathed should _now_ play with what is present. Mathed should not
impose any huge changes to the the rest of LyX at _this_ stage.
Have you looked at the BufferView_pimpl.C change in mathed93.diff?
I am moving the 50 LFUN_MATH* lines from the big switch into mathed.
I have removed two
On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
cur_cel is set everytime we get the pointer to the inset via
GetCellInset. It does not have to be the act_cell. Obviously, there
are some ways to get that inset that we forgot to check...
What I meant was that the message there is stupid, it's
Allan Rae [EMAIL PROTECTED] writes:
| On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
|
| Allan == Allan Rae [EMAIL PROTECTED] writes:
|
| Allan This still has the problem of needing to build po/POTFILES.in
| Allan from a dist rather than from a CVS tree -- and this should
| Allan preferably
So, what do the others who desperately wanted to keep the old look think
of this new old-look plan of JMarcs? (Lars, Juergen, Kathryn)
There at least two more of them. One of these thinks JMarc is either
drunk or should get a drink, the other one doesn't know the proposal yet
;-)
Andre'
--
Andre Poenitz [EMAIL PROTECTED] writes:
| Mathed should _now_ play with what is present. Mathed should not
| impose any huge changes to the the rest of LyX at _this_ stage.
|
| Have you looked at the BufferView_pimpl.C change in mathed93.diff?
|
|
| I am moving the 50 LFUN_MATH* lines from
Juergen == Juergen Vigna [EMAIL PROTECTED] writes:
Juergen On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
cur_cel is set everytime we get the pointer to the inset via
GetCellInset. It does not have to be the act_cell. Obviously, there
are some ways to get that inset that we forgot to check...
On Thu, 5 Jul 2001, Andre Poenitz wrote:
So, what do the others who desperately wanted to keep the old look think
of this new old-look plan of JMarcs? (Lars, Juergen, Kathryn)
There at least two more of them. One of these thinks JMarc is either
drunk or should get a drink
[...]
Well at
On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
What about a backtrace so that we can check by ourselves?
I found the problem and as I told you it wasn't where you could see it
with a backtrace. I had to step-debug the whole process until I got where
I wanted. The problem was the the
Juergen == Juergen Vigna [EMAIL PROTECTED] writes:
Juergen On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
What about a backtrace so that we can check by ourselves?
Juergen I found the problem and as I told you it wasn't where you
Juergen could see it with a backtrace.
So you do not have the
On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
Juergen I found the problem and as I told you it wasn't where you
Juergen could see it with a backtrace.
So you do not have the debug messages anymore?
Nope!
Jürgen
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
As already told I fixed the showstopper and now this new Undo should work
properly! Please test it an let me know!
Jürgen
--
-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._-._
Dr. Jürgen VignaE-Mail: [EMAIL PROTECTED]
Italienallee 13/N Tel/Fax:
Andre == Andre Poenitz [EMAIL PROTECTED] writes:
So, what do the others who desperately wanted to keep the old look
think of this new old-look plan of JMarcs? (Lars, Juergen, Kathryn)
Andre There at least two more of them. One of these thinks JMarc is
Andre either drunk or should get a
On 5 Jul 2001, Lars Gullik Bjønnes wrote:
Allan Rae [EMAIL PROTECTED] writes:
| On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
|
| Allan == Allan Rae [EMAIL PROTECTED] writes:
|
| Allan This still has the problem of needing to build po/POTFILES.in
| Allan from a dist rather than from a
On Thu, 5 Jul 2001, Juergen Vigna wrote:
On 05-Jul-2001 Allan Rae wrote:
So, what do the others who desperately wanted to keep the old look think
of this new old-look plan of JMarcs? (Lars, Juergen, Kathryn)
Well what we really complained about was the background graphics. If it
is
Compilation of math_parser.C with DEC cxx fails
cxx: Error: math_parser.C, line 189: #304 no instance of overloaded function
std::basic_istreamcharT, traits::get [with charT=char,
traits=std::char_traitschar] matches the argument list
argument types are: (unsigned
Allan == Allan Rae [EMAIL PROTECTED] writes:
There at least two more of them. One of these thinks JMarc is
either drunk or should get a drink
Allan [...]
Allan Well at least I'm not alone.
Tssk, tssk.
BTW Allan, the cvsweb pages on www.lyx.org are broken now :)
JMarc
slow, bgimage, old, ugly, unreadable, green, traditional,
higraphics, bwhog, why, enriched, rich, prehistoric, 1994,
classic, retro
green would be fairly neutral and avoid switching to blue somehow ;-)
Andre', helpful.
--
André Pönitz
Juergen Vigna [EMAIL PROTECTED] writes:
| On 05-Jul-2001 Jean-Marc Lasgouttes wrote:
|
| What about a backtrace so that we can check by ourselves?
|
| I found the problem and as I told you it wasn't where you could see it
| with a backtrace. I had to step-debug the whole process until I got
On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
BTW Allan, the cvsweb pages on www.lyx.org are broken now :)
I don't see anything broken what are you referring to?
Allan. (ARRae)
Dear André.
attached is a small patch to enable me to compile mathed. I also attach the
stripped down make log containing all the info/warning messages produced by
DEC cxx.
Hope this is of some use.
Angus
patch.diff.gz
make.log.gz
On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
BTW Allan, the cvsweb pages on www.lyx.org are broken now :)
If you are referring to the css-validator blame w3.org as they have just
upgraded their pages to support English, German and a couple of other
languages for error messages and have broken
On Mon, 25 Jun 2001, Zvezdan Petkovic wrote:
I'm not picky about this. The only important thing is that author's name
is enclosed in p/p so that font looks right in Netscape 4.x.
And I agree that these look really lost on the right side. What about:
p.quote-author {
text-align: right;
Juergen Vigna [EMAIL PROTECTED] writes:
| As already told I fixed the showstopper and now this new Undo should work
| properly! Please test it an let me know!
@@ -52,6 +52,8 @@ LyXText::LyXText(BufferView * bv)
{
bv_owner = bv;
inset_owner = 0;
+#warning We should activate the
Juergen Vigna [EMAIL PROTECTED] writes:
| As already told I fixed the showstopper and now this new Undo should work
| properly! Please test it an let me know!
protected:
+ ///
+ unsigned int id_;
+ ///
+ static unsigned int inset_id;
why can't these be private?
Juergen Vigna [EMAIL PROTECTED] writes:
| As already told I fixed the showstopper and now this new Undo should work
| properly! Please test it an let me know!
@@ -155,13 +158,13 @@ void InsetText::clear()
delete par;
par = tmp;
}
- par = new
Michel == Michel Castagner [EMAIL PROTECTED] writes:
Michel bwith the version .1.8 the item View dvi View PostScript
Michel Update DVI Update Postscript
Michel of the menu file disaspers
They are now in the View menu.
JMarc
Juergen Vigna [EMAIL PROTECTED] writes:
| As already told I fixed the showstopper and now this new Undo should work
| properly! Please test it an let me know!
@@ -54,8 +54,9 @@ void InsetTheorem::write(Buffer const *
}
-Inset * InsetTheorem::clone(Buffer const ) const
+Inset *
Last shot.
Seperate mathed functions for every LFUN_MATH*.
No change to BufferView*.*
A few bugs killed including those reported this morning by Dekel.
Andre'
--
André Pönitz . [EMAIL PROTECTED]
? out
? diff
? backup
? .BufferView_pimpl.C.swp
?
Allan Rae [EMAIL PROTECTED] writes:
| I wish you'd make your minds up what you want -- could have saved me a
| days screwing around.
Or listen better the first time...
--
Lgb
Allan Rae [EMAIL PROTECTED] writes:
| forøvrig mener jeg at POTFILES.in bør genereres manuelt
|
| How will generating POTFILES.in manually fix anything? (Kiss goodbye to
| Kayvan's automatic builds if you do)
because we then will only put those files indendet for a dist into the
POTFILES.in.
The relevant code is:
Ok. I know what's wrong there.
So it looks like the correct fix is to have:
{
while (yyis-good()) {
char c;
yyis-get(c);
...
}
}
Is this correct?
No. c is used directly as an index in the lexcode[] array.
Angus == Angus Leeming [EMAIL PROTECTED] writes:
Angus Compilation of math_parser.C with DEC cxx fails cxx: Error:
Angus math_parser.C, line 189: #304 no instance of overloaded
Angus function std::basic_istreamcharT, traits::get [with
Angus charT=char, traits=std::char_traitschar] matches the
Andre == Andre Poenitz [EMAIL PROTECTED] writes:
Posting a copy of my new feature request #438563 for discussion:
Andre I know that there is somewhere some bugtrack thingy concerning
Andre LyX somewhere on the web... Am I suposed to know more about it?
It is at
Juergen Vigna [EMAIL PROTECTED] writes:
| Good! It's good to have members in the crew who know actually what
| they are doing with STL consturcts ;) Change it to whatever you like
| more I'll complain only if it doesn't work properly, promised! :)
Ok, here is the patch:
? build
? ny
Index:
On 05-Jul-2001 Lars Gullik Bjønnes wrote:
Can you send the id_ fix as a separate patch?
Well Lars you have just to look for paragraph_pimpl inside the patch there
should not be much changed other than that.
Anyway I can commit this change also directly to cvs as it only adds a
id_ =
On 05-Jul-2001 Lars Gullik Bjønnes wrote:
Ok, here is the patch:
Well I probably don't know exactly how all this works but it seems to
me that if you have
boost:pointer a = new s;
boost:pointer b = a;
delete a;
delete b;
you release the new s 2 times isn't it? IMO chached_text doesn't
Alejandro == Alejandro Aguilar Sierra [EMAIL PROTECTED] writes:
Alejandro Hi, Now the mexican mirror is a true mirror (using rsync
Alejandro every night) with an updated apache/php server. In fact I
Alejandro have to install my favorite linux distribution, Debian, in
Alejandro this old Sparc10,
Jose == Jose Abilio Oliveira Matos [EMAIL PROTECTED] writes:
Jose Regarding \makeatleatletter and \makeatother where are they
Jose used and why?
They are used in case the user preamble contains macros with @ in
their name. These macros are internal macros, which are not supposed
to be used
attached is a small patch to enable me to compile mathed. I also attach the
stripped down make log containing all the info/warning messages produced by
DEC cxx.
As I said this breaks reading 8 Bit ASCII on systems where char is signed
since 'c' is used to access the lexcode[]
Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
BTW Allan, the cvsweb pages on www.lyx.org are broken now :)
Allan I don't see anything broken what are you referring to?
On the page
http://www.lyx.org/cgi-bin/cvsweb.cgi/
There is no image an
Sorry to be a grammar pedant, especially since I know that english isn't
necessarily the first language of many people around here, but the last
item on the Navigation Bar on the home page should really read
Fewer graphics (or maybe Low graphics) rather than Less graphics.
Oh, and it isn't
On 05-Jul-2001 Lars Gullik Bjønnes wrote:
Juergen Vigna [EMAIL PROTECTED] writes:
| As already told I fixed the showstopper and now this new Undo should work
| properly! Please test it an let me know!
@@ -52,6 +52,8 @@ LyXText::LyXText(BufferView * bv)
{
bv_owner = bv;
On 05-Jul-2001 Lars Gullik Bjønnes wrote:
protected:
+ ///
+ unsigned int id_;
+ ///
+ static unsigned int inset_id;
So I can access them directly in all insets without the need to go over the
function. I think that's the correct way to access the data I
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
Lars InsetText::InsetText() { - par = new Paragraph; + par = new
Lars Paragraph(); init(); }
Lars this change is a bug, it should be par = new Paragraph;
Could you recall us what the differences between the two versions are?
JMarc
On 05-Jul-2001 Lars Gullik Bjønnes wrote:
- par = new Paragraph;
+ par = new Paragraph();
init();
}
this change is a bug, it should be par = new Paragraph;
Yes I forgot to remove it, but if you get stuff going wrong you just
try everything (constructor of
On Thu, Jul 05, 2001 at 11:31:31AM +0300, Dekel Tsur wrote:
- Decorations are broken:
All over* decorations are not drawn at all.
An underline is drawn incorrectly: When there is \underline{x},
the line is drawn outside of the inset frame.
I saw that you fixed these.
Furthermore, when
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
| Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
|
| Lars InsetText::InsetText() { - par = new Paragraph; + par = new
| Lars Paragraph(); init(); }
|
| Lars this change is a bug, it should be par = new Paragraph;
|
| Could you recall us
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes:
| Allan == Allan Rae [EMAIL PROTECTED] writes:
|
| Allan On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
| BTW Allan, the cvsweb pages on www.lyx.org are broken now :)
|
| Allan I don't see anything broken what are you referring to?
|
| On the page
I moved a lyx file to the directory containing the graphics it
referenced in figure floats, edited the graphics pop-up to reflect the
change. Lyx did not indictate that the file had been changed.
Garst
Hi,
The File-menu entry gets very long when the list of Lastfiles is added at the end.
I suggest to add a new entry Open previous which contains the Lastfiles as a
submenu:
File:
New...
New from template...
Open...
Open previous - Lastfiles
---
etc
---
Exit
A gzipped patch to
On Thu, 5 Jul 2001, yan wong wrote:
Sorry to be a grammar pedant, especially since I know that english isn't
necessarily the first language of many people around here, but the last
item on the Navigation Bar on the home page should really read
Fewer graphics (or maybe Low graphics) rather
On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan The same what? You want a blue banner background as well? Or
Allan are you referring to doing something to the new improved look?
I mean have a web site which looks a bit like the new one, but
On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan Lars, Juergen, JMarc, Kathryn and whoever else, is this
Allan satisfactory?
And could we have the same in blue? :p (actually I tried to see
whether imagemagick is able to perform this kind of
Allan == Allan Rae [EMAIL PROTECTED] writes:
Allan The same what? You want a blue banner background as well? Or
Allan are you referring to doing something to the new improved look?
I mean have a web site which looks a bit like the new one, but with
the background image. The image that Edwin
goto:
http://www.devel.lyx.org/~rae/www-user/?traditional=1
be aware that the ?traditional variable is not cookied yet so if you
switch pages or navbar styles you'll have to reenter it.
I think I now have a traditional look that should be identical to old
except that we never used to
Dear Allan,
1. It is impossible to make everyone happy
2. Keeping on changing the 'look' of the page is like someone dying his/her
color everyweek or so... Doesn't look give good impression, does it? ;-)
R
- Original Message -
From: Allan Rae [EMAIL PROTECTED]
To: LyX Developers [EMAIL
I hope you don't mind seeing user feedback on lyx-devel, but I don't
know to what extend posts on lyx-user are seen by developers. So, here
we go:
After finshing a thesis written with Lyx, I feel the urge to give some
feedback and offer some ideas based on my experiences with using Lyx
for a
> "Allan" == Allan Rae <[EMAIL PROTECTED]> writes:
Allan> This still has the problem of needing to build po/POTFILES.in
Allan> from a dist rather than from a CVS tree -- and this should
Allan> preferably be automated or at least automatable so that
Allan> Kayvan's autogenerated rpms can
On 5 Jul 2001, Jean-Marc Lasgouttes wrote:
> > "Allan" == Allan Rae <[EMAIL PROTECTED]> writes:
>
> Allan> This still has the problem of needing to build po/POTFILES.in
> Allan> from a dist rather than from a CVS tree -- and this should
> Allan> preferably be automated or at least
This moves almost everything math related from BufferView_pimpl to mathed
and introduces a new LyXfunc 'math-import-selection' for later use.
This also removes the #include dependencies of BufferView_pimpl.C from
files in src/mathed. I had to make open_new_inset publicly accessible
for this to
On Thu, 5 Jul 2001, Eran Tromer wrote:
> [snip]
> > Let me try to explain the more strategic parts of the LyX development
> > effort at this moment:
> [snip]
>
> Thanks for the explanations! This really cleared things up for me,
> especially about what you were all up to in Italy... Now where's
On 04-Jul-2001 Andre Poenitz wrote:
>
> If BufferViewPimpl::open_new_inset were publicly available in
> BufferView, I could move all the MATH_* action handling from
> BufferView_pimpl.C to mathed/formula.C
>
> I think this would benefit encapsulation...
Why do you need that? I have insets in
On 05-Jul-2001 Andre Poenitz wrote:
> This also removes the #include dependencies of BufferView_pimpl.C from
> files in src/mathed. I had to make open_new_inset publicly accessible
> for this to work, but I consider this a small price.
As I told you in my earlier mail this is the wrong way
> On 04-Jul-2001 Andre Poenitz wrote:
> >
> > If BufferViewPimpl::open_new_inset were publicly available in
> > BufferView, I could move all the MATH_* action handling from
> > BufferView_pimpl.C to mathed/formula.C
> >
> > I think this would benefit encapsulation...
>
> Why do you need that?
> Why do you need that? I have insets in insets without the need to use
> that function. Did you have a look at the functions InsetInsertAllowed
> and insertInset()?
open_new_inset uses insertInset.
Would you be satified if I simply duplicated the code?
Andre'
--
André Pönitz
Ok. I duplicated open_new_inset. Buffer*.h is _not_ touched anymore.
I think it is stupid. And it is even more stupid to waste time in such
effort...
Andre'
--
André Pönitz . [EMAIL PROTECTED]
Index: BufferView_pimpl.C
On 05-Jul-2001 Andre Poenitz wrote:
> open_new_inset uses insertInset.
>
> Would you be satified if I simply duplicated the code?
Well I had a look at your patch and I really think you should just let it
there! This is only the creation of the outermost Inset and all this stuff
is there, or
On 05-Jul-2001 Andre Poenitz wrote:
> Ok. I duplicated open_new_inset. Buffer*.h is _not_ touched anymore.
> I think it is stupid. And it is even more stupid to waste time in such
> effort...
Well if you just waited a moment for my reply you probably would have
not wasted time ;) Come on I'm
> > Would you be satified if I simply duplicated the code?
>
> Well I had a look at your patch and I really think you should just let it
> there!
This sounds suspiciously like admitting that you criticized the patch
before reading it.
Maybe I am overreacting a bit currently...
> This is only
On 04-Jul-2001 Eran Tromer wrote:
> Addenum:
>
> Attached is a further simplified case that still exhibits the crash (but
> not the rendering problem). The 3x3 table is now empty, but deleting its
> first row causes a crash.
Yes and this is thanks to Lars LyXAssert() in getLyXText() which made
1 - 100 of 174 matches
Mail list logo
