Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 08:43 schrieb Jürgen Spitzmüller: switt wrote: + string h_path = addName(hpath, lang-code() + - + lang-variety()); + // first we try lang code+variety + if (!lang-variety().empty() haveLanguageFiles(h_path)) { + hpath = h_path; +

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: Should I revert the id() part of my last change then? No. What I mean is: doesn't somethong like the attached, simpler solution work equally well? Jürgen Index: src/HunspellChecker.cpp === ---

Re: Find replace in 2.0

Jürgen Spitzmüller sp...@lyx.org wrote in message news:201102180855.11402.sp...@lyx.org... -1. I think this simple and fast search method is still of much use besides the big, blown advanced dialog. Currently the dialogs are exactly the same except for the possibility to type non-plain text

Re: Icons

Jürgen Spitzmüller sp...@lyx.org wrote in message news:201102180850.11166.sp...@lyx.org... +1 for Oxygen. It's a very well-designed, large and clean icon set. As a bonus, Lyx would integrate even better into KDE. Where do I find the latest Oxygen set which contains the icons you're using

Re: Find replace in 2.0

Joost Verburg wrote: Currently the dialogs are exactly the same except for the possibility to type non-plain text in the advanced one. But the Advanced dialog takes up a lot of screen space. This is not always desirable. Perhaps it'd be good to make the Quick search a bit more simple then?

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 10:33 schrieb Jürgen Spitzmüller: Stephan Witt wrote: Should I revert the id() part of my last change then? No. What I mean is: doesn't somethong like the attached, simpler solution work equally well? Yes, but then IMHO we should rename Language::id() to

Re: Icons

Joost Verburg wrote: Where do I find the latest Oxygen set which contains the icons you're using here? The icons I use are not the latest, I have done this some years back. Note that some (the update PDF/master) are badly self-designed icons, since I did not find anythink appropriate back

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: Yes, but then IMHO we should rename Language::id() to Language::hunspellID()... But Aspell uses this id() as well, doesn't it? Jürgen

Re: Find replace in 2.0

I like the idea to make it a Firefox-like bar (which could still also include replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff. I have one and I will commit when 2.(0.)1 svn is open. Unless people are urging to get it in 2.0. Developing new features is just not very

Re: Find replace in 2.0

Vincent van Ravesteijn wrote: Developing new features is just not very successful if you try to fix a lot of bugs as well at the same time. bugfixing might be not as sexy, but you're the tacit hero, of course. Jürgen

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 10:55 schrieb Jürgen Spitzmüller: Stephan Witt wrote: Yes, but then IMHO we should rename Language::id() to Language::hunspellID()... But Aspell uses this id() as well, doesn't it? I meant to do it like the attached patch. Stephan Index: src/Language.h

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: I meant to do it like the attached patch. I don't like the idea of putting speller-specific code to Language. Using lang() as a unique identifier is probably a good idea, though. Jürgen

Re: r37716 - lyx-devel/trunk/src

Jürgen Spitzmüller wrote: I meant to do it like the attached patch. I don't like the idea of putting speller-specific code to Language. Using lang() as a unique identifier is probably a good idea, though. IOW I'd move the hunspellID code to HunspellChecker. And still, my proposed

Re: r37716 - lyx-devel/trunk/src

Jürgen Spitzmüller wrote: IOW I'd move the hunspellID code to HunspellChecker. And rename it to something more appropriate (such as HunspellDictionaryName). Sorry for the follow-ups, I'm slow today. Jürgen

Re: Icons

Stephan Witt wrote: What about the hopping train image? its on plan.pavel

Re: Icons

Jürgen Spitzmüller wrote: Joost Verburg wrote: What about this to start with (see screenshot)? These are too fanciful/colourish for my taste. i was just about to write they look better because are more colorful :) but i'll probably end up with my own set here, so no hard opinion... pavel

Re: Find replace in 2.0

Vincent van Ravesteijn wrote: I like the idea to make it a Firefox-like bar (which could still also include replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff. I have one and I will commit when 2.(0.)1 svn is open. Unless people are urging to get it in 2.0. please

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 11:34 schrieb Jürgen Spitzmüller: Jürgen Spitzmüller wrote: I meant to do it like the attached patch. I don't like the idea of putting speller-specific code to Language. Using lang() as a unique identifier is probably a good idea, though. IOW I'd move the hunspellID

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: IOW I'd move the hunspellID code to HunspellChecker. Ok. And leave the id() method in Language? It is not used currentyl, so it should be ditched. And still, my proposed simplification would apply. Then there would only one lookup per language. German = de_DE

Re: Icons

Jürgen Spitzmüller sp...@lyx.org wrote in message news:201102181054.36078.sp...@lyx.org... The icons I use are not the latest, I have done this some years back. Note that some (the update PDF/master) are badly self-designed icons, since I did not find anythink appropriate back then. We should

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 12:12 schrieb Jürgen Spitzmüller: Stephan Witt wrote: IOW I'd move the hunspellID code to HunspellChecker. Ok. And leave the id() method in Language? It is not used currentyl, so it should be ditched. And still, my proposed simplification would apply. Then there

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: Then we have this updated patch. Ok? Looks good to me. Thanks! Jürgen

Re: Icons

Jürgen Spitzmüller sp...@lyx.org wrote in message news:201102181239.57022.sp...@lyx.org... Yes. I hacked some together myself. See attachment. They are certainly not masterpieces, I mainly took some elements from existing icons, if possible, to have something halfway matching. Thanks. Do you

Re: Icons

Joost Verburg wrote: Thanks. Do you also have the 22x22 png versions? Yep. Just sent to you privately. Jürgen

Re: Icons

Joost Verburg wrote: Jürgen Spitzmüller sp...@lyx.org wrote in message news:201102181239.57022.sp...@lyx.org... Yes. I hacked some together myself. See attachment. They are certainly not masterpieces, I mainly took some elements from existing icons, if possible, to have something halfway

Foreign language marker

Can we please make the line that marks foerign languages thinner again (preferably as in branch)? This thick rule annoys me a lot. Jürgen

Re: Find replace in 2.0

Il 18/02/2011 00:48, Pavel Sanda ha scritto: Pavel Sanda wrote: You're right, I was confused myself now by the UI. These texts on the tabs (Basic and Advanced) don't make sense to me. Shouldn't that be renamed to Search and Settings or something similar? yes, looks more correct to me.

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. I had a fix for that (easy enough) and when I tried it... my file did not compile. Naively, I though that

Re: Foreign language marker

Am 18.02.2011 um 16:25 schrieb Jürgen Spitzmüller: Can we please make the line that marks foerign languages thinner again (preferably as in branch)? This thick rule annoys me a lot. I'll try to change that. Stephan

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 08:43 schrieb Jürgen Spitzmüller: > switt wrote: >> + string h_path = addName(hpath, lang->code() + "-" + >> lang->variety()); + // first we try lang code+variety >> + if (!lang->variety().empty() && haveLanguageFiles(h_path)) { >> + hpath =

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: > Should I revert the id() part of my last change then? No. What I mean is: doesn't somethong like the attached, simpler solution work equally well? Jürgen Index: src/HunspellChecker.cpp === ---

Re: Find & replace in 2.0

"Jürgen Spitzmüller" wrote in message news:201102180855.11402.sp...@lyx.org... -1. I think this simple and fast search method is still of much use besides the big, blown advanced dialog. Currently the dialogs are exactly the same except for the possibility to type non-plain

Re: Icons

"Jürgen Spitzmüller" wrote in message news:201102180850.11166.sp...@lyx.org... +1 for Oxygen. It's a very well-designed, large and clean icon set. As a bonus, Lyx would integrate even better into KDE. Where do I find the latest Oxygen set which contains the icons you're using

Re: Find & replace in 2.0

Joost Verburg wrote: > Currently the dialogs are exactly the same except for the possibility to > type non-plain text in the advanced one. But the Advanced dialog takes up a lot of screen space. This is not always desirable. > Perhaps it'd be good to make the "Quick" search a bit more simple

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 10:33 schrieb Jürgen Spitzmüller: > Stephan Witt wrote: >> Should I revert the id() part of my last change then? > > No. What I mean is: doesn't somethong like the attached, simpler solution > work > equally well? Yes, but then IMHO we should rename Language::id() to

Re: Icons

Joost Verburg wrote: > Where do I find the latest Oxygen set which contains the icons you're > using here? The icons I use are not the latest, I have done this some years back. Note that some (the update PDF/master) are badly self-designed icons, since I did not find anythink appropriate back

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: > Yes, but then IMHO we should rename Language::id() to > Language::hunspellID()... But Aspell uses this id() as well, doesn't it? Jürgen

Re: Find & replace in 2.0

> I like the idea to make it a Firefox-like bar (which could still also include > replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff. I have one and I will commit when 2.(0.)1 svn is open. Unless people are urging to get it in 2.0. Developing new features is just not very

Re: Find & replace in 2.0

Vincent van Ravesteijn wrote: > Developing new features is just not very successful if you try to fix > a lot of bugs as well at the same time. bugfixing might be not as sexy, but you're the tacit hero, of course. Jürgen

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 10:55 schrieb Jürgen Spitzmüller: > Stephan Witt wrote: >> Yes, but then IMHO we should rename Language::id() to >> Language::hunspellID()... > > But Aspell uses this id() as well, doesn't it? I meant to do it like the attached patch. Stephan Index: src/Language.h

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: > I meant to do it like the attached patch. I don't like the idea of putting speller-specific code to Language. Using lang() as a unique identifier is probably a good idea, though. Jürgen

Re: r37716 - lyx-devel/trunk/src

Jürgen Spitzmüller wrote: > > I meant to do it like the attached patch. > > I don't like the idea of putting speller-specific code to Language. Using > lang() as a unique identifier is probably a good idea, though. IOW I'd move the hunspellID code to HunspellChecker. And still, my proposed

Re: r37716 - lyx-devel/trunk/src

Jürgen Spitzmüller wrote: > IOW I'd move the hunspellID code to HunspellChecker. And rename it to something more appropriate (such as HunspellDictionaryName). Sorry for the follow-ups, I'm slow today. Jürgen

Re: Icons

Stephan Witt wrote: > What about the hopping train image? its on plan.pavel

Re: Icons

Jürgen Spitzmüller wrote: > Joost Verburg wrote: > > What about this to start with (see screenshot)? > > These are too fanciful/colourish for my taste. i was just about to write they look better because are more colorful :) but i'll probably end up with my own set here, so no hard opinion...

Re: Find & replace in 2.0

Vincent van Ravesteijn wrote: > > I like the idea to make it a Firefox-like bar (which could still also > > include > > replace, like in KDE's Kate editor). But I doubt this is LyX 2.0 stuff. > > I have one and I will commit when 2.(0.)1 svn is open. > > Unless people are urging to get it in

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 11:34 schrieb Jürgen Spitzmüller: > Jürgen Spitzmüller wrote: >>> I meant to do it like the attached patch. >> >> I don't like the idea of putting speller-specific code to Language. Using >> lang() as a unique identifier is probably a good idea, though. > > IOW I'd move the

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: > > IOW I'd move the hunspellID code to HunspellChecker. > > Ok. And leave the id() method in Language? It is not used currentyl, so it should be ditched. > > And still, my proposed > > simplification would apply. > > Then there would only one lookup per language. > German

Re: Icons

"Jürgen Spitzmüller" wrote in message news:201102181054.36078.sp...@lyx.org... The icons I use are not the latest, I have done this some years back. Note that some (the update PDF/master) are badly self-designed icons, since I did not find anythink appropriate back then. We

Re: r37716 - lyx-devel/trunk/src

Am 18.02.2011 um 12:12 schrieb Jürgen Spitzmüller: > Stephan Witt wrote: >>> IOW I'd move the hunspellID code to HunspellChecker. >> >> Ok. And leave the id() method in Language? > > It is not used currentyl, so it should be ditched. > >>> And still, my proposed >>> simplification would

Re: r37716 - lyx-devel/trunk/src

Stephan Witt wrote: > Then we have this updated patch. Ok? Looks good to me. Thanks! Jürgen

Re: Icons

"Jürgen Spitzmüller" wrote in message news:201102181239.57022.sp...@lyx.org... Yes. I hacked some together myself. See attachment. They are certainly not masterpieces, I mainly took some elements from existing icons, if possible, to have something halfway matching. Thanks. Do

Re: Icons

Joost Verburg wrote: > Thanks. Do you also have the 22x22 png versions? Yep. Just sent to you privately. Jürgen

Re: Icons

Joost Verburg wrote: > "Jürgen Spitzmüller" wrote in message > news:201102181239.57022.sp...@lyx.org... >> Yes. I hacked some together myself. See attachment. They are certainly not >> masterpieces, I mainly took some elements from existing icons, if >> possible, to >> have

Foreign language marker

Can we please make the line that marks foerign languages thinner again (preferably as in branch)? This thick rule annoys me a lot. Jürgen

Re: Find & replace in 2.0

Il 18/02/2011 00:48, Pavel Sanda ha scritto: Pavel Sanda wrote: You're right, I was confused myself now by the UI. These texts on the tabs ("Basic" and "Advanced") don't make sense to me. Shouldn't that be renamed to "Search" and "Settings" or something similar? yes, looks more correct to me.

Re: r37353 - lyx-devel/trunk/lib/lyx2lyx

Le 11/02/2011 00:10, Richard Heck a écrit : This gets called at the end of InsetText::read(), and because we are PassThru, all the params get reset to their defaults. Hence, no centering. I had a fix for that (easy enough) and when I tried it... my file did not compile. Naively, I though that

Re: Foreign language marker

Am 18.02.2011 um 16:25 schrieb Jürgen Spitzmüller: > Can we please make the line that marks foerign languages thinner again > (preferably as in branch)? This thick rule annoys me a lot. I'll try to change that. Stephan