Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, I continue my backwards visit of history. I carefully followed your reviews and modified the code accordingly. Your comments on them were really useful. I forgot a couple of remarks in this commit. - RowPainter rp(pi, *text_, pit, row, bidi, x, y); + +

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, I continue my backwards visit of history. I carefully followed your reviews and modified the code accordingly. Your comments on them were really useful. I forgot a couple of remarks in this commit. - RowPainter rp(pi, *text_, pit, row, bidi, x, y); + +

Re: Row by Row sliding (review of

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, +++ b/src/Cursor.cpp at at -278,7 +278,7 at at CursorData::CursorData(DocIterator const dit) // bv functions are not yet available! Cursor::Cursor(BufferView bv) : CursorData(bv.buffer()), bv_(bv), - x_target_(-1), textTargetOffset_(0) +

Libertine support LyX version 2.1.0 (beta 1)

2013-08-01 Thread Dr Eberhard Lisse
The latest version of libertine in MacTeX 2013 (updated with tlmgr) lacks the file libertineMono-type1.sty. I took libertineRoman-type1.sty, modified it accordingly, put it into my local tree, texhashed, reconfigured LyX and it works. Cool. el On 2013-08-01 10:40 , Dr Eberhard Lisse wrote:

[PATCH] CMake export tests: remove LuaTeX for some langs

2013-08-01 Thread Scott Kostyshak
LyX does not currently support exporting documents to LuaTeX in certain languages. Until LyX adds features for exporting documents in these languages with LuaTeX, it does not make sense to have these export tests. Comments? Scott From 375dc4407b42b0732f1cd8478d000afec47c2d0f Mon Sep 17 00:00:00

[PATCH] CMake: tests now fail if no default_output_format

2013-08-01 Thread Scott Kostyshak
If a .lyx file has no 'default_output_format' property (that is, not even 'default'), then it is malformed and the test should fail. Before this patch, we guess that the correct format to test with is 'pdf'. Comments? Scott From 9ec76ee7f68037f900c458b25fc3510ec8b78e3f Mon Sep 17 00:00:00 2001

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, > > I continue my backwards visit of history. I carefully followed your reviews and modified the code accordingly. Your comments on them were really useful. > I forgot a couple of remarks in this commit. > > - RowPainter rp(pi, *text_, pit, row, bidi, x, y); > +

Re: Row by Row sliding (review of 095060cfcaa8f)

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, > > I continue my backwards visit of history. I carefully followed your reviews and modified the code accordingly. Your comments on them were really useful. > I forgot a couple of remarks in this commit. > > - RowPainter rp(pi, *text_, pit, row, bidi, x, y); > +

Re: Row by Row sliding (review of

2013-08-01 Thread Hashini Senaratne
Hello Jean-Marc, > +++ b/src/Cursor.cpp > -278,7 +278,7 CursorData::CursorData(DocIterator const & dit) > // bv functions are not yet available! > Cursor::Cursor(BufferView & bv) > : CursorData(()), bv_(), > - x_target_(-1), textTargetOffset_(0) > +

Libertine support LyX version 2.1.0 (beta 1)

2013-08-01 Thread Dr Eberhard Lisse
The latest version of libertine in MacTeX 2013 (updated with tlmgr) lacks the file libertineMono-type1.sty. I took libertineRoman-type1.sty, modified it accordingly, put it into my local tree, texhashed, reconfigured LyX and it works. Cool. el On 2013-08-01 10:40 , Dr Eberhard Lisse wrote: >

[PATCH] CMake export tests: remove LuaTeX for some langs

2013-08-01 Thread Scott Kostyshak
LyX does not currently support exporting documents to LuaTeX in certain languages. Until LyX adds features for exporting documents in these languages with LuaTeX, it does not make sense to have these export tests. Comments? Scott From 375dc4407b42b0732f1cd8478d000afec47c2d0f Mon Sep 17 00:00:00

[PATCH] CMake: tests now fail if no default_output_format

2013-08-01 Thread Scott Kostyshak
If a .lyx file has no 'default_output_format' property (that is, not even 'default'), then it is malformed and the test should fail. Before this patch, we guess that the correct format to test with is 'pdf'. Comments? Scott From 9ec76ee7f68037f900c458b25fc3510ec8b78e3f Mon Sep 17 00:00:00 2001