Re: [RFC] Python related system prompt "Lyx must be updated" on macOS

2022-01-03 Thread Stephan Witt
Am 04.01.2022 um 01:37 schrieb José Abílio Matos : > > On Friday, 31 December 2021 13.03.57 WET Stephan Witt wrote: > > I’m curious how difficult it would be to ignore python2 and present a > > message box for users to tell them how to get a python3 interpreter. > > > > BR, Stephan > > For now

Re: [LyX/master] #12434 add event handler for pinch-to-zoom gesture

2022-01-03 Thread Stephan Witt
Am 03.01.2022 um 16:15 schrieb Scott Kostyshak : > > On Mon, Jan 03, 2022 at 07:07:45AM +0100, Stephan Witt wrote: >> commit d4324034300f73f76e5ac34fb1e7653fa6e2ddf5 >> Author: Stephan Witt >> Date: Mon Jan 3 07:37:03 2022 +0100 >> >>#12434 add event handler for pinch-to-zoom gesture >> ---

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 18.32.14 WET José Abílio Matos wrote: > In any case I found other cases where the code is wrong (like the BOM > removal that does not work) and that it does not give an error although it > is wrong. For future reference this is an issue that happens silently. In this

Re: [RFC] Python related system prompt "Lyx must be updated" on macOS

2022-01-03 Thread José Abílio Matos
On Friday, 31 December 2021 13.03.57 WET Stephan Witt wrote: > I’m curious how difficult it would be to ignore python2 and present a > message box for users to tell them how to get a python3 interpreter. > > BR, Stephan For now we always search for Python 3 before Python 2. We know what is the

Re: [RFC] Python related system prompt "Lyx must be updated" on macOS

2022-01-03 Thread José Abílio Matos
On Wednesday, 29 December 2021 10.38.38 WET Stephan Witt wrote: > In any case we should ensure the detected usable python is used > consequently. > > Stephan This should be done now. All the heuristics regarding Python detection is now placed in src/support/ os.cpp. In particular we can try use

Re: Status of Master?

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 22.40.05 WET Enrico Forestieri wrote: > If i remember correctly, if the command starts with "python -tt" then we > could be sure it was a command defined by us and we replaced that with > os::python(). The last was for sure invoking a Python 2, while the bare > python

Re: Status of Master?

2022-01-03 Thread Enrico Forestieri
On Mon, Jan 03, 2022 at 08:48:09PM +, José Abílio Matos wrote: > > On Sunday, 2 January 2022 21.36.22 WET Richard Kimberly Heck wrote: > > OK, let me cc José on that. > > > > Riki > > I have a patch that it is mostly complete but I have one doubt. > In src/support/ForkedCalls.cpp there is a

Re: Status of Master?

2022-01-03 Thread José Abílio Matos
On Sunday, 2 January 2022 21.36.22 WET Richard Kimberly Heck wrote: > OK, let me cc José on that. > > Riki I have a patch that it is mostly complete but I have one doubt. In src/support/ForkedCalls.cpp there is a comment that says: // Make sure that a V2 python is run, if available Does anyone

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 16.02.51 WET Pavel Sanda wrote: > On Mon, Jan 03, 2022 at 03:16:47PM +, José Abílio Matos wrote: > > If you want I can take care of that, in 2.4, and see if there are cases > > where the conversion is missing. > > Please do, I suffer from ophidiophobia. You keep

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread Pavel Sanda
On Mon, Jan 03, 2022 at 03:16:47PM +, José Abílio Matos wrote: > If you want I can take care of that, in 2.4, and see if there are cases where > the conversion is missing. Please do, I suffer from ophidiophobia. > @Riki: is it possible to have a layout file such that the encoding is not >

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 14.55.53 WET Pavel Sanda wrote: > If I get that right the part of the "..." -> b"..." should be committed to > 2.4? > > Pavel Good point. Yes, it should (I thought that it already was) specially in order to be consistent with all the other code that already does that.

Re: [LyX/master] #12434 add event handler for pinch-to-zoom gesture

2022-01-03 Thread Scott Kostyshak
On Mon, Jan 03, 2022 at 07:07:45AM +0100, Stephan Witt wrote: > commit d4324034300f73f76e5ac34fb1e7653fa6e2ddf5 > Author: Stephan Witt > Date: Mon Jan 3 07:37:03 2022 +0100 > > #12434 add event handler for pinch-to-zoom gesture > --- Cool. I do not actually use the touch screen, but I

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread Pavel Sanda
On Mon, Jan 03, 2022 at 02:04:20PM +, José Abílio Matos wrote: > Looking into further detail I would easily that the first part of the patch > is > correct (change "..." to b"..."). > > The second part where it changes sys.stdin to sys.stdin.buffer is probably > incorrect: > > The similar

Re: Status of Master?

2022-01-03 Thread José Abílio Matos
On Sunday, 2 January 2022 23.52.37 WET José Abílio Matos wrote: > Another option would be instead of doing this in LyXRC.cpp to do it in > Converter.cpp and Mover.cpp where supposedly the commands are used. Then we > could expose this to users. This is the counterpart to the previous patch. The

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Wednesday, 29 December 2021 14.52.29 WET Pavel Sanda wrote: > Jose, > > are the proposed changes sensible? > I remember there were flowing similar patches to python codebase before. The changes are reasonable for python 3. I am not so sure about python 2 (because we support it) although it