Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: rgheck Date: Wed Jun 6 21:33:57 2007 New Revision: 18692 URL: http://www.lyx.org/trac/changeset/18692 Log: Fix bug 3823: Division needs not to return an integer. Also added some comments about a different possible fix. Two things: - Why do we divide by

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Enrico Forestieri
On Sat, Jun 16, 2007 at 12:29:55PM +0200, Michael Gerz wrote: [EMAIL PROTECTED] schrieb: Author: rgheck Date: Wed Jun 6 21:33:57 2007 New Revision: 18692 URL: http://www.lyx.org/trac/changeset/18692 Log: Fix bug 3823: Division needs not to return an integer. Also added some

[Fwd: Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp]

2007-06-16 Thread Richard Heck
[EMAIL PROTECTED] schrieb: Author: rgheck Date: Wed Jun 6 21:33:57 2007 New Revision: 18692 URL: http://www.lyx.org/trac/changeset/18692 Log: Fix bug 3823: Division needs not to return an integer. Also added some comments about a different possible fix. Two things: - Why do we divide by

Re: [Fwd: Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp]

2007-06-16 Thread Enrico Forestieri
On Sat, Jun 16, 2007 at 11:08:19AM -0400, Richard Heck wrote: - There are two more places where a floating point division may be useful. Yes. Surprising no bug reports about that one, as it'll give the same problem. But anyway, we should just have: Yes. Possibly, limiting the

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Michael Gerz
Hi, Based on Enrico's comment, here comes a shorter patch. I need one more OK. Michael Index: LaTeXFeatures.cpp === --- LaTeXFeatures.cpp (Revision 18800) +++ LaTeXFeatures.cpp (Arbeitskopie) @@ -499,7 +499,7 @@ //in

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Michael Gerz
Sorry, folks :-( Here comes a better patch. Still one more OK needed. Michael Index: LaTeXFeatures.cpp === --- LaTeXFeatures.cpp (Revision 18800) +++ LaTeXFeatures.cpp (Arbeitskopie) @@ -499,7 +499,7 @@ //in

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Richard Heck
Michael Gerz wrote: Hi, Based on Enrico's comment, here comes a shorter patch. I need one more OK. As Enrico mentioned, you probably want the limiting-precision bit here, too: if (mustProvide(ct-xcolor-soul)) { RGBColor cadd =

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Richard Heck
Beat me to it. Definitely OK, then. Michael Gerz wrote: Sorry, folks :-( Here comes a better patch. Still one more OK needed. Michael Index: LaTeXFeatures.cpp

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Michael Gerz
[EMAIL PROTECTED] schrieb: Author: rgheck Date: Wed Jun 6 21:33:57 2007 New Revision: 18692 URL: http://www.lyx.org/trac/changeset/18692 Log: Fix bug 3823: Division needs not to return an integer. Also added some comments about a different possible fix. Two things: - Why do we divide by

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Enrico Forestieri
On Sat, Jun 16, 2007 at 12:29:55PM +0200, Michael Gerz wrote: > [EMAIL PROTECTED] schrieb: > > Author: rgheck > > Date: Wed Jun 6 21:33:57 2007 > > New Revision: 18692 > > > > URL: http://www.lyx.org/trac/changeset/18692 > > Log: > > Fix bug 3823: Division needs not to return an integer. > > > >

[Fwd: Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp]

2007-06-16 Thread Richard Heck
[EMAIL PROTECTED] schrieb: Author: rgheck Date: Wed Jun 6 21:33:57 2007 New Revision: 18692 URL: http://www.lyx.org/trac/changeset/18692 Log: Fix bug 3823: Division needs not to return an integer. Also added some comments about a different possible fix. Two things: - Why do we divide by

Re: [Fwd: Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp]

2007-06-16 Thread Enrico Forestieri
On Sat, Jun 16, 2007 at 11:08:19AM -0400, Richard Heck wrote: > > - There are two more places where a floating point division may be > > useful. > Yes. Surprising no bug reports about that one, as it'll give the same > problem. But anyway, > we should just have: Yes. Possibly, limiting the

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Michael Gerz
Hi, Based on Enrico's comment, here comes a shorter patch. I need one more OK. Michael Index: LaTeXFeatures.cpp === --- LaTeXFeatures.cpp (Revision 18800) +++ LaTeXFeatures.cpp (Arbeitskopie) @@ -499,7 +499,7 @@ //in

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Michael Gerz
Sorry, folks :-( Here comes a better patch. Still one more OK needed. Michael Index: LaTeXFeatures.cpp === --- LaTeXFeatures.cpp (Revision 18800) +++ LaTeXFeatures.cpp (Arbeitskopie) @@ -499,7 +499,7 @@ //in

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Richard Heck
Michael Gerz wrote: Hi, Based on Enrico's comment, here comes a shorter patch. I need one more OK. As Enrico mentioned, you probably want the limiting-precision bit here, too: if (mustProvide("ct-xcolor-soul")) { RGBColor cadd =

Re: [Cvslog] r18692 - /lyx-devel/trunk/src/LaTeXFeatures.cpp

2007-06-16 Thread Richard Heck
Beat me to it. Definitely OK, then. Michael Gerz wrote: Sorry, folks :-( Here comes a better patch. Still one more OK needed. Michael Index: LaTeXFeatures.cpp