Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 18:43:36, schrieb Kornel Benko kor...@lyx.org Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 15/07/2015 15:26, Kornel Benko a écrit : So, can I apply my patch now? I have to fight with some tests, but YES.

Re: [PATCH] Auto feature for minibuffer toolbar

Am 15.07.2015 um 19:07 schrieb Kornel Benko kor...@lyx.org: Am Mittwoch, 15. Juli 2015 um 18:43:36, schrieb Kornel Benko kor...@lyx.org Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 15/07/2015 15:26, Kornel Benko a écrit : So, can I apply my

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 20:37:35, schrieb Stephan Witt st.w...@gmx.net Also I have now a reproducible crash, but only with my private user dir. 1.) Open a file 2.) try to insert space in the middle of a word == crash This recipe doesn't work for me. Do you have an example file to

Re: [PATCH] Auto feature for minibuffer toolbar

Le 01/07/2015 12:55, Kornel Benko a écrit : Am Mittwoch, 1. Juli 2015 um 12:31:11, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 01/07/2015 12:02, Kornel Benko a écrit : Just create your test.ui or xxdefaults.ui that contains === Format 2 Include default.ui

Re: [PATCH] Auto feature for minibuffer toolbar

Am 15.07.2015 um 20:46 schrieb Kornel Benko kor...@lyx.org: Am Mittwoch, 15. Juli 2015 um 20:37:35, schrieb Stephan Witt st.w...@gmx.net Also I have now a reproducible crash, but only with my private user dir. 1.) Open a file 2.) try to insert space in the middle of a word == crash

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 18:43:36, schrieb Kornel Benko kor...@lyx.org Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 15/07/2015 15:26, Kornel Benko a écrit : So, can I apply my patch now? I have to fight with some tests, but YES.

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 14:34:47, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 01/07/2015 12:55, Kornel Benko a écrit : Am Mittwoch, 1. Juli 2015 um 12:31:11, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 01/07/2015 12:02, Kornel Benko a écrit : Just create your test.ui

Re: [PATCH] Auto feature for minibuffer toolbar

Le 15/07/2015 15:26, Kornel Benko a écrit : So, can I apply my patch now? I have to fight with some tests, but YES. OK, I did it now. Have fun :) JMarc

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 15/07/2015 15:26, Kornel Benko a écrit : So, can I apply my patch now? I have to fight with some tests, but YES. OK, I did it now. Have fun :) JMarc In trying to correct a test, I see now the

Re: [PATCH] Auto feature for minibuffer toolbar

Le 01/07/2015 12:55, Kornel Benko a écrit : Am Mittwoch, 1. Juli 2015 um 12:31:11, schrieb Jean-Marc Lasgouttes Le 01/07/2015 12:02, Kornel Benko a écrit : Just create your test.ui or xxdefaults.ui that contains === Format 2 Include "default.ui"

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 14:34:47, schrieb Jean-Marc Lasgouttes > Le 01/07/2015 12:55, Kornel Benko a écrit : > > Am Mittwoch, 1. Juli 2015 um 12:31:11, schrieb Jean-Marc Lasgouttes > > > >> Le 01/07/2015 12:02, Kornel Benko a écrit : > >> Just

Re: [PATCH] Auto feature for minibuffer toolbar

Le 15/07/2015 15:26, Kornel Benko a écrit : So, can I apply my patch now? I have to fight with some tests, but YES. OK, I did it now. Have fun :) JMarc

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes > Le 15/07/2015 15:26, Kornel Benko a écrit : > >> So, can I apply my patch now? > > > > I have to fight with some tests, but YES. > > OK, I did it now. Have fun :) > > JMarc In trying to correct a test,

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 18:43:36, schrieb Kornel Benko > Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes > > > Le 15/07/2015 15:26, Kornel Benko a écrit : > > >> So, can I apply my patch now? > > > > > > I have to fight with some

Re: [PATCH] Auto feature for minibuffer toolbar

Am 15.07.2015 um 19:07 schrieb Kornel Benko : > Am Mittwoch, 15. Juli 2015 um 18:43:36, schrieb Kornel Benko >> Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes >> >>> Le 15/07/2015 15:26, Kornel Benko a écrit : > So,

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 20:37:35, schrieb Stephan Witt > > > > Also I have now a reproducible crash, but only with my private user dir. > > > > 1.) Open a file > > 2.) try to insert space in the middle of a word ==> crash > > This recipe doesn't work for me. Do you have an

Re: [PATCH] Auto feature for minibuffer toolbar

Am 15.07.2015 um 20:46 schrieb Kornel Benko : > Am Mittwoch, 15. Juli 2015 um 20:37:35, schrieb Stephan Witt >>> >>> Also I have now a reproducible crash, but only with my private user dir. >>> >>> 1.) Open a file >>> 2.) try to insert space in the middle of a

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 15. Juli 2015 um 18:43:36, schrieb Kornel Benko > Am Mittwoch, 15. Juli 2015 um 17:44:22, schrieb Jean-Marc Lasgouttes > > > Le 15/07/2015 15:26, Kornel Benko a écrit : > > >> So, can I apply my patch now? > > > > > > I have to fight with some

Re: [PATCH] Auto feature for minibuffer toolbar

Le 01/07/2015 12:02, Kornel Benko a écrit : Looking at the code, the Toolbars part should work. What is the problem? The problem is, that there is no such extra user ui file. Just create your test.ui or xxdefaults.ui that contains === Format 2 Include default.ui

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 1. Juli 2015 um 10:57:59, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 30/06/2015 11:32, Kornel Benko a écrit : I'll think about it. You can also have a working environment where the minibuffer toolbar is not auto but on. This supposedly works. I could not find a way

Re: [PATCH] Auto feature for minibuffer toolbar

Le 01/07/2015 11:34, Kornel Benko a écrit : Thanks, after examining the patch, I already found it. But the lack of a preference entry makes it so un-handy. We need something which could extend the default.ui. Say it has the content ... Toolbars minibuffer auto,off,bottom End Toolbar

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 1. Juli 2015 um 12:31:11, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 01/07/2015 12:02, Kornel Benko a écrit : Looking at the code, the Toolbars part should work. What is the problem? The problem is, that there is no such extra user ui file. Just create your test.ui

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 1. Juli 2015 um 11:47:33, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 01/07/2015 11:34, Kornel Benko a écrit : Thanks, after examining the patch, I already found it. But the lack of a preference entry makes it so un-handy. We need something which could extend the

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 1. Juli 2015 um 10:57:59, schrieb Jean-Marc Lasgouttes > Le 30/06/2015 11:32, Kornel Benko a écrit : > >> I'll think about it. You can also have a working environment where the > >> minibuffer toolbar is not auto but on. This supposedly works. > > > > I could not

Re: [PATCH] Auto feature for minibuffer toolbar

Le 01/07/2015 11:34, Kornel Benko a écrit : Thanks, after examining the patch, I already found it. But the lack of a preference entry makes it so un-handy. We need something which could extend the default.ui. Say it has the content ... Toolbars "minibuffer" "auto,off,bottom" End

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 1. Juli 2015 um 11:47:33, schrieb Jean-Marc Lasgouttes > Le 01/07/2015 11:34, Kornel Benko a écrit : > > Thanks, after examining the patch, I already found it. But the lack of a > > preference entry > > makes it so un-handy. > > We need something which could

Re: [PATCH] Auto feature for minibuffer toolbar

Le 01/07/2015 12:02, Kornel Benko a écrit : Looking at the code, the Toolbars part should work. What is the problem? The problem is, that there is no such extra user ui file. Just create your test.ui or xxdefaults.ui that contains === Format 2 Include "default.ui"

Re: [PATCH] Auto feature for minibuffer toolbar

Am Mittwoch, 1. Juli 2015 um 12:31:11, schrieb Jean-Marc Lasgouttes > Le 01/07/2015 12:02, Kornel Benko a écrit : > >> Looking at the code, the Toolbars part should work. What is the problem? > > > > The problem is, that there is no such extra user ui file. > > Just create

Re: [PATCH] Auto feature for minibuffer toolbar

Le 22/06/2015 22:50, Kornel Benko a écrit : This one definitely is better. Next glitch, sorry: Calling e.g. 'M-x dialog-show spellcheckerreturn' not only opens the dialog, but executes it, so that there is a dialog message 'We are at end of document, do you want to proceed from the

Re: [PATCH] Auto feature for minibuffer toolbar

Le 22/06/2015 22:50, Kornel Benko a écrit : This one definitely is better. Next glitch, sorry: Calling e.g. 'M-x dialog-show spellchecker' not only opens the dialog, but executes it, so that there is a dialog message 'We are at end of document, do you want to proceed from the start'

Re: [PATCH] Auto feature for minibuffer toolbar

Am Montag, 22. Juni 2015 um 16:10:35, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 19/06/2015 16:31, Kornel Benko a écrit : From memory: 1.) start lyx, the minibuffer is already displayed. 2.) open any file 3.) M-x, the cursor is displayed in the minibuffer 4.) M-x, in the

Re: [PATCH] Auto feature for minibuffer toolbar

Am Montag, 22. Juni 2015 um 16:53:06, schrieb Kornel Benko kor...@lyx.org Am Montag, 22. Juni 2015 um 16:10:35, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 19/06/2015 16:31, Kornel Benko a écrit : From memory: 1.) start lyx, the minibuffer is already displayed. 2.) open any

Re: [PATCH] Auto feature for minibuffer toolbar

Subject: [PATCH] Auto feature for minibuffer toolbar Now the minibuffer toolbar is auto by default. It is opened by command-execute (M-x) and closed when the command is executed without error. * make lyx::dispatch return a DispatchResult struct * there is a new MINIBUFFER type of toolbar, that can

Re: [PATCH] Auto feature for minibuffer toolbar

8 Apr 2015 19:10:33 +0200 Subject: [PATCH] Auto feature for minibuffer toolbar Now the minibuffer toolbar is "auto" by default. It is opened by command-execute (M-x) and closed when the command is executed without error. * make lyx::dispatch return a DispatchResult struct * there is a n

Re: [PATCH] Auto feature for minibuffer toolbar

Am Montag, 22. Juni 2015 um 16:10:35, schrieb Jean-Marc Lasgouttes > Le 19/06/2015 16:31, Kornel Benko a écrit : > > From memory: > > 1.) start lyx, the minibuffer is already displayed. > > 2.) open any file > > 3.) M-x, the cursor is displayed in the minibuffer > > 4.) M-x,

Re: [PATCH] Auto feature for minibuffer toolbar

Am Montag, 22. Juni 2015 um 16:53:06, schrieb Kornel Benko > Am Montag, 22. Juni 2015 um 16:10:35, schrieb Jean-Marc Lasgouttes > > > Le 19/06/2015 16:31, Kornel Benko a écrit : > > > From memory: > > > 1.) start lyx, the minibuffer is already displayed. > >

Re: [PATCH] Auto feature for minibuffer toolbar

Le 18/06/2015 17:41, Kornel Benko a écrit : With this patch every key is going to the minibuffer. I tried cua and emacs binding. Could you give more details on what you do? JMarc

Re: [PATCH] Auto feature for minibuffer toolbar

Am Freitag, 19. Juni 2015 um 16:12:17, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 18/06/2015 17:41, Kornel Benko a écrit : With this patch every key is going to the minibuffer. I tried cua and emacs binding. Could you give more details on what you do? JMarc From memory: 1.)

Re: [PATCH] Auto feature for minibuffer toolbar

Le 18/06/2015 17:41, Kornel Benko a écrit : With this patch every key is going to the minibuffer. I tried cua and emacs binding. Could you give more details on what you do? JMarc

Re: [PATCH] Auto feature for minibuffer toolbar

Am Freitag, 19. Juni 2015 um 16:12:17, schrieb Jean-Marc Lasgouttes > Le 18/06/2015 17:41, Kornel Benko a écrit : > > With this patch every key is going to the minibuffer. I tried cua and emacs > > binding. > > Could you give more details on what you do? > > JMarc From

Re: [PATCH] Auto feature for minibuffer toolbar

Am Donnerstag, 18. Juni 2015 um 16:27:55, schrieb Jean-Marc Lasgouttes lasgout...@lyx.org Le 18/06/2015 08:24, Scott Kostyshak a écrit : I wrote this poorly. The last sentence above is referring to the behavior without the patch. I was (attempting to) say that the reason I like that *with

Re: [PATCH] Auto feature for minibuffer toolbar

...@lyx.org Date: Sat, 18 Apr 2015 19:10:33 +0200 Subject: [PATCH] Auto feature for minibuffer toolbar Now the minibuffer toolbar is auto by default. It is opened by command-execute (M-x) and closed when the command is executed. --- lib/ui/default.ui | 2 +- src/frontends/qt4

Re: [PATCH] Auto feature for minibuffer toolbar

Am Donnerstag, 18. Juni 2015 um 08:38:28, schrieb Enrico Forestieri for...@lyx.org On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: What do you mean? For me M-x does not toggle, it just opens the mini-buffer. Actually I just tested and if I press it rapidly many times

Re: [PATCH] Auto feature for minibuffer toolbar

On Thu, Jun 18, 2015 at 08:51:12AM +0200, Kornel Benko wrote: Am Donnerstag, 18. Juni 2015 um 08:38:28, schrieb Enrico Forestieri for...@lyx.org On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: What do you mean? For me M-x does not toggle, it just opens the

Re: [PATCH] Auto feature for minibuffer toolbar

On Wed, Jun 17, 2015 at 05:51:28PM +0200, Jean-Marc Lasgouttes wrote: Le 14/06/2015 07:48, Scott Kostyshak a écrit : Note though that I do like that if I just press return (that is, entering an empty string), the command buffer closes. The only reason I like this though is that a subsequent

Re: [PATCH] Auto feature for minibuffer toolbar

On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: What do you mean? For me M-x does not toggle, it just opens the mini-buffer. Actually I just tested and if I press it rapidly many times sometimes I can get it to close the mini-buffer. Yours toggles perfectly? I wonder if this

Re: [PATCH] Auto feature for minibuffer toolbar

On Thu, Jun 18, 2015 at 03:11:25AM -0400, Scott Kostyshak wrote: On Thu, Jun 18, 2015 at 08:51:12AM +0200, Kornel Benko wrote: Am Donnerstag, 18. Juni 2015 um 08:38:28, schrieb Enrico Forestieri for...@lyx.org On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: What

Re: [PATCH] Auto feature for minibuffer toolbar

On Wed, Jun 17, 2015 at 05:51:28PM +0200, Jean-Marc Lasgouttes wrote: > Le 14/06/2015 07:48, Scott Kostyshak a écrit : > >>Note though that I do like that if I just press return (that is, > >>entering an empty string), the command buffer closes. The only reason > >>I like this though is that a

Re: [PATCH] Auto feature for minibuffer toolbar

On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: > > What do you mean? For me M-x does not toggle, it just opens the > mini-buffer. Actually I just tested and if I press it rapidly many times > sometimes I can get it to close the mini-buffer. Yours toggles > perfectly? I wonder if

Re: [PATCH] Auto feature for minibuffer toolbar

Am Donnerstag, 18. Juni 2015 um 08:38:28, schrieb Enrico Forestieri > On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: > > > > What do you mean? For me M-x does not toggle, it just opens the > > mini-buffer. Actually I just tested and if I press it rapidly many

Re: [PATCH] Auto feature for minibuffer toolbar

On Thu, Jun 18, 2015 at 08:51:12AM +0200, Kornel Benko wrote: > Am Donnerstag, 18. Juni 2015 um 08:38:28, schrieb Enrico Forestieri > > > On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: > > > > > > What do you mean? For me M-x does not toggle, it just opens the

Re: [PATCH] Auto feature for minibuffer toolbar

On Thu, Jun 18, 2015 at 03:11:25AM -0400, Scott Kostyshak wrote: > On Thu, Jun 18, 2015 at 08:51:12AM +0200, Kornel Benko wrote: > > Am Donnerstag, 18. Juni 2015 um 08:38:28, schrieb Enrico Forestieri > > > > > On Thu, Jun 18, 2015 at 02:24:30AM -0400, Scott Kostyshak wrote: > >

Re: [PATCH] Auto feature for minibuffer toolbar

arc Lasgouttes <lasgout...@lyx.org> Date: Sat, 18 Apr 2015 19:10:33 +0200 Subject: [PATCH] Auto feature for minibuffer toolbar Now the minibuffer toolbar is "auto" by default. It is opened by command-execute (M-x) and closed when the command is executed. --- lib/ui/default.ui

Re: [PATCH] Auto feature for minibuffer toolbar

Am Donnerstag, 18. Juni 2015 um 16:27:55, schrieb Jean-Marc Lasgouttes > Le 18/06/2015 08:24, Scott Kostyshak a écrit : > > I wrote this poorly. The last sentence above is referring to the > > behavior without the patch. I was (attempting to) say that the reason I > > like

Re: [PATCH] Auto feature for minibuffer toolbar

Le 14/06/2015 07:48, Scott Kostyshak a écrit : Note though that I do like that if I just press return (that is, entering an empty string), the command buffer closes. The only reason I like this though is that a subsequent alt + x does not hide the mini-buffer. I am not sure that I follow you

Re: [PATCH] Auto feature for minibuffer toolbar

Le 14/06/2015 07:48, Scott Kostyshak a écrit : Note though that I do like that if I just press return (that is, entering an empty string), the command buffer closes. The only reason I like this though is that a subsequent alt + x does not hide the mini-buffer. I am not sure that I follow you

Re: [PATCH] Auto feature for minibuffer toolbar

On Tue, Apr 21, 2015 at 03:57:22PM -0400, Scott Kostyshak wrote: On Mon, Apr 20, 2015 at 8:33 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Also, what if you misspelled the command you entered so that the command is disabled? Should the mini-buffer stay open so you can correct it

Re: [PATCH] Auto feature for minibuffer toolbar

On Tue, Apr 21, 2015 at 03:57:22PM -0400, Scott Kostyshak wrote: > On Mon, Apr 20, 2015 at 8:33 AM, Jean-Marc Lasgouttes > wrote: > > >> Also, what if you misspelled the command you entered so that the > >> command is disabled? Should the mini-buffer stay open so you can > >>

Re: [PATCH] Auto feature for minibuffer toolbar

On Mon, Apr 20, 2015 at 8:33 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Also, what if you misspelled the command you entered so that the command is disabled? Should the mini-buffer stay open so you can correct it quickly and enter it (without having to open the mini-buffer again)? I

Re: [PATCH] Auto feature for minibuffer toolbar

On Mon, Apr 20, 2015 at 8:33 AM, Jean-Marc Lasgouttes wrote: >> Also, what if you misspelled the command you entered so that the >> command is disabled? Should the mini-buffer stay open so you can >> correct it quickly and enter it (without having to open the >> mini-buffer

Re: [PATCH] Auto feature for minibuffer toolbar

Le 19/04/2015 00:00, Scott Kostyshak a écrit : Regarding your comment No need to keep the minibuffer open anymore can you add why to the comment? Is it because a command was just executed? Yes, exactly. Also, what if you misspelled the command you entered so that the command is disabled?

Re: [PATCH] Auto feature for minibuffer toolbar

Le 19/04/2015 00:00, Scott Kostyshak a écrit : Regarding your comment "No need to keep the minibuffer open anymore" can you add why to the comment? Is it because a command was just executed? Yes, exactly. Also, what if you misspelled the command you entered so that the command is disabled?

[PATCH] Auto feature for minibuffer toolbar

upgrading, I am not sure that we have a good solution for that. Thoughts? JMarc From d62f0050865c36a422752a1d06a7fe297f46cee0 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes lasgout...@lyx.org Date: Sat, 18 Apr 2015 19:10:33 +0200 Subject: [PATCH] Auto feature for minibuffer toolbar Now

Re: [PATCH] Auto feature for minibuffer toolbar

On Sat, Apr 18, 2015 at 1:18 PM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: This patch makes minibuffer work like it does in emacs: it is open when invoking M-x, and gets closed when the command has been executed. It may be necessary to remove you session data (.config/LyX/lyx.conf for

[PATCH] Auto feature for minibuffer toolbar

upgrading, I am not sure that we have a good solution for that. Thoughts? JMarc >From d62f0050865c36a422752a1d06a7fe297f46cee0 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes <lasgout...@lyx.org> Date: Sat, 18 Apr 2015 19:10:33 +0200 Subject: [PATCH] Auto feature for minibuffer too

Re: [PATCH] Auto feature for minibuffer toolbar

On Sat, Apr 18, 2015 at 1:18 PM, Jean-Marc Lasgouttes wrote: > This patch makes minibuffer work like it does in emacs: it is open when > invoking M-x, and gets closed when the command has been executed. > > It may be necessary to remove you session data (.config/LyX/lyx.conf