Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-29 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg I could only find one: The error list is not shown if the file Georg is corrupt. This could probably be fixed by handing the temp Georg buffer to InsertLyXFile: Is it really necessary to disconnect, or is it done when the buffer is deleted?

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-29 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Georg I could only find one: The error list is not shown if the file Georg is corrupt. This could probably be fixed by handing the temp Georg buffer to InsertLyXFile: Is it really necessary to disconnect, or is it done when the buffer is deleted? It is probably

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-29 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg It works perfectly. One minor note: Is the debug message Georg lyxerr[Debug::DEBUG] pasteSelection sel_index Georg endl; Georg in pasteSelection still needed? I removed the message and committed. JMarc

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> I could only find one: The error list is not shown if the file Georg> is corrupt. This could probably be fixed by handing the temp Georg> buffer to InsertLyXFile: Is it really necessary to disconnect, or is it done when the buffer is

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-29 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg> I could only find one: The error list is not shown if the file > Georg> is corrupt. This could probably be fixed by handing the temp > Georg> buffer to InsertLyXFile: > > Is it really necessary to disconnect, or is it done when the buffer is > deleted? It is

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-29 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> It works perfectly. One minor note: Is the debug message Georg> lyxerr[Debug::DEBUG] << " pasteSelection " << sel_index << Georg> endl; Georg> in pasteSelection still needed? I removed the message and committed. JMarc

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-28 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg The advantage of my patch is that it uses the existing cut and Georg paste code and that it will automatically benefit from future Georg changes to that code. I thought again about it during the week-end and came up with the following version

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-28 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Georg The advantage of my patch is that it uses the existing cut and Georg paste code and that it will automatically benefit from future Georg changes to that code. I thought again about it during the week-end and came up with the following version of the

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-28 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> The advantage of my patch is that it uses the existing cut and Georg> paste code and that it will automatically benefit from future Georg> changes to that code. I thought again about it during the week-end and came up with the

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-28 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg> The advantage of my patch is that it uses the existing cut and > Georg> paste code and that it will automatically benefit from future > Georg> changes to that code. > > I thought again about it during the week-end and came up with the > following version of

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-25 Thread Jean-Marc Lasgouttes
Georg == Georg Baum [EMAIL PROTECTED] writes: Georg It works if the cursor is in a new empty paragraph. It tries to Georg eat all available memory (and more) if the cursor is inside a Georg section. I cannot see that. Could you give directions? Georg Unavailable layouts are parsed as errors

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-25 Thread Georg Baum
Jean-Marc Lasgouttes wrote: Georg It works if the cursor is in a new empty paragraph. It tries to Georg eat all available memory (and more) if the cursor is inside a Georg section. I cannot see that. Could you give directions? I tried again and I see now that it does work with small

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-25 Thread Jean-Marc Lasgouttes
> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes: Georg> It works if the cursor is in a new empty paragraph. It tries to Georg> eat all available memory (and more) if the cursor is inside a Georg> section. I cannot see that. Could you give directions? Georg> Unavailable layouts are

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-25 Thread Georg Baum
Jean-Marc Lasgouttes wrote: > Georg> It works if the cursor is in a new empty paragraph. It tries to > Georg> eat all available memory (and more) if the cursor is inside a > Georg> section. > > I cannot see that. Could you give directions? I tried again and I see now that it does work with

[PATCH] bug 2096: LyX file inserting is broken

2005-11-24 Thread Jean-Marc Lasgouttes
After a lot of head scratching (a first patch with cut and paste, plus many ruminations on code merging), I came up with the following patch to fix LyX file insertion. As an added bonus, it fixes the situation where inInset could be NULL. I'd appreciate if someone could give it a good testing.

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-24 Thread Georg Baum
Am Donnerstag, 24. November 2005 16:47 schrieb Jean-Marc Lasgouttes: After a lot of head scratching (a first patch with cut and paste, plus many ruminations on code merging), I came up with the following patch to fix LyX file insertion. As an added bonus, it fixes the situation where inInset

[PATCH] bug 2096: LyX file inserting is broken

2005-11-24 Thread Jean-Marc Lasgouttes
After a lot of head scratching (a first patch with cut and paste, plus many ruminations on code merging), I came up with the following patch to fix LyX file insertion. As an added bonus, it fixes the situation where inInset could be NULL. I'd appreciate if someone could give it a good testing.

Re: [PATCH] bug 2096: LyX file inserting is broken

2005-11-24 Thread Georg Baum
Am Donnerstag, 24. November 2005 16:47 schrieb Jean-Marc Lasgouttes: > > After a lot of head scratching (a first patch with cut and paste, plus > many ruminations on code merging), I came up with the following > patch to fix LyX file insertion. As an added bonus, it fixes the > situation where