Re: [PATCH-final] Bug 3676

2007-08-27 Thread Jürgen Spitzmüller
Richard Heck wrote: It went in at 19565, 19598, and 19657. Whether it's for 1.5.x isn't clear to me. It ended up being a very large commit, and I'm guessing it'll be hard to port it once it's seen enough testing. But you might want to look at it. The new dialog is very nice, if I do say so

Re: [PATCH-final] Bug 3676

2007-08-27 Thread Jürgen Spitzmüller
Richard Heck wrote: > It went in at 19565, 19598, and 19657. Whether it's for 1.5.x isn't > clear to me. It ended up being a very large commit, and I'm guessing > it'll be hard to port it once it's seen enough testing. But you might > want to look at it. The new dialog is very nice, if I do say so

Re: [PATCH-final] Bug 3676

2007-08-26 Thread Jürgen Spitzmüller
Richard Heck wrote: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at 19520, but current svn won't build completely. I'm also attaching the log. Richard, what's

Re: [PATCH-final] Bug 3676

2007-08-26 Thread Richard Heck
Jürgen Spitzmüller wrote: Richard Heck wrote: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at 19520, but current svn won't build completely. I'm also attaching

Re: [PATCH-final] Bug 3676

2007-08-26 Thread Jürgen Spitzmüller
Richard Heck wrote: > With those suggestions, here is the putatively final patch. I intend to > commit as soon as the trunk will build again and I can verify that > everything works there. I've done that at 19520, but current svn won't > build completely. I'm also attaching the log. Richard,

Re: [PATCH-final] Bug 3676

2007-08-26 Thread Richard Heck
Jürgen Spitzmüller wrote: Richard Heck wrote: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at 19520, but current svn won't build completely. I'm also attaching

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Jean-Marc Lasgouttes
Richard Heck [EMAIL PROTECTED] writes: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at 19520, but current svn won't build completely. I'm also attaching the

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck [EMAIL PROTECTED] writes: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at 19520, but current svn won't build

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Jean-Marc Lasgouttes
Richard Heck [EMAIL PROTECTED] writes: Things are a little confusing here, because of where the code is headed. Probably it should change, shortly, to BibKeyList.{h,cpp}, which is about to become a class rather than just a typedef. There will still be some other functions in that file that

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Andre Poenitz
On Fri, Aug 17, 2007 at 11:53:02AM +0200, Jean-Marc Lasgouttes wrote: Richard Heck [EMAIL PROTECTED] writes: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > With those suggestions, here is the putatively final patch. I intend > to commit as soon as the trunk will build again and I can verify that > everything works there. I've done that at 19520, but current svn won't > build completely. I'm also attaching

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Richard Heck <[EMAIL PROTECTED]> writes: With those suggestions, here is the putatively final patch. I intend to commit as soon as the trunk will build again and I can verify that everything works there. I've done that at 19520, but current svn won't build

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > Things are a little confusing here, because of where the code is > headed. Probably it should change, shortly, to BibKeyList.{h,cpp}, > which is about to become a class rather than just a typedef. There > will still be some other functions in that file

Re: [PATCH-final] Bug 3676

2007-08-17 Thread Andre Poenitz
On Fri, Aug 17, 2007 at 11:53:02AM +0200, Jean-Marc Lasgouttes wrote: > Richard Heck <[EMAIL PROTECTED]> writes: > > > With those suggestions, here is the putatively final patch. I intend > > to commit as soon as the trunk will build again and I can verify that > > everything works there. I've