Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Angus == Angus Leeming [EMAIL PROTECTED] writes: I cannot do much to make sure that the new win32 code works, so I'll have to trust you on this :) | Angus No, all you have to do is convince yourself that it doesn't | Angus break on *nix. We've

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Jean-Marc Lasgouttes
Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes: | OK, it seems that our Code_Rules do not say anything about that... Lars I am in favour of the #if defined(FOO) style. The we should add it to the code rules and say when they should used. It seems autoconf style prefers #ifdef. JMarc

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Andre Poenitz
On Wed, Apr 20, 2005 at 12:02:58PM +0200, Jean-Marc Lasgouttes wrote: Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes: | OK, it seems that our Code_Rules do not say anything about that... Lars I am in favour of the #if defined(FOO) style. The we should add it to the code rules and

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Lars Gullik Bjønnes
Andre Poenitz [EMAIL PROTECTED] writes: | On Wed, Apr 20, 2005 at 12:02:58PM +0200, Jean-Marc Lasgouttes wrote: Lars == Lars Gullik Bjønnes [EMAIL PROTECTED] writes: | OK, it seems that our Code_Rules do not say anything about that... Lars I am in favour of the #if defined(FOO) style.

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: >> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: > >>> I cannot do much to make sure that the new win32 code works, so >>> I'll have to trust you on this :) > | Angus> No, all you have to do is convince yourself that it doesn't | Angus>

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | OK, it seems that our Code_Rules do not say anything about that... Lars> I am in favour of the "#if defined(FOO)" style. The we should add it to the code rules and say when they should used. It seems autoconf style prefers

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Andre Poenitz
On Wed, Apr 20, 2005 at 12:02:58PM +0200, Jean-Marc Lasgouttes wrote: > > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: > > | OK, it seems that our Code_Rules do not say anything about that... > > Lars> I am in favour of the "#if defined(FOO)" style. > > The we should add it to

Re: [PATCH 13x, 14x] child processes

2005-04-20 Thread Lars Gullik Bjønnes
Andre Poenitz <[EMAIL PROTECTED]> writes: | On Wed, Apr 20, 2005 at 12:02:58PM +0200, Jean-Marc Lasgouttes wrote: >> > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: >> >> | OK, it seems that our Code_Rules do not say anything about that... >> >> Lars> I am in favour of the "#if

[PATCH 13x, 14x] child processes

2005-04-19 Thread Angus Leeming
These patches implement asynchronous loading of graphics in Windows. The code on *nix is unchanged in the 1.3.x tree, apart from the removal of some functions that are no longer called. (They were used by the dialog to kill child processes but that went some time ago.) The 1.4.x code on *nix

Re: [PATCH 13x, 14x] child processes

2005-04-19 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: Angus These patches implement asynchronous loading of graphics in Angus Windows. The code on *nix is unchanged in the 1.3.x tree, apart Angus from the removal of some functions that are no longer called. Angus (They were used by the dialog to kill

Re: [PATCH 13x, 14x] child processes

2005-04-19 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: Angus These patches implement asynchronous loading of graphics in Angus Windows. The code on *nix is unchanged in the 1.3.x tree, apart Angus from the removal of some functions that are no longer called. Angus (They were used by the dialog to kill child processes

Re: [PATCH 13x, 14x] child processes

2005-04-19 Thread Jean-Marc Lasgouttes
Angus == Angus Leeming [EMAIL PROTECTED] writes: I cannot do much to make sure that the new win32 code works, so I'll have to trust you on this :) Angus No, all you have to do is convince yourself that it doesn't Angus break on *nix. We've never supported win32 before so we can't Angus

[PATCH 13x, 14x] child processes

2005-04-19 Thread Angus Leeming
These patches implement asynchronous loading of graphics in Windows. The code on *nix is unchanged in the 1.3.x tree, apart from the removal of some functions that are no longer called. (They were used by the dialog to kill child processes but that went some time ago.) The 1.4.x code on *nix

Re: [PATCH 13x, 14x] child processes

2005-04-19 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: Angus> These patches implement asynchronous loading of graphics in Angus> Windows. The code on *nix is unchanged in the 1.3.x tree, apart Angus> from the removal of some functions that are no longer called. Angus> (They were used by the

Re: [PATCH 13x, 14x] child processes

2005-04-19 Thread Angus Leeming
Jean-Marc Lasgouttes wrote: > Angus> These patches implement asynchronous loading of graphics in > Angus> Windows. The code on *nix is unchanged in the 1.3.x tree, apart > Angus> from the removal of some functions that are no longer called. > Angus> (They were used by the dialog to kill child

Re: [PATCH 13x, 14x] child processes

2005-04-19 Thread Jean-Marc Lasgouttes
> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes: >> I cannot do much to make sure that the new win32 code works, so >> I'll have to trust you on this :) Angus> No, all you have to do is convince yourself that it doesn't Angus> break on *nix. We've never supported win32 before so we