Re: [Patch] use Qt resources

2007-10-22 Thread Helge Hafting
Andre Poenitz wrote: On Fri, Oct 19, 2007 at 10:26:57AM +0200, Helge Hafting wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by

Re: [Patch] use Qt resources

2007-10-22 Thread Helge Hafting
Andre Poenitz wrote: On Fri, Oct 19, 2007 at 10:26:57AM +0200, Helge Hafting wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by

Re: [Patch] use Qt resources

2007-10-19 Thread Jean-Marc Lasgouttes
Andre Poenitz [EMAIL PROTECTED] writes: On Thu, Oct 18, 2007 at 08:47:18AM -0500, Bo Peng wrote: Scons? There's a Resources.cpp to be build and compiled in frontends/qt4. There is no such file. Did you add it to svn? This is a generated file built by Resources.qrc: echo

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Abdelrazak Younes wrote: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure on Windows). Note that most of the icons are loaded on startup now that we

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 11:07:19AM +0200, Alfredo Braunstein wrote: Abdelrazak Younes wrote: Good question. Because in the second case the change could actually mean *slower* startup times... I don't think the difference would be noticeable... the lib/images/math Didn't this

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 11:04:18AM +0200, Abdelrazak Younes wrote: Alfredo Braunstein wrote: Abdelrazak Younes wrote: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 10:37:46AM +0200, Alfredo Braunstein wrote: Abdelrazak Younes wrote: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 09:43:00AM +0200, Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Bo Peng wrote: Please #ifdef WIN32, or apply a proper solution. (Or should I use rcc -name option?) Please apply even a temporary fix. I can not compile under linux with this. Just go ahead and apply your suggested fix with #ifdef. Abdel.

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Abdelrazak Younes wrote: Hum not so good as we are both wrong! We should not count the .svn/ directory... images/math/ is actually 2.9M. Haha you're right. Another thing that makes me wonder, the 1.5.x lib/images dir with .xpm images was only 2.9M. Did the xpm - png change had some impact

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Good question. Because in the second case the change could actually mean *slower* startup times... I don't think the difference would be noticeable... the lib/images/math Didn't this start as a presumable startup time improvement? I

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Abdelrazak Younes wrote: Good question. Because in the second case the change could actually mean *slower* startup times... I don't think the difference would be noticeable... the lib/images/math Didn't this start as a presumable startup time improvement? directory is only 6 megs in

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure on Windows). Note that most of the icons are loaded

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes [EMAIL PROTECTED] writes: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure on Windows). Note that most of

Re: [Patch] use Qt resources

2007-10-19 Thread Jean-Marc Lasgouttes
Abdelrazak Younes [EMAIL PROTECTED] writes: This should be fixed yes. We probably need an API for icon loading; but wait, we already have that in GuiToolbar.cpp: static QIcon getIcon(FuncRequest const f, bool unknown) So, what do we want to support? I guess adding one or two cases for

Re: [Patch] use Qt resources

2007-10-19 Thread Helge Hafting
Abdelrazak Younes wrote: Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 10:45:30AM +0200, Jean-Marc Lasgouttes wrote: Abdelrazak Younes [EMAIL PROTECTED] writes: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 10:26:57AM +0200, Helge Hafting wrote: Abdelrazak Younes wrote: Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC

Re: [Patch] use Qt resources

2007-10-19 Thread Enrico Forestieri
On Fri, Oct 19, 2007 at 10:06:21AM -0500, Bo Peng wrote: Please #ifdef WIN32, or apply a proper solution. (Or should I use rcc -name option?) Please apply even a temporary fix. I can not compile under linux with this. I am going to fix it. The problem is that cmake adds the -name parameter

Re: [Patch] use Qt resources

2007-10-19 Thread Bo Peng
Please #ifdef WIN32, or apply a proper solution. (Or should I use rcc -name option?) Please apply even a temporary fix. I can not compile under linux with this. Bo

Re: [Patch] use Qt resources

2007-10-19 Thread Jean-Marc Lasgouttes
Abdelrazak Younes [EMAIL PROTECTED] writes: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure on Windows). Note that most of the icons are loaded on

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Alfredo Braunstein wrote: directory is only 6 megs in size. I don't know how the resource file is Note that lib/images (*including* lib/images/math) is just 7.9M. Right, we make a good team! Hum not so good as we are both wrong! We should not count the .svn/

Re: [Patch] use Qt resources

2007-10-19 Thread Jean-Marc Lasgouttes
Andre Poenitz <[EMAIL PROTECTED]> writes: > On Thu, Oct 18, 2007 at 08:47:18AM -0500, Bo Peng wrote: >> > Scons? >> > >> > There's a Resources.cpp to be build and compiled in frontends/qt4. >> >> There is no such file. Did you add it to svn? > > This is a generated file built by > >

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Abdelrazak Younes wrote: >> And this is an advantage because? > > Presumably faster loading. I haven't tested yet but I can imagine that > reading one big file on disk is faster than reading 600 small files > (this is for sure on Windows). Note that most of the icons are loaded on > startup now

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 11:07:19AM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > > Good question. > > > >> Because in the > >> second case the change could actually mean *slower* startup times... > > > > I don't think the difference would be noticeable... the lib/images/math >

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 11:04:18AM +0200, Abdelrazak Younes wrote: > Alfredo Braunstein wrote: > >Abdelrazak Younes wrote: > > > >>>And this is an advantage because? > >>Presumably faster loading. I haven't tested yet but I can imagine that > >>reading one big file on disk is faster than reading

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 10:37:46AM +0200, Alfredo Braunstein wrote: > Abdelrazak Younes wrote: > > >> And this is an advantage because? > > > > Presumably faster loading. I haven't tested yet but I can imagine that > > reading one big file on disk is faster than reading 600 small files > > (this

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 09:43:00AM +0200, Alfredo Braunstein wrote: > Andre Poenitz wrote: > > > On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: > >> > This is a generated file built by > >> > > >> > Resources.qrc: > >> > echo "" > $@ > >> > find $(top_srcdir)/lib/images

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Bo Peng wrote: Please #ifdef WIN32, or apply a proper solution. (Or should I use rcc -name option?) Please apply even a temporary fix. I can not compile under linux with this. Just go ahead and apply your suggested fix with #ifdef. Abdel.

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Hum not so good as we are both wrong! > We should not count the .svn/ directory... images/math/ is actually 2.9M. Haha you're right. >>> Another thing that makes me wonder, the 1.5.x lib/images dir with .xpm >>> images was only 2.9M. Did the xpm -> png change had some

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: Good question. Because in the second case the change could actually mean *slower* startup times... I don't think the difference would be noticeable... the lib/images/math Didn't this start as a presumable startup time improvement? I

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Abdelrazak Younes wrote: > Good question. > >> Because in the >> second case the change could actually mean *slower* startup times... > > I don't think the difference would be noticeable... the lib/images/math Didn't this start as a presumable startup time improvement? > directory is only 6

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Abdelrazak Younes wrote: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure on Windows). Note that most of the icons are loaded

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Abdelrazak Younes <[EMAIL PROTECTED]> writes: And this is an advantage because? Presumably faster loading. I haven't tested yet but I can imagine that reading one big file on disk is faster than reading 600 small files (this is for sure on Windows). Note that most

Re: [Patch] use Qt resources

2007-10-19 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: > This should be fixed yes. We probably need an API for icon loading; > but wait, we already have that in GuiToolbar.cpp: > > static QIcon getIcon(FuncRequest const & f, bool unknown) > > So, what do we want to support? I guess adding one or two cases

Re: [Patch] use Qt resources

2007-10-19 Thread Helge Hafting
Abdelrazak Younes wrote: Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo "" > $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Alfredo Braunstein wrote: Andre Poenitz wrote: On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo "" > $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e 's:$(top_srcdir)/lib/\(.*\):&:' \

Re: [Patch] use Qt resources

2007-10-19 Thread Alfredo Braunstein
Andre Poenitz wrote: > On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: >> > This is a generated file built by >> > >> > Resources.qrc: >> > echo "" > $@ >> > find $(top_srcdir)/lib/images -name '*.png' \ >> > | sed -e 's:$(top_srcdir)/lib/\(.*\):> >

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 10:45:30AM +0200, Jean-Marc Lasgouttes wrote: > Abdelrazak Younes <[EMAIL PROTECTED]> writes: > > >> And this is an advantage because? > > > > Presumably faster loading. I haven't tested yet but I can imagine that > > reading one big file on disk is faster than reading 600

Re: [Patch] use Qt resources

2007-10-19 Thread Andre Poenitz
On Fri, Oct 19, 2007 at 10:26:57AM +0200, Helge Hafting wrote: > Abdelrazak Younes wrote: > >Alfredo Braunstein wrote: > >>Andre Poenitz wrote: > >> > >>>On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: > >This is a generated file built by > > > >Resources.qrc: > >

Re: [Patch] use Qt resources

2007-10-19 Thread Enrico Forestieri
On Fri, Oct 19, 2007 at 10:06:21AM -0500, Bo Peng wrote: > > Please #ifdef WIN32, or apply a proper solution. (Or should I use rcc > > -name option?) > > Please apply even a temporary fix. I can not compile under linux with this. I am going to fix it. The problem is that cmake adds the -name

Re: [Patch] use Qt resources

2007-10-19 Thread Bo Peng
> Please #ifdef WIN32, or apply a proper solution. (Or should I use rcc > -name option?) Please apply even a temporary fix. I can not compile under linux with this. Bo

Re: [Patch] use Qt resources

2007-10-19 Thread Jean-Marc Lasgouttes
Abdelrazak Younes <[EMAIL PROTECTED]> writes: >> And this is an advantage because? > > Presumably faster loading. I haven't tested yet but I can imagine that > reading one big file on disk is faster than reading 600 small files > (this is for sure on Windows). Note that most of the icons are

Re: [Patch] use Qt resources

2007-10-19 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Alfredo Braunstein wrote: directory is only 6 megs in size. I don't know how the resource file is Note that lib/images (*including* lib/images/math) is just 7.9M. Right, we make a good team! Hum not so good as we are both wrong! We should not count the .svn/

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Wed, Oct 17, 2007 at 09:55:53PM -0500, Bo Peng wrote: On 10/16/07, Andre Poenitz [EMAIL PROTECTED] wrote: On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
Scons? There's a Resources.cpp to be build and compiled in frontends/qt4. There is no such file. Did you add it to svn? Bo

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 08:47:18AM -0500, Bo Peng wrote: Scons? There's a Resources.cpp to be build and compiled in frontends/qt4. There is no such file. Did you add it to svn? This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e 's:$(top_srcdir)/lib/\(.*\):file alias=\1/file:' \ $@ echo /qresource/RCC $@

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 01:32:44PM -0500, Bo Peng wrote: On 10/18/07, Bo Peng [EMAIL PROTECTED] wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \ |

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
What is the advantage of doing all these? Compiled-in resources vs 600 seperately installed files? Makes sense. Thanks. BTW, you use find to get all the images under lib/images, but some of them are unused. Scons only compiles the used ones that are listed in scons_manifest. Bo

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
OK. Scons is fixed for this. Abdel seems to have the same problem with cmake. I did ask people to test he patch, didn't I? You did ask, but I had no idea what your patch was about, and did not test. Bo

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
On 10/18/07, Bo Peng [EMAIL PROTECTED] wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e 's:$(top_srcdir)/lib/\(.*\):file alias=\1/file:' \

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: This is a generated file built by Resources.qrc: echo !DOCTYPE RCCRCC version='1.0'qresource $@ find $(top_srcdir)/lib/images -name '*.png' \ | sed -e 's:$(top_srcdir)/lib/\(.*\):file

Re: [Patch] use Qt resources

2007-10-18 Thread Peter Kümmel
Andre Poenitz wrote: On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed are welcome. Slightly more complete patch attached. Andre' + +static void initializeResources() +{ +

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 01:51:35PM -0500, Bo Peng wrote: What is the advantage of doing all these? Compiled-in resources vs 600 seperately installed files? Makes sense. Thanks. BTW, you use find to get all the images under lib/images, but some of them are unused. Scons only compiles

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
BTW, you use find to get all the images under lib/images, but some of them are unused. Scons only compiles the used ones that are listed in scons_manifest. Would anybody object to remove the unused ones? I am not quite sure. For example, I can add font-bold to ui/stdtoolbar.inc, and

Re: [Patch] use Qt resources

2007-10-18 Thread Martin Vermeer
On Thu, Oct 18, 2007 at 04:07:56PM -0500, Bo Peng wrote: BTW, you use find to get all the images under lib/images, but some of them are unused. Scons only compiles the used ones that are listed in scons_manifest. Would anybody object to remove the unused ones? I am not quite sure.

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
I've replaced your qInitResources() with the 'official' Qt Q_INIT_RESOURCE(Resources) because on windows the rcc generates qInitResources_Resources(). I do not know what is going on here, but Linux/qt does not have qInitResources_Resources()... and now I am getting

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Wed, Oct 17, 2007 at 09:55:53PM -0500, Bo Peng wrote: > On 10/16/07, Andre Poenitz <[EMAIL PROTECTED]> wrote: > > On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: > > > > > > Could somebody on Windows please try this one? > > > > > > [It should work] > > > > > > Also anu

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
> Scons? > > There's a Resources.cpp to be build and compiled in frontends/qt4. There is no such file. Did you add it to svn? Bo

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 08:47:18AM -0500, Bo Peng wrote: > > Scons? > > > > There's a Resources.cpp to be build and compiled in frontends/qt4. > > There is no such file. Did you add it to svn? This is a generated file built by Resources.qrc: echo "" > $@ find

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
> This is a generated file built by > > Resources.qrc: > echo "" > $@ > find $(top_srcdir)/lib/images -name '*.png' \ > | sed -e 's:$(top_srcdir)/lib/\(.*\): alias="\1">&:' \ > >> $@ > echo "" >> $@ What is the advantage of doing all these?

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 01:32:44PM -0500, Bo Peng wrote: > On 10/18/07, Bo Peng <[EMAIL PROTECTED]> wrote: > > > This is a generated file built by > > > > > > Resources.qrc: > > > echo "" > $@ > > > find $(top_srcdir)/lib/images -name '*.png' \ > > > | sed -e

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
> > What is the advantage of doing all these? > > Compiled-in resources vs 600 seperately installed files? Makes sense. Thanks. BTW, you use find to get all the images under lib/images, but some of them are unused. Scons only compiles the used ones that are listed in scons_manifest. Bo

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
> > OK. Scons is fixed for this. Abdel seems to have the same problem with > > cmake. > > I did ask people to test he patch, didn't I? You did ask, but I had no idea what your patch was about, and did not test. Bo

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
On 10/18/07, Bo Peng <[EMAIL PROTECTED]> wrote: > > This is a generated file built by > > > > Resources.qrc: > > echo "" > $@ > > find $(top_srcdir)/lib/images -name '*.png' \ > > | sed -e 's:$(top_srcdir)/lib/\(.*\): > alias="\1">&:' \ > > >> $@ > >

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 12:20:23PM -0500, Bo Peng wrote: > > This is a generated file built by > > > > Resources.qrc: > > echo "" > $@ > > find $(top_srcdir)/lib/images -name '*.png' \ > > | sed -e 's:$(top_srcdir)/lib/\(.*\): > alias="\1">&:' \ > >

Re: [Patch] use Qt resources

2007-10-18 Thread Peter Kümmel
Andre Poenitz wrote: On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed are welcome. Slightly more complete patch attached. Andre' + +static void initializeResources() +{ +

Re: [Patch] use Qt resources

2007-10-18 Thread Andre Poenitz
On Thu, Oct 18, 2007 at 01:51:35PM -0500, Bo Peng wrote: > > > What is the advantage of doing all these? > > > > Compiled-in resources vs 600 seperately installed files? > > Makes sense. Thanks. > > BTW, you use find to get all the images under lib/images, but some of > them are unused. Scons

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
> > BTW, you use find to get all the images under lib/images, but some of > > them are unused. Scons only compiles the used ones that are listed in > > scons_manifest. > > Would anybody object to remove the unused ones? I am not quite sure. For example, I can add font-bold to ui/stdtoolbar.inc,

Re: [Patch] use Qt resources

2007-10-18 Thread Martin Vermeer
On Thu, Oct 18, 2007 at 04:07:56PM -0500, Bo Peng wrote: > > > BTW, you use find to get all the images under lib/images, but some of > > > them are unused. Scons only compiles the used ones that are listed in > > > scons_manifest. > > > > Would anybody object to remove the unused ones? > > I am

Re: [Patch] use Qt resources

2007-10-18 Thread Bo Peng
> I've replaced your qInitResources() with the 'official' Qt > Q_INIT_RESOURCE(Resources) because on windows the > rcc generates qInitResources_Resources(). > I do not know what is going on here, but Linux/qt does not have qInitResources_Resources()... and now I am getting

Re: [Patch] use Qt resources

2007-10-17 Thread Bo Peng
On 10/16/07, Andre Poenitz [EMAIL PROTECTED] wrote: On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed are welcome. Slightly more complete patch attached. I get

Re: [Patch] use Qt resources

2007-10-17 Thread Bo Peng
On 10/16/07, Andre Poenitz <[EMAIL PROTECTED]> wrote: > On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: > > > > Could somebody on Windows please try this one? > > > > [It should work] > > > > Also anu observations on startup speed are welcome. > > Slightly more complete patch

[Patch] use Qt resources

2007-10-16 Thread Andre Poenitz
Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed are welcome. Andre' Index: GuiToolbar.cpp === --- GuiToolbar.cpp (revision 20995) +++ GuiToolbar.cpp (working copy)

Re: [Patch] use Qt resources

2007-10-16 Thread Andre Poenitz
On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed are welcome. Slightly more complete patch attached. Andre' Index: GuiToolbar.cpp

[Patch] use Qt resources

2007-10-16 Thread Andre Poenitz
Could somebody on Windows please try this one? [It should work] Also anu observations on startup speed are welcome. Andre' Index: GuiToolbar.cpp === --- GuiToolbar.cpp (revision 20995) +++ GuiToolbar.cpp (working copy)

Re: [Patch] use Qt resources

2007-10-16 Thread Andre Poenitz
On Tue, Oct 16, 2007 at 11:11:23PM +0200, Andre Poenitz wrote: > > Could somebody on Windows please try this one? > > [It should work] > > Also anu observations on startup speed are welcome. Slightly more complete patch attached. Andre' Index: GuiToolbar.cpp