On Thu, May 25, 2017 at 01:08:20AM +0200, Guillaume MM wrote:
> Hi Scott, indeed there is no need for this in 2.3 and I meant to reply
> to Jean-Marc later. In addition gcc 4.6 might get in the way and I am
> hoping that 2.4 is the good time to unsupport it. So it's best not to
> have this in
Le 24/05/2017 à 04:59, Scott Kostyshak a écrit :
On Tue, May 09, 2017 at 04:25:15PM +0200, Jean-Marc Lasgouttes wrote:
Le 21/04/2017 à 00:11, Guillaume MM a écrit :
Le 08/04/2017 à 23:05, Jean-Marc Lasgouttes a écrit :
FileName:
This would be automatically copyable and movable if not for
On Tue, May 09, 2017 at 04:25:15PM +0200, Jean-Marc Lasgouttes wrote:
> Le 21/04/2017 à 00:11, Guillaume MM a écrit :
> > Le 08/04/2017 à 23:05, Jean-Marc Lasgouttes a écrit :
> > >
> > > > FileName:
> > > > This would be automatically copyable and movable if not for the use of
> > > > the
Le 21/04/2017 à 00:11, Guillaume MM a écrit :
Le 08/04/2017 à 23:05, Jean-Marc Lasgouttes a écrit :
FileName:
This would be automatically copyable and movable if not for the use of
the pointer to implementation.
What is the problem with the pointer?
For motivations see for instance
Le 21/04/2017 à 00:11, Guillaume MM a écrit :
I am thinking about something along the lines of the attached patches.
But to be clear, one should not expect any performance gain. Only some
review, clarification, and simplification of the code.
Speaking of review, I found that setMouseHover was
Le 08/04/2017 à 23:05, Jean-Marc Lasgouttes a écrit :
Also, I do not understand this (I know it is the same as the old code)
+explicit Inset(Inset const &) : buffer_(0) {}
What is this good for? The semantics look quite broken to me. Is this
even used? (I guess we should make it private to
Le 08/04/2017 à 00:00, Guillaume MM a écrit :
The solution is of course not to make the code more complicated (and
error-prone) with custom move operators. Instead one should rely on
compiler-generated move and copy constructors and assignment operators
in a more systematic manner, sometimes
Le 28/03/2017 à 12:22, Jean-Marc Lasgouttes a écrit :
This one is probably for Guillaume.
Coverity complains about missing move constructors for Inset, MathAtom,
Mover, SpecializedMover, FileName, InsetMathNest, InsetMathHull.
The help text says: "This class does not have a user-written move
This one is probably for Guillaume.
Coverity complains about missing move constructors for Inset, MathAtom,
Mover, SpecializedMover, FileName, InsetMathNest, InsetMathHull.
The help text says: "This class does not have a user-written move
assignment operator and its copy assignment operator
