Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Vincent van Ravesteijn
Vincent van Ravesteijn schreef: Solving: - The GuiTabular dialog has an auto-apply policy. The buttoncontroller however changes the Close button into Cancel, while pressing Cancel does apply the settings. Therefore I added a new ButtonPolicy: AutoApplyPolicy. - When editing the width edit

[patch] Fix UI GuiTabular

2008-11-17 Thread Vincent van Ravesteijn
Solving: - The GuiTabular dialog has an auto-apply policy. The buttoncontroller however changes the Close button into Cancel, while pressing Cancel does apply the settings. Therefore I added a new ButtonPolicy: AutoApplyPolicy. - When editing the width edit field is not finished by an enter

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: Solving: - The GuiTabular dialog has an auto-apply policy. The buttoncontroller however changes the Close button into Cancel, while pressing Cancel does apply the settings. Therefore I added a new ButtonPolicy: AutoApplyPolicy. I think we really need

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Pavel Sanda
Vincent van Ravesteijn wrote: Solving: - The GuiTabular dialog has an auto-apply policy. The buttoncontroller however changes the Close button into Cancel, while pressing Cancel does i'm really happy you looked into this, as Uwe says in #1699 we are the only word processor where you apply

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: I'm fixing the current design of the dialog. Whether the design should be changed is the next question ? It should have been changed long ago. Maybe you'll find the time. The current design is only a burden of the past. PS. I removed the new policy again,

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Charles de Miramon
Jürgen Spitzmüller wrote: I think we really need OK/Apply/Cancel buttons in the long term (there's also an old bug report somewhere). +1 C. -- http://www.kde-france.org

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Charles de Miramon
Jürgen Spitzmüller wrote: Vincent van Ravesteijn wrote: I'm fixing the current design of the dialog. Whether the design should be changed is the next question ? It should have been changed long ago. Maybe you'll find the time. The current design is only a burden of the past. I would

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Vincent van Ravesteijn
Vincent van Ravesteijn schreef: Solving: - The GuiTabular dialog has an auto-apply policy. The buttoncontroller however changes the Close button into Cancel, while pressing Cancel does apply the settings. Therefore I added a new ButtonPolicy: AutoApplyPolicy. - When editing the width edit

[patch] Fix UI GuiTabular

2008-11-17 Thread Vincent van Ravesteijn
Solving: - The GuiTabular dialog has an auto-apply policy. The buttoncontroller however changes the Close button into Cancel, while pressing Cancel does apply the settings. Therefore I added a new ButtonPolicy: AutoApplyPolicy. - When editing the width edit field is not finished by an enter

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > Solving: > - The GuiTabular dialog has an auto-apply policy. The buttoncontroller > however changes the Close button into Cancel, while pressing Cancel does > apply the settings. Therefore I added a new ButtonPolicy: AutoApplyPolicy. I think we really need

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Pavel Sanda
Vincent van Ravesteijn wrote: > > Solving: > - The GuiTabular dialog has an auto-apply policy. The buttoncontroller > however changes the Close button into Cancel, while pressing Cancel does i'm really happy you looked into this, as Uwe says in #1699 we are the only word processor where you

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > I'm fixing the current design of the dialog. Whether the design should > be changed is the next question ? It should have been changed long ago. Maybe you'll find the time. The current design is only a burden of the past. > PS. I removed the new policy again,

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Charles de Miramon
Jürgen Spitzmüller wrote: > I think we really need OK/Apply/Cancel buttons in the long term (there's > also an old bug report somewhere). > +1 C. -- http://www.kde-france.org

Re: [patch] Fix UI GuiTabular

2008-11-17 Thread Charles de Miramon
Jürgen Spitzmüller wrote: > Vincent van Ravesteijn wrote: >> I'm fixing the current design of the dialog. Whether the design should >> be changed is the next question ? > > It should have been changed long ago. Maybe you'll find the time. The > current design is only a burden of the past. > I