Re: [possible patch]: numerical citation fix

2004-05-23 Thread Andre Poenitz
On Thu, May 13, 2004 at 10:33:34AM +0100, Angus Leeming wrote: which seems to be a qt issue btw. (incidentally, there seem to be some dispatch problems in xforms; opening the citation dialog from an inset is a real pain). Andre has got a new job at the wrong time, it would appear ;-)

Re: [possible patch]: numerical citation fix

2004-05-23 Thread Andre Poenitz
On Thu, May 13, 2004 at 10:33:34AM +0100, Angus Leeming wrote: > > which seems to be a qt issue btw. (incidentally, there seem to be > > some dispatch problems in xforms; opening the citation dialog from > > an inset is a real pain). > > Andre has got a new job at the wrong time, it would appear

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Angus Leeming
Juergen Spitzmueller wrote: Angus, it works very well. Now only the off-by-one error is still there. Before we address that one, which seems to be a qt issue btw. Juergen, can you explain to me what the problem is and how to reproduce it? (incidentally, there seem to be some dispatch

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Jürgen Spitzmüller
Angus Leeming wrote: which seems to be a qt issue btw. Juergen, can you explain to me what the problem is and how to reproduce it? You have to switch a document with existing citation insets from natbib-authoryear to jurabib. Then click on an inset: The style in the combo is wrong (off by

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Angus Leeming
Jürgen Spitzmüller wrote: Juergen, can you explain to me what the problem is and how to reproduce it? You have to switch a document with existing citation insets from natbib-authoryear to jurabib. Then click on an inset: The style in the combo is wrong (off by one). Ok. And presumably this

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Jürgen Spitzmüller
Angus Leeming wrote: Are there any other citation bugs none that I am aware of ATM. Jürgen.

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Angus Leeming
Juergen Spitzmueller wrote: >> > Angus, it works very well. Now only the off-by-one error is still >> > there. >> >> Before we address that one, > > which seems to be a qt issue btw. Juergen, can you explain to me what the problem is and how to reproduce it? > (incidentally, there seem to be >

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Jürgen Spitzmüller
Angus Leeming wrote: > > which seems to be a qt issue btw. > > Juergen, can you explain to me what the problem is and how to > reproduce it? You have to switch a document with existing citation insets from natbib-authoryear to jurabib. Then click on an inset: The style in the combo is wrong

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Angus Leeming
Jürgen Spitzmüller wrote: >> Juergen, can you explain to me what the problem is and how to >> reproduce it? > > You have to switch a document with existing citation insets from > natbib-authoryear to jurabib. Then click on an inset: The style in > the combo is wrong (off by one). Ok. And

Re: [possible patch]: numerical citation fix

2004-05-17 Thread Jürgen Spitzmüller
Angus Leeming wrote: > Are there any other citation bugs none that I am aware of ATM. Jürgen.

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Juergen Spitzmueller
Angus Leeming wrote: Angus, it works very well. Now only the off-by-one error is still there. Before we address that one, which seems to be a qt issue btw. (incidentally, there seem to be some dispatch problems in xforms; opening the citation dialog from an inset is a real pain).

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Angus Leeming
Juergen Spitzmueller wrote: Angus Leeming wrote: Angus, it works very well. Now only the off-by-one error is still there. Before we address that one, which seems to be a qt issue btw. (incidentally, there seem to be some dispatch problems in xforms; opening the citation dialog from an

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Juergen Spitzmueller
Angus Leeming wrote: You (the Qt guys) tend to use multiple radio buttons where I would use a single choice. Is there a rationale? tooltips. Jürgen.

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Angus Leeming wrote: You (the Qt guys) tend to use multiple radio buttons where I would use a single choice. Is there a rationale? Juergen tooltips. One can always have a big tooltip that explains the different choices. JMarc

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: One can always have a big tooltip that explains the different choices. In the qt world, that would rather be a What's this? (which has not been implemented yet). Anyway, we have very much place on the bibliography pane, and therefore the radio solution seems more

Re: [possible patch]: numerical citation fix

2004-05-13 Thread John Levon
On Thu, May 13, 2004 at 12:48:36PM +0200, Jean-Marc Lasgouttes wrote: One can always have a big tooltip There's no such thing as a big tooltip, so to speak... john

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Jean-Marc Lasgouttes
John == John Levon [EMAIL PROTECTED] writes: John On Thu, May 13, 2004 at 12:48:36PM +0200, Jean-Marc Lasgouttes John wrote: One can always have a big tooltip John There's no such thing as a big tooltip, so to speak... Indeed, it should be more like a 'what's this?' or whatever it's called.

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Juergen Spitzmueller
Angus Leeming wrote: > > Angus, it works very well. Now only the off-by-one error is still > > there. > > Before we address that one, which seems to be a qt issue btw. (incidentally, there seem to be some dispatch problems in xforms; opening the citation dialog from an inset is a real pain).

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Angus Leeming
Juergen Spitzmueller wrote: > Angus Leeming wrote: >> > Angus, it works very well. Now only the off-by-one error is still >> > there. >> >> Before we address that one, > > which seems to be a qt issue btw. (incidentally, there seem to be > some dispatch problems in xforms; opening the citation

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Juergen Spitzmueller
Angus Leeming wrote: > You (the Qt guys) tend to use > multiple radio buttons where I would use a single choice. Is there a > rationale? tooltips. Jürgen.

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Angus Leeming wrote: >> You (the Qt guys) tend to use multiple radio buttons where I would >> use a single choice. Is there a rationale? Juergen> tooltips. One can always have a big tooltip that explains the different

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > One can always have a big tooltip that explains the different choices. In the qt world, that would rather be a "What's this?" (which has not been implemented yet). Anyway, we have very much place on the bibliography pane, and therefore the radio solution seems more

Re: [possible patch]: numerical citation fix

2004-05-13 Thread John Levon
On Thu, May 13, 2004 at 12:48:36PM +0200, Jean-Marc Lasgouttes wrote: > One can always have a big tooltip There's no such thing as a big tooltip, so to speak... john

Re: [possible patch]: numerical citation fix

2004-05-13 Thread Jean-Marc Lasgouttes
> "John" == John Levon <[EMAIL PROTECTED]> writes: John> On Thu, May 13, 2004 at 12:48:36PM +0200, Jean-Marc Lasgouttes John> wrote: >> One can always have a big tooltip John> There's no such thing as a big tooltip, so to speak... Indeed, it should be more like a 'what's this?' or whatever

Re: [possible patch]: numerical citation fix

2004-05-12 Thread Angus Leeming
Juergen Spitzmueller wrote: Angus Leeming wrote: Doh! Wrong patch! That was the old one you've already commented on. Angus, it works very well. Now only the off-by-one error is still there. Before we address that one, here's another clean-up patch. This one stores a biblio::CiteEngine

Re: [possible patch]: numerical citation fix

2004-05-12 Thread Angus Leeming
Juergen Spitzmueller wrote: > Angus Leeming wrote: >> Doh! Wrong patch! That was the old one you've already commented on. > > Angus, it works very well. Now only the off-by-one error is still > there. Before we address that one, here's another clean-up patch. This one stores a biblio::CiteEngine

Re: [possible patch]: numerical citation fix

2004-05-07 Thread Juergen Spitzmueller
Angus Leeming wrote: attached is a patch that should help ensure the above requirement. It's actually just a refactoring of existing code, even though it looks pretty frightening. No, it looks very reasonable and clean. Good idea! If you'd be good enough to stress test it, that'd be great.

Re: [possible patch]: numerical citation fix

2004-05-07 Thread Juergen Spitzmueller
Angus Leeming wrote: Doh! Wrong patch! That was the old one you've already commented on. Angus, it works very well. Now only the off-by-one error is still there. Regards, Jürgen.

Re: [possible patch]: numerical citation fix

2004-05-07 Thread Juergen Spitzmueller
Angus Leeming wrote: > attached is a patch that should help ensure the above requirement. > It's actually just a refactoring of existing code, even though it > looks pretty frightening. No, it looks very reasonable and clean. Good idea! > If you'd be good enough to stress test it, that'd be

Re: [possible patch]: numerical citation fix

2004-05-07 Thread Juergen Spitzmueller
Angus Leeming wrote: > Doh! Wrong patch! That was the old one you've already commented on. Angus, it works very well. Now only the off-by-one error is still there. Regards, Jürgen.

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Juergen Spitzmueller
Angus Leeming wrote: Could you check it out, please? If all is well I guess that it can be backported to 1.3.x. Angus, the output of the first two entries in the combox is reversed. I.e., the first entry (labelled [#ID]), produces \citet, which is Name [#ID]. The second, labelled Name [#ID],

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Angus Leeming
Juergen Spitzmueller wrote: Angus Leeming wrote: Could you check it out, please? If all is well I guess that it can be backported to 1.3.x. Angus, the output of the first two entries in the combox is reversed. I.e., the first entry (labelled [#ID]), produces \citet, which is Name [#ID].

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Angus Leeming
Juergen Spitzmueller wrote: Finally, since jurabib does not support numerical styles, jurabib and numerical should be mutually exclusive (currently there is a problem when switching from Jurabib/numerical to natbib). Jürgen, attached is a patch that should help ensure the above requirement.

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Angus Leeming
Angus Leeming wrote: Jürgen, attached is a patch that should help ensure the above requirement. It's actually just a refactoring of existing code, even though it looks pretty frightening. Doh! Wrong patch! That was the old one you've already commented on. -- AngusIndex:

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Juergen Spitzmueller
Angus Leeming wrote: > Could you check it out, please? If all is well I guess that it can be > backported to 1.3.x. Angus, the output of the first two entries in the combox is reversed. I.e., the first entry (labelled [#ID]), produces \citet, which is "Name [#ID]". The second, labelled Name

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Angus Leeming
Juergen Spitzmueller wrote: > Angus Leeming wrote: >> Could you check it out, please? If all is well I guess that it can >> be backported to 1.3.x. > > Angus, the output of the first two entries in the combox is > reversed. I.e., the first entry (labelled [#ID]), produces \citet, > which is

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Angus Leeming
Juergen Spitzmueller wrote: > Finally, since jurabib does not support numerical styles, jurabib > and numerical should be mutually exclusive (currently there is a > problem when switching from Jurabib/numerical to natbib). Jürgen, attached is a patch that should help ensure the above

Re: [possible patch]: numerical citation fix

2004-05-06 Thread Angus Leeming
Angus Leeming wrote: > Jürgen, > > attached is a patch that should help ensure the above requirement. > It's actually just a refactoring of existing code, even though it > looks pretty frightening. Doh! Wrong patch! That was the old one you've already commented on. -- AngusIndex:

[possible patch]: numerical citation fix

2004-05-05 Thread Angus Leeming
Juergen, I think that this patch fixes a bug report of yours: when using natbib/jurabib and numerical citation style, it'd be nice if the first entry in the list of possible citations in the dialog was [#ID]. Could you check it out, please? If all is well I guess that it can be backported to

Re: [possible patch]: numerical citation fix

2004-05-05 Thread Juergen Spitzmueller
Angus Leeming wrote: Juergen, I think that this patch fixes a bug report of yours: when using natbib/jurabib and numerical citation style, it'd be nice if the first entry in the list of possible citations in the dialog was [#ID]. I didn't test it yet, But note that jurabib does not

Re: [possible patch]: numerical citation fix

2004-05-05 Thread Angus Leeming
Juergen Spitzmueller wrote: Could you check it out, please? If all is well I guess that it can be backported to 1.3.x. As soon as I return from Switzerland. Thanks. -- Angus

[possible patch]: numerical citation fix

2004-05-05 Thread Angus Leeming
Juergen, I think that this patch fixes a bug report of yours: when using natbib/jurabib and numerical citation style, it'd be nice if the first entry in the list of possible citations in the dialog was [#ID]. Could you check it out, please? If all is well I guess that it can be backported to

Re: [possible patch]: numerical citation fix

2004-05-05 Thread Juergen Spitzmueller
Angus Leeming wrote: > Juergen, > > I think that this patch fixes a bug report of yours: when using > natbib/jurabib and numerical citation style, it'd be nice if the > first entry in the list of possible citations in the dialog was > [#ID]. I didn't test it yet, But note that jurabib does not

Re: [possible patch]: numerical citation fix

2004-05-05 Thread Angus Leeming
Juergen Spitzmueller wrote: >> Could you check it out, please? If all is well I guess that it can >> be backported to 1.3.x. > As soon as I return from Switzerland. Thanks. -- Angus