Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt st.w...@gmx.net writes: Please refrain from using #defines. I do not think this particular one is useful. I know that defines are bad. But here I don't know how to make the used location clear. The alternative is a local const string in method pairstring,string

Re: Code Review: Next step to provide spellchecker with dictionaries included

On 5/28/2010 4:31 PM, Stephan Witt wrote: 3. system support directory - there will the shipped data files live. Is this the LyX library directory? So the dictionaries / thesaurus lists could be stored in e.g. Resources\dict and Resources\thes on Windows? Joost

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 02.06.2010 um 19:31 schrieb Joost Verburg: On 5/28/2010 4:31 PM, Stephan Witt wrote: 3. system support directory - there will the shipped data files live. Is this the LyX library directory? So the dictionaries / thesaurus lists could be stored in e.g. Resources\dict and Resources\thes

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt writes: >>> Please refrain from using #defines. I do not think this particular one >>> is useful. >> >> I know that defines are bad. But here I don't know how to make the used >> location clear. >> The alternative is a local const string in method >>

Re: Code Review: Next step to provide spellchecker with dictionaries included

On 5/28/2010 4:31 PM, Stephan Witt wrote: 3. system support directory - there will the shipped data files live. Is this the LyX library directory? So the dictionaries / thesaurus lists could be stored in e.g. "Resources\dict" and "Resources\thes" on Windows? Joost

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 02.06.2010 um 19:31 schrieb Joost Verburg: > On 5/28/2010 4:31 PM, Stephan Witt wrote: >> 3. system support directory - there will the shipped data files live. > > Is this the LyX library directory? So the dictionaries / thesaurus lists > could be stored in e.g. "Resources\dict" and

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt st.w...@gmx.net writes: The dictionaries are arch independent AFAIK. So the question is where to store and how to install them. The logical place would be lyx-devel/lib/dict and lyx-devel/lib/thes. But this is in SVN-tree... Installing them at this place does not mean that we

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt st.w...@gmx.net writes: I've prepared a patch to change hunspell and myThes wrappers to be ready for included dictionaries. Please have a look at the patch and point me to typos and thinkos. With the changes the binary searches the data files in this order: 1. user path from

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 31.05.2010 um 12:36 schrieb Jean-Marc LASGOUTTES: Stephan Witt st.w...@gmx.net writes: The dictionaries are arch independent AFAIK. So the question is where to store and how to install them. The logical place would be lyx-devel/lib/dict and lyx-devel/lib/thes. But this is in SVN-tree...

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 31.05.2010 um 14:37 schrieb Stephan Witt: Am 31.05.2010 um 13:00 schrieb Jean-Marc LASGOUTTES: Thanks for commenting! Stephan Witt st.w...@gmx.net writes: I've prepared a patch to change hunspell and myThes wrappers to be ready for included dictionaries. Please have a look at the

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt writes: > The dictionaries are arch independent AFAIK. So the question is where to > store and how to install them. > The logical place would be lyx-devel/lib/dict and lyx-devel/lib/thes. But > this is in SVN-tree... Installing them at this place does not mean

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt writes: > I've prepared a patch to change hunspell and myThes wrappers to be ready for > included dictionaries. > Please have a look at the patch and point me to typos and thinkos. > With the changes the binary searches the data files in this order: > 1. user path

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 31.05.2010 um 12:36 schrieb Jean-Marc LASGOUTTES: > Stephan Witt writes: >> The dictionaries are arch independent AFAIK. So the question is where to >> store and how to install them. >> The logical place would be lyx-devel/lib/dict and lyx-devel/lib/thes. But >> this is in

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 31.05.2010 um 14:37 schrieb Stephan Witt: > Am 31.05.2010 um 13:00 schrieb Jean-Marc LASGOUTTES: > > Thanks for commenting! > >> Stephan Witt writes: >>> I've prepared a patch to change hunspell and myThes wrappers to be ready >>> for included dictionaries. >>> Please have

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 29.05.2010 um 02:02 schrieb Pavel Sanda: Stephan Witt wrote: The next steps on my agenda are * dictionary collection this is mac only thing or other archs need something similar? The dictionaries are arch independent AFAIK. So the question is where to store and how to install them. The

Re: Code Review: Next step to provide spellchecker with dictionaries included

Am 29.05.2010 um 02:02 schrieb Pavel Sanda: > Stephan Witt wrote: >> The next steps on my agenda are >> * dictionary collection > > this is mac only thing or other archs need something similar? The dictionaries are arch independent AFAIK. So the question is where to store and how to install

Code Review: Next step to provide spellchecker with dictionaries included

Dear LyX developers, I've prepared a patch to change hunspell and myThes wrappers to be ready for included dictionaries. Please have a look at the patch and point me to typos and thinkos. With the changes the binary searches the data files in this order: 1. user path from configuration 2. user

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt wrote: The next steps on my agenda are * dictionary collection this is mac only thing or other archs need something similar? +#define MAX_SELECTOR 3 +string dictPath(int selector) +{ + switch (selector) { + case 2: return

Code Review: Next step to provide spellchecker with dictionaries included

Dear LyX developers, I've prepared a patch to change hunspell and myThes wrappers to be ready for included dictionaries. Please have a look at the patch and point me to typos and thinkos. With the changes the binary searches the data files in this order: 1. user path from configuration 2. user

Re: Code Review: Next step to provide spellchecker with dictionaries included

Stephan Witt wrote: > The next steps on my agenda are > * dictionary collection this is mac only thing or other archs need something similar? > +#define MAX_SELECTOR 3 > +string dictPath(int selector) > +{ > + switch (selector) { > + case 2: return >