Here are two further patches to clean up the code:
* local_bidi.patch: The bidi object in the class Text is only used in
places now where a ParagraphMetrics::computeRowMetrics call comes
before. And this function the Bidi object is updated. So it is a
little step now to remove the
On Thursday 07 June 2007 21:01:10 Stefan Schimanski wrote:
Here are two further patches to clean up the code:
* local_bidi.patch: The bidi object in the class Text is only used in
places now where a ParagraphMetrics::computeRowMetrics call comes
before. And this function the Bidi object is
Here are two further patches to clean up the code:
* local_bidi.patch: The bidi object in the class Text is only used in
places now where a ParagraphMetrics::computeRowMetrics call comes
before. And this function the Bidi object is updated. So it is a
little step now to remove the
On Thursday 07 June 2007 21:01:10 Stefan Schimanski wrote:
> Here are two further patches to clean up the code:
>
> * local_bidi.patch: The bidi object in the class Text is only used in
> places now where a ParagraphMetrics::computeRowMetrics call comes
> before. And this function the Bidi object
The reason for the crash:
Index: src/Cursor.cpp
===
--- src/Cursor.cpp (Revision 18674)
+++ src/Cursor.cpp (Arbeitskopie)
@@ -1438,18 +1438,33 @@
Font Cursor::getFont() const
{
+ // The logic here should more or less
One relevant point from there to here, though: I'm not sure you'll
be able to do away with bidi entirely. For example, as I suggest in
that thread, for visual mode I think we'll have to use vis2log
and log2vis. And once we're using anything Bidi related in cursor
movement, we'll have to
The updated patches, to be applied in this order:
no_bidi_isboundary.patch
no_bidi_setcurrentfont.patch
no_bidi_setcurrentfont.patch
Description: Binary data
no_bidi_isboundary.patch
Description: Binary data
As suggested by Dov, the discussion about spaces around RTL/LTR will
be
On Wednesday 06 June 2007 10:17:42 Stefan Schimanski wrote:
As suggested by Dov, the discussion about spaces around RTL/LTR will
be continued in the other thread. I have also posted these two
patches there because the following RTL advances are based on this.
Stefan
OK.
--
José Abílio
Stefan Schimanski wrote:
The updated patches, to be applied in this order:
no_bidi_isboundary.patch
no_bidi_setcurrentfont.patch
As suggested by Dov, the discussion about spaces around RTL/LTR will be
continued in the other thread. I have also posted these two patches
there because the
The reason for the crash:
Index: src/Cursor.cpp
===
--- src/Cursor.cpp (Revision 18674)
+++ src/Cursor.cpp (Arbeitskopie)
@@ -1438,18 +1438,33 @@
Font Cursor::getFont() const
{
+ // The logic here should more or less
One relevant point from there to here, though: I'm not sure you'll
be able to do away with bidi entirely. For example, as I suggest in
that thread, for "visual mode" I think we'll have to use vis2log
and log2vis. And once we're using anything Bidi related in cursor
movement, we'll have to
The updated patches, to be applied in this order:
no_bidi_isboundary.patch
no_bidi_setcurrentfont.patch
no_bidi_setcurrentfont.patch
Description: Binary data
no_bidi_isboundary.patch
Description: Binary data
As suggested by Dov, the discussion about spaces around RTL/LTR will
be
On Wednesday 06 June 2007 10:17:42 Stefan Schimanski wrote:
> As suggested by Dov, the discussion about spaces around RTL/LTR will
> be continued in the other thread. I have also posted these two
> patches there because the following RTL advances are based on this.
>
> Stefan
OK.
--
José
Stefan Schimanski wrote:
The updated patches, to be applied in this order:
no_bidi_isboundary.patch
no_bidi_setcurrentfont.patch
As suggested by Dov, the discussion about spaces around RTL/LTR will be
continued in the other thread. I have also posted these two patches
there because the
Hi!
Before playing the patchwork game again in fixing the bugs in the
subject and, without noticing, introducing a hand full new bugs, here
are some patches which clean up the bidi mess:
The Bidi class mainly offers the isBoundary method whose use is
spread over the LyX code.
Stefan Schimanski wrote:
Hi!
Before playing the patchwork game again in fixing the bugs in the
subject and, without noticing, introducing a hand full new bugs, here
are some patches which clean up the bidi mess:
The Bidi class mainly offers the isBoundary method whose use is spread
over
Stefan Schimanski wrote:
Hi!
Before playing the patchwork game again in fixing the bugs in the
subject and, without noticing, introducing a hand full new bugs, here
are some patches which clean up the bidi mess:
I'm getting a crash as soon as I try typing in to a new document with
these
So the only clean approach is to rip out all bidi references from the code
and finally use the
Font information of each position which also holds the RTL/LTR flag. This is
done by nobidi.patch
(see below).
I don't know the details but I agree that bidi references should be kicked out as
I'm getting a crash as soon as I try typing in to a new document with these
patches... trace
attached. (I may have misapplied the patches, see my last remark below...)
I don't gsee this. But I must admit that I needed some time until I figured out the correct order of
applying the patches
Hi!
Before playing the patchwork game again in fixing the bugs in the
subject and, without noticing, introducing a hand full new bugs, here
are some patches which clean up the bidi mess:
The Bidi class mainly offers the isBoundary method whose use is
spread over the LyX code.
Stefan Schimanski wrote:
Hi!
Before playing the patchwork game again in fixing the bugs in the
subject and, without noticing, introducing a hand full new bugs, here
are some patches which clean up the bidi mess:
The Bidi class mainly offers the isBoundary method whose use is spread
over
Stefan Schimanski wrote:
Hi!
Before playing the patchwork game again in fixing the bugs in the
subject and, without noticing, introducing a hand full new bugs, here
are some patches which clean up the bidi mess:
I'm getting a crash as soon as I try typing in to a new document with
these
> So the only clean approach is to rip out all bidi references from the code
and finally use the
> Font information of each position which also holds the RTL/LTR flag. This is
done by nobidi.patch
> (see below).
I don't know the details but I agree that bidi references should be kicked out as
> I'm getting a crash as soon as I try typing in to a new document with these
patches... trace
> attached. (I may have misapplied the patches, see my last remark below...)
I don't gsee this. But I must admit that I needed some time until I figured out the correct order of
applying the patches
24 matches
Mail list logo
