Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
R. Lahaye wrote: Disallowing the wide toggle when in one-column mode, would very annoying in this context. Please don't! Does that make sense? Yes. I won't disable wide floats in one column mode. But I have disabled h[ere], b[ottom] and H[ere, definitely] for wide floats because the first

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Dekel Tsur wrote: No. For the following, assume that the default placement is 'tbp'. There should be a distinction between specifying I want to use the default placement, even if I change it, I don't understand this sentence. and I want to use 'tbp' placement, even if I change the default

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Dekel Tsur
On Thu, Jul 25, 2002 at 10:21:38AM +0200, Juergen Spitzmueller wrote: Dekel Tsur wrote: No. For the following, assume that the default placement is 'tbp'. There should be a distinction between specifying I want to use the default placement, even if I change it, I don't understand this

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Dekel Tsur wrote: Because latex has such a distinction. I can use either \begin{float} or \begin{float}[tbp] OK, I see the reason for this checkbox. Actually, I'd prefer two buttons: Float Default for the default of the specific float and Document Default for the value set in

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: | They will probably complain because now they need to use the mouse to | obtain wide floats. BTW should the default be 'wide' or not? We need lfuns to change float parameters. GUI dialogs should not really be needed to accomplish this. --

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Juergen Spitzmueller) writes: | Attached is a patch which renames Wide to Span multiple columns, | includes Is it span all or span some? It is all, right? then it should be Span all columns -- Lgb

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: Is it span all or span some? It is all, right? then it should be Span all columns Yes, although I read that they won't work with multicolumn, so it's two columns. But I'll change it. Thanks, Juergen

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Herbert Voss
Lars Gullik Bjønnes wrote: [EMAIL PROTECTED] (Juergen Spitzmueller) writes: | Attached is a patch which renames Wide to Span multiple columns, | includes Is it span all or span some? It is all, right? then it should be Span all columns I spend you a beer, when you can create a float

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: Did you take a look at http://bugzilla.lyx.org/show_bug.cgi?id=394 It would be nice to apply in some form the patch which is there. I planned at some time to add it to 1.2.x, but I never did it (I remember there was something I did not like, but what??). Hang on

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Kuba Ober
I am not sure that Wide Float is the best description of the checkbox. Firstly Wide float would be better, but anyway I am not sure everybody will understand what it does. What about span whole width or something similar which looks english? Or do people think that Wide float is explicit

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
R. Lahaye wrote: > Disallowing the wide toggle when in one-column mode, would very > annoying in this context. Please don't! > > Does that make sense? Yes. I won't disable wide floats in one column mode. But I have disabled h[ere], b[ottom] and H[ere, definitely] for wide floats because the

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Dekel Tsur wrote: > No. For the following, assume that the default placement is 'tbp'. > There should be a distinction between specifying > "I want to use the default placement, even if I change it", I don't understand this sentence. > and "I want to use 'tbp' placement, even if I change the

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Dekel Tsur
On Thu, Jul 25, 2002 at 10:21:38AM +0200, Juergen Spitzmueller wrote: > Dekel Tsur wrote: > > No. For the following, assume that the default placement is 'tbp'. > > There should be a distinction between specifying > > "I want to use the default placement, even if I change it", > > I don't

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Dekel Tsur wrote: > Because latex has such a distinction. > I can use either \begin{float} or \begin{float}[tbp] OK, I see the reason for this checkbox. > > Actually, I'd prefer two buttons: "Float Default" for the default of the > > specific float and "Document Default" for the value set in >

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | They will probably complain because now they need to use the mouse to | obtain wide floats. BTW should the default be 'wide' or not? We need lfuns to change float parameters. GUI dialogs should not really be needed to accomplish this. --

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Lars Gullik Bjønnes
[EMAIL PROTECTED] (Juergen Spitzmueller) writes: | Attached is a patch which renames "Wide" to "Span multiple columns", | includes Is it "span all" or "span some"? It is "all", right? then it should be "Span all columns" -- Lgb

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Lars Gullik Bjønnes wrote: > Is it "span all" or "span some"? > It is "all", right? then it should be "Span all columns" Yes, although I read that they won't work with multicolumn, so it's two columns. But I'll change it. Thanks, Juergen

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Herbert Voss
Lars Gullik Bjønnes wrote: > [EMAIL PROTECTED] (Juergen Spitzmueller) writes: > > | Attached is a patch which renames "Wide" to "Span multiple columns", > | includes > > Is it "span all" or "span some"? > It is "all", right? then it should be "Span all columns" I spend you a beer, when you

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > Did you take a look at > http://bugzilla.lyx.org/show_bug.cgi?id=394 > > It would be nice to apply in some form the patch which is there. I > planned at some time to add it to 1.2.x, but I never did it (I > remember there was something I did not like, but what??).

Re: Fwd: [PATCH] wide float toggle

2002-07-25 Thread Kuba Ober
> I am not sure that "Wide Float" is the best description of the > checkbox. Firstly "Wide float" would be better, but anyway I am not > sure everybody will understand what it does. > > What about "span whole width" or something similar which looks > english? > > Or do people think that "Wide

Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Please check the controller stuff. This is new land to me... There's one problem and a few questions left, though: The problem: After changing the type from wide to normal or vice versa, the inset button (label) gets not updated immediately. I guess an update call is needed. Can someone have a

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Angus Leeming
On Wednesday 24 July 2002 3:10 pm, Juergen Spitzmueller wrote: Please check the controller stuff. This is new land to me... There's one problem and a few questions left, though: The problem: After changing the type from wide to normal or vice versa, the inset button (label) gets not

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Angus Leeming wrote: You mean the label to the button in the LyX view? Yes. Try void ControlFloat::applyParamsToInset() { inset()-placement(params().placement); + inset()-wide(params().wide); + lv_.view()-updateInset(inset(), true); } ControlFloat.C: In method `void

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Angus Leeming
On Wednesday 24 July 2002 3:41 pm, Juergen Spitzmueller wrote: Angus Leeming wrote: ControlFloat.C: In method `void ControlFloat::applyParamsToInset()': ControlFloat.C:30: invalid use of undefined type `class BufferView' ../../../src/lyxgluelength.h:23: forward declaration of `class

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Questions: - I've read in a german float-doc (from Axel Juergen Reichert) that the [h]-option is not allowed with *-floats. Juergen Can someone confirm this? If so, we should take this into Juergen account. How was the

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Angus Leeming wrote: #include BufferView.h Perfect. Thanks. Updated patch attached. Juergen Index: src/frontends/controllers/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/controllers/ChangeLog,v retrieving revision

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Am Mittwoch, 24. Juli 2002 16:38 schrieb Jean-Marc Lasgouttes: Juergen Questions: - I've read in a german float-doc (from Axel Juergen Reichert) that the [h]-option is not allowed with *-floats. Juergen Can someone confirm this? If so, we should take this into Juergen account. How was the

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Angus Leeming wrote: #include BufferView.h Juergen Perfect. Thanks. Updated patch attached. Excellent. I'll apply it. JMarc

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: Juergen Angus Leeming wrote: #include BufferView.h Juergen Perfect. Thanks. Updated patch attached. I applied the patch and remove the extra (wide) entries in the InsertFloat menu. We should maybe have shortcuts there... I'll have a

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: I am not sure that Wide Float is the best description of the checkbox. Firstly Wide float would be better, but anyway I am not sure everybody will understand what it does. Agreed. Personally I didn't get this for a long time. What about span whole width or

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
Juergen == Juergen Spitzmueller [EMAIL PROTECTED] writes: What about span whole width or something similar which looks english? Juergen What about span all columns because that is what they Juergen actually are for. Does this mean that it should be disabled when in one-column mode? This is

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: Juergen What about span all columns because that is what they Juergen actually are for. Does this mean that it should be disabled when in one-column mode? This is limiting from latex point of view, but it seems better in terms of intuitiveness. Are there many

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes: Jürgen IMHO the minipage placement is unrelated (and different) to Jürgen that. You are right, of course. JMarc

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
Jürgen == Jürgen Spitzmüller [EMAIL PROTECTED] writes: Did you take a look at http://bugzilla.lyx.org/show_bug.cgi?id=394 It would be nice to apply in some form the patch which is there. I planned at some time to add it to 1.2.x, but I never did it (I remember there was something I did

[PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Dekel Tsur wrote: The harm is that users who don't know latex will be confused by the outcome. I suggest that selecting wide float should disable the here and bottom buttons, but add an expert mode button (either in the float dialog, on in the preferences dialog) that will allow enabling them

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Dekel Tsur
Dekel, I have had a look at your patch for #394. IMHO better than a default checkbox would be a default-button which sets the placement checkboxes to the default values (more informative to the user). Also the default placement should be initially set for new floats. But I don't know how to

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread R. Lahaye
Jean-Marc Lasgouttes writes: Are there many people out there who like to mark their floats as narrow/wide although they are in a one-column document (probably because the doc will become two-columns later)? YES, YES. For example when writing papers for journals. The first submission for

Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Please check the controller stuff. This is new land to me... There's one problem and a few questions left, though: The problem: After changing the type from wide to normal or vice versa, the inset button (label) gets not updated immediately. I guess an update call is needed. Can someone have a

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Angus Leeming
On Wednesday 24 July 2002 3:10 pm, Juergen Spitzmueller wrote: > Please check the controller stuff. This is new land to me... > > There's one problem and a few questions left, though: > > The problem: > After changing the type from wide to normal or vice versa, the inset button > (label) gets not

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Angus Leeming wrote: > You mean the label to the button in the LyX view? Yes. > Try > > void ControlFloat::applyParamsToInset() > { > inset()->placement(params().placement); > + inset()->wide(params().wide); > + lv_.view()->updateInset(inset(), true); > } ControlFloat.C: In

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Angus Leeming
On Wednesday 24 July 2002 3:41 pm, Juergen Spitzmueller wrote: > Angus Leeming wrote: > ControlFloat.C: In method `void ControlFloat::applyParamsToInset()': > ControlFloat.C:30: invalid use of undefined type `class BufferView' > ../../../src/lyxgluelength.h:23: forward declaration of `class

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Questions: - I've read in a german float-doc (from Axel Juergen> Reichert) that the [h]-option is not allowed with *-floats. Juergen> Can someone confirm this? If so, we should take this into Juergen> account. How was

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Angus Leeming wrote: > #include "BufferView.h" Perfect. Thanks. Updated patch attached. Juergen Index: src/frontends/controllers/ChangeLog === RCS file: /cvs/lyx/lyx-devel/src/frontends/controllers/ChangeLog,v retrieving revision

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Am Mittwoch, 24. Juli 2002 16:38 schrieb Jean-Marc Lasgouttes: > Juergen> Questions: - I've read in a german float-doc (from Axel > Juergen> Reichert) that the [h]-option is not allowed with *-floats. > Juergen> Can someone confirm this? If so, we should take this into > Juergen> account. > > How

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Angus Leeming wrote: >> #include "BufferView.h" Juergen> Perfect. Thanks. Updated patch attached. Excellent. I'll apply it. JMarc

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: Juergen> Angus Leeming wrote: >> #include "BufferView.h" Juergen> Perfect. Thanks. Updated patch attached. I applied the patch and remove the extra (wide) entries in the Insert>Float menu. We should maybe have shortcuts

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Jean-Marc Lasgouttes wrote: > I am not sure that "Wide Float" is the best description of the > checkbox. Firstly "Wide float" would be better, but anyway I am not > sure everybody will understand what it does. Agreed. Personally I didn't get this for a long time. > What about "span whole width"

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
> "Juergen" == Juergen Spitzmueller <[EMAIL PROTECTED]> writes: >> What about "span whole width" or something similar which looks >> english? Juergen> What about "span all columns" because that is what they Juergen> actually are for. Does this mean that it should be disabled when in

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Juergen> What about "span all columns" because that is what they > Juergen> actually are for. > > Does this mean that it should be disabled when in one-column mode? > This is limiting from latex point of view, but it seems better in > terms of intuitiveness. Are

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: Jürgen> IMHO the minipage placement is unrelated (and different) to Jürgen> that. You are right, of course. JMarc

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Jean-Marc Lasgouttes
> "Jürgen" == Jürgen Spitzmüller <[EMAIL PROTECTED]> writes: >> Did you take a look at http://bugzilla.lyx.org/show_bug.cgi?id=394 >> It would be nice to apply in some form the patch which is there. I >> planned at some time to add it to 1.2.x, but I never did it (I >> remember there was

[PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Juergen Spitzmueller
Dekel Tsur wrote: > The harm is that users who don't know latex will be confused by the > outcome. I suggest that selecting wide float should disable the "here" and > "bottom" buttons, but add an "expert mode" button (either in the float > dialog, on in the preferences dialog) that will allow

Re: [PATCH 2] Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread Dekel Tsur
> Dekel, I have had a look at your patch for #394. IMHO better than a "default > checkbox would be a "default"-button which sets the placement checkboxes to > the default values (more informative to the user). Also the default placement > should be initially set for new floats. But I don't know

Re: Fwd: [PATCH] wide float toggle

2002-07-24 Thread R. Lahaye
Jean-Marc Lasgouttes writes: > > Are there many people out there who like to > mark their floats as narrow/wide although they are in a one-column > document (probably because the doc will become two-columns later)? YES, YES. For example when writing papers for journals. The first submission for