Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 18.32.14 WET José Abílio Matos wrote: > In any case I found other cases where the code is wrong (like the BOM > removal that does not work) and that it does not give an error although it > is wrong. For future reference this is an issue that happens silently. In this

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 16.02.51 WET Pavel Sanda wrote: > On Mon, Jan 03, 2022 at 03:16:47PM +, José Abílio Matos wrote: > > If you want I can take care of that, in 2.4, and see if there are cases > > where the conversion is missing. > > Please do, I suffer from ophidiophobia. You keep

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread Pavel Sanda
On Mon, Jan 03, 2022 at 03:16:47PM +, José Abílio Matos wrote: > If you want I can take care of that, in 2.4, and see if there are cases where > the conversion is missing. Please do, I suffer from ophidiophobia. > @Riki: is it possible to have a layout file such that the encoding is not >

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Monday, 3 January 2022 14.55.53 WET Pavel Sanda wrote: > If I get that right the part of the "..." -> b"..." should be committed to > 2.4? > > Pavel Good point. Yes, it should (I thought that it already was) specially in order to be consistent with all the other code that already does that.

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread Pavel Sanda
On Mon, Jan 03, 2022 at 02:04:20PM +, José Abílio Matos wrote: > Looking into further detail I would easily that the first part of the patch > is > correct (change "..." to b"..."). > > The second part where it changes sys.stdin to sys.stdin.buffer is probably > incorrect: > > The similar

Re: Fwd: String/Bytes Problem in layout2layout.py

2022-01-03 Thread José Abílio Matos
On Wednesday, 29 December 2021 14.52.29 WET Pavel Sanda wrote: > Jose, > > are the proposed changes sensible? > I remember there were flowing similar patches to python codebase before. The changes are reasonable for python 3. I am not so sure about python 2 (because we support it) although it

Fwd: String/Bytes Problem in layout2layout.py

2021-12-29 Thread Pavel Sanda
Jose, are the proposed changes sensible? I remember there were flowing similar patches to python codebase before. Pavel - Forwarded message from "Leo L. Schwab" - From: "Leo L. Schwab" To: Debian Bug Tracking System Subject: Bug#1002821: lyx-common: String/Bytes Problem in