Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Jürgen Spitzmüller
Bo Peng wrote: A 'better' fix has been committed, but there is still a problem of copy/paste table cells. Do we have a bugzilla entry? Sorry for asking, I'm still trying to catch up ... Jürgen

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Darren Freeman
On Mon, 2007-08-27 at 08:28 +0200, Jürgen Spitzmüller wrote: Bo Peng wrote: A 'better' fix has been committed, but there is still a problem of copy/paste table cells. Do we have a bugzilla entry? Sorry for asking, I'm still trying to catch up ... I started the thread, but due to

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Jürgen Spitzmüller
Darren Freeman wrote: So no, not to my knowledge. There is a simple patch under test. Could you create a bugzilla entry and upload the patch there, please? Jürgen

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Darren Freeman
On Mon, 2007-08-27 at 10:08 +0200, Jürgen Spitzmüller wrote: Darren Freeman wrote: There is a simple patch under test. Could you create a bugzilla entry and upload the patch there, please? http://bugzilla.lyx.org/show_bug.cgi?id=4173 Have fun, Darren

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Jürgen Spitzmüller
Bo Peng wrote: > A 'better' fix has been committed, but there is still a problem of > copy/paste table cells. Do we have a bugzilla entry? Sorry for asking, I'm still trying to catch up ... Jürgen

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Darren Freeman
On Mon, 2007-08-27 at 08:28 +0200, Jürgen Spitzmüller wrote: > Bo Peng wrote: > > A 'better' fix has been committed, but there is still a problem of > > copy/paste table cells. > > Do we have a bugzilla entry? Sorry for asking, I'm still trying to catch > up ... I started the thread, but due to

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Jürgen Spitzmüller
Darren Freeman wrote: > So no, not to my knowledge. > > There is a simple patch under test. Could you create a bugzilla entry and upload the patch there, please? Jürgen

Re: Middle-click copy-paste borked in SVN

2007-08-27 Thread Darren Freeman
On Mon, 2007-08-27 at 10:08 +0200, Jürgen Spitzmüller wrote: > Darren Freeman wrote: > > There is a simple patch under test. > > Could you create a bugzilla entry and upload the patch there, please? http://bugzilla.lyx.org/show_bug.cgi?id=4173 Have fun, Darren

Re: Middle-click copy-paste borked in SVN

2007-08-26 Thread Jürgen Spitzmüller
Bo Peng wrote: Done. No status.15x is needed, and no trunk because a better fix will be applied later. What is the status of this? Is a better fix available? Jürgen

Re: Middle-click copy-paste borked in SVN

2007-08-26 Thread Bo Peng
On 8/26/07, Jürgen Spitzmüller [EMAIL PROTECTED] wrote: Bo Peng wrote: Done. No status.15x is needed, and no trunk because a better fix will be applied later. What is the status of this? Is a better fix available? A 'better' fix has been committed, but there is still a problem of

Re: Middle-click copy-paste borked in SVN

2007-08-26 Thread Jürgen Spitzmüller
Bo Peng wrote: > Done. No status.15x is needed, and no trunk because a better fix will > be applied later. What is the status of this? Is a better fix available? Jürgen

Re: Middle-click copy-paste borked in SVN

2007-08-26 Thread Bo Peng
On 8/26/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: > Bo Peng wrote: > > Done. No status.15x is needed, and no trunk because a better fix will > > be applied later. > > What is the status of this? Is a better fix available? A 'better' fix has been committed, but there is still a problem of

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
Bo Peng [EMAIL PROTECTED] writes: Here is the fix I would propose. It ensures that the cursor is set through BufferView::mouseSetCursor, so that the selection is always tracked correctly. The patch is a little longer because I used the occasion to slightly cleanup the code (I do not think the

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
Richard Heck [EMAIL PROTECTED] writes: Would it be possible to get 2304 taken care of here? I.e., shift+mouse selects from old location to new location? That must be right here. We'll keep that for later. JMarc

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
Did you manage to test it? Still testing, but 1. open doc/UserGuide.lyx 2. go to the table before 4.4.1 3. select mul, select 45, middle button pastes mul. The same holds for math formula. In E=mc^2, select m, select = , paste m. Bo

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
Two saveSelection at MousePressed should fix them, right? I guess your better solution can be introduced later. I mean the following patch. It does not make sense to release 1.5.1 without this simple fix. Can I apply? Bo Index: src/insets/InsetTabular.cpp

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
Bo Peng [EMAIL PROTECTED] writes: Two saveSelection at MousePressed should fix them, right? I guess your better solution can be introduced later. I mean the following patch. It does not make sense to release 1.5.1 without this simple fix. Can I apply? OK, but with FIXMEs. JMarc

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
OK, but with FIXMEs. Done. No status.15x is needed, and no trunk because a better fix will be applied later. Bo

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
Bo Peng [EMAIL PROTECTED] writes: Did you manage to test it? Still testing, but 1. open doc/UserGuide.lyx 2. go to the table before 4.4.1 3. select mul, select 45, middle button pastes mul. The same holds for math formula. In E=mc^2, select m, select = , paste m. I looked at the two

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
I looked at the two code chunks and I know why it happens. I will skip this for 1.5.1 though, since I want to release fast. Two saveSelection at MousePressed should fix them, right? I guess your better solution can be introduced later. Anyway, it is your decision... Bo

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
Bo Peng [EMAIL PROTECTED] writes: OK, but with FIXMEs. Done. No status.15x is needed, and no trunk because a better fix will be applied later. Thanks. JMarc

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> Here is the fix I would propose. It ensures that the cursor is set >> through BufferView::mouseSetCursor, so that the selection is always >> tracked correctly. The patch is a little longer because I used the >> occasion to slightly cleanup the code (I do

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
Richard Heck <[EMAIL PROTECTED]> writes: > Would it be possible to get 2304 taken care of here? I.e., shift+mouse > selects from old location to new location? That must be right here. We'll keep that for later. JMarc

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
> Did you manage to test it? Still testing, but 1. open doc/UserGuide.lyx 2. go to the table before 4.4.1 3. select mul, select 45, middle button pastes mul. The same holds for math formula. In E=mc^2, select m, select = , paste m. Bo

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
> Two saveSelection at MousePressed should fix them, right? I guess your > better solution can be introduced later. I mean the following patch. It does not make sense to release 1.5.1 without this simple fix. Can I apply? Bo Index: src/insets/InsetTabular.cpp

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> Two saveSelection at MousePressed should fix them, right? I guess your >> better solution can be introduced later. > > I mean the following patch. It does not make sense to release 1.5.1 > without this simple fix. Can I apply? OK, but with FIXMEs. JMarc

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
> OK, but with FIXMEs. Done. No status.15x is needed, and no trunk because a better fix will be applied later. Bo

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> Did you manage to test it? > > Still testing, but > > 1. open doc/UserGuide.lyx > 2. go to the table before 4.4.1 > 3. select mul, select 45, middle button pastes mul. > > The same holds for math formula. In E=mc^2, select m, select = , paste m. I looked

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Bo Peng
> I looked at the two code chunks and I know why it happens. I will skip > this for 1.5.1 though, since I want to release fast. Two saveSelection at MousePressed should fix them, right? I guess your better solution can be introduced later. Anyway, it is your decision... Bo

Re: Middle-click copy-paste borked in SVN

2007-08-03 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> OK, but with FIXMEs. > > Done. No status.15x is needed, and no trunk because a better fix will > be applied later. Thanks. JMarc

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jean-Marc Lasgouttes
Bo Peng [EMAIL PROTECTED] writes: Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. I submitted a quick fix (r19199). It can be reverted if JMarc has some better idea. Here is the fix I would propose. It ensures that the cursor is set through

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: Bo, Juergen, José? Fine with me. If Bo agrees, you can commit to branch (Ha!). Jürgen

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Bo Peng
I submitted a quick fix (r19199). It can be reverted if JMarc has some better idea. Here is the fix I would propose. It ensures that the cursor is set through BufferView::mouseSetCursor, so that the selection is always tracked correctly. The patch is a little longer because I used the

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jean-Marc Lasgouttes
Bo Peng [EMAIL PROTECTED] writes: Please commit to trunk so that it can be thoroughly tested. I did so. All comments are welcome (especially since the code path is not exactly as it was). In particular, I got rid of paset_internally because it does not seem useful anymore, but this might have

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: Jean-Marc Lasgouttes wrote: Bo, Juergen, José? Fine with me. If Bo agrees, you can commit to branch (Ha!). I committed to trunk for now, master. JMarc

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: I committed to trunk for now, master. Well done, son. Jürgen

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Richard Heck
Jean-Marc Lasgouttes wrote: Bo Peng [EMAIL PROTECTED] writes: Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. I submitted a quick fix (r19199). It can be reverted if JMarc has some better idea. Here is the fix I would propose. It ensures that

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: >> Jose, can you wait a bit for the fix of this one? Should be a one >> liner somewhere. > > I submitted a quick fix (r19199). It can be reverted if JMarc has some > better idea. Here is the fix I would propose. It ensures that the cursor is set through

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > Bo, Juergen, José? Fine with me. If Bo agrees, you can commit to branch (Ha!). Jürgen

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Bo Peng
> > I submitted a quick fix (r19199). It can be reverted if JMarc has some > > better idea. > > Here is the fix I would propose. It ensures that the cursor is set > through BufferView::mouseSetCursor, so that the selection is always > tracked correctly. The patch is a little longer because I used

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jean-Marc Lasgouttes
"Bo Peng" <[EMAIL PROTECTED]> writes: > Please commit to trunk so that it can be thoroughly tested. I did so. All comments are welcome (especially since the code path is not exactly as it was). In particular, I got rid of paset_internally because it does not seem useful anymore, but this might

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: > Jean-Marc Lasgouttes wrote: >> Bo, Juergen, José? > > Fine with me. If Bo agrees, you can commit to branch (Ha!). I committed to trunk for now, master. JMarc

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Jürgen Spitzmüller
Jean-Marc Lasgouttes wrote: > I committed to trunk for now, master. Well done, son. Jürgen

Re: Middle-click copy-paste borked in SVN

2007-07-31 Thread Richard Heck
Jean-Marc Lasgouttes wrote: "Bo Peng" <[EMAIL PROTECTED]> writes: Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. I submitted a quick fix (r19199). It can be reverted if JMarc has some better idea. Here is the fix I would propose. It ensures

Middle-click copy-paste borked in SVN

2007-07-24 Thread Darren Freeman
Hi all, I noticed this a few days ago but haven't been actively using. This is all within LyX, no external apps. When I copy and paste something, and then select something else and middle-click paste, I get the earlier selection pasted as though the current selection has no effect. Can anyone

Re: Middle-click copy-paste borked in SVN

2007-07-24 Thread Bo Peng
Can anyone else reproduce? Yes. I can. Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. JMarc? Bo

Re: Middle-click copy-paste borked in SVN

2007-07-24 Thread Bo Peng
Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. I submitted a quick fix (r19199). It can be reverted if JMarc has some better idea. Bo Index: src/Text3.cpp === --- src/Text3.cpp (revision

Middle-click copy-paste borked in SVN

2007-07-24 Thread Darren Freeman
Hi all, I noticed this a few days ago but haven't been actively using. This is all within LyX, no external apps. When I copy and paste something, and then select something else and middle-click paste, I get the earlier selection pasted as though the current selection has no effect. Can anyone

Re: Middle-click copy-paste borked in SVN

2007-07-24 Thread Bo Peng
Can anyone else reproduce? Yes. I can. Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. JMarc? Bo

Re: Middle-click copy-paste borked in SVN

2007-07-24 Thread Bo Peng
Jose, can you wait a bit for the fix of this one? Should be a one liner somewhere. I submitted a quick fix (r19199). It can be reverted if JMarc has some better idea. Bo Index: src/Text3.cpp === --- src/Text3.cpp (revision