Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-29 Thread Stephan Witt
Am 27.11.2010 um 23:13 schrieb Stephan Witt: Am 27.11.2010 um 21:13 schrieb Stephan Witt: Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead of count_

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-29 Thread Stephan Witt
Am 27.11.2010 um 23:13 schrieb Stephan Witt: > Am 27.11.2010 um 21:13 schrieb Stephan Witt: > >> Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: >> >>> Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead

PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
I cannot see why on_replacePB_clicked is so different from on_replaceAllPB_clicked. Does anybody have an explanation? The attached patch would simplify on_replacePB_clicked a lot and works. Stephan Index: src/frontends/qt4/GuiSpellchecker.cpp

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Jean-Marc Lasgouttes
Le 27/11/2010 16:05, Stephan Witt a écrit : I cannot see why on_replacePB_clicked is so different from on_replaceAllPB_clicked. Does anybody have an explanation? The attached patch would simplify on_replacePB_clicked a lot and works. I complicated an already existing code in order to be able

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 18:02 schrieb Jean-Marc Lasgouttes: Le 27/11/2010 16:05, Stephan Witt a écrit : I cannot see why on_replacePB_clicked is so different from on_replaceAllPB_clicked. Does anybody have an explanation? The attached patch would simplify on_replacePB_clicked a lot and works. I

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 18:53 schrieb Stephan Witt: Am 27.11.2010 um 18:02 schrieb Jean-Marc Lasgouttes: Le 27/11/2010 16:05, Stephan Witt a écrit : I cannot see why on_replacePB_clicked is so different from on_replaceAllPB_clicked. Does anybody have an explanation? The attached patch would

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Jean-Marc Lasgouttes
Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead of count_ manipulation skip over replaced word 3. correct the absolute word count Better? I cannot tell. This code is very fragile (although better than in 1.6), only

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead of count_ manipulation skip over replaced word 3. correct the absolute word count Better? I cannot tell. This

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 21:13 schrieb Stephan Witt: Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead of count_ manipulation skip over replaced word 3. correct the

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 21:13 schrieb Stephan Witt: Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead of count_ manipulation skip over replaced word 3. correct the

PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
I cannot see why on_replacePB_clicked is so different from on_replaceAllPB_clicked. Does anybody have an explanation? The attached patch would simplify on_replacePB_clicked a lot and works. Stephan Index: src/frontends/qt4/GuiSpellchecker.cpp

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Jean-Marc Lasgouttes
Le 27/11/2010 16:05, Stephan Witt a écrit : I cannot see why on_replacePB_clicked is so different from on_replaceAllPB_clicked. Does anybody have an explanation? The attached patch would simplify on_replacePB_clicked a lot and works. I complicated an already existing code in order to be able

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 18:02 schrieb Jean-Marc Lasgouttes: > Le 27/11/2010 16:05, Stephan Witt a écrit : >> I cannot see why on_replacePB_clicked is so different from >> on_replaceAllPB_clicked. >> Does anybody have an explanation? >> The attached patch would simplify on_replacePB_clicked a lot and

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 18:53 schrieb Stephan Witt: > Am 27.11.2010 um 18:02 schrieb Jean-Marc Lasgouttes: > >> Le 27/11/2010 16:05, Stephan Witt a écrit : >>> I cannot see why on_replacePB_clicked is so different from >>> on_replaceAllPB_clicked. >>> Does anybody have an explanation? >>> The attached

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Jean-Marc Lasgouttes
Le 27/11/2010 19:45, Stephan Witt a écrit : The result is the next patch: 1. start check in updateView only once 2. instead of count_ manipulation skip over replaced word 3. correct the absolute word count Better? I cannot tell. This code is very fragile (although better than in 1.6), only

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: > Le 27/11/2010 19:45, Stephan Witt a écrit : >> The result is the next patch: >> 1. start check in updateView only once >> 2. instead of count_ manipulation skip over replaced word >> 3. correct the absolute word count >> >> Better? > > I

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 21:13 schrieb Stephan Witt: > Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: > >> Le 27/11/2010 19:45, Stephan Witt a écrit : >>> The result is the next patch: >>> 1. start check in updateView only once >>> 2. instead of count_ manipulation skip over replaced word >>> 3.

Re: PATCH for GuiSpellchecker.cpp to simplify on_replacePB_clicked()

2010-11-27 Thread Stephan Witt
Am 27.11.2010 um 21:13 schrieb Stephan Witt: > Am 27.11.2010 um 19:49 schrieb Jean-Marc Lasgouttes: > >> Le 27/11/2010 19:45, Stephan Witt a écrit : >>> The result is the next patch: >>> 1. start check in updateView only once >>> 2. instead of count_ manipulation skip over replaced word >>> 3.