Re: [LyX/master] Do not return copies of string members

2023-05-12 Thread Enrico Forestieri
On Fri, May 12, 2023 at 09:22:03AM +0200, Jean-Marc Lasgouttes wrote: Le 11/05/2023 à 23:04, Enrico Forestieri a écrit : Anyway, I don't think the autoconf test is broken because: From what I read here: https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html this define is merely

Re: [LyX/master] Do not return copies of string members

2023-05-12 Thread Jean-Marc Lasgouttes
Le 11/05/2023 à 23:04, Enrico Forestieri a écrit : Anyway, I don't think the autoconf test is broken because: From what I read here: https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html this define is merely a default. It looks like one can choose to change it, as long as all

Re: [LyX/master] Do not return copies of string members

2023-05-12 Thread Jean-Marc Lasgouttes
Le 11/05/2023 à 19:59, Enrico Forestieri a écrit : Is this somthing special about cygwin or is our autoconf test broken? The former, I think. This is what I get when comparing cygwin and native windows configuration: $ diff -up build-cygwin/config.h build-win32/config.h | grep -B1

Re: [LyX/master] Do not return copies of string members

2023-05-11 Thread Enrico Forestieri
On Thu, May 11, 2023 at 08:51:13PM +0200, Enrico Forestieri wrote: On Thu, May 11, 2023 at 07:59:48PM +0200, Enrico Forestieri wrote: On Thu, May 11, 2023 at 04:32:45PM +0200, Jean-Marc Lasgouttes wrote: Is this somthing special about cygwin or is our autoconf test broken? The former, I

Re: [LyX/master] Do not return copies of string members

2023-05-11 Thread Enrico Forestieri
On Thu, May 11, 2023 at 07:59:48PM +0200, Enrico Forestieri wrote: On Thu, May 11, 2023 at 04:32:45PM +0200, Jean-Marc Lasgouttes wrote: Is this somthing special about cygwin or is our autoconf test broken? The former, I think. Or not, maybe, see below. This is what I get when comparing

Re: [LyX/master] Do not return copies of string members

2023-05-11 Thread Enrico Forestieri
On Thu, May 11, 2023 at 04:32:45PM +0200, Jean-Marc Lasgouttes wrote: Le 11/05/2023 à 15:26, Jean-Marc Lasgouttes a écrit : In file included from ../../../../src/frontends/qt/Toolbars.cpp:15: ../../../../src/Converter.h: In member function ‘const string& lyx::Converter::from() const’:

Re: [LyX/master] Do not return copies of string members

2023-05-11 Thread Jean-Marc Lasgouttes
Le 11/05/2023 à 15:26, Jean-Marc Lasgouttes a écrit : In file included from ../../../../src/frontends/qt/Toolbars.cpp:15: ../../../../src/Converter.h: In member function ‘const string& lyx::Converter::from() const’: ../../../../src/Converter.h:55:51: warning: returning reference to temporary

Re: [LyX/master] Do not return copies of string members

2023-05-11 Thread Jean-Marc Lasgouttes
Le 10/05/2023 à 23:19, Enrico Forestieri a écrit : After this commit my cygwin build crashes badly at startup. I can't even get a backtrace. What is strange is that a native Windows build works fine, instead. Both builds use the same version of gcc: OK, I'll revert for now. However I get a

Re: [LyX/master] Do not return copies of string members

2023-05-10 Thread Enrico Forestieri
On Wed, May 10, 2023 at 11:21:04AM +0200, Jean-Marc Lasgouttes wrote: Le 09/05/2023 à 22:08, Enrico Forestieri a écrit : On Fri, May 05, 2023 at 07:28:59PM +0200, Jean-Marc Lasgouttes wrote: commit 3ae5d6bdec1df23cc0d848b2d8bf6b09323b Author: Jean-Marc Lasgouttes Date:   Fri May 5

Re: [LyX/master] Do not return copies of string members

2023-05-10 Thread Jean-Marc Lasgouttes
Le 09/05/2023 à 22:08, Enrico Forestieri a écrit : On Fri, May 05, 2023 at 07:28:59PM +0200, Jean-Marc Lasgouttes wrote: commit 3ae5d6bdec1df23cc0d848b2d8bf6b09323b Author: Jean-Marc Lasgouttes Date:   Fri May 5 20:35:23 2023 +0200    Do not return copies of string members    This fixes

Re: [LyX/master] Do not return copies of string members

2023-05-09 Thread Enrico Forestieri
On Fri, May 05, 2023 at 07:28:59PM +0200, Jean-Marc Lasgouttes wrote: commit 3ae5d6bdec1df23cc0d848b2d8bf6b09323b Author: Jean-Marc Lasgouttes Date: Fri May 5 20:35:23 2023 +0200 Do not return copies of string members This fixes the g++ 12 warnings below. After this commit my