Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Scott Kostyshak
On Mon, Apr 11, 2016 at 10:04:38PM +0100, Guillaume Munch wrote: > Le 11/04/2016 21:48, Andrew Parsloe a écrit : > >Jean-Marc earlier suggested that I make a trac ticket. Time zones have > >obviously got in the way. Is a ticket still needed? > > > > I don't think so. Thanks for the report, I know

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 21:48, Andrew Parsloe a écrit : Jean-Marc earlier suggested that I make a trac ticket. Time zones have obviously got in the way. Is a ticket still needed? I don't think so. Thanks for the report, I know I would have suffered from that bug at some point. Guillaume

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Andrew Parsloe
On 12/04/2016 8:17 a.m., Guillaume Munch wrote: Le 11/04/2016 20:53, Scott Kostyshak a écrit : On Mon, Apr 11, 2016 at 08:27:42PM +0100, Guillaume Munch wrote: Le 11/04/2016 20:10, Richard Heck a écrit : Again, why stripping "Flex:" off the beginning of name_? This is not how it is done

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 20:53, Scott Kostyshak a écrit : On Mon, Apr 11, 2016 at 08:27:42PM +0100, Guillaume Munch wrote: Le 11/04/2016 20:10, Richard Heck a écrit : Again, why stripping "Flex:" off the beginning of name_? This is not how it is done before the regression. Or did I miss something?

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Scott Kostyshak
On Mon, Apr 11, 2016 at 08:27:42PM +0100, Guillaume Munch wrote: > Le 11/04/2016 20:10, Richard Heck a écrit : > Again, why stripping "Flex:" off the beginning of name_? This is not > how it is done before the regression. Or did I miss something? > >>> > >>>name_ wouldn't have contained

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 20:10, Richard Heck a écrit : Again, why stripping "Flex:" off the beginning of name_? This is not how it is done before the regression. Or did I miss something? name_ wouldn't have contained "Flex:". It's there because InsetLayout::name() includes it. I am not sure that you

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Richard Heck
On 04/11/2016 02:25 PM, Guillaume Munch wrote: > Le 11/04/2016 19:02, Richard Heck a écrit : >> On 04/11/2016 12:57 PM, Guillaume Munch wrote: >>> Le 11/04/2016 17:28, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 17:53, Scott Kostyshak a écrit : > I can confirm that I do not see the

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 19:02, Richard Heck a écrit : On 04/11/2016 12:57 PM, Guillaume Munch wrote: Le 11/04/2016 17:28, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 17:53, Scott Kostyshak a écrit : I can confirm that I do not see the problem in 2.1.4 and I do see it with 2.2.0dev. I suppose this is

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Richard Heck
On 04/11/2016 12:57 PM, Guillaume Munch wrote: > Le 11/04/2016 17:28, Jean-Marc Lasgouttes a écrit : >> Le 11/04/2016 17:53, Scott Kostyshak a écrit : >>> I can confirm that I do not see the problem in 2.1.4 and I do see it >>> with 2.2.0dev. >>> >>> I suppose this is a dataloss bug, and that

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:28, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 17:53, Scott Kostyshak a écrit : I can confirm that I do not see the problem in 2.1.4 and I do see it with 2.2.0dev. I suppose this is a dataloss bug, and that there is a rule of not going to an RC with a known dataloss bug that

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:39, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 18:33, Richard Heck a écrit : Here is a very lightly tested patch. It looks OK to me, but this kind of changes has potential to do more harm than good. So if we do not have 1/ good user testing and 2/ a +1 from someone who

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:33, Richard Heck a écrit : This is exactly what I was going to do. A quicker and dirtier and very safe (IMO) fix is: @@ -75,6 +75,8 @@ void InsetFlex::write(ostream & os) const // use il.name(), since this resolves obsoleted // InsetLayout

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 17:33, Richard Heck a écrit : On 04/11/2016 12:28 PM, Jean-Marc Lasgouttes wrote: Le 11/04/2016 17:53, Scott Kostyshak a écrit : I can confirm that I do not see the problem in 2.1.4 and I do see it with 2.2.0dev. I suppose this is a dataloss bug, and that there is a rule of not

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Jean-Marc Lasgouttes
Le 11/04/2016 18:33, Richard Heck a écrit : Here is a very lightly tested patch. It looks OK to me, but this kind of changes has potential to do more harm than good. So if we do not have 1/ good user testing and 2/ a +1 from someone who understands this code, I am not sure we want it in rc1. And

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Richard Heck
On 04/11/2016 12:28 PM, Jean-Marc Lasgouttes wrote: > Le 11/04/2016 17:53, Scott Kostyshak a écrit : >> I can confirm that I do not see the problem in 2.1.4 and I do see it >> with 2.2.0dev. >> >> I suppose this is a dataloss bug, and that there is a rule of not going >> to an RC with a known

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Jean-Marc Lasgouttes
Le 11/04/2016 17:53, Scott Kostyshak a écrit : I can confirm that I do not see the problem in 2.1.4 and I do see it with 2.2.0dev. I suppose this is a dataloss bug, and that there is a rule of not going to an RC with a known dataloss bug that is a regression. Although the bug only shows in a

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Scott Kostyshak
On Mon, Apr 11, 2016 at 04:45:02PM +0100, Guillaume Munch wrote: > Le 11/04/2016 12:36, Jean-Marc Lasgouttes a écrit : > >Le 11/04/2016 07:27, Andrew Parsloe a écrit : > >>Suppose a module defines flex insets moo and baa (the locale-dependent > >>version of foo and bah in New Zealand), and these

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Scott Kostyshak
On Mon, Apr 11, 2016 at 01:36:28PM +0200, Jean-Marc Lasgouttes wrote: > Le 11/04/2016 07:27, Andrew Parsloe a écrit : > >Suppose a module defines flex insets moo and baa (the locale-dependent > >version of foo and bah in New Zealand), and these are used in a document > >to which the module has

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Jean-Marc Lasgouttes
Le 11/04/2016 17:45, Guillaume Munch a écrit : Le 11/04/2016 12:36, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 07:27, Andrew Parsloe a écrit : Suppose a module defines flex insets moo and baa (the locale-dependent version of foo and bah in New Zealand), and these are used in a document to

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Guillaume Munch
Le 11/04/2016 12:36, Jean-Marc Lasgouttes a écrit : Le 11/04/2016 07:27, Andrew Parsloe a écrit : Suppose a module defines flex insets moo and baa (the locale-dependent version of foo and bah in New Zealand), and these are used in a document to which the module has been added. If the module is

Re: Regression in saving of flex insets in beta2?

2016-04-11 Thread Jean-Marc Lasgouttes
Le 11/04/2016 07:27, Andrew Parsloe a écrit : Suppose a module defines flex insets moo and baa (the locale-dependent version of foo and bah in New Zealand), and these are used in a document to which the module has been added. If the module is now deleted from the document, the flex insets become

Regression in saving of flex insets in beta2?

2016-04-10 Thread Andrew Parsloe
Suppose a module defines flex insets moo and baa (the locale-dependent version of foo and bah in New Zealand), and these are used in a document to which the module has been added. If the module is now deleted from the document, the flex insets become undefined. If the document is saved then