Re: We now include both png and svgz?

Scott Kostyshak wrote: > From what I understand, there is support for the change. I think Georg's > main concern was that on some systems it might not work, but Enrico > seems confident that it will work even on less commonly used systems and > even for 4.8.x. This is fine with me as well, I had

Re: We now include both png and svgz?

On Mon, Dec 07, 2015 at 08:43:03PM +0100, Georg Baum wrote: > Scott Kostyshak wrote: > > > From what I understand, there is support for the change. I think Georg's > > main concern was that on some systems it might not work, but Enrico > > seems confident that it will work even on less commonly

compilation error with Re: We now include both png and svgz?

Am 07.12.2015 um 19:48 schrieb Enrico Forestieri: Done at db363ab1. Now I get a compilation error: Generating qrc_Resources.cpp RCC: Error in 'D:/LyXGit/Master/compile-2013/src/frontends/qt4/Resources.qrc' : Cannot find file 'D:/LyXGit/Master/lib/images/all-changes-accept.png' maybe

Re: compilation error with Re: We now include both png and svgz?

Am Montag, 7. Dezember 2015 um 22:10:35, schrieb Uwe Stöhr > Am 07.12.2015 um 19:48 schrieb Enrico Forestieri: > > > Done at db363ab1. > > Now I get a compilation error: > >Generating qrc_Resources.cpp >RCC: Error in >

Re: compilation error with Re: We now include both png and svgz?

Am Montag, 7. Dezember 2015 um 22:38:48, schrieb Kornel Benko > Am Montag, 7. Dezember 2015 um 22:10:35, schrieb Uwe Stöhr > > Am 07.12.2015 um 19:48 schrieb Enrico Forestieri: > > > > > Done at db363ab1. > > > > Now I get a compilation error: > > > >

Re: compilation error with Re: We now include both png and svgz?

Am 07.12.2015 um 22:53 schrieb Kornel Benko: That is not enough, you have also remove the object files many thanks! Now the error is gone. best regards Uwe

Re: We now include both png and svgz?

On Sun, Dec 06, 2015 at 09:12:11PM -0500, Scott Kostyshak wrote: > On Sun, Dec 06, 2015 at 03:08:47PM +0100, Enrico Forestieri wrote: > > On Sun, Dec 06, 2015 at 11:52:14AM +0100, Georg Baum wrote: > > > > > Jean-Marc Lasgouttes wrote: > > > > > > > Le 06/12/15 00:02, Scott Kostyshak a écrit : >

Re: We now include both png and svgz?

On Sun, Dec 06, 2015 at 11:52:14AM +0100, Georg Baum wrote: > Jean-Marc Lasgouttes wrote: > > > Le 06/12/15 00:02, Scott Kostyshak a écrit : > >> There was an issue on Windows that came from not including a .dll. Now > >> that the issue has been fixed, we should decide if we would like to > >>

Re: We now include both png and svgz?

Jean-Marc Lasgouttes wrote: > Le 06/12/15 00:02, Scott Kostyshak a écrit : >> There was an issue on Windows that came from not including a .dll. Now >> that the issue has been fixed, we should decide if we would like to >> consider removing the .pngs. If we would like to remove the .pngs for >>

Re: We now include both png and svgz?

On Sun, Dec 06, 2015 at 03:08:47PM +0100, Enrico Forestieri wrote: > On Sun, Dec 06, 2015 at 11:52:14AM +0100, Georg Baum wrote: > > > Jean-Marc Lasgouttes wrote: > > > > > Le 06/12/15 00:02, Scott Kostyshak a écrit : > > >> There was an issue on Windows that came from not including a .dll. Now

Re: We now include both png and svgz?

Le 06/12/15 00:02, Scott Kostyshak a écrit : There was an issue on Windows that came from not including a .dll. Now that the issue has been fixed, we should decide if we would like to consider removing the .pngs. If we would like to remove the .pngs for 2.2.0 I think we should definitely do this

Re: We now include both png and svgz?

On Mon, Nov 16, 2015 at 06:01:57PM +0100, Enrico Forestieri wrote: > On Sun, Nov 15, 2015 at 05:57:00PM +0100, Georg Baum wrote: > > > Enrico Forestieri wrote: > > > > > It is not intended to work that way. If the svgz image is there, it is > > > not expected that Qt is not able to show it. The

Re: We now include both png and svgz?

On Sun, Nov 15, 2015 at 05:57:00PM +0100, Georg Baum wrote: > Enrico Forestieri wrote: > > > It is not intended to work that way. If the svgz image is there, it is > > not expected that Qt is not able to show it. The double entry are there > > only to assure that if there is no svgz then the png

Re: We now include both png and svgz?

On Sun, Nov 15, 2015 at 05:31:28PM -0500, Scott Kostyshak wrote: > > Is the only disadvantage of including the .pngs bloat in the sense that > we are increasing the size of our tars and of the repos? Yep. > Or is there a > concern that shipping .pngs could lead to different issues also (because

Re: We now include both png and svgz?

On Sun, Nov 15, 2015 at 05:59:38PM +0100, Jean-Marc Lasgouttes wrote: > Le 15/11/2015 17:57, Georg Baum a écrit : > >OK, if it is assumed that qt can show svg images, then it does not make > >sense to ship or own .pngs. If we want to stick with this, we should remove > >the .pngs now and require

Re: We now include both png and svgz?

Enrico Forestieri wrote: > It is not intended to work that way. If the svgz image is there, it is > not expected that Qt is not able to show it. The double entry are there > only to assure that if there is no svgz then the png can be used instead. > In this way, you are able to override the

Re: We now include both png and svgz?

Le 15/11/2015 17:57, Georg Baum a écrit : OK, if it is assumed that qt can show svg images, then it does not make sense to ship or own .pngs. If we want to stick with this, we should remove the .pngs now and require qtsvg at configure time. For me personally the svgs work fine both with qt 4.8

Re: We now include both png and svgz?

Vincent van Ravesteijn wrote: > In any case, the logic is a bit strange. The icon names are defined > with the extension {png,svgz} so that any one matched, and getPixmap > checks whether the file can be loaded or not. However, iconName then > already decides on whether it is png or svgz just

Re: We now include both png and svgz?

On Thu, Nov 12, 2015 at 09:14:02PM +0100, Georg Baum wrote: > Vincent van Ravesteijn wrote: > > > In any case, the logic is a bit strange. The icon names are defined > > with the extension {png,svgz} so that any one matched, and getPixmap > > checks whether the file can be loaded or not. However,

Re: We now include both png and svgz?

On Wed, Nov 11, 2015 at 01:37:51PM +0100, Vincent van Ravesteijn wrote: > > So, either we make QtSvg a "required" dependency, and cmake/autotools > should check for it, or we improve the logic to decide whether we lood > the png or svgz variant. It is not intended to work that way. If the svgz

Re: We now include both png and svgz?

On Wed, Nov 11, 2015 at 1:02 PM, Jean-Marc Lasgouttes wrote: > Le 10/11/2015 10:02, Vincent van Ravesteijn a écrit : >> >> At the moment you cannot use LyX with Qt4 because it cannot read svgz >> files, and the code is not correctly falling back to png files. >> >> So yes, we

Re: We now include both png and svgz?

Le 10/11/2015 10:02, Vincent van Ravesteijn a écrit : At the moment you cannot use LyX with Qt4 because it cannot read svgz files, and the code is not correctly falling back to png files. So yes, we need both, otherwise we will have to require newer versions of Qt. My copy of lyx 2.2 with

Re: We now include both png and svgz?

Am Mittwoch, 11. November 2015 um 13:02:53, schrieb Jean-Marc Lasgouttes > Le 10/11/2015 10:02, Vincent van Ravesteijn a écrit : > > At the moment you cannot use LyX with Qt4 because it cannot read svgz > > files, and the code is not correctly falling back to png files. > > >

Re: We now include both png and svgz?

Le 11/11/15 13:37, Vincent van Ravesteijn a écrit : In any case, the logic is a bit strange. The icon names are defined with the extension {png,svgz} so that any one matched, and getPixmap checks whether the file can be loaded or not. However, iconName then already decides on whether it is png

Re: We now include both png and svgz?

On Tue, Nov 10, 2015 at 4:13 AM, Scott Kostyshak wrote: > When experimenting with building the tar balls, I noticed a significant > difference in size between 2.2.0dev and 2.1.4. > > lyx-2.1.4.tar.gz is 20.8 MB > lyx-2.2.0dev.tar.gz is 24.8 MB > > A quick check seems to show

Re: We now include both png and svgz?

Scott Kostyshak wrote: > > At the moment you cannot use LyX with Qt4 because it cannot read svgz > > files, and the code is not correctly falling back to png files. > > > > So yes, we need both, otherwise we will have to require newer versions of > > Qt. > > I see. Makes sense. I will set a

Re: We now include both png and svgz?

On Tue, Nov 10, 2015 at 10:02:15AM +0100, Vincent van Ravesteijn wrote: > On Tue, Nov 10, 2015 at 4:13 AM, Scott Kostyshak wrote: > > When experimenting with building the tar balls, I noticed a significant > > difference in size between 2.2.0dev and 2.1.4. > > > >

Re: We now include both png and svgz?

On Tue, Nov 10, 2015 at 06:42:50PM -0800, Pavel Sanda wrote: > Scott Kostyshak wrote: > > > At the moment you cannot use LyX with Qt4 because it cannot read svgz > > > files, and the code is not correctly falling back to png files. > > > > > > So yes, we need both, otherwise we will have to

We now include both png and svgz?

When experimenting with building the tar balls, I noticed a significant difference in size between 2.2.0dev and 2.1.4. lyx-2.1.4.tar.gz is 20.8 MB lyx-2.2.0dev.tar.gz is 24.8 MB A quick check seems to show that most of the change comes from now including .svgz (in addition to .png). Why do we