On 05-Mar-2001 Edwin Leuven wrote:
Which would mean that it happens here:
while (pos + i par-Last()
string::size_type(i) size
cs ? str[i] == par-GetChar(pos + i)
: toupper(str[i]) == toupper(par-GetChar(pos + i))) {
I fixed the
Juergen Vigna [EMAIL PROTECTED] writes:
| On 05-Mar-2001 Edwin Leuven wrote:
|
| Which would mean that it happens here:
|
| while (pos + i par-Last()
| string::size_type(i) size
| cs ? str[i] == par-GetChar(pos + i)
| :
On 06-Mar-2001 Lars Gullik Bjnnes wrote:
No no... that you put parantesis around _obvious_ expressions. btw.
You got me #:O) (big smile)
I'd like to see the above while condition rewritten. It way to large
and complex.
Well we have to rewrite quite a bit in there to permit fr also inside
Edwin Leuven [EMAIL PROTECTED] writes:
| Hi,
|
| I attach the patch that moves find/replace to frontends. It also moves some
| stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be
| removed. Could someone check and/or apply it?
+
+ bool found;
+ do {
+
No no... that you put parantesis around _obvious_ expressions. btw.
You got me #:O) (big smile)
I'd like to see the above while condition rewritten. It way to large
and complex.
Should I resubmit the patch with these expression chopped up in pieces?
gr.ed.
"Edwin" == Edwin Leuven [EMAIL PROTECTED] writes:
Edwin Should I resubmit the patch with these expression chopped up in
Edwin pieces?
The patch is applied already, but you can submit a cleanup patch.
JMarc
On 06-Mar-2001 Lars Gullik Bjnnes wrote:
Ad Jrgen's segfault report, I think there is a mistake in the code
somewhere, but I can't see it offhand. I belive the reason Jrgen sees
The segfault wasn't a segfault, but an Assert(false) (I traced this down
and could so find the error) and was in
On 05-Mar-2001 Edwin Leuven wrote:
> Which would mean that it happens here:
>
> while (pos + i < par->Last()
>&& string::size_type(i) < size
>&& cs ? str[i] == par->GetChar(pos + i)
>: toupper(str[i]) == toupper(par->GetChar(pos + i))) {
Juergen Vigna <[EMAIL PROTECTED]> writes:
| On 05-Mar-2001 Edwin Leuven wrote:
|
| > Which would mean that it happens here:
| >
| > while (pos + i < par->Last()
| >&& string::size_type(i) < size
| >&& cs ? str[i] == par->GetChar(pos + i)
| >
On 06-Mar-2001 Lars Gullik Bjønnes wrote:
> No no... that you put parantesis around _obvious_ expressions. btw.
You got me #:O) (big smile)
> I'd like to see the above while condition rewritten. It way to large
> and complex.
Well we have to rewrite quite a bit in there to permit f also
Edwin Leuven <[EMAIL PROTECTED]> writes:
| Hi,
|
| I attach the patch that moves find/replace to frontends. It also moves some
| stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be
| removed. Could someone check and/or apply it?
+
+ bool found;
+ do {
+
> > No no... that you put parantesis around _obvious_ expressions. btw.
>
> You got me #:O) (big smile)
>
> > I'd like to see the above while condition rewritten. It way to large
> > and complex.
Should I resubmit the patch with these expression chopped up in pieces?
gr.ed.
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes:
Edwin> Should I resubmit the patch with these expression chopped up in
Edwin> pieces?
The patch is applied already, but you can submit a cleanup patch.
JMarc
On 06-Mar-2001 Lars Gullik Bjønnes wrote:
> Ad Jürgen's segfault report, I think there is a mistake in the code
> somewhere, but I can't see it offhand. I belive the reason Jürgen sees
The segfault wasn't a segfault, but an Assert(false) (I traced this down
and could so find the error) and was
Hi,
I attach the patch that moves find/replace to frontends. It also moves some
stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be
removed. Could someone check and/or apply it?
Thanks for your help.
Greetings, Ed.
ps. could someone apply the qt2 character patch?
On Monday 05 March 2001 09:36, Edwin Leuven wrote:
Hi,
ps. could someone apply the qt2 character patch?
Ed,
I thought I'd try and compile it, but configure fails because I have qt 2.2.1
here and configure looks for 2.2.3. Is this really needed or will I still be
able to compile.
from
On Monday 05 March 2001 10:21, Angus Leeming wrote:
On Monday 05 March 2001 09:36, Edwin Leuven wrote:
Hi,
ps. could someone apply the qt2 character patch?
Ed,
I thought I'd try and compile it, but configure fails because I have qt
2.2.1
here and configure looks for 2.2.3. Is
Angus Leeming [EMAIL PROTECTED] writes:
| On Monday 05 March 2001 10:21, Angus Leeming wrote:
| On Monday 05 March 2001 09:36, Edwin Leuven wrote:
|
|Hi,
|
| ps. could someone apply the qt2 character patch?
|
| Ed,
|
| I thought I'd try and compile it, but configure fails
Edwin Leuven [EMAIL PROTECTED] writes:
| Hi,
|
| I attach the patch that moves find/replace to frontends. It also moves some
| stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be
| removed. Could someone check and/or apply it?
|
| Thanks for your help.
+
On Mon, 5 Mar 2001, Angus Leeming wrote:
I see that Lars has beaten me to it and committed this patch. I'd just report
that it compiles on my box, so I think the configure test should be changed
to #if (QT_VERSION 221) at least.
I changed this. Hmm.
Ah yes ... I see what's gone on I
On Monday 05 March 2001 10:44, Lars Gullik Bjønnes wrote:
| One small point. Launching the copyright dialog, I see that the program
is
| now called KLyX
yes, remove that...
Done.
A
+ bool const casesens,
peculiar spelling... wouldn't "caseness" be better?
Whatever you want, I can also add "itive" to make it "casesensitive". You
want a new patch, or is it ok as is for the moment? Ed.
On 05-Mar-2001 Edwin Leuven wrote:
Whatever you want, I can also add "itive" to make it "casesensitive". You
want a new patch, or is it ok as is for the moment? Ed.
Well I tried the patch here and got a segfault on search.
Here is the backtrace:
(gdb) bt
#0 0x401b2a21 in __kill () from
Well I tried the patch here and got a segfault on search.
Here is the backtrace:
I can reproduce this as often as I want. I just have to press 2 or 3
times the "" button with the same searchstring then I'll get this!
That's strange. I don't have this.
Apparantly (correct me if I'm wrong)
Hi,
I attach the patch that moves find/replace to frontends. It also moves some
stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be
removed. Could someone check and/or apply it?
Thanks for your help.
Greetings, Ed.
ps. could someone apply the qt2 character patch?
On Monday 05 March 2001 09:36, Edwin Leuven wrote:
> > Hi,
>
> ps. could someone apply the qt2 character patch?
Ed,
I thought I'd try and compile it, but configure fails because I have qt 2.2.1
here and configure looks for 2.2.3. Is this really needed or will I still be
able to compile.
On Monday 05 March 2001 10:21, Angus Leeming wrote:
> On Monday 05 March 2001 09:36, Edwin Leuven wrote:
>
> > > Hi,
> >
> > ps. could someone apply the qt2 character patch?
>
> Ed,
>
> I thought I'd try and compile it, but configure fails because I have qt
2.2.1
> here and configure looks
Angus Leeming <[EMAIL PROTECTED]> writes:
| On Monday 05 March 2001 10:21, Angus Leeming wrote:
| > On Monday 05 March 2001 09:36, Edwin Leuven wrote:
| >
| > > > Hi,
| > >
| > > ps. could someone apply the qt2 character patch?
| >
| > Ed,
| >
| > I thought I'd try and compile it, but
Edwin Leuven <[EMAIL PROTECTED]> writes:
| Hi,
|
| I attach the patch that moves find/replace to frontends. It also moves some
| stuff out ouf LyXText. The files src/lyxfr1.[Ch] and src/lyxfr0.[Ch] can be
| removed. Could someone check and/or apply it?
|
| Thanks for your help.
+
On Mon, 5 Mar 2001, Angus Leeming wrote:
> I see that Lars has beaten me to it and committed this patch. I'd just report
> that it compiles on my box, so I think the configure test should be changed
> to #if (QT_VERSION < 221) at least.
I changed this. Hmm.
Ah yes ... I see what's gone on I
On Monday 05 March 2001 10:44, Lars Gullik Bjønnes wrote:
> | One small point. Launching the copyright dialog, I see that the program
is
> | now called KLyX
>
> yes, remove that...
Done.
A
>
> + bool const & casesens,
>
> peculiar spelling... wouldn't "caseness" be better?
>
Whatever you want, I can also add "itive" to make it "casesensitive". You
want a new patch, or is it ok as is for the moment? Ed.
On 05-Mar-2001 Edwin Leuven wrote:
>
> Whatever you want, I can also add "itive" to make it "casesensitive". You
> want a new patch, or is it ok as is for the moment? Ed.
Well I tried the patch here and got a segfault on search.
Here is the backtrace:
(gdb) bt
#0 0x401b2a21 in __kill ()
> Well I tried the patch here and got a segfault on search.
> Here is the backtrace:
>
> I can reproduce this as often as I want. I just have to press 2 or 3
> times the ">" button with the same searchstring then I'll get this!
>
That's strange. I don't have this.
Apparantly (correct me if I'm
Jean-Marc Lasgouttes writes:
"Jochen" == Jochen Kuepper [EMAIL PROTECTED]
writes:
Jochen Some patches to LyX-1.1 needed for the find replace stuff.
Jochen ( JMarc, you forgot these, I guess :-)
JL You're right. Thanks.
Jochen Btw. is it actually ok to put in Emacs Local
Jean-Marc Lasgouttes writes:
"Lars" == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
JL I agree that having this in all files would be nice.
Lars I don't. We have not until now _forced_ anyone to use a
Lars specific style, and I don't think we should begin doing that
Lars now.
"Lars" == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
JL The style needn't be the same in all files, but one file should
JL have a consistent style. I guess local variables can serve this
JL goal.
Lars I don't see why we should force even that on the developers.
What's forced on me
Jean-Marc Lasgouttes writes:
"Lars" == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
JL The style needn't be the same in all files, but one file should
JL have a consistent style. I guess local variables can serve this
JL goal.
Lars I don't see why we should force even that on the
On Die, 09 Feb 1999 Jean-Marc Lasgouttes wrote:
"Lars" == Lars Gullik Bjønnes [EMAIL PROTECTED] writes:
JL I agree that having this in all files would be nice.
Lars I don't. We have not until now _forced_ anyone to use a specific
Lars style, and I don't think we should begin doing that now.
39 matches
Mail list logo
