Re: Compiling and using master on macOS

2020-07-08 Thread Daniel
On 2020-07-07 00:24, Stephan Witt wrote: Am 06.07.2020 um 09:59 schrieb Daniel : On 2020-03-15 21:37, Stephan Witt wrote: Am 15.03.2020 um 17:16 schrieb Daniel : Hi, I am about to try compiling and using master on macOS. I just has a look at INSTALL.MacOSX. It mentions Qt version 4. That

Re: Compiling and using master on macOS

2020-07-08 Thread Stephan Witt
Am 07.07.2020 um 07:35 schrieb Daniel : > > On 2020-07-07 07:30, Daniel wrote: >> On 2020-07-07 00:24, Stephan Witt wrote: >>> Am 06.07.2020 um 09:59 schrieb Daniel : On 2020-03-15 21:37, Stephan Witt wrote: > Am 15.03.2020 um 17:16 schrieb Daniel : >> >> Hi, >>

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools #1781

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1781/-- [...truncated 966 lines...] OutputParams.h:364:32: warning: 'std::__debug::unordered_set > lyx::OutputParams::docbook_anchors_to_ignore' [-Wreorder]

Re: Compiling and using master on macOS

2020-07-08 Thread Stephan Witt
Am 08.07.2020 um 08:21 schrieb Daniel : > > On 2020-07-07 00:24, Stephan Witt wrote: >> Am 06.07.2020 um 09:59 schrieb Daniel : >>> >>> On 2020-03-15 21:37, Stephan Witt wrote: Am 15.03.2020 um 17:16 schrieb Daniel : > > Hi, > > I am about to try compiling and using master

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 12:02:59 +0200 schrieb Jean-Marc Lasgouttes : > Le 08/07/2020 à 11:58, ci-...@inria.fr a écrit : > > FAIL: tests/test_layout > > Something is wrong with this test... > > JMarc Yes, checking the layouts with "ctest -R check_layout" gives: 42% tests passed, 109

Fwd: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Jean-Marc Lasgouttes
Hello, More work for Thibaut :) I ran coverity against master and here is what it returns (below). Item 1 is about checking return of regex_match Item 2 is probably fixed by an earlier definition of the "label" variable Item 3&4 seem to be only an issue with libstdc++, we cannot do much

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 01:50:29PM +0200, Kornel Benko wrote: > All of the failed tests fail in style 'Description', defined probably in > stdlists.inc. > Roundtrip fails because of missing entry 'DocBookItemTag listitem'. Do you know what is this 'Roundtrip' test suppose to test? P --

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 09:17:12AM +0200, Pavel Sanda wrote: > commit 7989ebca85ddf95d58dfb86e234a17e5470d62c2 > Author: Thibaut Cuvelier > Date: Fri May 10 02:54:44 2019 +0200 > > Add documentation for the new layout attributes. Thibaut, this patch broke the manual (likely wrong merge

Re: New DocBook support

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 03:44:01PM +0200, Thibaut Cuvelier wrote: > I don't exactly know where to submit this, so here it is: another patch to > clean up. This should remove support for DeclareDocBookClass in layouts, as > it's no more useful. it's in. p -- lyx-devel mailing list

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1990/-- [...truncated 1153 lines...] CXX insets/InsetSpace.o CXX insets/InsetSpecialChar.o CXX insets/InsetTabular.o CXX insets/InsetText.o

Re: Docbook 5 merged

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 03:00:10PM +0200, Pavel Sanda wrote: > - Two already known issues - fix documentation and tests, please see other > mails... another one: we can't still select docbook as default output format of the document... p -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Jean-Marc Lasgouttes
Le 08/07/2020 à 11:58, ci-...@inria.fr a écrit : FAIL: tests/test_layout Something is wrong with this test... JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Fwd: New DocBook support (0005)

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 12:35:55AM +0200, Thibaut Cuvelier wrote: > > On Mon, Jul 06, 2020 at 05:18:16AM +0200, Thibaut Cuvelier wrote: > > > > > diff --git a/src/OutputParams.h b/src/OutputParams.h > > > > > index 1ad36722d0..0244a0ea41 100644 > > > Here is a rebased version of the patch.

Docbook 5 merged

2020-07-08 Thread Pavel Sanda
Hi Thibaut and others, I am mostly done with merging Docbook to master. There are several TODOs I see now: - Add entries into various sections of RELEASE-NOTES, these should contain: - New output target for Docbook 5 - Files gone (examples/layouts) - Warning that ppl. using archaic

Re: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 14:53:49 +0200 schrieb Jean-Marc Lasgouttes : > >>> CID 360530: Error handling issues (CHECKED_RETURN) > >>> Calling "regex_match" without checking return value (as is done > >>> elsewhere 48 > >>> out of 49 times). > 1194

Re: New DocBook support

2020-07-08 Thread Thibaut Cuvelier
On Fri, 26 Jun 2020 at 18:56, Thibaut Cuvelier wrote: > Dear list, > > Here is the complete set of patches for the new DocBook implementation > I've been working on for the last few years. It is a complete overhaul of > the existing DocBook implementation, with a completely different mindset: >

Re: Fwd: New DocBook support (0005)

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 02:01:38PM +0200, Pavel Sanda wrote: > You have them in attachment :) now really. p -- pp 2020-07-08 13:56:16.458794194 +0200 ++ 0004-Add-required-elements-in-the-layouts-to-support-DocB.patch 2020-07-08 13:55:04.926411437 +0200 --- a/src/Buffer.cpp +++

Re: Docbook 5 merged

2020-07-08 Thread Jean-Marc Lasgouttes
Le 08/07/2020 à 15:00, Pavel Sanda a écrit : - As with any new feature there are likely some hidden issues and we would benefit from docbook users feedback and I'm not sure how to proceed. We could ask on users lists for the feedback (and perhaps persuade JMarc to release 2.4alpha1, which

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 13:54:18 +0200 schrieb Pavel Sanda : > On Wed, Jul 08, 2020 at 01:50:29PM +0200, Kornel Benko wrote: > > All of the failed tests fail in style 'Description', defined probably in > > stdlists.inc. > > Roundtrip fails because of missing entry 'DocBookItemTag listitem'. > > Do

Re: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Jean-Marc Lasgouttes
Le 08/07/2020 à 15:32, Kornel Benko a écrit : I wonder why the use of std::regex_match()? We use #include "support/regex.h" the correct is either lyx::regex_match() or regex_match() in the lyx namespace. Very good point. We use the second form in the source. JMarc --

Re: Compiling and using master on macOS

2020-07-08 Thread racoon
On 2020-07-08 08:28, Stephan Witt wrote: Am 07.07.2020 um 07:35 schrieb Daniel : On 2020-07-07 07:30, Daniel wrote: On 2020-07-07 00:24, Stephan Witt wrote: Am 06.07.2020 um 09:59 schrieb Daniel : On 2020-03-15 21:37, Stephan Witt wrote: Am 15.03.2020 um 17:16 schrieb Daniel : Hi, I

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 04:27:30PM +0200, Thibaut Cuvelier wrote: > On Wed, 8 Jul 2020 at 14:38, Pavel Sanda wrote: > > > On Wed, Jul 08, 2020 at 09:17:12AM +0200, Pavel Sanda wrote: > > > commit 7989ebca85ddf95d58dfb86e234a17e5470d62c2 > > > Author: Thibaut Cuvelier > > > Date: Fri May 10

Re: New DocBook support

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 15:48, Pavel Sanda wrote: > On Wed, Jul 08, 2020 at 03:44:01PM +0200, Thibaut Cuvelier wrote: > > I don't exactly know where to submit this, so here it is: another patch > to > > clean up. This should remove support for DeclareDocBookClass in layouts, > as > > it's no more

Re: Fwd: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Richard Kimberly Heck
On 7/8/20 11:28 AM, Jean-Marc Lasgouttes wrote: > Le 08/07/2020 à 14:53, Jean-Marc Lasgouttes a écrit : >> Hello, >> >> More work for Thibaut :) I ran coverity against master and here is >> what it returns (below). > > Now I tried clang 10 and I get the following 2 warnings. Besides the >

Re: [LyX/master] Wininstaller, fix bug where previous installations, with emergency version greater than 1, could not be seen in registry on overinstall

2020-07-08 Thread Richard Kimberly Heck
On 7/7/20 3:55 PM, Yu Jin wrote: > Am Di., 7. Juli 2020 um 21:29 Uhr schrieb Richard Kimberly Heck > mailto:rikih...@lyx.org>>: > > On 7/7/20 3:19 PM, Yu Jin wrote: >> Am Di., 7. Juli 2020 um 21:14 Uhr schrieb Eugene Chornyi >> mailto:yu_...@lyx.org>>: >> >> commit

Jenkins build is back to normal : Build branch "master" » ubuntu-xenial-qt4-autotools #1782

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools/1782/ -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Fwd: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Jean-Marc Lasgouttes
Le 08/07/2020 à 14:53, Jean-Marc Lasgouttes a écrit : Hello, More work for Thibaut :) I ran coverity against master and here is what it returns (below). Now I tried clang 10 and I get the following 2 warnings. Besides the overloading problem, the indentation issue seems to be related with

Re: Docbook 5 merged

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 15:01, Pavel Sanda wrote: > There are several TODOs I see now: > I'm adding a few other points (including a future roadmap): - Rewrite https://wiki.lyx.org/LyX/DocBook - Default output format (for the sake of completeness) - (For later:) add support for CALS tables (add a

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 14:28:23 +0200 schrieb Kornel Benko : > Am Wed, 8 Jul 2020 13:54:18 +0200 > schrieb Pavel Sanda : > > > On Wed, Jul 08, 2020 at 01:50:29PM +0200, Kornel Benko wrote: > > > All of the failed tests fail in style 'Description', defined probably in > > > stdlists.inc. Roundtrip

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1991

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1991/-- [...truncated 1132 lines...] CXX insets/InsetSpace.o CXX insets/InsetSpecialChar.o CXX insets/InsetTabular.o CXX insets/InsetText.o

Re: Text selection does not work as expected

2020-07-08 Thread Yu Jin
Am Sa., 4. Juli 2020 um 22:02 Uhr schrieb Scott Kostyshak : > On Sat, Jul 04, 2020 at 07:50:18PM +0200, Yu Jin wrote: > > Am Sa., 4. Juli 2020 um 17:16 Uhr schrieb Scott Kostyshak < > skost...@lyx.org > > >: > > > > > > > > Thanks for looking into this, Eugene. Just to make sure I understand, > >

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 06:54:20PM +0200, Thibaut Cuvelier wrote: > > > Here is the updated version of the manual and the corresponding patch. It > > > should apply cleanly, now (even though I don't get why it's that > > large???)! > > > > I don't want updated version. I want some very old one

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 19:56, Pavel Sanda wrote: > On Wed, Jul 08, 2020 at 06:54:20PM +0200, Thibaut Cuvelier wrote: > > > > Here is the updated version of the manual and the corresponding > patch. It > > > > should apply cleanly, now (even though I don't get why it's that > > > large???)! > > >

Re: Text selection does not work as expected

2020-07-08 Thread Scott Kostyshak
On Wed, Jul 08, 2020 at 07:22:45PM +0200, Yu Jin wrote: > Here we go, patch attached. I decided to put Qt version check 5.10.1, > because I have tested it on LyX 2.3.1, which was shipped with Qt 5.10.1 and > the bug was not there yet. Your patch is perfect, Eugene. Thanks! Please commit. One

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 09:32:26PM +0200, Kornel Benko wrote: > This patch fixes it. Nice catch! Please commit. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

Re: Build failed in Jenkins: Build branch "master" ?? ubuntu-xenial-qt4-autotools-extended #1990

2020-07-08 Thread Kornel Benko
Am Wed, 8 Jul 2020 23:55:28 +0200 schrieb Pavel Sanda : > On Wed, Jul 08, 2020 at 09:32:26PM +0200, Kornel Benko wrote: > > This patch fixes it. > > Nice catch! Please commit. P OK, done. Kornel pgpvPeZG_UN19.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 08:34:30PM +0200, Thibaut Cuvelier wrote: > > Good, do you have idea on top of which commit this was written (even > > approximate date would be helpful). > > > > The last commit before modifying this file dates back to October 2017: >

Re: Docbook 5 merged

2020-07-08 Thread Pavel Sanda
On Wed, Jul 08, 2020 at 09:24:46PM +0200, Thibaut Cuvelier wrote: > > - As with any new feature there are likely some hidden issues and we would > > benefit from docbook users feedback and I'm not sure how to proceed. > > We could ask on users lists for the feedback (and perhaps persuade JMarc >

Re: [LyX/master] Add documentation for the new layout attributes.

2020-07-08 Thread Thibaut Cuvelier
It looks fine, thanks! Thibaut Cuvelier On Thu, 9 Jul 2020 at 00:46, Pavel Sanda wrote: > On Wed, Jul 08, 2020 at 08:34:30PM +0200, Thibaut Cuvelier wrote: > > > Good, do you have idea on top of which commit this was written (even > > > approximate date would be helpful). > > > > > > > The

Re: New Defects reported by Coverity Scan for LyX

2020-07-08 Thread Thibaut Cuvelier
On Wed, 8 Jul 2020 at 14:54, Jean-Marc Lasgouttes wrote: > Item 1 is about checking return of regex_match > > Item 2 is probably fixed by an earlier definition of the "label" variable > Here are two patches, one per item. I also included Kornel's comment about std::regex_match.

Build failed in Jenkins: Build branch "master" » ubuntu-xenial-qt4-autotools-extended #1992

2020-07-08 Thread ci-lyx
https://ci.inria.fr/lyx/job/build-master-head/job/ubuntu-xenial-qt4-autotools-extended/1992/-- [...truncated 2110 lines...] GEN moc_GuiThesaurus.cpp GEN moc_GuiToc.cpp GEN moc_GuiToolbar.cpp GEN moc_GuiView.cpp GEN

Re: Docbook 5 merged

2020-07-08 Thread Richard Kimberly Heck
First, let me add my congratulations to that of others. This really is very nice work. One thing that might be attractive to people is the possibility of using DocBook 5 export possibly plus some XSLT or something of the sort to produce ebooks. This has been much discussed on the user list. You

Re: Using PGP keys to sign documents, helpful for needauth converters?

2020-07-08 Thread Richard Kimberly Heck
On 7/7/20 4:39 AM, Pavel Sanda wrote: > On Mon, Jul 06, 2020 at 02:30:57PM -0400, Richard Kimberly Heck wrote: >> Could we use the private key to put some kind of signature into the >> header, along with an indication of what key is needed to verify it? > We could just store in the header