Re: [patch] Bugs 4733 4714

2009-04-03 Thread Abdelrazak Younes
Vincent van Ravesteijn wrote: Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is not unnecessarily scrolled to show

RE: [patch] Bugs 4733 4714

2009-04-03 Thread Vincent van Ravesteijn - TNW
Vincent van Ravesteijn wrote: Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is not unnecessarily scrolled to show

Re: [patch] Bugs 4733 4714

2009-04-03 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: Vincent van Ravesteijn wrote: Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is

RE: [patch] Bugs 4733 4714

2009-04-03 Thread Vincent van Ravesteijn - TNW
cursorPosAndHeight() could even go into Cursor as I see twice buffer_view_-cursor() and no other use of buffer_view_. Is that a good idea (although the Cursor class is getting crowded) ? No because we want to slim down Cursor and screen positions should not be handled in there. Ah..

Re: [patch] Bugs 4733 4714

2009-04-03 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: cursorPosAndHeight() could even go into Cursor as I see twice buffer_view_-cursor() and no other use of buffer_view_. Is that a good idea (although the Cursor class is getting crowded) ? No because we want to slim down Cursor and screen

Re: [patch] Bugs 4733 & 4714

2009-04-03 Thread Abdelrazak Younes
Vincent van Ravesteijn wrote: Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is not unnecessarily scrolled to show

RE: [patch] Bugs 4733 & 4714

2009-04-03 Thread Vincent van Ravesteijn - TNW
>Vincent van Ravesteijn wrote: >> Hi all, >> >> This patch solves a part of bug 4714 >> (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug >> 4733 (http://www.lyx.org/trac/ticket/4174). >> >> It makes sure that when switching between documents, the buffer is not >> unnecessarily

Re: [patch] Bugs 4733 & 4714

2009-04-03 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: Vincent van Ravesteijn wrote: Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is

RE: [patch] Bugs 4733 & 4714

2009-04-03 Thread Vincent van Ravesteijn - TNW
>> >> cursorPosAndHeight() could even go into Cursor as I see twice >> buffer_view_->cursor() and no other use of buffer_view_. >> >> Is that a good idea (although the Cursor class is getting crowded) ? >> > >No because we want to slim down Cursor and screen positions should >not be handled

Re: [patch] Bugs 4733 & 4714

2009-04-03 Thread Abdelrazak Younes
Vincent van Ravesteijn - TNW wrote: cursorPosAndHeight() could even go into Cursor as I see twice buffer_view_->cursor() and no other use of buffer_view_. Is that a good idea (although the Cursor class is getting crowded) ? No because we want to slim down Cursor and screen

[patch] Bugs 4733 4714

2009-04-02 Thread Vincent van Ravesteijn
Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is not unnecessarily scrolled to show the cursor. The new function were

[patch] Bugs 4733 & 4714

2009-04-02 Thread Vincent van Ravesteijn
Hi all, This patch solves a part of bug 4714 (http://www.lyx.org/trac/ticket/4174) and improves the fix for bug 4733 (http://www.lyx.org/trac/ticket/4174). It makes sure that when switching between documents, the buffer is not unnecessarily scrolled to show the cursor. The new function were