Re: cmake compilation error

Am Sonntag, 12. März 2017 um 19:52:57, schrieb Guillaume Munch > Le 12/03/2017 à 16:51, Kornel Benko a écrit : > > > > Should we emit a warning (which probably will be ignored) or better refuse > > to build > > with "5.0" <= QT < "5.4" ? > > I don't think so, the indication

Re: [LyX/master] Fix typo found by coverity

Le 07/03/2017 à 21:14, Richard Heck a écrit : Actually there are other uses of the variable `formats' in Formats.cpp, and I think that they are all incorrect (should be formatlist). This will not matter in most cases, fortunately. I will try to have a look at this. I did that at a2bfe0042d.

Spurious warning about externally changed file

Recipe: 1/ new file 2/ type something 3/ Save as... a.lyx 4/ LyX warns that a.lyx has been externally modified. JMarc

Re: [LyX/master] Fix typo found by coverity

On 03/13/2017 06:43 AM, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 21:14, Richard Heck a écrit : >>> Actually there are other uses of the variable `formats' in >>> Formats.cpp, and I think that they are all incorrect (should be >>> formatlist). This will not matter in most cases, fortunately.

Fwd: New Defects reported by Coverity Scan for LyX

Here are new defaults discovered by coverity. Guillaume, I think that they should all ring bells wrt your recent external modification code. JMarc Message transféré Sujet : New Defects reported by Coverity Scan for LyX Date : Mon, 13 Mar 2017 09:50:13 -0700 De :

Re: [LyX/master] Fix typo found by coverity

Le 13/03/2017 à 16:18, Richard Heck a écrit : I'll move the formats variable to the singleton, too. That seems worth doing, yes, and should be painless? I think it should be a bit long, but painless. JMarc

Re: cmake build

Am 12.03.2017 um 21:35 schrieb Ian Wilder : > > On 2017-02-13 16:21:52 +, Kornel Benko said: > >> Am Mittwoch, 1. Februar 2017 um 09:58:40, schrieb Ian Wilder >> >>> Hey everyone! >>> I am attempting to build lyx master using the cmake

Re: cmake build

Am Sonntag, 12. März 2017 um 16:35:43, schrieb Ian Wilder > On 2017-02-13 16:21:52 +, Kornel Benko said: > > > Am Mittwoch, 1. Februar 2017 um 09:58:40, schrieb Ian Wilder > > > >> Hey everyone! > >> ... > > > > 1.) Please do not

Re: forced screen recenter in GuiApplication::dispatch?

Le 13/03/2017 à 04:37, Scott Kostyshak a écrit : On Sat, Dec 10, 2016 at 12:56:43AM -0500, Scott Kostyshak wrote: Regarding the comment "This is done unless explicitly requested", is it still possible to request that a redraw not be done and if so how? Or is this comment left-over from how

Re: [patch] Fix color when branch name has a space

Le 07/03/2017 à 06:08, Scott Kostyshak a écrit : For the first patch, I changed the write() routine to add quotes around the branch name. Otherwise, read() gets confused. But should I instead have changed the read routine()? Lexer::quoteString does what you need. And actually you could just

Re: [patch] Fix color when branch name has a space

On Mon, Mar 13, 2017 at 11:03:40AM +0100, Jean-Marc Lasgouttes wrote: > Le 07/03/2017 à 06:08, Scott Kostyshak a écrit : > > For the first patch, I changed the write() routine to add quotes around > > the branch name. Otherwise, read() gets confused. But should I instead > > have changed the read

Re: [LyX/master] Fix typo found by coverity

On 03/13/2017 12:05 PM, Jean-Marc Lasgouttes wrote: > Le 13/03/2017 à 16:18, Richard Heck a écrit : >> I'll move the formats variable to the singleton, too. That seems worth >> doing, yes, and should be painless? > > I think it should be a bit long, but painless. Done. Not too long, but

Re: forced screen recenter in GuiApplication::dispatch?

On Mon, Mar 13, 2017 at 10:56:10AM +0100, Jean-Marc Lasgouttes wrote: > Le 13/03/2017 à 04:37, Scott Kostyshak a écrit : > > On Sat, Dec 10, 2016 at 12:56:43AM -0500, Scott Kostyshak wrote: > > > Regarding the comment "This is done unless explicitly requested", is it > > > still possible to

Re: Fwd: New Defects reported by Coverity Scan for LyX

Jean-Marc Lasgouttes wrote: > Here are new defaults discovered by coverity. Guillaume, I think that they > should all ring bells wrt your recent external modification code. Btw since you were working on coverity bugs for a while now, how many _real_ bugs have been found and what's the ratio to