Patch for lyx.org PayPal donate call

2011-12-12 Thread Scott Kostyshak
- it's fast, free and secure! name=submit src=https://www.paypal.com/images/x-click-but04.gif; /p /form Best, Scott Kostyshak

RE: Patch for lyx.org PayPal donate call

2012-01-14 Thread Scott Kostyshak
Comments? Can others reproduce? From: Scott Kostyshak Sent: Monday, December 12, 2011 3:40 AM To: lyx-devel@lists.lyx.org Subject: Patch for lyx.org PayPal donate call The donate PayPal button, accessed on http://www.lyx.org/Donate gave me a PayPal page

[patch] fix document settings branches GUI behavior

2012-02-21 Thread Scott Kostyshak
1 and my attempt at bug 2 are in the attached patch. Best, Scott Kostyshak Index: src/frontends/qt4/ui/BranchesUi.ui === --- src/frontends/qt4/ui/BranchesUi.ui (revision 40746) +++ src/frontends/qt4/ui/BranchesUi.ui (working copy

RE: [patch] fix document settings branches GUI behavior

2012-02-21 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM What I would do is to study the code of the Insert-Citation dialog, which has the correct behaviour in the search (find?) field, if I understand

RE: [patch] fix document settings branches GUI behavior

2012-02-21 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Tuesday, February 21, 2012 3:55 AM What I would do is to study the code of the Insert-Citation dialog, which has the correct behaviour in the search (find?) field, if I understand

[patch] fix for trunk regression regarding view hidden

2012-02-22 Thread Scott Kostyshak
The attached patch fixes a regression introduced into trunk in r40585 description of regression: Non-hidden files are shown in the submenu view hidden and hidden files are not shown there. You can reproduce by opening a new file and seeing that it is listed under view hidden. Additionally,

RE: [patch] fix for trunk regression regarding view hidden

2012-02-22 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Pavel Sanda [sa...@lyx.org] Sent: Wednesday, February 22, 2012 6:08 AM I don't see the whole context of the code but it seems to me that to get pre-r40585 logic, '!' shall be put ahead of the whole clause, no? Yes, you are

[patch] LFUN_WORD_REPLACE does not clear selection

2012-03-01 Thread Scott Kostyshak
The bug this patch fixes can be reproduced as follows: 1. enable continuous spell check. 2. type a misspelled word and press space so that it has a wavy red underline. 3. right-click and choose a suggested replacement word. 4. press the backspace button. Result: nothing happens. If you press the

RE: [patch] fix document settings branches GUI behavior

2012-03-01 Thread Scott Kostyshak
From: Scott Kostyshak Sent: Tuesday, February 21, 2012 4:49 PM I'm getting closer. I realize that I need to connect the signal returnPressed from newBranchLE to on_addBranchPB_pressed. I did this, and it seems to have partially done what I want, but when I enter text into the LE and press

RE: Patch for lyx.org PayPal donate call

2012-03-01 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Richard Heck [rgh...@comcast.net] Sent: Monday, January 16, 2012 11:45 AM On 01/16/2012 11:14 AM, Jean-Marc Lasgouttes wrote: Le 16/01/2012 16:45, Richard Heck a écrit : So can you explain what this line would do? What is the

forwarding questions from tex.stackexchange to lyx-users list

2012-03-01 Thread Scott Kostyshak
tex.stackexchange seems to be gaining popularity. I was surprised by the number of posts with a lyx tag. There were three just from yesterday. There don't seem to be any developers that are active on tex.stackexchange and there are few users of LyX that answer questions there. Would it be

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-02 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, March 01, 2012 11:05 AM I would try to fix the actual place that modifies cursor, which is probably in findOne (lyxfind.cpp). OK I will study this. Thanks for the guidance, Scott

RE: [patch] fix document settings branches GUI behavior

2012-03-03 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Friday, March 02, 2012 8:09 AM The attached implements this (part 1). Part 2 also implements the behaviour of GuiSelectionManager that Ctrl+Enter does quit the dialog. OK, I will study this to see how you did it. Thanks for the help and

RE: [patch] fix document settings branches GUI behavior

2012-03-03 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Saturday, March 03, 2012 9:10 AM I have a few issues after applying both of your patches. Note that I am using Ubuntu 11.10 64-bit. (1) empty strings can be added by pressing enter. fix: remove the following part of branches_part1.diff: -

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-09 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, March 01, 2012 11:05 AM I would try to fix the actual place that modifies cursor, which is probably in findOne (lyxfind.cpp). replaceOne is the function called. What is the point of the following code in CutAndPaste.cpp's function

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-03-09 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Friday, March 09, 2012 5:43 AM The point was to fix bug 2068 http://www.lyx.org/trac/ticket/2068 which is related to spellchecker. [although I do not remember anything about that :)] Interesting! That looks quite tricky. However, things

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-04-17 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Monday, March 19, 2012 9:21 AM I wonder whether in replaceAll whether the putSelectionAt call should be removed. It seems to be overridden by the subsequent setCursor. I've been meaning to give a more in-depth look at this but haven't done

RE: [patch] LFUN_WORD_REPLACE does not clear selection

2012-04-18 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, April 18, 2012 6:50 AM Don't bother with it. OTOH, your gentle nudge made me commit your patch :) I just removed the new useless parameter 'backwards' of

[patch] doc settings local layout empty string

2012-04-20 Thread Scott Kostyshak
go to document settings local layout enter a space the bug is that you have to validate. This seems unnecessary. Suppose someone accidentally entered some text (maybe they thought it was the preamble) and then realized he was in the wrong spot and erased everything. If an unobservant (doesn't

RE: [patch] doc settings local layout empty string

2012-04-21 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Friday, April 20, 2012 9:54 AM This seems sensible, overall. Minor comments below. It's a micro-optimization, but it might also make it more understandable not to do this every time, but to check is_valid_ first: If that's false, we shouldn't need

RE: [patch] doc settings local layout empty string

2012-04-21 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Saturday, April 21, 2012 4:25 PM Whitespace was a bit inconsistent in the patch. Possibly some sort of setting in your editor. I use vim and made the patch with git diff. I must have done something strange. Let me know if this happens again so I

RE: [patch] doc settings local layout empty string

2012-04-22 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Sunday, April 22, 2012 7:00 PM I guess this is a matter of preference. But somehow it just seemed cleaner the way it was before. --- When I looked at it, I was worried by (2). It's also true that any kind of optimization here will probably be

patches for chkconfig.ltx and unnoticed exit 1 from configure.py

2012-04-25 Thread Scott Kostyshak
The attached minor patches fix a couple of typos that cause configure.py to give an unexplained (this could be improved) 1 exit status. These typos were introduced into trunk here: http://www.lyx.org/trac/changeset/503bd6cf7193b3aaf806dfeb896248116a06d8b2/lyxgit and branch here:

RE: Colaborar desarrolo

2012-04-27 Thread Scott Kostyshak
From: Yolanda Saiz [ysaiz...@hotmail.com] Sent: Thursday, April 26, 2012 2:06 PM Hola, Me gustaría colaborar en el desarrollo, ya me diréis como hacerlo. Un saludo, Yolanda Saiz Hola Yolanda, No soy un programador para LyX pero le contesto porque hablo español. Con qué quiere colaborar

[PATCH] for duplicate bibstyle names

2012-04-30 Thread Scott Kostyshak
I'm not sure how to handle this. I have two .bst files with the same name: /usr/local/texlive/2011/texmf-dist/bibtex/bst/beebe/econometrica.bst /usr/local/texlive/2011/texmf-dist/bibtex/bst/economic/econometrica.bst Because of this I get duplicate entries when choosing a bibstyle in the bibtex

RE: [PATCH] for duplicate bibstyle names

2012-05-01 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Tuesday, May 01, 2012 1:02 PM It certainly does seem misleading to offer the user two choices that do the same thing. But of course there could be cases where you had two bst files with the same name that did different things, though LyX couldn't

RE: [PATCH] for duplicate bibstyle names

2012-05-02 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Wednesday, May 02, 2012 5:39 PM So perhaps we can decide how to handle this. Let's say you've got dir1/file.bst and also dir2/file.bst. We display them that way. Now suppose someone chooses one of them. Should we automatically insert that partial

RE: [PATCH] for duplicate bibstyle names

2012-05-03 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Thursday, May 03, 2012 9:26 AM Should we first check if the bst files are indeed different? If they are not different, then I don't think we need to bother the user with extra information/options. This isn't a bad idea, but I'm not sure how to do

[PATCH] Correct handling of gecos on Unix systems

2012-05-05 Thread Scott Kostyshak
LyX tries to use gecos [1] information to get the user's real name to put in the name field in tools preferences identity. LyX currently uses all four gecos fields, which is why on Ubuntu I've been seeing scott,,,. If you had entered a room number, work phone, or home phone in your gecos,

RE: Select file format with save-as?

2012-05-10 Thread Scott Kostyshak
Guenter Milde [mi...@users.sf.net] Sent: Friday, May 11, 2012 1:50 AM Currently, the filename of the exported file is determined by LyX and you can only change it later in a file manager (e.g. when exporting to an older lyx file format). OTOH, LyX's save-as dialogue does only save in LyX's native

RE: Select file format with save-as?

2012-05-11 Thread Scott Kostyshak
From: Guenter Milde [mi...@users.sf.net] Sent: Friday, May 11, 2012 2:12 AM Probably. I can't tell, as I cannot find it in my LyX 2.0.3. But it would solve a long standing issue. It was implemented in the development version. See here:

RE: Select file format with save-as?

2012-05-11 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Friday, May 11, 2012 4:28 AM Tell us how to do that with Qt and we will do it :) Ah. The only relevant option I see is QFileDialog::HideNameFilterDetails() which doesn't help us. I thought there would be a way to disable that box. Scott

[patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Scott Kostyshak
In the menu when there is an entry that has an ampersand and it has a shortcut, an unnecessary underscore is displayed. For example, instead of Find Replace (Quick)... I see _Find Replace (Quick) I see this behavior on Ubuntu 12.04 with Qt 4.8.1. The attached patch fixes this. Note that

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-20 Thread Scott Kostyshak
From: Vincent van Ravesteijn [v...@lyx.org] Sent: Sunday, May 20, 2012 7:05 AM Isn't this exactly what is expected ? The |F means that the F is the accelerator, and thus it will be underlined. I don't see a relation with the ampersand. I agree that F should be underlined. But for me (without

RE: no GUI error when configure fails on first configure

2012-05-20 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Sunday, May 20, 2012 9:53 AM I think the GUI is accessible at this point---if use_gui is true. So you might just try something like: if (use_gui) frontend::Alert(...); else LYXERR0(...); at the relevant point. If not, then we

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-21 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, May 20, 2012 1:36 PM I think that some code (qt? our own?) assumes that means that is a shortcut and is thus underlined. I thought we were supposed to repalce with automatically to avoid that. It might be that the rules for using

why does import save?

2012-05-22 Thread Scott Kostyshak
I've only tried this for importing .tex and .csv files but whenever I import them LyX automatically saves the resulting lyx file. In some cases, this is exactly what I want to do but I was surprised because in my experience usually an import function just imports and does not automatically

RE: no GUI error when configure fails on first configure

2012-05-22 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Monday, May 21, 2012 10:20 AM That said, the error message is wrong. If there were no text classes, then we would have told the user this at the beginning of LyX:execCommands(). I guess the question, then, is: If initial configuration failed, what

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-05-22 Thread Scott Kostyshak
From: Tommaso Cucinotta [tomm...@lyx.org] Sent: Tuesday, May 22, 2012 7:17 PM In any case, it doesn't look like anyone has reproduced this and no one has complained about it before so I guess we should not do anything about it? FYI, I cannot reproduce on my Ubuntu 12.04: Good to know.

[patch] autogen.sh better exit message

2012-05-23 Thread Scott Kostyshak
If autogen.sh completes successfully, it outputs run ./configure ; make. I do not think this is good advice because what if configure has an error? The make command will still run. I suggest: You can now run ./configure [autogen.patch] because upon successful exit, configure tells you to run

RE: trunk regression

2012-05-30 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Wednesday, May 23, 2012 8:43 AM On 05/23/2012 03:21 AM, Scott Kostyshak wrote: LyX hangs if a converter fails. I can reproduce this in current trunk by opening a new document and putting \foo in an ERT box and trying to view or export to pdflatex

RE: trunk regression

2012-05-31 Thread Scott Kostyshak
Your initialization patch fixes the problem for me. Thanks for tracking this down, Scott

insert bibtex bibliography GUI proposal

2012-06-01 Thread Scott Kostyshak
I find that the GUI for adding a bibtex bibliography is not optimized for the most common use: adding your own bibliography. Is it very common to use one of the example bibliographies? I also find that it's unintuitive if you're not used to it and want to add your own .bib. I remember thinking

RE: insert bibtex bibliography GUI proposal

2012-06-01 Thread Scott Kostyshak
From: John Tapsell [johnf...@gmail.com] Sent: Friday, June 01, 2012 3:21 AM On 1 June 2012 07:56, Scott Kostyshak skost...@princeton.edu wrote: I find that the GUI for adding a bibtex bibliography is not optimized for the most common use: adding your own bibliography. Is it very common to use

RE: insert bibtex bibliography GUI proposal

2012-06-01 Thread Scott Kostyshak
From: Jürgen Spitzmüller [sp...@lyx.org] Sent: Friday, June 01, 2012 3:23 AM Scott Kostyshak wrote: I would like to get some opinions on this before I start working on it. Am I alone in thinking the GUI is confusing? Do most people use the example .bibs more than their own .bibs? Or perhaps

RE: LyX crash after font assert

2012-06-04 Thread Scott Kostyshak
From: Tommaso Cucinotta [tomm...@lyx.org] Sent: Sunday, June 03, 2012 8:17 PM on trunk: 1) open embedded manual 2) put cursor at the very beginning of document 3) try to open Advanced Find and Replace (C-S-f) and I get this: lyx: SIGSEGV signal caught! I get this from a new document. That is:

RE: Git version; scrolling again

2012-06-07 Thread Scott Kostyshak
From: Jerry [lancebo...@qwest.net] Sent: Thursday, June 07, 2012 1:35 AM How can I tell which version of LyX I am building? I _think_ I'm building from git master but then there's this: the command git log -1 will tell you what revision you currently have checked out. the command git branch

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-06-27 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, June 27, 2012 9:31 AM Le 21/05/2012 08:02, Scott Kostyshak a écrit : In any case, it doesn't look like anyone has reproduced this and no one has complained about it before so I guess we should not do anything about

RE: [patch] ampersand + shortcut leaves an underscore in menu

2012-06-29 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, June 27, 2012 9:31 AM Is it unity bug https://bugs.launchpad.net/ubuntu/+source/libdbusmenu/+bug/994564 that you see? In this case, this has just been fixed in ubuntu precise-proposed. The patch there fixes the problem for me.

Preferences File Formats viewer and editor combo boxes

2012-07-03 Thread Scott Kostyshak
In tools Preferences File Handling File Formats my first entry is BMP. Despite the fact that gimp is in the viewerCO combo box, it is set to Custom and gimp is in the text box. What should happen is that gimp should be set in the combo box. (Note that gimp is just being used as an example

RE: [PATCH] for duplicate bibstyle names

2012-07-03 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Thursday, May 03, 2012 5:33 PM Come to think of it, this is something that should be done during reconfiguration, or whenever we all the TeXFiles.py script, so it can just be done in that script. Presumably, there is some python module that would

RE: insert bibtex bibliography GUI proposal

2012-07-04 Thread Scott Kostyshak
From: Jürgen Spitzmüller [sp...@lyx.org] Sent: Friday, June 01, 2012 5:07 AM John Tapsell wrote: If you need people to read documentation, the GUI is too complicated. It should be so simple that you don't need documentation. Good point. I'm not completely convinced by this argument (although

RE: no GUI error when configure fails on first configure

2012-07-04 Thread Scott Kostyshak
From: Richard Heck [rgh...@comcast.net] Sent: Monday, May 21, 2012 10:20 AM OK, I see the problem. Richard, are you able to add this to your todo list? Should I open a trac ticket? Thanks, Scott

RE: why does import save?

2012-07-04 Thread Scott Kostyshak
From: John McCabe-Dansted [gma...@gmail.com] Sent: Wednesday, May 23, 2012 11:02 PM On Wed, May 23, 2012 at 8:52 PM, Richard Heck rgh...@comcast.net wrote: I agree with you generally here. The conversion, like for export, should be done in a temporary directory, if only because the importer

RE: [PATCH] for duplicate bibstyle names

2012-07-05 Thread Scott Kostyshak
From: Richard Heck [rgh...@lyx.org] Sent: Thursday, July 05, 2012 9:17 AM On 07/04/2012 01:53 AM, Scott Kostyshak wrote: From: Richard Heck [rgh...@comcast.net] Sent: Thursday, May 03, 2012 5:33 PM Richard, is this something you can put on your todo list? Should I make a trac ticket

RE: why does import save?

2012-07-05 Thread Scott Kostyshak
From: Richard Heck [rgh...@lyx.org] Sent: Thursday, July 05, 2012 9:19 AM I'd open a ticket, yes. Ticket created here: http://www.lyx.org/trac/ticket/8236 Scott

RE: Preferences File Formats viewer and editor combo boxes

2012-07-05 Thread Scott Kostyshak
From: Richard Heck [rgh...@lyx.org] Sent: Thursday, July 05, 2012 9:17 AM Since we do use eatLine(), we don't need them as delimiters. So it would be an option just not to write them. Ticket created here: http://www.lyx.org/trac/ticket/8237 On a different note, and more out of curiosity, would

RE: Patch for lyx.org PayPal donate call

2012-07-05 Thread Scott Kostyshak
From: Scott Kostyshak Sent: Thursday, March 01, 2012 4:42 AM The English version has been working fine, but all of the other languages are still directed to an English Paypal page. The other country codes are listed here: https://cms.paypal.com/us/cgi-bin/?cmd=_render-contentcontent_ID

RE: Conclusion - New Windows installer for LyX 2.0.4

2012-07-08 Thread Scott Kostyshak
From: lyx-devel@lists.lyx.org [lyx-devel@lists.lyx.org] on behalf of Uwe Stöhr [uwesto...@web.de] Sent: Sunday, July 08, 2012 11:55 AM I have now provided the new installer version LyX-204-3 here: http://sourceforge.net/projects/lyxwininstaller/ The download link on the sourceforge front page

Undo.cpp reports an error on trunk

2012-07-11 Thread Scott Kostyshak
I can reproduce as follows: 1. Start a fresh LyX session. 2. Open a new document. 3. Save (or Save As). I get the following messages: Saving document ~/newfile1.lyx... Saving document ~/newfile1.lyx... done. Document ~/newfile1.lyx reloaded. (buffer-write: Ctrl+S, F2)Undo.cpp (515): There is no

questions and proposal regarding enum FuncAttribs

2012-07-12 Thread Scott Kostyshak
I've found uses only of the following FuncAttribs values (from grepping for the funcHasFlag function): AtPoint, ReadOnly, NoBuffer, NoInternal The following values are not being used at all: Argument, NoUpdate, SingleParUpdate. Are they still left around because they might be useful in the

RE: StatWeave integration

2012-07-12 Thread Scott Kostyshak
From: Brian Quistorff [bquisto...@gmail.com] Sent: Wednesday, July 11, 2012 10:03 AM Would these be good to put in the stock LyX distribution? I would like to see this module make it in to the stock LyX distribution. I think many people could be interested. However, I think the unofficial

RE: questions and proposal regarding enum FuncAttribs

2012-07-13 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, July 12, 2012 5:20 AM I think theargument flag is not flexible enough to be useful. ok. In the meantime, it would not hurt to fix one by one the examples you gave (in getStatus). Returning meaningful error messages when getStatus

RE: questions and proposal regarding enum FuncAttribs

2012-07-13 Thread Scott Kostyshak
From: Pavel Sanda [sa...@lyx.org] Sent: Friday, July 13, 2012 4:43 PM Scott Kostyshak wrote: In the meantime, it would not hurt to fix one by one the examples you gave (in getStatus). Returning meaningful error messages when getStatus disables a function would make sense too. ok, I will look

RE: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, July 12, 2012 5:20 AM Le 12/07/2012 09:44, Scott Kostyshak a écrit : It seems that there are many LFUNs that would fall under the description of the Argument flag (currently help-open is the only LFUN to specify it). If this flag

checking whether a buffer is hidden

2012-07-15 Thread Scott Kostyshak
What is the correct way to check whether a buffer is hidden? I am currently doing the following bool const hidden = !(guiApp-currentView() guiApp-currentView()-workArea(*b)); which works fine but I'm not sure if it's the right way. Thanks, Scott

RE: questions and proposal regarding enum FuncAttribs

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 9:41 AM Le 15/07/12 09:10, Scott Kostyshak a écrit : I think theargument flag is not flexible enough to be useful. Why not? The attached patch checks whether the LFUN being called in GuiView.cpp has the Argument flag

doxygen command for LyXAction.cpp -- LFUNs.lyx

2012-07-15 Thread Scott Kostyshak
How do I turn LyXAction.cpp into LFUNs.lyx? Thanks, Scott

[PATCH] LFUN_BUFFER_FORALL

2012-07-15 Thread Scott Kostyshak
Attached is a patch that implements LFUN_BUFFER_FORALL, which applies a passed LFUN command to all buffers. My motivation was that I sometimes need to do the same thing in all of the buffers that I have open. Another advantage of implementing this LFUN is that it allows buffer-specific settings

RE: checking whether a buffer is hidden

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 9:34 AM Le 15/07/12 09:14, Scott Kostyshak a écrit : What is the correct way to check whether a buffer is hidden? I am currently doing the following bool const hidden = !(guiApp-currentView() guiApp-currentView

[PATCH] LFUN_BUFFER_EXPORT_ALL File menu reorganization

2012-07-15 Thread Scott Kostyshak
Attached is a patch that does the following: (1) Creates LFUN_BUFFER_EXPORT_ALL. My motivation was that I'm often working on several problem sets or notes at once and would like to export all of them to pdf. (2) Reorganizes the File menu: The current implementation places import next to

RE: [PATCH] LFUN_BUFFER_FORALL

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 5:14 PM + case LFUN_BUFFER_FORALL: { + Buffer * const buf = currentBufferView()-buffer(); + if (!buf) + break; Why is this test needed?

RE: checking whether a buffer is hidden

2012-07-15 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 4:54 PM The problem is that it needs to be a member function of GuiApplication. The buffer itself has no reason to know that it is hidden. In what part of code do you need to know this information? I use this in

RE: doxygen command for LyXAction.cpp -- LFUNs.lyx

2012-07-15 Thread Scott Kostyshak
From: Pavel Sanda [sa...@lyx.org] Sent: Sunday, July 15, 2012 6:34 PM Doxygen generation is not related to LFUNs.lyx. - doxygen: make doxydoc - LFUNs.lyx: make lfundoc Thanks, Scott

RE: [PATCH] LFUN_BUFFER_EXPORT_ALL File menu reorganization

2012-07-15 Thread Scott Kostyshak
From: Pavel Sanda [sa...@lyx.org] Sent: Sunday, July 15, 2012 7:19 PM While I think adding LFUNs you proposed makes sense, I don't think it's good idea to add this new stuff into the File menu (at most poke them away to some submenu). I would rather see the menu shrink than expand (e.g. Print).

RE: [PATCH] LFUN_BUFFER_EXPORT_ALL File menu reorganization

2012-07-16 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Monday, July 16, 2012 5:57 AM Concerning menus, I think we should put things where UI manuals tell us to put them. While I understand Scott's ideas, I suspect that they may be disturbing to some. Sounds good. I would have to have a stronger

RE: [PATCH] LFUN_BUFFER_EXPORT_ALL File menu reorganization

2012-07-16 Thread Scott Kostyshak
From: Pavel Sanda [sa...@lyx.org] Sent: Monday, July 16, 2012 7:26 AM Scott Kostyshak wrote: I'm not sure where to put Export All if not in the File menu. To me this function looks rather as corner case than common usage. But you can always make the changes privately. I think that many people

RE: [PATCH] LFUN_BUFFER_FORALL

2012-07-17 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Sunday, July 15, 2012 5:14 PM Moreover, this code should not be in GuiView, but in GuiApplication, since the function is at application level. Attached is my attempt to move the code to GuiApplication. I am having trouble instantiating a

RE: [PATCH] LFUN_BUFFER_FORALL

2012-07-18 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, July 18, 2012 4:14 AM JMarc, Thank you for your guidance. Attached is an updated patch and below I respond to your comments. Scott Try to #include GuiWorkArea.h at the start of GuiApplication.cpp. That works. + case

RE: [PATCH] LFUN_BUFFER_FORALL

2012-07-20 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, July 19, 2012 4:15 AM Le 19/07/2012 04:46, Scott Kostyshak a écrit : If there are more windows open, buffer-forall iterates over the buffers in the current window, treating a buffer as hidden as designated in the current window

trunk regression: [LyX master] Fix crash introduced in my previous commit f6b1c24b

2012-07-22 Thread Scott Kostyshak
I am getting an assert on trunk. git bisect lead me to this commit. I can reproduce with: 1. start a new document 2. ctrl+m to enter inline math mode 3. type x 4. undo I get the following: lassert.cpp (35): ASSERTION undo.pars VIOLATED IN Undo.cpp:422 Assertion triggered in void

RE: lyx manuals

2012-08-12 Thread Scott Kostyshak
From: Jack Tanner [i...@hotmail.com] Sent: Sunday, August 12, 2012 3:10 PM It'd be handy to have easy access to PDF versions of LyX manuals. Is there a place where current LyX manuals are posted on the web in PDF, or could PDFs be included with the installer? They are here:

[patch] Object::disconnect: Unexpected null parameter

2012-08-13 Thread Scott Kostyshak
. 2011) introduced in 5c5850e2 so maybe he knows if there is a different fix or if d.current_work_area_ being null could cause other problems. Thanks, Scott From 6b50077d5bd2bc9b3c5cdae2f06d13864f95dc60 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak skost...@princeton.edu Date: Tue, 14 Aug 2012 00

RE: [LyX master] de.po: update

2012-08-21 Thread Scott Kostyshak
From: lyx-...@lists.lyx.org [lyx-...@lists.lyx.org] on behalf of Juergen Spitzmueller [sp...@lyx.org] Sent: Tuesday, August 21, 2012 12:14 PM commit 99088a1152986b69d2f5d6ba3e499fb32d900513 Author: Juergen Spitzmueller sp...@lyx.org Date: Tue Aug 21 18:13:49 2012 +0200 de.po: update I

RE: [PATCH] LFUN_BUFFER_FORALL

2012-08-22 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Friday, July 20, 2012 4:45 AM The problem is that the LFUN is mixing real hidden buffers (visible nowhere) with the ones that are visible in some other window. I think these two things are very different from a user point of view. Conclusion:

RE: [PATCH] LFUN_BUFFER_FORALL

2012-08-22 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, August 22, 2012 4:12 AM Le 22/08/2012 09:04, Scott Kostyshak a écrit : + * \li Notion: A buffer is `locally visible' with respect to a view if it + is visible within that view. If not, it is `locally hidden

RE: [PATCH] LFUN_BUFFER_FORALL

2012-08-22 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Wednesday, August 22, 2012 6:27 AM I would revert the definition: a buffer is hidden if it is internally opened in LyX, but not visible in any window (rewritten into proper English) Sounds good. To make things really simple, what if only

RE: [PATCH] LFUN_BUFFER_FORALL

2012-08-23 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, August 23, 2012 4:41 AM Le 23/08/2012 06:19, Scott Kostyshak a écrit : Currently buffer-forall rehides each hidden buffer after the LFUN is applied. Should it not do that? Is it because they had to be made visible earlier? I

RE: [PATCH] LFUN_BUFFER_FORALL

2012-08-27 Thread Scott Kostyshak
From: Jean-Marc Lasgouttes [lasgout...@lyx.org] Sent: Thursday, August 23, 2012 9:15 AM Then I propose to simplify things a lot by only dispatching to visible buffers (for now). No more special parameter. The updated patch is attached. How does it look? Scottdiff --git a/src/LyXAction.cpp

Extending mini-buffer completion

2012-08-28 Thread Scott Kostyshak
Would it be useful to extend tab-completion to work for LFUN-arguments of LFUNs? For example, the following commands accept LFUNs as arguments: repeat command-sequence inset-forall buffer-forall If this would be useful, I have the following untested implementation in mind: 1.

Re: LFUN documentation typos

2012-08-30 Thread Scott Kostyshak
On Thu, Aug 30, 2012 at 6:43 PM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: Attached are some corrections of typos for the LFUN documentation for trunk. Except the change in inset-settings (why?) all changes are fine. Because otherwise there is an extra space: ...|index_print

minor trac bug

2012-08-31 Thread Scott Kostyshak
Where is the correct place to report this? Should I report it at the main trac site or is it lyx.org-specific? 1. go to http://www.lyx.org/trac/ 2. login 3. click on account 4. logout When I do this on Firefox or Chromium on Ubuntu I get Error: Not Found. Unknown preference panel I think this is

export to LyX Archive fails on an unsaved buffer

2012-08-31 Thread Scott Kostyshak
On Ubuntu 12.04 using current trunk I get an error [1] from 1. Start a new document 2. File Export Export to LyX Archive The converter for me is: python -tt $$s/scripts/lyxpak.py $$r/$$f Does a new flag need to be created? For example, promptsave, which if specified in a converter would

[patch] add some cmake files to .gitignore

2012-09-01 Thread Scott Kostyshak
I don't know much about git and I don't know much about cmake so I wouldn't be surprised if this is incorrect. The attached patch asks git to ignore temporary cmake files, which are created after running cmake .. Could someone check? Thanks, Scott diff --git a/.gitignore b/.gitignore index

[patch] typos

2012-09-01 Thread Scott Kostyshak
The attached patch cleans up some comments, LFUN documentation, an error message, and lyx --help output. Scott diff --git a/lib/layouts/stdsections.inc b/lib/layouts/stdsections.inc index d9d7476..26da87c 100644 --- a/lib/layouts/stdsections.inc +++ b/lib/layouts/stdsections.inc @@ -3,7 +3,7 @@

[patch] constify

2012-09-01 Thread Scott Kostyshak
The attached patch does some constifying that has been hanging around. Scott diff --git a/src/Buffer.cpp b/src/Buffer.cpp index cb856b0..5386520 100644 --- a/src/Buffer.cpp +++ b/src/Buffer.cpp @@ -1391,7 +1391,7 @@ bool Buffer::makeLaTeXFile(FileName const fname, ofdocstream ofs;

Re: [patch] constify

2012-09-02 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 8:47 AM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: @@ -2453,7 +2453,7 @@ void GuiApplication::hideDialogs(string const name, Inset * inset) const Buffer const * GuiApplication::updateInset(Inset const * inset) const { Buffer const * buffer_ = 0

Re: [patch] add some cmake files to .gitignore

2012-09-02 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 10:12 AM, Enrico Forestieri for...@lyx.org wrote: On Sat, Sep 01, 2012 at 07:10:59PM -0400, Scott Kostyshak wrote: I don't know much about git and I don't know much about cmake so I wouldn't be surprised if this is incorrect. The attached patch asks git to ignore

Re: [patch] constify

2012-09-02 Thread Scott Kostyshak
On Sun, Sep 2, 2012 at 4:23 PM, Pavel Sanda sa...@lyx.org wrote: Scott Kostyshak wrote: (a) the style is inconsistent This is good enough reason. I did grep sources and we indeed use const_iterator for end in most cases. (3) I've read that compilers can apply more aggressive optimizations

Re: [patch] constify

2012-09-02 Thread Scott Kostyshak
What about an iterator object? (that is, I'm no longer asking about iterator vs. const_iterator but now const_iterator vs. const iterator const) Never mind, your previous comment applies to this as well: The fact that end is not modified anywhere in the loop will be quickly discovered by

  1   2   3   4   5   6   7   8   9   10   >