Re: Errors with some testcases because of redefined \strong
Am Donnerstag, den 16.02.2017, 16:19 +0100 schrieb Kornel Benko: > > I'd probably use \providecommand. But you'd need to check whether > the > > output is identical (see below). And alternative is using \def or > > \@ifundefined{strong}{\newcommand...}{\renewcommand...} > > OK. Any solution is better than what we have now. I have committed a fix using \providecommand. I have verified that fontspec's strong produces formally identical output. This should also go to stable. Jürgen signature.asc Description: This is a digitally signed message part
Re: Errors with some testcases because of redefined \strong
Am Donnerstag, den 16.02.2017, 17:06 +0100 schrieb Kornel Benko: > Isn't that the meaning of 'solution'? You have a point. Jürgen signature.asc Description: This is a digitally signed message part
Re: Errors with some testcases because of redefined \strong
Am Donnerstag, 16. Februar 2017 um 16:47:43, schrieb Jürgen Spitzmüller> Am Donnerstag, den 16.02.2017, 16:19 +0100 schrieb Kornel Benko: > > OK. Any solution is better than what we have now. > > No, not any. Only one that does not break other documents. What we have > now only breaks with Non-TeX fonts, and only with a very recent > fontspec. Isn't that the meaning of 'solution'? > Jürgen Kornel signature.asc Description: This is a digitally signed message part.
Re: Errors with some testcases because of redefined \strong
Am Donnerstag, den 16.02.2017, 16:19 +0100 schrieb Kornel Benko: > OK. Any solution is better than what we have now. No, not any. Only one that does not break other documents. What we have now only breaks with Non-TeX fonts, and only with a very recent fontspec. Jürgen signature.asc Description: This is a digitally signed message part
Re: Errors with some testcases because of redefined \strong
Am Donnerstag, 16. Februar 2017 um 15:08:24, schrieb Jürgen Spitzmüller> Am Donnerstag, den 16.02.2017, 11:15 +0100 schrieb Kornel Benko: > > Hi, > > the attached patch fixes it for me. > > This will fail for all cases were strong is not defined. > > I'd probably use \providecommand. But you'd need to check whether the > output is identical (see below). And alternative is using \def or > \@ifundefined{strong}{\newcommand...}{\renewcommand...} OK. Any solution is better than what we have now. > > 16 testcases are affected. > > E.g. export/doc/Additional_pdf4_systemF: > > Desc: LaTeX Error: Command \strong already defined. > > Text: \newcommand{\strong}[1]{\textbf{#1}} > > > > Your command was ignored. > > Type Ito replace it with another command, > > orto continue without it. > > > > Anybody else seeing this? > > I suppose this is due to the recent fontspec update: > > - v2.6 (2017/02/12) > > [...] > * Add `\strong` as the "weight" analogy to `\emph`. This will need > some extra syntactic sugar from `fontspec` before it becomes > truly useful. Feels like it will remain there from now on. > Jürgen > > > Kornel signature.asc Description: This is a digitally signed message part.
Re: Errors with some testcases because of redefined \strong
Am Donnerstag, den 16.02.2017, 11:15 +0100 schrieb Kornel Benko: > Hi, > the attached patch fixes it for me. This will fail for all cases were strong is not defined. I'd probably use \providecommand. But you'd need to check whether the output is identical (see below). And alternative is using \def or \@ifundefined{strong}{\newcommand...}{\renewcommand...} > 16 testcases are affected. > E.g. export/doc/Additional_pdf4_systemF: > Desc: LaTeX Error: Command \strong already defined. > Text: \newcommand{\strong}[1]{\textbf{#1}} > > Your command was ignored. > Type I to replace it with another command, > orto continue without it. > > Anybody else seeing this? I suppose this is due to the recent fontspec update: - v2.6 (2017/02/12) [...] * Add `\strong` as the "weight" analogy to `\emph`. This will need some extra syntactic sugar from `fontspec` before it becomes truly useful. Jürgen > > Kornel signature.asc Description: This is a digitally signed message part
Errors with some testcases because of redefined \strong
Hi, the attached patch fixes it for me. 16 testcases are affected. E.g. export/doc/Additional_pdf4_systemF: Desc: LaTeX Error: Command \strong already defined. Text: \newcommand{\strong}[1]{\textbf{#1}} Your command was ignored. Type Ito replace it with another command, orto continue without it. Anybody else seeing this? Kornel signature.asc Description: This is a digitally signed message part. diff --git a/lib/layouts/logicalmkup.module b/lib/layouts/logicalmkup.module index 33b954d..0b7a569 100644 --- a/lib/layouts/logicalmkup.module +++ b/lib/layouts/logicalmkup.module @@ -52,7 +52,7 @@ InsetLayout Flex:Strong Series Bold EndFont Preamble - \newcommand{\strong}[1]{\textbf{#1}} + \renewcommand{\strong}[1]{\textbf{#1}} EndPreamble InToc true HTMLTag strong