Re: [LyX/master] Update internal Hunspell to latest release (1.6.2)

[Stephan Witt]

Am 18.09.2017 um 18:17 schrieb Jürgen Spitzmüller :
> 
> Am Montag, den 18.09.2017, 18:13 +0200 schrieb Juergen Spitzmueller:
>> commit 3b89cd9c283d1daadfbf1d7367aa103450a276ae
>> Author: Juergen Spitzmueller 
>> Date:   Mon Sep 18 18:12:21 2017 +0200
>> 
>>Update internal Hunspell to latest release (1.6.2)
> 
> Please test whether this builds with cmake.

On MacOS the default spell-checker is the OS native service.
The hunspell backend is another usable option only.

I’m using 1.3.3 with C++-header ATM - with newer versions
I had problems AFAIR but I don’t remember the details anymore.
I’ve tried 1.3.4 and 1.5.4, the version 1.6.2 I didn’t try.

> Wrt MacOSX, there are still some references to 1.3.3 in the build
> script, which I didn't touch yet, since I suspect this is related to
> the "self-compiled hunspell with explicit given include path" Stephan
> referred to:
> 
> diff --git a/development/LyX-Mac-binary-release.sh b/development/LyX-
> Mac-binary-release.sh
> index 6379876bba..59e6e6823c 100644
> --- a/development/LyX-Mac-binary-release.sh
> +++ b/development/LyX-Mac-binary-release.sh
> @@ -21,9 +21,9 @@ ASpellVersion=${ASpellVersion:-"0.60.6.1"}
> ASpellSource="aspell-${ASpellVersion}"
> ASpellLibrary="libaspell.15.dylib"
> 
> -HunSpellVersion=${HunSpellVersion:-"1.3.3"}
> +HunSpellVersion=${HunSpellVersion:-"1.6.2"}
> HunSpellSource="hunspell-${HunSpellVersion}"
> -HunSpellLibrary="libhunspell-1.3.0.dylib"
> +HunSpellLibrary="libhunspell-1.6.2.dylib"
> 
> unset DYLD_LIBRARY_PATH LD_LIBRARY_PATH
> 
> 
> Stephan, let me know if I should commit this change as well.

No, I’d like to test this myself before. ATM it would break for sure.
At least on a virgin system. I did not check but I’m almost sure
the installed shared lib is libhunspell-1.6.0.dylib, e.g.

Stephan

Re: [LyX/master] Update internal Hunspell to latest release (1.6.2)

[Kornel Benko]

Am Montag, 18. September 2017 um 20:02:25, schrieb Jürgen Spitzmüller 

> Am Montag, den 18.09.2017, 19:45 +0200 schrieb Kornel Benko:
> > Missing:
> > 3rdparty/hunspell/1.6.2/src/hunspell/license.hunspell,
> > 3rdparty/hunspell/1.6.2/src/hunspell/license.myspell
> 
> These were left out by purpose (the license is in the top dir). I
> missed them when adapting CMakeList.txt.
> 
> > After copying these files from previous source tree, it compiles
> > cleanly (on clean build tree).
> 
> I've removed those files now from CMakeList.txt

Yes, thanks, should have seen it myself.

> Jürgen

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Update internal Hunspell to latest release (1.6.2)

[Jürgen Spitzmüller]

Am Montag, den 18.09.2017, 19:45 +0200 schrieb Kornel Benko:
> Missing:
>   3rdparty/hunspell/1.6.2/src/hunspell/license.hunspell,
>   3rdparty/hunspell/1.6.2/src/hunspell/license.myspell

These were left out by purpose (the license is in the top dir). I
missed them when adapting CMakeList.txt.

> After copying these files from previous source tree, it compiles
> cleanly (on clean build tree).

I've removed those files now from CMakeList.txt

Jürgen

signature.asc
Description: This is a digitally signed message part

Re: [LyX/master] Update internal Hunspell to latest release (1.6.2)

[Kornel Benko]

Am Montag, 18. September 2017 um 18:17:33, schrieb Jürgen Spitzmüller 

> Am Montag, den 18.09.2017, 18:13 +0200 schrieb Juergen Spitzmueller:
> > commit 3b89cd9c283d1daadfbf1d7367aa103450a276ae
> > Author: Juergen Spitzmueller 
> > Date:   Mon Sep 18 18:12:21 2017 +0200
> > 
> > Update internal Hunspell to latest release (1.6.2)
> 
> Please test whether this builds with cmake.

Missing:
3rdparty/hunspell/1.6.2/src/hunspell/license.hunspell,
3rdparty/hunspell/1.6.2/src/hunspell/license.myspell

After copying these files from previous source tree, it compiles cleanly (on 
clean build tree).

...

> Jürgen

Kornel

signature.asc
Description: This is a digitally signed message part.

Re: [LyX/master] Update internal Hunspell to latest release (1.6.2)

[Jürgen Spitzmüller]

Am Montag, den 18.09.2017, 18:13 +0200 schrieb Juergen Spitzmueller:
> commit 3b89cd9c283d1daadfbf1d7367aa103450a276ae
> Author: Juergen Spitzmueller 
> Date:   Mon Sep 18 18:12:21 2017 +0200
> 
> Update internal Hunspell to latest release (1.6.2)

Please test whether this builds with cmake.

Wrt MacOSX, there are still some references to 1.3.3 in the build
script, which I didn't touch yet, since I suspect this is related to
the "self-compiled hunspell with explicit given include path" Stephan
referred to:

diff --git a/development/LyX-Mac-binary-release.sh b/development/LyX-
Mac-binary-release.sh
index 6379876bba..59e6e6823c 100644
--- a/development/LyX-Mac-binary-release.sh
+++ b/development/LyX-Mac-binary-release.sh
@@ -21,9 +21,9 @@ ASpellVersion=${ASpellVersion:-"0.60.6.1"}
 ASpellSource="aspell-${ASpellVersion}"
 ASpellLibrary="libaspell.15.dylib"
 
-HunSpellVersion=${HunSpellVersion:-"1.3.3"}
+HunSpellVersion=${HunSpellVersion:-"1.6.2"}
 HunSpellSource="hunspell-${HunSpellVersion}"
-HunSpellLibrary="libhunspell-1.3.0.dylib"
+HunSpellLibrary="libhunspell-1.6.2.dylib"
 
 unset DYLD_LIBRARY_PATH LD_LIBRARY_PATH


Stephan, let me know if I should commit this change as well.

Jürgen 

signature.asc
Description: This is a digitally signed message part