Re: Compiling With Qt5

2024-04-06 Thread Kornel Benko
Am Sat, 6 Apr 2024 10:59:42 +0200 schrieb Pavel Sanda : > On Sat, Apr 06, 2024 at 10:37:16AM +0200, Kornel Benko wrote: > > In this commit I only fixed the the wrong casing of "Qt6Core_Found" to > > "Qt6Core_FOUND". So this code was there for a long time, but was not > > working. > >

Re: Compiling With Qt5

2024-04-06 Thread Pavel Sanda
On Sat, Apr 06, 2024 at 10:37:16AM +0200, Kornel Benko wrote: > In this commit I only fixed the the wrong casing of "Qt6Core_Found" to > "Qt6Core_FOUND". > So this code was there for a long time, but was not working. Nevertheless, can we have cmake defaulting to qt5 for 2.4.x? P -- lyx-devel

Re: Compiling With Qt5

2024-04-06 Thread Kornel Benko
Am Fri, 5 Apr 2024 17:23:57 -0400 schrieb Richard Kimberly Heck : > On 4/5/24 03:02, Kornel Benko wrote: > > Am Thu, 4 Apr 2024 13:39:18 -0400 > > schrieb Richard Kimberly Heck : > > > >> On 4/3/24 06:34, Jean-Marc Lasgouttes wrote: > >>> Le 03/04/2024 à 12:27, Pavel Sanda a écrit : >

Re: Compiling With Qt5

2024-04-06 Thread Jürgen Spitzmüller
Am Freitag, dem 05.04.2024 um 17:23 -0400 schrieb Richard Kimberly Heck: > Unless I'm misreading it, commit 993e784a6284a to 2.4.x makes Qt6 the > default (and that commit is also in 2.4.1-devel). That's bad. I think our Qt6 implementation still has too many drawbacks. I would keep it opt-in in

Re: Compiling With Qt5

2024-04-05 Thread Richard Kimberly Heck
On 4/5/24 03:02, Kornel Benko wrote: Am Thu, 4 Apr 2024 13:39:18 -0400 schrieb Richard Kimberly Heck : On 4/3/24 06:34, Jean-Marc Lasgouttes wrote: Le 03/04/2024 à 12:27, Pavel Sanda a écrit : On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote: Also, do we want Qt6 to be

Re: Compiling With Qt5

2024-04-05 Thread Kornel Benko
Am Thu, 4 Apr 2024 13:39:18 -0400 schrieb Richard Kimberly Heck : > On 4/3/24 06:34, Jean-Marc Lasgouttes wrote: > > Le 03/04/2024 à 12:27, Pavel Sanda a écrit : > >> On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote: > >>> Also, do we want Qt6 to be the default with

Re: Compiling With Qt5

2024-04-04 Thread Richard Kimberly Heck
On 4/3/24 06:34, Jean-Marc Lasgouttes wrote: Le 03/04/2024 à 12:27, Pavel Sanda a écrit : On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote: Also, do we want Qt6 to be the default with 2.4.x? In master, that might make sense, but it seems odd to change that now. I would

Re: Compiling With Qt5

2024-04-03 Thread Jean-Marc Lasgouttes
Le 03/04/2024 à 12:27, Pavel Sanda a écrit : On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote: Also, do we want Qt6 to be the default with 2.4.x? In master, that might make sense, but it seems odd to change that now. I would not do that for 2.4 at this stage. I guess we

Re: Compiling With Qt5

2024-04-03 Thread Pavel Sanda
On Tue, Apr 02, 2024 at 09:54:22PM -0400, Richard Kimberly Heck wrote: > Also, do we want Qt6 to be the default with 2.4.x? In master, that might > make sense, but it seems odd to change that now. I would not do that for 2.4 at this stage. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Compiling With Qt5

2024-04-03 Thread Kornel Benko
Am Tue, 2 Apr 2024 21:54:22 -0400 schrieb Richard Kimberly Heck : > On 4/2/24 21:19, Scott Kostyshak wrote: > > On Tue, Apr 02, 2024 at 08:41:50PM GMT, Richard Kimberly Heck wrote: > >> I'm now getting: > >> > >> CMake Error at CMakeLists.txt:826 (find_package): > >>   Could not find a package

Re: Compiling With Qt5

2024-04-02 Thread Richard Kimberly Heck
On 4/2/24 21:19, Scott Kostyshak wrote: On Tue, Apr 02, 2024 at 08:41:50PM GMT, Richard Kimberly Heck wrote: I'm now getting: CMake Error at CMakeLists.txt:826 (find_package):   Could not find a package configuration file provided by "Qt6Svg" with any   of the following names:    

Re: Compiling With Qt5

2024-04-02 Thread Scott Kostyshak
On Tue, Apr 02, 2024 at 08:41:50PM GMT, Richard Kimberly Heck wrote: > I'm now getting: > > CMake Error at CMakeLists.txt:826 (find_package): >   Could not find a package configuration file provided by "Qt6Svg" with any >   of the following names: > >     Qt6SvgConfig.cmake >