Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Petr Pchelko
It’s 10.9 - specific, so I could check this as soon as I bring a miniDP adaptor home. With best regards. Petr. 20 марта 2014 г., в 1:51 до полудня, Sergey Bylokhov написал(а): > On 3/19/14 11:50 PM, Petr Pchelko wrote: >> Hello, Sergey. >> >> After Anthony have asked all the possible questio

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
On 3/19/14 11:50 PM, Petr Pchelko wrote: Hello, Sergey. After Anthony have asked all the possible questions I’m left with the only option: The fix looks good to me. BTW: I see that there’s one more bug in this method: https://bugs.openjdk.java.net/browse/JDK-8036927 Is it also resolved by thi

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Petr Pchelko
Hello, Sergey. After Anthony have asked all the possible questions I’m left with the only option: The fix looks good to me. BTW: I see that there’s one more bug in this method: https://bugs.openjdk.java.net/browse/JDK-8036927 Is it also resolved by this fix? With best regards. Petr. 19 марта

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
All right, if you say this additional filtering is required for correct results and tests confirm that, let it be. I'm fine with the fix then. -- best regards, Anthony On 3/19/2014 11:29 PM, Sergey Bylokhov wrote: On 3/19/14 10:43 PM, Anthony Petrov wrote: Why would there be a regression? Di

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
On 3/19/14 10:43 PM, Anthony Petrov wrote: Why would there be a regression? Displays using hardware mirroring are never included in the list by either CGGetActiveDisplayList or CGGetOnlineDisplayList. So in this case the results should be the same independent from the function used. Similarly

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
Why would there be a regression? Displays using hardware mirroring are never included in the list by either CGGetActiveDisplayList or CGGetOnlineDisplayList. So in this case the results should be the same independent from the function used. Similarly, when using software mirroring, both functi

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
On 3/19/14 9:35 PM, Anthony Petrov wrote: On 3/19/2014 9:29 PM, Sergey Bylokhov wrote: On 3/19/14 9:20 PM, Anthony Petrov wrote: 1. Previously we didn't exclude mirrored displays from the list. So the new code that you're adding at lines 84-92 might be better integrated as a separate fix. Befo

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
Hi Sergey, Generally the fix looks good. I have only two concerns: 1. Previously we didn't exclude mirrored displays from the list. So the new code that you're adding at lines 84-92 might be better integrated as a separate fix. 2. Before the fix, the list of display devices returned from ge

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
On 3/19/2014 9:29 PM, Sergey Bylokhov wrote: On 3/19/14 9:20 PM, Anthony Petrov wrote: 1. Previously we didn't exclude mirrored displays from the list. So the new code that you're adding at lines 84-92 might be better integrated as a separate fix. Before the fix we use CGGetActiveDisplayList, w

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
Hello, Anthony. On 3/19/14 9:20 PM, Anthony Petrov wrote: Hi Sergey, Generally the fix looks good. I have only two concerns: 1. Previously we didn't exclude mirrored displays from the list. So the new code that you're adding at lines 84-92 might be better integrated as a separate fix. Before

[9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. After the fix we use screen in sleep state as normal screen, where we can create new windows, etc. Disadvantage is that Robot still does not work on such devices. Bug: https://bugs.openjdk.java.net/browse/JDK-7124417 Webrev can be found at: http://cr.open